arm: dts: rk3399-puma: re-add vdd_log for uboot
PATCH 1/1 arm: dts: rk3399-puma: re-add vdd_log for uboot
The rk3399-puma board needs a 950mV vdd_log to work stable. This was already added in
commit 77012e79ffc3 ("rockchip: rk3399-puma: Set VDD_LOG to 950 mV") but lost again with
commit 167efc2c7a46 ("arm64: dts: rk3399: Sync v5.7-rc1 from Linux")
So to make puma stable again re-add the vdd_log pwm regulator. As it is not part of the mainline Linux dts right now, add it to the -u-boot dtsi for puma.
--- arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi | 11 +++++++++++ 1 file changed, 11 insertions(+)
arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi +11 -0
@@ -49,6 +49,17 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + + vdd_log: vdd-log { + compatible = "pwm-regulator"; + pwms = <&pwm2 0 25000 1>; + regulator-name = "vdd_log"; + regulator-min-microvolt = <800000>; + regulator-max-microvolt = <1400000>; + regulator-always-on; + regulator-boot-on; + regulator-init-microvolt = <950000>; + }; }; &gpio1 {
Signature · 1 line
2.30.2
Quoted 6 lines · Heiko Stuebner
The rk3399-puma board needs a 950mV
vdd_logto work stable. This was already added in
commit77012e79ffc3("rockchip: rk3399-puma: SetVDD_LOGto 950 mV") but lost again with
commit167efc2c7a46("arm64: dts: rk3399: Sync v5.7-rc1 from Linux")
Quoted 6 lines
So to make puma stable again re-add the
vdd_logpwm regulator. As it is not part of the mainline Linux dts right now, add it to the -u-boot dtsi for puma.Fixes 167efc2c7a46 ("arm64: dts: rk3399: Sync v5.7-rc1 from Linux")Signed-off-by Heiko Stuebner <[email protected]>
As the history shows here, this keeps getting lost on resync. What's the status on getting this in to the upstream dts itself?
Signature · 1 line
Tom
Hi Heiko,
Quoted 28 lines · Heiko Stuebner
The rk3399-puma board needs a 950mV
vdd_logto work stable. This was already added in
commit77012e79ffc3("rockchip: rk3399-puma: SetVDD_LOGto 950 mV") but lost again with
commit167efc2c7a46("arm64: dts: rk3399: Sync v5.7-rc1 from Linux")So to make puma stable again re-add the
vdd_logpwm regulator. As it is not part of the mainline Linux dts right now, add it to the -u-boot dtsi for puma.Fixes 167efc2c7a46 ("arm64: dts: rk3399: Sync v5.7-rc1 from Linux")Signed-off-by Heiko Stuebner <[email protected]>--- arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi | 11 +++++++++++ 1 file changed, 11 insertions(+)arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi +4
-0@@ -49,6 +49,17 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + + vdd_log: vdd-log { + compatible = "pwm-regulator"; + pwms = <&pwm2 0 25000 1>;
arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi line 65
Quoted 10 lines
arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi +7
-0+ regulator-name = "vdd_log"; + regulator-min-microvolt = <800000>; + regulator-max-microvolt = <1400000>; + regulator-always-on; + regulator-boot-on; + regulator-init-microvolt = <950000>; + }; }; &gpio1 {
Is this a spurious patch by any chance?
https://source.denx.de/u-boot/u-boot/-/commit/1621afc84f8a109cfdb98c9e370c355289e07870 seems to have more or less the same content, sent (and merged) about a year ago by Christoph.
Moreover, it seems to still be there in master: https://source.denx.de/u-boot/u-boot/-/blob/master/arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi#L52-L62
Cheers,
Quentin
Hi Quentin,
Am Montag, 3. Januar 2022, 13:26:09 CET schrieb Quentin Schulz:
Quoted 40 lines
Hi Heiko,
Quoted 37 lines · Heiko Stuebner
The rk3399-puma board needs a 950mV
vdd_logto work stable. This was already added in
commit77012e79ffc3("rockchip: rk3399-puma: SetVDD_LOGto 950 mV") but lost again with
commit167efc2c7a46("arm64: dts: rk3399: Sync v5.7-rc1 from Linux")So to make puma stable again re-add the
vdd_logpwm regulator. As it is not part of the mainline Linux dts right now, add it to the -u-boot dtsi for puma.Fixes 167efc2c7a46 ("arm64: dts: rk3399: Sync v5.7-rc1 from Linux")Signed-off-by Heiko Stuebner <[email protected]>--- arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi | 11 +++++++++++ 1 file changed, 11 insertions(+)arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi +11
-0@@ -49,6 +49,17 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + + vdd_log: vdd-log { + compatible = "pwm-regulator"; + pwms = <&pwm2 0 25000 1>; + regulator-name = "vdd_log"; + regulator-min-microvolt = <800000>; + regulator-max-microvolt = <1400000>; + regulator-always-on; + regulator-boot-on; + regulator-init-microvolt = <950000>; + }; };
Quoted 3 lines
arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi line 65
Quoted 1 line
arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi +0
-0&gpio1 {Is this a spurious patch by any chance?
yep, I realized that I was on 2021.01 still. Shortly after that the vdd_log was re-added by Christoph.
Heiko
Quoted 11 lines
https://source.denx.de/u-boot/u-boot/-/commit/1621afc84f8a109cfdb98c9e370c355289e07870
seems to have more or less the same content, sent (and merged) about a year ago by Christoph.Moreover, it seems to still be there in master:
https://source.denx.de/u-boot/u-boot/-/blob/master/arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi#L52-L62Cheers,
Quentin
Hi Heiko,
Quoted 7 lines · Heiko Stuebner <[email protected]> 于2021年12月26日周日 20:46写道:
The rk3399-puma board needs a 950mV
vdd_logto work stable. This was already added in
commit77012e79ffc3("rockchip: rk3399-puma: SetVDD_LOGto 950 mV") but lost again with
commit167efc2c7a46("arm64: dts: rk3399: Sync v5.7-rc1 from Linux")
Quoted 6 lines
So to make puma stable again re-add the
vdd_logpwm regulator. As it is not part of the mainline Linux dts right now, add it to the -u-boot dtsi for puma.Fixes 167efc2c7a46 ("arm64: dts: rk3399: Sync v5.7-rc1 from Linux")Signed-off-by Heiko Stuebner <[email protected]>
Thanks,
- Kever
Quoted 29 lines
--- arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi | 11 +++++++++++ 1 file changed, 11 insertions(+)arch/arm/dts/rk3399-puma-haikou-u-boot.dtsi +11
-1@@ -49,6 +49,17 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; }; + + vdd_log: vdd-log { + compatible = "pwm-regulator"; + pwms = <&pwm2 0 25000 1>; + regulator-name = "vdd_log"; + regulator-min-microvolt = <800000>; + regulator-max-microvolt = <1400000>; + regulator-always-on; + regulator-boot-on; + regulator-init-microvolt = <950000>; + }; }; &gpio1 { --2.30.2