m68k/kernel: array out of bound access in process_uboot_commandline
PATCH v2 1/1 m68k/kernel: array out of bound access in process_uboot_commandline
When the size of commandp >= size, array out of bound write occurs because len == 0.
Signed-off-by Hangyu Hua <[email protected]>
--- arch/m68k/kernel/uboot.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/m68k/kernel/uboot.c +2 -1
@@ -101,5 +101,6 @@ __init void process_uboot_commandline(char *commandp, int size) }parse_uboot_commandline (commandp, len); - commandp[len -1 ] =0 ; +if (len >0 ) + commandp[len -1 ] =0 ; }
Signature · 1 line
2.25.1
Geert Uytterhoeven
maintainerCC greg
Quoted 23 lines · Hangyu Hua
When the size of commandp >= size, array out of bound write occurs because len == 0.
Signed-off-by Hangyu Hua <[email protected]>--- arch/m68k/kernel/uboot.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)arch/m68k/kernel/uboot.c +2
-2@@ -101,5 +101,6 @@ __init void process_uboot_commandline(char *commandp, int size) }parse_uboot_commandline (commandp, len); - commandp[len -1 ] =0 ; +if (len >0 ) + commandp[len -1 ] =0 ; } --2.25.1
Hi, I think this patch may be forgotten. So I send this e-mail. And I cc Andreas
who helped me fix the initial version of this patch.
Happy new year.
Quoted 27 lines · Geert Uytterhoeven
CC greg
Quoted 23 lines · Hangyu Hua
When the size of commandp >= size, array out of bound write occurs because len == 0.
Signed-off-by Hangyu Hua <[email protected]>--- arch/m68k/kernel/uboot.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)arch/m68k/kernel/uboot.c +2
-2@@ -101,5 +101,6 @@ __init void process_uboot_commandline(char *commandp, int size) }parse_uboot_commandline (commandp, len); - commandp[len -1 ] =0 ; +if (len >0 ) + commandp[len -1 ] =0 ; } --2.25.1