Skip to contentSkip to conversation

Add PCIe support for Iomega iConnect board

PATCH In review Tony Dinh 3 participants 9 messages Jan 2, 2022 – Jan 14, 2022

lore
Share & tools
lore

Tony Dinh

author
#0 lore raw

cover Add PCIe support for Iomega iConnect board

The Iomega iConnect board has an internal mPCIe slot.
- Add PCIe support to enable the mPCIe slot to accept devices such as Wifi card or mSATA.
- Add SYS_THUMB_BUILD to keep u-boot image size within 512K
- Add myself as maintainer. Luka no longer has this board and wishes
to see someone maintaining it actively

Tony Dinh (3):
arm: kirkwood: iConnect : Add PCIe related configs
arm: kirkwood: iConnect : Add PCIe late init
arm: kirkwood: iConnect : Update board maintainer

 board/iomega/iconnect/MAINTAINERS | 1 +
 board/iomega/iconnect/iconnect.c  | 7 +++++++
 configs/iconnect_defconfig        | 5 +++++
 3 files changed, 13 insertions(+)
Signature · 1 line
2.30.2
author
#1 lore raw

PATCH 1/3 arm: kirkwood: iConnect : Add PCIe related configs

- Add MVEBU PCIe configs
- Also add SYS_THUMB_BUILD to keep u-boot image size within 512K

---

 configs/iconnect_defconfig | 5 +++++
 1 file changed, 5 insertions(+)
configs/iconnect_defconfig +5 -0
index d8593bcdd2..bc44dbd218 100644
@@ -2,6 +2,7 @@ CONFIG_ARM=y
 CONFIG_SKIP_LOWLEVEL_INIT=y
 CONFIG_SYS_DCACHE_OFF=y
 CONFIG_ARCH_CPU_INIT=y
+CONFIG_SYS_THUMB_BUILD=y
 CONFIG_ARCH_KIRKWOOD=y
 CONFIG_SYS_TEXT_BASE=0x600000
 CONFIG_NR_DRAM_BANKS=2
@@ -15,9 +16,11 @@ CONFIG_SYS_LOAD_ADDR=0x800000
 CONFIG_BOOTDELAY=3
 CONFIG_USE_PREBOOT=y
 # CONFIG_DISPLAY_BOARDINFO is not set
+CONFIG_BOARD_LATE_INIT=y
 CONFIG_SYS_PROMPT="iconnect => "
 # CONFIG_CMD_FLASH is not set
 CONFIG_CMD_NAND=y
+CONFIG_CMD_PCI=y
 CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_MII=y
@@ -40,6 +43,8 @@ CONFIG_MTD=y
 CONFIG_MTD_RAW_NAND=y
 CONFIG_MVGBE=y
 CONFIG_MII=y
+CONFIG_PCI=y
+CONFIG_PCI_MVEBU=y
 CONFIG_SYS_NS16550=y
 CONFIG_USB=y
 CONFIG_USB_EHCI_HCD=y
Signature · 1 line
2.30.2
Reviewed-by on v1 1/3
#2 lore raw

Re: [PATCH 1/3] arm: kirkwood: iConnect : Add PCIe related configs

Quoted 4 lines · Tony Dinh

- Add MVEBU PCIe configs
- Also add SYS_THUMB_BUILD to keep u-boot image size within 512K

Thanks,
Stefan

Quoted 31 lines

---

  configs/iconnect_defconfig | 5 +++++
  1 file changed, 5 insertions(+)
configs/iconnect_defconfig +3 -0
index d8593bcdd2..bc44dbd218 100644
@@ -2,6 +2,7 @@ CONFIG_ARM=y
  CONFIG_SKIP_LOWLEVEL_INIT=y
  CONFIG_SYS_DCACHE_OFF=y
  CONFIG_ARCH_CPU_INIT=y
+CONFIG_SYS_THUMB_BUILD=y
  CONFIG_ARCH_KIRKWOOD=y
  CONFIG_SYS_TEXT_BASE=0x600000
  CONFIG_NR_DRAM_BANKS=2
@@ -15,9 +16,11 @@ CONFIG_SYS_LOAD_ADDR=0x800000
  CONFIG_BOOTDELAY=3
  CONFIG_USE_PREBOOT=y
  # CONFIG_DISPLAY_BOARDINFO is not set
+CONFIG_BOARD_LATE_INIT=y
  CONFIG_SYS_PROMPT="iconnect => "
  # CONFIG_CMD_FLASH is not set
  CONFIG_CMD_NAND=y
+CONFIG_CMD_PCI=y
  CONFIG_CMD_USB=y
  # CONFIG_CMD_SETEXPR is not set
  CONFIG_CMD_MII=y

configs/iconnect_defconfig CONFIG_MTD=y · line 50

Quoted 8 lines
configs/iconnect_defconfig +2 -0
@@ -40,6 +43,8 @@ CONFIG_MTD=y
  CONFIG_MTD_RAW_NAND=y
  CONFIG_MVGBE=y
  CONFIG_MII=y
+CONFIG_PCI=y
+CONFIG_PCI_MVEBU=y
  CONFIG_SYS_NS16550=y
  CONFIG_USB=y
  CONFIG_USB_EHCI_HCD=y

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
author
#3 lore raw

PATCH 2/3 arm: kirkwood: iConnect : Add PCIe late init

In reply to Tony Dinh

- Add board_late_init function to enable pci_init

---

 board/iomega/iconnect/iconnect.c | 7 +++++++
 1 file changed, 7 insertions(+)
board/iomega/iconnect/iconnect.c +7 -0
index fe4be28b13..9e123aab00 100644
@@ -92,3 +92,10 @@ int board_init(void)
 
 	return 0;
 }
+
+int board_late_init(void)
+{
+	/* Do late init to ensure successful enumeration of PCIe devices */
+	pci_init();
+	return 0;
+}
Signature · 1 line
2.30.2
Reviewed-by on v1 2/3
#4 lore raw

Re: [PATCH 2/3] arm: kirkwood: iConnect : Add PCIe late init

Quoted 13 lines · Tony Dinh

- Add board_late_init function to enable pci_init

---

  board/iomega/iconnect/iconnect.c | 7 +++++++
  1 file changed, 7 insertions(+)
board/iomega/iconnect/iconnect.c +0 -0
index fe4be28b13..9e123aab00 100644

board/iomega/iconnect/iconnect.c int board_init(void) · line 99

Quoted 8 lines
board/iomega/iconnect/iconnect.c +5 -0
@@ -92,3 +92,10 @@ int board_init(void)
 
  	return 0;
  }
+
+int board_late_init(void)
+{
+	/* Do late init to ensure successful enumeration of PCIe devices */
+	pci_init();

Thanks,
Stefan

board/iomega/iconnect/iconnect.c int board_init(void) · line 101

Quoted 3 lines
board/iomega/iconnect/iconnect.c +2 -0
+	return 0;
+}

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
author
#5 lore raw

PATCH 3/3 arm: kirkwood: iConnect : Update board maintainer

In reply to Tony Dinh

Add myself as maintainer.

---

 board/iomega/iconnect/MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
board/iomega/iconnect/MAINTAINERS +1 -0
index 167cf074b9..a1b018e816 100644
@@ -1,4 +1,5 @@
 ICONNECT BOARD
+M:      Tony Dinh <[email protected]>
 M:	Luka Perkov <[email protected]>
 S:	Maintained
 F:	board/iomega/iconnect/
Signature · 1 line
2.30.2
Reviewed-by on v1 3/3
#6 lore raw

Re: [PATCH 3/3] arm: kirkwood: iConnect : Update board maintainer

Quoted 3 lines · Tony Dinh

Add myself as maintainer.

Thanks,
Stefan

Quoted 11 lines

---

  board/iomega/iconnect/MAINTAINERS | 1 +
  1 file changed, 1 insertion(+)
board/iomega/iconnect/MAINTAINERS +0 -0
index 167cf074b9..a1b018e816 100644

board/iomega/iconnect/MAINTAINERS line 5

Quoted 5 lines
board/iomega/iconnect/MAINTAINERS +1 -0
@@ -1,4 +1,5 @@
  ICONNECT BOARD
+M:      Tony Dinh <[email protected]>
  M:	Luka Perkov <[email protected]>
  S:	Maintained
  F:	board/iomega/iconnect/

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
Reviewed-by on the v1 series
#7 lore raw
In reply to Tony Dinh
Quoted 6 lines · On Saturday 01 January 2022 20:57:36 Tony Dinh wrote:

The Iomega iConnect board has an internal mPCIe slot.
- Add PCIe support to enable the mPCIe slot to accept devices such as Wifi card or mSATA.
- Add SYS_THUMB_BUILD to keep u-boot image size within 512K
- Add myself as maintainer. Luka no longer has this board and wishes
to see someone maintaining it actively

I guess that this series requires kirkwood patch which I sent recently:
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

Anyway, this patch series looks good, so:

Quoted 14 lines

Tony Dinh (3):
arm: kirkwood: iConnect : Add PCIe related configs
arm: kirkwood: iConnect : Add PCIe late init
arm: kirkwood: iConnect : Update board maintainer

 board/iomega/iconnect/MAINTAINERS | 1 +
 board/iomega/iconnect/iconnect.c  | 7 +++++++
 configs/iconnect_defconfig        | 5 +++++
 3 files changed, 13 insertions(+)
Signature · 1 line
2.30.2
#8 lore raw
In reply to Tony Dinh
Quoted 13 lines · Tony Dinh

The Iomega iConnect board has an internal mPCIe slot.
- Add PCIe support to enable the mPCIe slot to accept devices such as Wifi card or mSATA.
- Add SYS_THUMB_BUILD to keep u-boot image size within 512K
- Add myself as maintainer. Luka no longer has this board and wishes
to see someone maintaining it actively

Tony Dinh (3):
arm: kirkwood: iConnect : Add PCIe related configs
arm: kirkwood: iConnect : Add PCIe late init
arm: kirkwood: iConnect : Update board maintainer

Quoted 5 lines
  board/iomega/iconnect/MAINTAINERS | 1 +
  board/iomega/iconnect/iconnect.c  | 7 +++++++
  configs/iconnect_defconfig        | 5 +++++
  3 files changed, 13 insertions(+)

Applied to u-boot-marvell/master

Thanks,
Stefan