Skip to contentSkip to conversation

tests/kms_scaling_modes: New IGT to validate scaling modes

PATCH Superseded Swati Sharma 3 participants 8 messages Jan 3, 2022 – Jan 21, 2022 Arm/Amlogic Meson SoC support

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Swati Sharma

author
#0 lore raw

PATCH 1/1 tests/kms_scaling_modes: New IGT to validate scaling modes

In this IGT, various scaling modes are validated. Scaling mode is one of the connector properties. This property defines how a non-native mode is upscaled to the native mode of an LCD panel.

There are basically 4 types of scaling modes defined:

None:
No upscaling happens, scaling is left to the panel. Not all drivers expose this mode.
Full:
The output is upscaled to the full resolution of the panel, ignoring the aspect ratio. It will expand current image to the size of the monitor.
Center:
No upscaling happens, the output is centered within the native resolution the panel. As a result, black bars may appear around the image.
Full aspect:
The output is upscaled to maximize either the width or height while retaining the aspect ratio. It will fill the screen w/o stretching the image. Black bars are placed either on top and bottom or left and right of the picture.

Note: This IGT is build upon kms_panel_fitting

Signed-off-by Swati Sharma <[email protected]>
---
 tests/kms_scaling_modes.c | 167 ++++++++++++++++++++++++++++++++++++++
 tests/meson.build         |   1 +
 2 files changed, 168 insertions(+)
 create mode 100644 tests/kms_scaling_modes.c
tests/kms_scaling_modes.c new file +167 -0
new file mode 100644
index 00000000..d90783d0
@@ -0,0 +1,167 @@
+/*
+ * Copyright © 2022 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
+ * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+ * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ *
+ * Authors:
+ *     Swati Sharma <[email protected]>
+ *
+ */
+
+#include "igt.h"
+#include <fcntl.h>
+#include <termios.h>
+#include <unistd.h>
+
+IGT_TEST_DESCRIPTION("Test display scaling modes");
+
+/* Test flags */
+enum {
+	TEST_NONE = 1 << 0,
+	TEST_FULL = 1 << 1,
+	TEST_CENTER = 1 << 2,
+	TEST_FULLASPECT = 1 << 3,
+};
+
+/* Common test data */
+typedef struct data {
+	igt_display_t display;
+	int drm_fd;
+} data_t;
+
+static void test_cycle_flags(igt_output_t *output, uint32_t test_flags)
+{
+	if (test_flags & TEST_NONE)
+		igt_output_set_prop_value(output, IGT_CONNECTOR_SCALING_MODE, DRM_MODE_SCALE_NONE);
+	if (test_flags & TEST_FULL)
+		igt_output_set_prop_value(output, IGT_CONNECTOR_SCALING_MODE, DRM_MODE_SCALE_FULLSCREEN);
+	if (test_flags & TEST_CENTER)
+		igt_output_set_prop_value(output, IGT_CONNECTOR_SCALING_MODE, DRM_MODE_SCALE_CENTER);
+	if (test_flags & TEST_FULLASPECT)
+		igt_output_set_prop_value(output, IGT_CONNECTOR_SCALING_MODE, DRM_MODE_SCALE_ASPECT);
+}
+
+static void test_scaling_mode_on_output(igt_display_t *display, const enum pipe pipe,
+					igt_output_t *output, uint32_t flags)
+{
+	igt_plane_t *primary, *sprite;
+	drmModeModeInfo mode;
+	struct igt_fb red, blue;
+	int ret;
+
+	igt_output_set_pipe(output, pipe);
+	mode = *igt_output_get_mode(output);
+
+	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+	sprite = igt_output_get_plane_type(output, DRM_PLANE_TYPE_OVERLAY);
+
+	igt_create_color_fb(display->drm_fd, mode.hdisplay, mode.vdisplay,
+			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
+			    0.f, 0.f, 1.f, &blue);
+
+	igt_create_color_fb(display->drm_fd, 640, 480,
+			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
+			    1.f, 0.f, 0.f, &red);
+
+	igt_plane_set_fb(primary, &blue);
+	igt_plane_set_fb(sprite, &red);
+
+	igt_display_commit2(display, COMMIT_ATOMIC);
+
+	mode.hdisplay = 640;
+	mode.vdisplay = 480;
+	igt_output_override_mode(output, &mode);
+
+	igt_plane_set_fb(sprite, NULL);
+	igt_plane_set_fb(primary, &red);
+
+	test_cycle_flags(output, flags);
+
+	/* Don't pass ALLOW_MODESET with overridden mode, force fastset */
+	ret = igt_display_try_commit_atomic(display, 0, NULL);
+
+	if (ret != -EINVAL)
+		igt_display_commit_atomic(display, 0, NULL);
+	else
+		igt_skip_on_f(ret == -EINVAL, "Scaling mode not supported\n");
+
+        igt_remove_fb(display->drm_fd, &red);
+        igt_remove_fb(display->drm_fd, &blue);
+}
+
+/* Returns true if an output supports scaling mode property */
+static bool has_scaling_mode(igt_output_t *output)
+{
+	return igt_output_has_prop(output, IGT_CONNECTOR_SCALING_MODE) &&
+	       igt_output_get_prop(output, IGT_CONNECTOR_SCALING_MODE);
+}
+
+static void test_scaling_mode(data_t *data, uint32_t flags)
+{
+	igt_display_t *display = &data->display;
+	igt_output_t *output;
+	enum pipe pipe;
+	int valid_tests = 0;
+
+	for_each_pipe_with_valid_output(display, pipe, output) {
+		if (!has_scaling_mode(output))
+			continue;
+
+		igt_dynamic_f("%s-pipe-%s", output->name, kmstest_pipe_name(pipe));
+		igt_display_reset(display);
+		test_scaling_mode_on_output(display, pipe, output, flags);
+		valid_tests++;
+	}
+
+	igt_require_f(valid_tests, "No valid crtc/connector combinations found\n");
+}
+
+igt_main
+{
+	data_t data = {};
+
+	igt_fixture {
+		data.drm_fd = drm_open_driver_master(DRIVER_ANY);
+		igt_require(data.drm_fd >= 0);
+
+		kmstest_set_vt_graphics_mode();
+
+		igt_display_require(&data.display, data.drm_fd);
+		igt_require(data.display.is_atomic);
+
+		igt_display_require_output(&data.display);
+	}
+
+	igt_describe("Tests full display scaling mode");
+	igt_subtest_with_dynamic("scaling-mode-full")
+		test_scaling_mode(&data, TEST_FULL);
+	igt_describe("Tests center display scaling mode");
+	igt_subtest_with_dynamic("scaling-mode-center")
+		test_scaling_mode(&data, TEST_CENTER);
+	igt_describe("Tests full aspect display scaling mode");
+	igt_subtest_with_dynamic("scaling-mode-full-aspect")
+		test_scaling_mode(&data, TEST_FULLASPECT);
+	igt_describe("Tests none display scaling mode (no scaling)");
+	igt_subtest_with_dynamic("scaling-mode-none")
+		test_scaling_mode(&data, TEST_NONE);
+
+	igt_fixture
+		igt_display_fini(&data.display);
+}
tests/meson.build +1 -0
index c14acf99..7003d064 100644
@@ -50,6 +50,7 @@ test_progs = [
 	'kms_properties',
 	'kms_rmfb',
 	'kms_rotation_crc',
+	'kms_scaling_modes',
 	'kms_selftest',
 	'kms_sequence',
 	'kms_setmode',
Signature · 1 line
2.25.1
CI
#1 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_scaling_modes: New IGT to validate scaling modes

== Series Details ==

== Series Details ==

Series: tests/kms_scaling_modes: New IGT to validate scaling modes
URL : https://patchwork.freedesktop.org/series/98463/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11044 -> IGTPW_6532
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_6532 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_6532, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6532/index.html

Participating hosts (46 -> 36)
------------------------------

Missing (10): fi-kbl-soraka bat-dg1-6 bat-dg1-5 fi-tgl-u2 fi-bsw-cyan bat-adlp-6 bat-rpls-1 fi-bdw-samus bat-jsl-2 bat-jsl-1

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_6532:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@hangcheck:
- fi-ivb-3770: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11044/fi-ivb-3770/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6532/fi-ivb-3770/igt@i915_selftest@[email protected]

Known issues
------------

Here are the changes found in IGTPW_6532 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@semaphore:
- fi-bsw-nick: NOTRUN -> [SKIP][3] ([fdo#109271]) +17 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6532/fi-bsw-nick/igt@amdgpu/[email protected]

* igt@gem_flink_basic@bad-flink:
- fi-skl-6600u: [PASS][4] -> [FAIL][5] ([i915#4547])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11044/fi-skl-6600u/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6532/fi-skl-6600u/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [PASS][6] -> [INCOMPLETE][7] ([i915#3921])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11044/fi-snb-2600/igt@i915_selftest@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6532/fi-snb-2600/igt@i915_selftest@[email protected]

* igt@runner@aborted:
- fi-ivb-3770: NOTRUN -> [FAIL][8] ([fdo#109271] / [i915#2426] / [i915#4312])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6532/fi-ivb-3770/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@uncore:
- fi-bsw-nick: [INCOMPLETE][9] -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11044/fi-bsw-nick/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6532/fi-bsw-nick/igt@i915_selftest@[email protected]

#### Warnings ####

* igt@amdgpu/amd_prime@i915-to-amd:
- fi-tgl-1115g4: [SKIP][11] ([fdo#109315] / [i915#2575]) -> [SKIP][12] ([fdo#109315] / [i915#1888] / [i915#2575])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11044/fi-tgl-1115g4/igt@amdgpu/[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6532/fi-tgl-1115g4/igt@amdgpu/[email protected]

* igt@runner@aborted:
- fi-skl-6600u: [FAIL][13] ([i915#2722] / [i915#4312]) -> [FAIL][14] ([i915#4312])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11044/fi-skl-6600u/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6532/fi-skl-6600u/igt@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6322 -> IGTPW_6532

CI-20190529: 20190529
CI_DRM_11044: 7b527a181f96f90a4c2f04d2705bdaffdd8168b6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6532: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6532/index.html
IGT_6322: b0b7679b358b300b7b6bf42c6921d0aa1fc14388 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Testlist changes ==

+igt@kms_scaling_modes@scaling-mode-center
+igt@kms_scaling_modes@scaling-mode-full
+igt@kms_scaling_modes@scaling-mode-full-aspect
+igt@kms_scaling_modes@scaling-mode-none

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6532/index.html

CI
#2 lore raw

[igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_scaling_modes: New IGT to validate scaling modes

In reply to Swati Sharma
== Series Details ==

== Series Details ==

Series: tests/kms_scaling_modes: New IGT to validate scaling modes
URL : https://patchwork.freedesktop.org/series/98463/
State : warning

== Summary ==

Pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/476783 for the overview.

build-containers:build-debian has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/17229466):
Authenticating with credentials from job payload (GitLab Registry)
Pulling docker image registry.freedesktop.org/wayland/ci-templates/buildah:2019-08-13.0 ...
Using docker image sha256:594aa868d31ee3304dee8cae8a3433c89a6fcfcf6c7d420c04cce22f60147176 for registry.freedesktop.org/wayland/ci-templates/buildah:2019-08-13.0 with digest registry.freedesktop.org/wayland/ci-templates/buildah@sha256:7dbcf22cd2c1c7d49db0dc7b4ab207c3d6a4a09bd81cc3b71a688d3727d8749f ... section_end:1641287340:prepare_executor
section_start:1641287340:prepare_script
Preparing environment
Running on runner-lb3m2qse-project-3185-concurrent-0 via fdo-packet-m1xl-3...
section_end:1641287345:prepare_script
section_start:1641287345:get_sources
Getting source from Git repository

  $ eval "$CI_PRE_CLONE_SCRIPT"
  Fetching changes...
  Reinitialized existing Git repository in /builds/gfx-ci/igt-ci-tags/.git/
  fatal: unable to access 'https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags.git/': The requested URL returned error: 504
  section_end:1641289147:get_sources
  section_start:1641289147:cleanup_file_variables
  Cleaning up file based variables
  section_end:1641289148:cleanup_file_variables
  ERROR: Job failed: exit code 1

build-containers:build-debian-arm64 has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/17229468):
Authenticating with credentials from job payload (GitLab Registry)
Pulling docker image registry.freedesktop.org/wayland/ci-templates/buildah:2019-08-13.0 ...
Using docker image sha256:594aa868d31ee3304dee8cae8a3433c89a6fcfcf6c7d420c04cce22f60147176 for registry.freedesktop.org/wayland/ci-templates/buildah:2019-08-13.0 with digest registry.freedesktop.org/wayland/ci-templates/buildah@sha256:7dbcf22cd2c1c7d49db0dc7b4ab207c3d6a4a09bd81cc3b71a688d3727d8749f ... section_end:1641287340:prepare_executor
section_start:1641287340:prepare_script
Preparing environment
Running on runner-lb3m2qse-project-3185-concurrent-2 via fdo-packet-m1xl-3...
section_end:1641287345:prepare_script
section_start:1641287345:get_sources
Getting source from Git repository

  $ eval "$CI_PRE_CLONE_SCRIPT"
  Fetching changes...
  Reinitialized existing Git repository in /builds/gfx-ci/igt-ci-tags/.git/
  fatal: unable to access 'https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags.git/': The requested URL returned error: 504
  section_end:1641289147:get_sources
  section_start:1641289147:cleanup_file_variables
  Cleaning up file based variables
  section_end:1641289148:cleanup_file_variables
  ERROR: Job failed: exit code 1

build-containers:build-debian-armhf has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/17229467):
Authenticating with credentials from job payload (GitLab Registry)
Pulling docker image registry.freedesktop.org/wayland/ci-templates/buildah:2019-08-13.0 ...
Using docker image sha256:594aa868d31ee3304dee8cae8a3433c89a6fcfcf6c7d420c04cce22f60147176 for registry.freedesktop.org/wayland/ci-templates/buildah:2019-08-13.0 with digest registry.freedesktop.org/wayland/ci-templates/buildah@sha256:7dbcf22cd2c1c7d49db0dc7b4ab207c3d6a4a09bd81cc3b71a688d3727d8749f ... section_end:1641287340:prepare_executor
section_start:1641287340:prepare_script
Preparing environment
Running on runner-lb3m2qse-project-3185-concurrent-1 via fdo-packet-m1xl-3...
section_end:1641287345:prepare_script
section_start:1641287345:get_sources
Getting source from Git repository

  $ eval "$CI_PRE_CLONE_SCRIPT"
  Fetching changes...
  Reinitialized existing Git repository in /builds/gfx-ci/igt-ci-tags/.git/
  fatal: unable to access 'https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags.git/': The requested URL returned error: 504
  section_end:1641289147:get_sources
  section_start:1641289147:cleanup_file_variables
  Cleaning up file based variables
  section_end:1641289148:cleanup_file_variables
  ERROR: Job failed: exit code 1

build-containers:build-fedora has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/17229470):
Using Docker executor with image registry.freedesktop.org/wayland/ci-templates/buildah:2019-08-13.0 ...
Authenticating with credentials from job payload (GitLab Registry)
Pulling docker image registry.freedesktop.org/wayland/ci-templates/buildah:2019-08-13.0 ...
Using docker image sha256:594aa868d31ee3304dee8cae8a3433c89a6fcfcf6c7d420c04cce22f60147176 for registry.freedesktop.org/wayland/ci-templates/buildah:2019-08-13.0 with digest registry.freedesktop.org/wayland/ci-templates/buildah@sha256:7dbcf22cd2c1c7d49db0dc7b4ab207c3d6a4a09bd81cc3b71a688d3727d8749f ... section_end:1641287339:prepare_executor
section_start:1641287339:prepare_script
Preparing environment
Running on runner-ya9tm6yf-project-3185-concurrent-0 via fdo-packet-m1xl-2...
section_end:1641287342:prepare_script
section_start:1641287342:get_sources
Getting source from Git repository

  $ eval "$CI_PRE_CLONE_SCRIPT"
  Fetching changes...
  Reinitialized existing Git repository in /builds/gfx-ci/igt-ci-tags/.git/
  fatal: unable to access 'https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags.git/': The requested URL returned error: 504
  section_end:1641289144:get_sources
  section_start:1641289144:cleanup_file_variables
  Cleaning up file based variables
  section_end:1641289145:cleanup_file_variables
  ERROR: Job failed: exit code 1

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/476783

CI
#3 lore raw

[igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_scaling_modes: New IGT to validate scaling modes (rev2)

In reply to Swati Sharma
== Series Details ==

== Series Details ==

Series: tests/kms_scaling_modes: New IGT to validate scaling modes (rev2)
URL : https://patchwork.freedesktop.org/series/98463/
State : warning

== Summary ==

Pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/480700 for the overview.

build-containers:build-debian-arm64 has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/17430548):
Pulling docker image registry.freedesktop.org/wayland/ci-templates/buildah:2019-08-13.0 ...
Using docker image sha256:594aa868d31ee3304dee8cae8a3433c89a6fcfcf6c7d420c04cce22f60147176 for registry.freedesktop.org/wayland/ci-templates/buildah:2019-08-13.0 with digest registry.freedesktop.org/wayland/ci-templates/buildah@sha256:7dbcf22cd2c1c7d49db0dc7b4ab207c3d6a4a09bd81cc3b71a688d3727d8749f ... section_end:1641831439:prepare_executor
section_start:1641831439:prepare_script
Preparing environment
Running on runner-lb3m2qse-project-3185-concurrent-1 via fdo-packet-m1xl-3...
section_end:1641831447:prepare_script
section_start:1641831447:get_sources
Getting source from Git repository

  $ eval "$CI_PRE_CLONE_SCRIPT"
  Fetching changes...
  Reinitialized existing Git repository in /builds/gfx-ci/igt-ci-tags/.git/
  error: RPC failed; HTTP 504 curl 22 The requested URL returned error: 504
  fatal: the remote end hung up unexpectedly
  section_end:1641832661:get_sources
  section_start:1641832661:cleanup_file_variables
  Cleaning up file based variables
  section_end:1641832665:cleanup_file_variables
  ERROR: Job failed: exit code 1

build-containers:build-debian-armhf has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/17430547):
Authenticating with credentials from job payload (GitLab Registry)
Pulling docker image registry.freedesktop.org/wayland/ci-templates/buildah:2019-08-13.0 ...
Using docker image sha256:594aa868d31ee3304dee8cae8a3433c89a6fcfcf6c7d420c04cce22f60147176 for registry.freedesktop.org/wayland/ci-templates/buildah:2019-08-13.0 with digest registry.freedesktop.org/wayland/ci-templates/buildah@sha256:7dbcf22cd2c1c7d49db0dc7b4ab207c3d6a4a09bd81cc3b71a688d3727d8749f ... section_end:1641831439:prepare_executor
section_start:1641831439:prepare_script
Preparing environment
Running on runner-lb3m2qse-project-3185-concurrent-0 via fdo-packet-m1xl-3...
section_end:1641831447:prepare_script
section_start:1641831447:get_sources
Getting source from Git repository

  $ eval "$CI_PRE_CLONE_SCRIPT"
  Fetching changes...
  Reinitialized existing Git repository in /builds/gfx-ci/igt-ci-tags/.git/
  fatal: unable to access 'https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags.git/': The requested URL returned error: 504
  section_end:1641833257:get_sources
  section_start:1641833257:cleanup_file_variables
  Cleaning up file based variables
  section_end:1641833259:cleanup_file_variables
  ERROR: Job failed: exit code 1

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/480700

CI
#4 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_scaling_modes: New IGT to validate scaling modes (rev2)

In reply to Swati Sharma
== Series Details ==

== Series Details ==

Series: tests/kms_scaling_modes: New IGT to validate scaling modes (rev2)
URL : https://patchwork.freedesktop.org/series/98463/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11060 -> IGTPW_6547
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/index.html

Participating hosts (47 -> 38)
------------------------------

Additional (1): fi-icl-u2
Missing (10): fi-bdw-samus bat-dg1-6 bat-dg1-5 fi-bsw-cyan bat-adlp-6 bat-adlp-4 bat-rpls-1 bat-rpls-2 bat-jsl-2 bat-jsl-1

Known issues
------------

Here are the changes found in IGTPW_6547 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_cs_nop@fork-gfx0:
- fi-icl-u2: NOTRUN -> [SKIP][1] ([fdo#109315]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/fi-icl-u2/igt@amdgpu/[email protected]

* igt@gem_exec_suspend@basic-s3@smem:
- fi-skl-6600u: [PASS][2] -> [INCOMPLETE][3] ([i915#4547])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/fi-skl-6600u/igt@gem_exec_suspend@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/fi-skl-6600u/igt@gem_exec_suspend@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-icl-u2: NOTRUN -> [SKIP][4] ([i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/fi-icl-u2/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][5] ([i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/fi-icl-u2/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][6] ([fdo#111827]) +8 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/fi-icl-u2/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: NOTRUN -> [SKIP][7] ([fdo#109278]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/fi-icl-u2/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-u2: NOTRUN -> [SKIP][8] ([fdo#109285])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/fi-icl-u2/igt@[email protected]

* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][9] ([i915#3301])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/fi-icl-u2/igt@[email protected]

* igt@runner@aborted:
- fi-skl-6600u: NOTRUN -> [FAIL][10] ([i915#4312])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/fi-skl-6600u/igt@[email protected]

#### Possible fixes ####

* igt@i915_pm_rpm@module-reload:
- fi-kbl-soraka: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/fi-kbl-soraka/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/fi-kbl-soraka/igt@[email protected]

[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6326 -> IGTPW_6547

CI-20190529: 20190529
CI_DRM_11060: fc2f3e82805b4f14e1de3d3e1408ebbe3e982128 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6547: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/index.html
IGT_6326: ec75f64fcbcf4aac58fbf1bf629e8f59b19db4ce @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Testlist changes ==

+igt@kms_scaling_modes@scaling-mode-center
+igt@kms_scaling_modes@scaling-mode-full
+igt@kms_scaling_modes@scaling-mode-full-aspect
+igt@kms_scaling_modes@scaling-mode-none

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/index.html

CI
#5 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_scaling_modes: New IGT to validate scaling modes (rev2)

In reply to Swati Sharma
== Series Details ==

== Series Details ==

Series: tests/kms_scaling_modes: New IGT to validate scaling modes (rev2)
URL : https://patchwork.freedesktop.org/series/98463/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11060_full -> IGTPW_6547_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_6547_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_6547_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/index.html

Participating hosts (10 -> 7)
------------------------------

Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_6547_full:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@execlists:
- shard-glk: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-glk7/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-glk5/igt@i915_selftest@[email protected]

New tests
---------

New tests have been introduced between CI_DRM_11060_full and IGTPW_6547_full:

### New IGT tests (17) ###

* igt@kms_scaling_modes@scaling-mode-center:
- Statuses : 4 skip(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-center@edp-1-pipe-a:
- Statuses : 2 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-center@edp-1-pipe-b:
- Statuses : 2 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-center@edp-1-pipe-c:
- Statuses : 2 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-center@edp-1-pipe-d:
- Statuses : 1 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-full:
- Statuses : 4 skip(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-full-aspect:
- Statuses : 4 skip(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-full-aspect@edp-1-pipe-a:
- Statuses : 2 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-full-aspect@edp-1-pipe-b:
- Statuses : 2 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-full-aspect@edp-1-pipe-c:
- Statuses : 2 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-full-aspect@edp-1-pipe-d:
- Statuses : 1 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-full@edp-1-pipe-a:
- Statuses : 2 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-full@edp-1-pipe-b:
- Statuses : 2 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-full@edp-1-pipe-c:
- Statuses : 2 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-full@edp-1-pipe-d:
- Statuses : 1 pass(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-none:
- Statuses : 4 skip(s)
- Exec time: [0.0] s

* igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-a:
- Statuses : 2 pass(s)
- Exec time: [0.0] s

Known issues
------------

Here are the changes found in IGTPW_6547_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_create@create-massive:
- shard-kbl: NOTRUN -> [DMESG-WARN][3] ([i915#3002])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-kbl7/igt@[email protected]
- shard-apl: NOTRUN -> [DMESG-WARN][4] ([i915#3002])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-apl7/igt@[email protected]

* igt@gem_ctx_isolation@preservation-s3@rcs0:
- shard-apl: NOTRUN -> [DMESG-WARN][5] ([i915#180])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-apl2/igt@gem_ctx_isolation@[email protected]

* igt@gem_ctx_persistence@legacy-engines-hostile:
- shard-snb: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#1099])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-snb7/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-iclb: [PASS][7] -> [TIMEOUT][8] ([i915#2481] / [i915#3070])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-iclb4/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb4/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#2846])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-glk1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-glk6/igt@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][11] -> [FAIL][12] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-iclb3/igt@gem_exec_fair@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vecs0:
- shard-apl: NOTRUN -> [FAIL][13] ([i915#2842])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-apl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][14] -> [FAIL][15] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-glk1/igt@gem_exec_fair@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-glk5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-iclb: NOTRUN -> [FAIL][16] ([i915#2842])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb8/igt@gem_exec_fair@[email protected]
- shard-glk: NOTRUN -> [FAIL][17] ([i915#2842])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-glk1/igt@gem_exec_fair@[email protected]
- shard-tglb: NOTRUN -> [FAIL][18] ([i915#2842])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-tglb2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][19] -> [FAIL][20] ([i915#2842]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-kbl1/igt@gem_exec_fair@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_lmem_swapping@random:
- shard-apl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#4613]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-apl7/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#4613])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-kbl6/igt@[email protected]

* igt@gem_pxp@display-protected-crc:
- shard-iclb: NOTRUN -> [SKIP][23] ([i915#4270])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb5/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][24] ([i915#4270])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-tglb5/igt@[email protected]

* igt@gem_render_copy@linear-to-vebox-y-tiled:
- shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271]) +136 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-apl8/igt@[email protected]

* igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
- shard-kbl: NOTRUN -> [SKIP][26] ([fdo#109271]) +104 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-kbl6/igt@[email protected]

* igt@gem_render_copy@y-tiled-mc-ccs-to-y-tiled-ccs:
- shard-iclb: NOTRUN -> [SKIP][27] ([i915#768])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb5/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-iclb: NOTRUN -> [SKIP][28] ([i915#3323])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][29] ([i915#3323])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-tglb8/igt@[email protected]

* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-tglb: NOTRUN -> [SKIP][30] ([i915#3297])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-tglb1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][31] ([i915#3297])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb7/igt@[email protected]

* igt@gen9_exec_parse@shadow-peek:
- shard-tglb: NOTRUN -> [SKIP][32] ([i915#2527] / [i915#2856]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][33] ([i915#2856]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb7/igt@[email protected]

* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [PASS][34] -> [SKIP][35] ([fdo#109271])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-apl3/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-apl8/igt@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-kbl: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#1937])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-kbl7/igt@i915_pm_lpsp@[email protected]

* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-glk: [PASS][37] -> [DMESG-WARN][38] ([i915#118])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-glk7/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-glk7/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#3777]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-apl7/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#3777]) +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-kbl3/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-glk: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#3777]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-glk7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][42] ([fdo#111615])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-tglb8/igt@[email protected]

* igt@kms_big_joiner@invalid-modeset:
- shard-iclb: NOTRUN -> [SKIP][43] ([i915#2705])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb2/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][44] ([i915#2705])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-tglb7/igt@[email protected]

* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#3886]) +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-apl6/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#109278] / [i915#3886]) +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb7/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html
- shard-glk: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#3886]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-glk7/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#3886]) +3 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-kbl4/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-d-bad-aux-stride-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][49] ([fdo#111615] / [i915#3689]) +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-tglb5/igt@kms_ccs@pipe-d-bad-aux-stride-yf_tiled_ccs.html

* igt@kms_chamelium@dp-hpd-for-each-pipe:
- shard-iclb: NOTRUN -> [SKIP][50] ([fdo#109284] / [fdo#111827]) +3 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb4/igt@[email protected]

* igt@kms_chamelium@vga-hpd-for-each-pipe:
- shard-kbl: NOTRUN -> [SKIP][51] ([fdo#109271] / [fdo#111827]) +10 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-kbl1/igt@[email protected]

* igt@kms_color@pipe-d-gamma:
- shard-iclb: NOTRUN -> [SKIP][52] ([fdo#109278] / [i915#1149])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb5/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-green-to-red:
- shard-glk: NOTRUN -> [SKIP][53] ([fdo#109271] / [fdo#111827]) +3 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-glk3/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][54] ([fdo#109271] / [fdo#111827]) +12 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-apl4/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-0-5:
- shard-snb: NOTRUN -> [SKIP][55] ([fdo#109271] / [fdo#111827]) +4 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-snb4/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][56] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb7/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-red-to-blue:
- shard-tglb: NOTRUN -> [SKIP][57] ([fdo#109284] / [fdo#111827]) +5 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-tglb7/igt@[email protected]

* igt@kms_content_protection@atomic:
- shard-apl: NOTRUN -> [TIMEOUT][58] ([i915#1319])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-apl1/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-512x512-rapid-movement:
- shard-iclb: NOTRUN -> [SKIP][59] ([fdo#109278] / [fdo#109279]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb5/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][60] ([fdo#109279] / [i915#3359]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-tglb5/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-32x10-sliding:
- shard-tglb: NOTRUN -> [SKIP][61] ([i915#3359]) +5 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-tglb7/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: [PASS][62] -> [DMESG-WARN][63] ([i915#180]) +2 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-apl2/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-apl4/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-64x21-sliding:
- shard-iclb: NOTRUN -> [SKIP][64] ([fdo#109278]) +10 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb1/igt@[email protected]

* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-iclb: NOTRUN -> [SKIP][65] ([fdo#109274] / [fdo#109278]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb3/igt@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][66] -> [INCOMPLETE][67] ([i915#180] / [i915#1982])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-apl2/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-apl6/igt@[email protected]

* igt@kms_flip@2x-flip-vs-panning-vs-hang:
- shard-iclb: NOTRUN -> [SKIP][68] ([fdo#109274]) +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb4/igt@[email protected]

* igt@kms_flip@2x-wf_vblank-ts-check:
- shard-tglb: NOTRUN -> [SKIP][69] ([fdo#109274] / [fdo#111825]) +4 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-tglb7/igt@kms_flip@2x-wf_vblank-ts-check.html

* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling:
- shard-tglb: NOTRUN -> [SKIP][70] ([i915#2587])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-tglb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html
- shard-iclb: [PASS][71] -> [SKIP][72] ([i915#3701])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-iclb7/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt:
- shard-tglb: NOTRUN -> [SKIP][73] ([fdo#109280] / [fdo#111825]) +4 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-tglb1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][74] -> [DMESG-WARN][75] ([i915#180]) +1 similar issue
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-kbl6/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-kbl7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-pgflip-blt:
- shard-glk: NOTRUN -> [SKIP][76] ([fdo#109271]) +39 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-glk8/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-pgflip-blt.html

* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-iclb: NOTRUN -> [SKIP][77] ([fdo#109280]) +3 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-mmap-cpu.html

* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [PASS][78] -> [SKIP][79] ([i915#433])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-tglb6/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-tglb1/igt@[email protected]

* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#533])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-kbl3/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#533])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-glk1/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#533])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-apl7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][83] ([i915#265])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-apl3/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][84] ([fdo#108145] / [i915#265])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-apl8/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][85] ([i915#265]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-kbl1/igt@[email protected]

* igt@kms_plane_cursor@pipe-c-viewport-size-128:
- shard-snb: NOTRUN -> [SKIP][86] ([fdo#109271]) +87 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-snb5/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-kbl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#658])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-kbl7/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#658])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-glk5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][89] ([fdo#111068] / [i915#658])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb4/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#658])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-apl3/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][91] ([i915#2920])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-tglb3/igt@[email protected]

* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][92] -> [SKIP][93] ([fdo#109441]) +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb3/igt@kms_psr@psr2_cursor_render.html

* igt@kms_setmode@basic:
- shard-glk: [PASS][94] -> [FAIL][95] ([i915#31])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-glk2/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-glk1/igt@[email protected]

* igt@kms_sysfs_edid_timing:
- shard-apl: NOTRUN -> [FAIL][96] ([IGT#2])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-apl7/igt@kms_sysfs_edid_timing.html

* igt@nouveau_crc@pipe-d-source-outp-complete:
- shard-iclb: NOTRUN -> [SKIP][97] ([fdo#109278] / [i915#2530])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb8/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][98] ([i915#2530])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-tglb3/igt@[email protected]

* igt@perf@gen12-unprivileged-single-ctx-counters:
- shard-iclb: NOTRUN -> [SKIP][99] ([fdo#109289])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb4/igt@[email protected]

* igt@prime_nv_pcopy@test3_3:
- shard-iclb: NOTRUN -> [SKIP][100] ([fdo#109291]) +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb5/igt@prime_nv_pcopy@test3_3.html
- shard-tglb: NOTRUN -> [SKIP][101] ([fdo#109291]) +2 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-tglb8/igt@prime_nv_pcopy@test3_3.html

* igt@prime_vgem@fence-write-hang:
- shard-iclb: NOTRUN -> [SKIP][102] ([fdo#109295])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb8/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][103] ([fdo#109295])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-tglb2/igt@[email protected]

* igt@sysfs_clients@sema-50:
- shard-iclb: NOTRUN -> [SKIP][104] ([i915#2994])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb8/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#2994])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-kbl3/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#2994])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-apl2/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][107] ([fdo#109271] / [i915#2994])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-glk1/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][108] ([i915#2994])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-tglb1/igt@[email protected]

#### Possible fixes ####

* igt@gem_eio@kms:
- shard-tglb: [FAIL][109] ([i915#232]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-tglb1/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-tglb7/igt@[email protected]

* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [SKIP][111] ([i915#4525]) -> [PASS][112] +2 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-iclb8/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb1/igt@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][113] ([i915#2842]) -> [PASS][114] +3 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-kbl3/igt@gem_exec_fair@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-kbl4/igt@gem_exec_fair@[email protected]
- shard-glk: [FAIL][115] ([i915#2842]) -> [PASS][116] +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-glk2/igt@gem_exec_fair@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-glk2/igt@gem_exec_fair@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-iclb: [FAIL][117] ([i915#2346]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [INCOMPLETE][119] ([i915#636]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-kbl4/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-kbl3/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [DMESG-WARN][121] ([i915#180]) -> [PASS][122] +4 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-apl3/igt@kms_flip@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-apl6/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-kbl: [DMESG-WARN][123] ([i915#180]) -> [PASS][124] +1 similar issue
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-kbl7/igt@kms_flip@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-kbl7/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-move:
- shard-glk: [FAIL][125] ([i915#2546]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-glk8/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-glk2/igt@[email protected]

* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [SKIP][127] ([fdo#109441]) -> [PASS][128] +2 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-iclb6/igt@kms_psr@psr2_sprite_blt.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html

* igt@perf_pmu@enable-race@vecs0:
- shard-glk: [DMESG-WARN][129] ([i915#118]) -> [PASS][130] +2 similar issues
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11060/shard-glk2/igt@perf_pmu@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6547/index.html

#6 lore raw
In reply to Swati Sharma

Hi Swati,

I think this type scaling happen only on eDP with i915. What this mean is if there's on Intel CI shards boxes some with eDP and others without eDP there will be flip flopping with test skipping or running depending which box test will get to run on. If shards machines in same hw family are similar with respect to eDP then there's no issue on flip flopping for that reason.

Some comments below

Quoted 70 lines · Swati Sharma

In this IGT, various scaling modes are validated. Scaling mode is one of the connector properties. This property defines how a non-native mode is upscaled to the native mode of an LCD panel.

There are basically 4 types of scaling modes defined:

None:
No upscaling happens, scaling is left to the panel. Not all drivers expose this mode.
Full:
The output is upscaled to the full resolution of the panel, ignoring the aspect ratio. It will expand current image to the size of the monitor.
Center:
No upscaling happens, the output is centered within the native resolution the panel. As a result, black bars may appear around the image.
Full aspect:
The output is upscaled to maximize either the width or height while retaining the aspect ratio. It will fill the screen w/o stretching the image. Black bars are placed either on top and bottom or left and right of the picture.

Note: This IGT is build upon kms_panel_fitting

Signed-off-by Swati Sharma <[email protected]>
---
  tests/kms_scaling_modes.c | 167 ++++++++++++++++++++++++++++++++++++++
  tests/meson.build         |   1 +
  2 files changed, 168 insertions(+)

create mode 100644 tests/kms_scaling_modes.c

tests/kms_scaling_modes.c new file +31 -0
new file mode 100644
index 00000000..d90783d0
@@ -0,0 +1,167 @@
+/*
+ * Copyright © 2022 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
+ * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+ * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ *
+ * Authors:
+ *     Swati Sharma <[email protected]>
+ *
+ */
+
+#include "igt.h"
+#include <fcntl.h>
+#include <termios.h>
+#include <unistd.h>

tests/kms_scaling_modes.c line 41

Quoted 10 lines
tests/kms_scaling_modes.c new file +10 -0
+
+IGT_TEST_DESCRIPTION("Test display scaling modes");
+
+/* Test flags */
+enum {
+	TEST_NONE = 1 << 0,
+	TEST_FULL = 1 << 1,
+	TEST_CENTER = 1 << 2,
+	TEST_FULLASPECT = 1 << 3,
+};

I didn't notice this enum doing anything else than code DRM_MODE_SCALE_* to different numbers which will be translated in test_cycle_flags(..), is this translation layer needed? Quickly looking it seem when calling test_scaling_mode(..) you could give DRM_MODE_SCALE_* as the flag directly and in place of calling test_cycle_flags(..) you'd just call igt_output_set_prop_value(..)

Quoted 50 lines
tests/kms_scaling_modes.c new file +50 -0
+
+/* Common test data */
+typedef struct data {
+	igt_display_t display;
+	int drm_fd;
+} data_t;
+
+static void test_cycle_flags(igt_output_t *output, uint32_t test_flags)
+{
+	if (test_flags & TEST_NONE)
+		igt_output_set_prop_value(output, IGT_CONNECTOR_SCALING_MODE, DRM_MODE_SCALE_NONE);
+	if (test_flags & TEST_FULL)
+		igt_output_set_prop_value(output, IGT_CONNECTOR_SCALING_MODE, DRM_MODE_SCALE_FULLSCREEN);
+	if (test_flags & TEST_CENTER)
+		igt_output_set_prop_value(output, IGT_CONNECTOR_SCALING_MODE, DRM_MODE_SCALE_CENTER);
+	if (test_flags & TEST_FULLASPECT)
+		igt_output_set_prop_value(output, IGT_CONNECTOR_SCALING_MODE, DRM_MODE_SCALE_ASPECT);
+}
+
+static void test_scaling_mode_on_output(igt_display_t *display, const enum pipe pipe,
+					igt_output_t *output, uint32_t flags)
+{
+	igt_plane_t *primary, *sprite;
+	drmModeModeInfo mode;
+	struct igt_fb red, blue;
+	int ret;
+
+	igt_output_set_pipe(output, pipe);
+	mode = *igt_output_get_mode(output);
+
+	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+	sprite = igt_output_get_plane_type(output, DRM_PLANE_TYPE_OVERLAY);
+
+	igt_create_color_fb(display->drm_fd, mode.hdisplay, mode.vdisplay,
+			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
+			    0.f, 0.f, 1.f, &blue);
+
+	igt_create_color_fb(display->drm_fd, 640, 480,
+			    DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
+			    1.f, 0.f, 0.f, &red);
+
+	igt_plane_set_fb(primary, &blue);
+	igt_plane_set_fb(sprite, &red);
+
+	igt_display_commit2(display, COMMIT_ATOMIC);
+
+	mode.hdisplay = 640;
+	mode.vdisplay = 480;
+	igt_output_override_mode(output, &mode);
+

tests/kms_scaling_modes.c line 101

Quoted 10 lines
tests/kms_scaling_modes.c new file +10 -0
+	igt_plane_set_fb(sprite, NULL);
+	igt_plane_set_fb(primary, &red);
+
+	test_cycle_flags(output, flags);
+
+	/* Don't pass ALLOW_MODESET with overridden mode, force fastset */
+	ret = igt_display_try_commit_atomic(display, 0, NULL);
+
+	if (ret != -EINVAL)
+		igt_display_commit_atomic(display, 0, NULL);

Not sure why this commit? On above igt_display_try_commit_atomic(..) actual commit happened already.

tests/kms_scaling_modes.c line 106

Quoted 5 lines
tests/kms_scaling_modes.c new file +5 -0
+	else
+		igt_skip_on_f(ret == -EINVAL, "Scaling mode not supported\n");
+
+        igt_remove_fb(display->drm_fd, &red);
+        igt_remove_fb(display->drm_fd, &blue);

^^
indentation with spaces instead of tab cause it to look misaligned in patch.

Quoted 73 lines
tests/kms_scaling_modes.c new file +61 -0
+}
+
+/* Returns true if an output supports scaling mode property */
+static bool has_scaling_mode(igt_output_t *output)
+{
+	return igt_output_has_prop(output, IGT_CONNECTOR_SCALING_MODE) &&
+	       igt_output_get_prop(output, IGT_CONNECTOR_SCALING_MODE);
+}
+
+static void test_scaling_mode(data_t *data, uint32_t flags)
+{
+	igt_display_t *display = &data->display;
+	igt_output_t *output;
+	enum pipe pipe;
+	int valid_tests = 0;
+
+	for_each_pipe_with_valid_output(display, pipe, output) {
+		if (!has_scaling_mode(output))
+			continue;
+
+		igt_dynamic_f("%s-pipe-%s", output->name, kmstest_pipe_name(pipe));
+		igt_display_reset(display);
+		test_scaling_mode_on_output(display, pipe, output, flags);
+		valid_tests++;
+	}
+
+	igt_require_f(valid_tests, "No valid crtc/connector combinations found\n");
+}
+
+igt_main
+{
+	data_t data = {};
+
+	igt_fixture {
+		data.drm_fd = drm_open_driver_master(DRIVER_ANY);
+		igt_require(data.drm_fd >= 0);
+
+		kmstest_set_vt_graphics_mode();
+
+		igt_display_require(&data.display, data.drm_fd);
+		igt_require(data.display.is_atomic);
+
+		igt_display_require_output(&data.display);
+	}
+
+	igt_describe("Tests full display scaling mode");
+	igt_subtest_with_dynamic("scaling-mode-full")
+		test_scaling_mode(&data, TEST_FULL);
+	igt_describe("Tests center display scaling mode");
+	igt_subtest_with_dynamic("scaling-mode-center")
+		test_scaling_mode(&data, TEST_CENTER);
+	igt_describe("Tests full aspect display scaling mode");
+	igt_subtest_with_dynamic("scaling-mode-full-aspect")
+		test_scaling_mode(&data, TEST_FULLASPECT);
+	igt_describe("Tests none display scaling mode (no scaling)");
+	igt_subtest_with_dynamic("scaling-mode-none")
+		test_scaling_mode(&data, TEST_NONE);
+
+	igt_fixture
+		igt_display_fini(&data.display);
+}
tests/meson.build +1 -0
index c14acf99..7003d064 100644
@@ -50,6 +50,7 @@ test_progs = [
  	'kms_properties',
  	'kms_rmfb',
  	'kms_rotation_crc',
+	'kms_scaling_modes',
  	'kms_selftest',
  	'kms_sequence',
  	'kms_setmode',
author
#7 lore raw

Thanks JP for the review. Addressed all the review comments
in rev2 https://patchwork.freedesktop.org/patch/470363/?series=98463&rev=3

Quoted 252 lines · Juha-Pekka Heikkila

Hi Swati,

I think this type scaling happen only on eDP with i915. What this mean is if there's on Intel CI shards boxes some with eDP and others without eDP there will be flip flopping with test skipping or running depending which box test will get to run on. If shards machines in same hw family are similar with respect to eDP then there's no issue on flip flopping for that reason.

Some comments below

Quoted 80 lines · Swati Sharma

In this IGT, various scaling modes are validated. Scaling mode is one of the connector properties. This property defines how a non-native mode is upscaled to the native mode of an LCD panel.

There are basically 4 types of scaling modes defined:

    None:
        No upscaling happens, scaling is left to the panel. Not all drivers expose this mode.
    Full:
        The output is upscaled to the full resolution of the panel, ignoring the aspect ratio. It will expand current image to the size of the monitor.
    Center:
        No upscaling happens, the output is centered within the native resolution the panel. As a result, black bars may appear around the image.
    Full aspect:
        The output is upscaled to maximize either the width or height while retaining the aspect ratio. It will fill the screen w/o stretching the image. Black bars are placed either on top and bottom or left and right of the picture.

Note: This IGT is build upon kms_panel_fitting

Signed-off-by Swati Sharma <[email protected]>

---
  tests/kms_scaling_modes.c | 167 ++++++++++++++++++++++++++++++++++++++ tests/meson.build         |   1 +

  2 files changed, 168 insertions(+)

  create mode 100644 tests/kms_scaling_modes.c

tests/kms_scaling_modes.c new file +4 -0
new file mode 100644
index 00000000..d90783d0
@@ -0,0 +1,167 @@
+/*
+ * Copyright © 2022 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person

obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
+ * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+ * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ *
+ * Authors:
+ *     Swati Sharma <[email protected]>
+ *
+ */

tests/kms_scaling_modes.c new file +5 -0
+
+#include "igt.h"
+#include <fcntl.h>
+#include <termios.h>
+#include <unistd.h>

tests/kms_scaling_modes.c line 41

Quoted 10 lines
tests/kms_scaling_modes.c new file +10 -0
+
+IGT_TEST_DESCRIPTION("Test display scaling modes");
+
+/* Test flags */
+enum {
+    TEST_NONE = 1 << 0,
+    TEST_FULL = 1 << 1,
+    TEST_CENTER = 1 << 2,
+    TEST_FULLASPECT = 1 << 3,
+};

I didn't notice this enum doing anything else than code DRM_MODE_SCALE_* to different numbers which will be translated in test_cycle_flags(..), is this translation layer needed? Quickly looking it seem when calling test_scaling_mode(..) you could give DRM_MODE_SCALE_* as the flag directly and in place of calling test_cycle_flags(..) you'd just call igt_output_set_prop_value(..)

Quoted 55 lines
tests/kms_scaling_modes.c new file +11 -0
+
+/* Common test data */
+typedef struct data {
+    igt_display_t display;
+    int drm_fd;
+} data_t;
+
+static void test_cycle_flags(igt_output_t *output, uint32_t test_flags)
+{
+    if (test_flags & TEST_NONE)
+        igt_output_set_prop_value(output, IGT_CONNECTOR_SCALING_MODE,

DRM_MODE_SCALE_NONE);
+    if (test_flags & TEST_FULL)
+        igt_output_set_prop_value(output, IGT_CONNECTOR_SCALING_MODE, DRM_MODE_SCALE_FULLSCREEN);
+    if (test_flags & TEST_CENTER)
+        igt_output_set_prop_value(output, IGT_CONNECTOR_SCALING_MODE, DRM_MODE_SCALE_CENTER);
+    if (test_flags & TEST_FULLASPECT)
+        igt_output_set_prop_value(output, IGT_CONNECTOR_SCALING_MODE, DRM_MODE_SCALE_ASPECT);

tests/kms_scaling_modes.c new file +3 -0
+}
+
+static void test_scaling_mode_on_output(igt_display_t *display, const

enum pipe pipe,
+                    igt_output_t *output, uint32_t flags)

tests/kms_scaling_modes.c new file +29 -0
+{
+    igt_plane_t *primary, *sprite;
+    drmModeModeInfo mode;
+    struct igt_fb red, blue;
+    int ret;
+
+    igt_output_set_pipe(output, pipe);
+    mode = *igt_output_get_mode(output);
+
+    primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+    sprite = igt_output_get_plane_type(output, DRM_PLANE_TYPE_OVERLAY);
+
+    igt_create_color_fb(display->drm_fd, mode.hdisplay, mode.vdisplay,
+                DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
+                0.f, 0.f, 1.f, &blue);
+
+    igt_create_color_fb(display->drm_fd, 640, 480,
+                DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_NONE,
+                1.f, 0.f, 0.f, &red);
+
+    igt_plane_set_fb(primary, &blue);
+    igt_plane_set_fb(sprite, &red);
+
+    igt_display_commit2(display, COMMIT_ATOMIC);
+
+    mode.hdisplay = 640;
+    mode.vdisplay = 480;
+    igt_output_override_mode(output, &mode);
+

tests/kms_scaling_modes.c line 101

Quoted 10 lines
tests/kms_scaling_modes.c new file +10 -0
+    igt_plane_set_fb(sprite, NULL);
+    igt_plane_set_fb(primary, &red);
+
+    test_cycle_flags(output, flags);
+
+    /* Don't pass ALLOW_MODESET with overridden mode, force fastset */
+    ret = igt_display_try_commit_atomic(display, 0, NULL);
+
+    if (ret != -EINVAL)
+        igt_display_commit_atomic(display, 0, NULL);

Not sure why this commit? On above igt_display_try_commit_atomic(..) actual commit happened already.

Quoted 5 lines

+    else
+        igt_skip_on_f(ret == -EINVAL, "Scaling mode not supported\n"); +
+        igt_remove_fb(display->drm_fd, &red);
+        igt_remove_fb(display->drm_fd, &blue);

^^
indentation with spaces instead of tab cause it to look misaligned in patch.

Quoted 75 lines
tests/kms_scaling_modes.c new file +21 -0
+}
+
+/* Returns true if an output supports scaling mode property */
+static bool has_scaling_mode(igt_output_t *output)
+{
+    return igt_output_has_prop(output, IGT_CONNECTOR_SCALING_MODE) &&
+           igt_output_get_prop(output, IGT_CONNECTOR_SCALING_MODE);
+}
+
+static void test_scaling_mode(data_t *data, uint32_t flags)
+{
+    igt_display_t *display = &data->display;
+    igt_output_t *output;
+    enum pipe pipe;
+    int valid_tests = 0;
+
+    for_each_pipe_with_valid_output(display, pipe, output) {
+        if (!has_scaling_mode(output))
+            continue;
+
+        igt_dynamic_f("%s-pipe-%s", output->name,

kmstest_pipe_name(pipe));
+        igt_display_reset(display);
+        test_scaling_mode_on_output(display, pipe, output, flags); +        valid_tests++;
+    }
+
+    igt_require_f(valid_tests, "No valid crtc/connector combinations found\n");

tests/kms_scaling_modes.c new file +34 -0
+}
+
+igt_main
+{
+    data_t data = {};
+
+    igt_fixture {
+        data.drm_fd = drm_open_driver_master(DRIVER_ANY);
+        igt_require(data.drm_fd >= 0);
+
+        kmstest_set_vt_graphics_mode();
+
+        igt_display_require(&data.display, data.drm_fd);
+        igt_require(data.display.is_atomic);
+
+        igt_display_require_output(&data.display);
+    }
+
+    igt_describe("Tests full display scaling mode");
+    igt_subtest_with_dynamic("scaling-mode-full")
+        test_scaling_mode(&data, TEST_FULL);
+    igt_describe("Tests center display scaling mode");
+    igt_subtest_with_dynamic("scaling-mode-center")
+        test_scaling_mode(&data, TEST_CENTER);
+    igt_describe("Tests full aspect display scaling mode");
+    igt_subtest_with_dynamic("scaling-mode-full-aspect")
+        test_scaling_mode(&data, TEST_FULLASPECT);
+    igt_describe("Tests none display scaling mode (no scaling)");
+    igt_subtest_with_dynamic("scaling-mode-none")
+        test_scaling_mode(&data, TEST_NONE);
+
+    igt_fixture
+        igt_display_fini(&data.display);
+}
tests/meson.build +1 -0
index c14acf99..7003d064 100644
@@ -50,6 +50,7 @@ test_progs = [
       'kms_properties',
       'kms_rmfb',
       'kms_rotation_crc',
+    'kms_scaling_modes',
       'kms_selftest',
       'kms_sequence',
       'kms_setmode',
Signature · 1 line
~Swati Sharma