Skip to contentSkip to conversation

drm/bridge: Add missing pm_runtime_disable() in __dw_mipi_dsi_probe

PATCH In review Miaoqian Lin 2 participants 2 messages Jan 5, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/bridge: Add missing pm_runtime_disable() in __dw_mipi_dsi_probe

If the probe fails, we should use pm_runtime_disable() to balance pm_runtime_enable().
Add missing pm_runtime_disable() for __dw_mipi_dsi_probe.

Fixes 46fc515 ("drm/bridge/synopsys: Add MIPI DSI host controller bridge")
---
 drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c +1 -0
index e44e18a0112a..56c3fd08c6a0 100644
@@ -1199,6 +1199,7 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
 	ret = mipi_dsi_host_register(&dsi->dsi_host);
 	if (ret) {
 		dev_err(dev, "Failed to register MIPI host: %d\n", ret);
+		pm_runtime_disable(dev);
 		dw_mipi_dsi_debugfs_remove(dsi);
 		return ERR_PTR(ret);
 	}
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw

Hey,

Thanks for submitting this fix.

Quoted 24 lines · Miaoqian Lin

If the probe fails, we should use pm_runtime_disable() to balance pm_runtime_enable().
Add missing pm_runtime_disable() for __dw_mipi_dsi_probe.

Fixes 46fc515 ("drm/bridge/synopsys: Add MIPI DSI host controller bridge")
---
 drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c +1 -1
index e44e18a0112a..56c3fd08c6a0 100644
@@ -1199,6 +1199,7 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
        ret = mipi_dsi_host_register(&dsi->dsi_host);
        if (ret) {
                dev_err(dev, "Failed to register MIPI host: %d\n", ret);
+               pm_runtime_disable(dev);
                dw_mipi_dsi_debugfs_remove(dsi);
                return ERR_PTR(ret);
        }
--
Quoted 2 lines

2.17.1

Added r-b tag and applied to drm-misc-next