drm/bridge: Add missing pm_runtime_disable() in __dw_mipi_dsi_probe
Subsystems (3)
PATCH 1/1 drm/bridge: Add missing pm_runtime_disable() in __dw_mipi_dsi_probe
If the probe fails, we should use pm_runtime_disable() to balance pm_runtime_enable().
Add missing pm_runtime_disable() for __dw_mipi_dsi_probe.
Fixes 46fc515 ("drm/bridge/synopsys: Add MIPI DSI host controller bridge")
Signed-off-by Miaoqian Lin <[email protected]>
--- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c +1 -0
@@ -1199,6 +1199,7 @@ __dw_mipi_dsi_probe(struct platform_device *pdev, ret =mipi_dsi_host_register (&dsi->dsi_host);if (ret) {dev_err (dev,"Failed to register MIPI host: %d\n" , ret); +pm_runtime_disable (dev);dw_mipi_dsi_debugfs_remove (dsi);return ERR_PTR (ret); }
Signature · 1 line
2.17.1
Hey,
Thanks for submitting this fix.
Quoted 24 lines · Miaoqian Lin
If the probe fails, we should use
pm_runtime_disable()to balancepm_runtime_enable().
Add missingpm_runtime_disable()for__dw_mipi_dsi_probe.Fixes 46fc515 ("drm/bridge/synopsys: Add MIPI DSI host controller bridge")Signed-off-by Miaoqian Lin <[email protected]>--- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c +1
-1@@ -1199,6 +1199,7 @@ __dw_mipi_dsi_probe(struct platform_device *pdev, ret =mipi_dsi_host_register (&dsi->dsi_host);if (ret) {dev_err (dev,"Failed to register MIPI host: %d\n" , ret); +pm_runtime_disable (dev);dw_mipi_dsi_debugfs_remove (dsi);return ERR_PTR (ret); } --
Quoted 2 lines
2.17.1
Added r-b tag and applied to drm-misc-next
Reviewed-by Robert Foss <[email protected]>