habanalabs: silence an uninitialized variable warning
Subsystems (2)
PATCH 1/1 habanalabs: silence an uninitialized variable warning
Smatch warns that:
drivers/misc/habanalabs/common/command_buffer.c:471 hl_cb_ioctl()
error: uninitialized symbol 'device_va'.
Which is true, but harmless. Anyway, it's easy to silence this by adding a error check.
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/misc/habanalabs/common/command_buffer.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/misc/habanalabs/common/command_buffer.c +2 -0
@@ -464,6 +464,8 @@ int hl_cb_ioctl(struct hl_fpriv *hpriv, void *data) args->in.flags, &usage_cnt, &device_va); +if (rc) +break ;memset (&args->out,0 ,sizeof (args->out));
Signature · 1 line
2.20.1
Quoted 28 lines · Dan Carpenter
Smatch warns that:
drivers/misc/habanalabs/common/command_buffer.c:471hl_cb_ioctl()
error: uninitialized symbol 'device_va'.Which is true, but harmless. Anyway, it's easy to silence this by adding a error check.
Signed-off-by Dan Carpenter <[email protected]>--- drivers/misc/habanalabs/common/command_buffer.c | 2 ++ 1 file changed, 2 insertions(+)drivers/misc/habanalabs/common/command_buffer.c +2
-1@@ -464,6 +464,8 @@ int hl_cb_ioctl(struct hl_fpriv *hpriv, void *data) args->in.flags, &usage_cnt, &device_va); +if (rc) +break ;memset (&args->out,0 ,sizeof (args->out)); --
Quoted 2 lines
2.20.1
Thanks!
Reviewed-by Oded Gabbay <[email protected]>
Applied to -next.