Skip to contentSkip to conversation

habanalabs: silence an uninitialized variable warning

PATCH Applied Dan Carpenter 2 participants 2 messages Jan 11, 2022 – Jan 23, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 habanalabs: silence an uninitialized variable warning

Smatch warns that:

drivers/misc/habanalabs/common/command_buffer.c:471 hl_cb_ioctl()
error: uninitialized symbol 'device_va'.

Which is true, but harmless. Anyway, it's easy to silence this by adding a error check.

---
 drivers/misc/habanalabs/common/command_buffer.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/misc/habanalabs/common/command_buffer.c +2 -0
index 3c0ae07a2d80..b9483a3cee91 100644
@@ -464,6 +464,8 @@ int hl_cb_ioctl(struct hl_fpriv *hpriv, void *data)
 				args->in.flags,
 				&usage_cnt,
 				&device_va);
+		if (rc)
+			break;
 
 		memset(&args->out, 0, sizeof(args->out));
 
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1 Applied
#1 lore raw
Quoted 28 lines · Dan Carpenter

Smatch warns that:

drivers/misc/habanalabs/common/command_buffer.c:471 hl_cb_ioctl()
error: uninitialized symbol 'device_va'.

Which is true, but harmless. Anyway, it's easy to silence this by adding a error check.

---
 drivers/misc/habanalabs/common/command_buffer.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/misc/habanalabs/common/command_buffer.c +2 -1
index 3c0ae07a2d80..b9483a3cee91 100644
@@ -464,6 +464,8 @@ int hl_cb_ioctl(struct hl_fpriv *hpriv, void *data)
                                args->in.flags,
                                &usage_cnt,
                                &device_va);
+               if (rc)
+                       break;
 
                memset(&args->out, 0, sizeof(args->out));
 
--
Quoted 2 lines

2.20.1

Thanks!

Applied to -next.