rtc: mc146818-lib: fix signedness bug in mc146818_get_time()
Subsystems (3)
PATCH 1/1 rtc: mc146818-lib: fix signedness bug in mc146818_get_time()
The mc146818_get_time() function returns zero on success or negative a error code on failure. It needs to be type int.
Fixes d35786b3a28d ("rtc: mc146818-lib: change return values of mc146818_get_time()")
Signed-off-by Dan Carpenter <[email protected]>
--- include/linux/mc146818rtc.h | 2 +- drivers/rtc/rtc-mc146818-lib.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
include/linux/mc146818rtc.h +1 -1
@@ -124,7 +124,7 @@ struct cmos_rtc_board_info {#endif /* ARCH_RTC_LOCATION */ bool mc146818_does_rtc_work (void ); -unsigned int mc146818_get_time (struct rtc_time *time); +int mc146818_get_time (struct rtc_time *time);int mc146818_set_time (struct rtc_time *time); bool mc146818_avoid_UIP(void (*callback)(unsigned char seconds, void *param),
drivers/rtc/rtc-mc146818-lib.c +1 -1
@@ -130,7 +130,7 @@ static void mc146818_get_time_callback(unsigned char seconds, void *param_in) p->ctrl =CMOS_READ (RTC_CONTROL ); } -unsigned int mc146818_get_time (struct rtc_time *time) +int mc146818_get_time (struct rtc_time *time) {struct mc146818_get_time_callback_param p = { .time = time
Signature · 1 line
2.20.1
W dniu 11.01.2022 o 08:19, Dan Carpenter pisze:
Quoted 5 lines
The
mc146818_get_time()function returns zero on success or negative a error code on failure. It needs to be type int.Fixes d35786b3a28d ("rtc: mc146818-lib: change return values of mc146818_get_time()")Signed-off-by Dan Carpenter <[email protected]>
Indeed, thanks for spotting this.
Reviewed-by Mateusz Jończyk <[email protected]>
Quoted 31 lines
--- include/linux/mc146818rtc.h | 2 +- drivers/rtc/rtc-mc146818-lib.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)include/linux/mc146818rtc.h +1
-1@@ -124,7 +124,7 @@ struct cmos_rtc_board_info {#endif /* ARCH_RTC_LOCATION */ bool mc146818_does_rtc_work (void ); -unsigned int mc146818_get_time (struct rtc_time *time); +int mc146818_get_time (struct rtc_time *time);int mc146818_set_time (struct rtc_time *time); bool mc146818_avoid_UIP(void (*callback)(unsigned char seconds, void *param),drivers/rtc/rtc-mc146818-lib.c +1
-1@@ -130,7 +130,7 @@ static void mc146818_get_time_callback(unsigned char seconds, void *param_in) p->ctrl =CMOS_READ (RTC_CONTROL ); } -unsigned int mc146818_get_time (struct rtc_time *time) +int mc146818_get_time (struct rtc_time *time) {struct mc146818_get_time_callback_param p = { .time = time
Quoted 4 lines · Dan Carpenter
The
mc146818_get_time()function returns zero on success or negative a error code on failure. It needs to be type int.
Applied, thanks!
[1/1] rtc: mc146818-lib: fix signedness bug in mc146818_get_time()
commit: 7372971c1be5b7d4fdd8ad237798bdc1d1d54162
Best regards,
Signature · 1 line
Alexandre Belloni <[email protected]>