Skip to contentSkip to conversation

rtc: mc146818-lib: fix signedness bug in mc146818_get_time()

PATCH Applied Dan Carpenter 3 participants 3 messages Jan 11, 2022 – Jan 16, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rtc: mc146818-lib: fix signedness bug in mc146818_get_time()

The mc146818_get_time() function returns zero on success or negative a error code on failure. It needs to be type int.

Fixes d35786b3a28d ("rtc: mc146818-lib: change return values of mc146818_get_time()")
---
 include/linux/mc146818rtc.h                    | 2 +-
 drivers/rtc/rtc-mc146818-lib.c                 | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
include/linux/mc146818rtc.h +1 -1
index 67fb0a12becc..808bb4cee230 100644
@@ -124,7 +124,7 @@ struct cmos_rtc_board_info {
 #endif /* ARCH_RTC_LOCATION */
 
 bool mc146818_does_rtc_work(void);
-unsigned int mc146818_get_time(struct rtc_time *time);
+int mc146818_get_time(struct rtc_time *time);
 int mc146818_set_time(struct rtc_time *time);
 
 bool mc146818_avoid_UIP(void (*callback)(unsigned char seconds, void *param),
drivers/rtc/rtc-mc146818-lib.c +1 -1
index f62e658cbe23..7f689f1bafc5 100644
@@ -130,7 +130,7 @@ static void mc146818_get_time_callback(unsigned char seconds, void *param_in)
 	p->ctrl = CMOS_READ(RTC_CONTROL);
 }
 
-unsigned int mc146818_get_time(struct rtc_time *time)
+int mc146818_get_time(struct rtc_time *time)
 {
 	struct mc146818_get_time_callback_param p = {
 		.time = time
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw

W dniu 11.01.2022 o 08:19, Dan Carpenter pisze:

Quoted 5 lines

The mc146818_get_time() function returns zero on success or negative a error code on failure. It needs to be type int.

Fixes d35786b3a28d ("rtc: mc146818-lib: change return values of mc146818_get_time()")

Indeed, thanks for spotting this.

Quoted 31 lines
---
 include/linux/mc146818rtc.h                    | 2 +-
 drivers/rtc/rtc-mc146818-lib.c                 | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
include/linux/mc146818rtc.h +1 -1
index 67fb0a12becc..808bb4cee230 100644
@@ -124,7 +124,7 @@ struct cmos_rtc_board_info {
 #endif /* ARCH_RTC_LOCATION */
 
 bool mc146818_does_rtc_work(void);
-unsigned int mc146818_get_time(struct rtc_time *time);
+int mc146818_get_time(struct rtc_time *time);
 int mc146818_set_time(struct rtc_time *time);
 
 bool mc146818_avoid_UIP(void (*callback)(unsigned char seconds, void *param),
drivers/rtc/rtc-mc146818-lib.c +1 -1
index f62e658cbe23..7f689f1bafc5 100644
@@ -130,7 +130,7 @@ static void mc146818_get_time_callback(unsigned char seconds, void *param_in)
 	p->ctrl = CMOS_READ(RTC_CONTROL);
 }
 
-unsigned int mc146818_get_time(struct rtc_time *time)
+int mc146818_get_time(struct rtc_time *time)
 {
 	struct mc146818_get_time_callback_param p = {
 		.time = time
maintainer Applied
#2 lore raw
In reply to Dan Carpenter
Quoted 4 lines · Dan Carpenter

The mc146818_get_time() function returns zero on success or negative a error code on failure. It needs to be type int.

Applied, thanks!

[1/1] rtc: mc146818-lib: fix signedness bug in mc146818_get_time()

      commit: 7372971c1be5b7d4fdd8ad237798bdc1d1d54162

Best regards,

Signature · 1 line
Alexandre Belloni <[email protected]>