Skip to contentSkip to conversation

GitHub Actions: ensure Ubuntu builds are made with the chosen SSL library

PATCH Superseded Antonio Quartulli 1 participant 2 messages Jan 14, 2022

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 GitHub Actions: ensure Ubuntu builds are made with the chosen SSL library

The configure parameter was appended to the stage name but not to the actual command. Fix this.

---
 .github/workflows/build.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
.github/workflows/build.yaml +2 -2
index ea1233b1..f96515bc 100644
@@ -161,8 +161,8 @@ jobs:
         uses: actions/[email protected]...
       - name: autoconf
         run: autoreconf -fvi
-      - name: configure --with-crypto-library=${{matrix.ssllib}}
-        run: ./configure
+      - name: configure
+        run: ./configure --with-crypto-library=${{matrix.ssllib}}
       - name: make all
         run: make -j3
       - name: make check
Signature · 1 line
2.34.1
#1 lore raw

NAK.

This change still lacks installing mbedtls as dependency.

Quoted 23 lines · Antonio Quartulli

The configure parameter was appended to the stage name but not to the actual command. Fix this.

---
  .github/workflows/build.yaml | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
.github/workflows/build.yaml +2 -2
index ea1233b1..f96515bc 100644
@@ -161,8 +161,8 @@ jobs:
          uses: actions/[email protected]...
        - name: autoconf
          run: autoreconf -fvi
-      - name: configure --with-crypto-library=${{matrix.ssllib}}
-        run: ./configure
+      - name: configure
+        run: ./configure --with-crypto-library=${{matrix.ssllib}}
        - name: make all
          run: make -j3
        - name: make check
Signature · 1 line
Antonio Quartulli