drm/bridge: Remove extra device acquisition method of i2c client in lt9611 driver
Subsystems (3)
PATCH v3 1/1 drm/bridge: Remove extra device acquisition method of i2c client in lt9611 driver
drm/bridge: Remove extra device acquisition method of i2c client in lt9611 driver.
We have got the device of i2c client in probe function.So we should remove extra device acquisition method of i2c client.
--- drivers/gpu/drm/bridge/lontium-lt9611.c | 4 ++-- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/bridge/lontium-lt9611.c +2 -2
@@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,if (!lt9611)return -ENOMEM ; - lt9611->dev = &client->dev; + lt9611->dev = dev; lt9611->client = client; lt9611->sleep = false;
@@ -1100,7 +1100,7 @@ static int lt9611_probe(struct i2c_client *client,return PTR_ERR (lt9611->regmap); } - ret =lt9611_parse_dt (&client->dev, lt9611); + ret =lt9611_parse_dt (dev, lt9611);if (ret) {dev_err (dev,"failed to parse device tree\n" );return ret;
drivers/gpu/drm/bridge/lontium-lt9611uxc.c +2 -2
@@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,if (!lt9611uxc)return -ENOMEM ; - lt9611uxc->dev = &client->dev; + lt9611uxc->dev = dev; lt9611uxc->client = client;mutex_init (<9611uxc->ocm_lock);
@@ -870,7 +870,7 @@ static int lt9611uxc_probe(struct i2c_client *client,return PTR_ERR (lt9611uxc->regmap); } - ret =lt9611uxc_parse_dt (&client->dev, lt9611uxc); + ret =lt9611uxc_parse_dt (dev, lt9611uxc);if (ret) {dev_err (dev,"failed to parse device tree\n" );return ret;
Signature · 1 line
2.25.1
Hey Zhiming,
Quoted 2 lines · Zhiming Liu
drm/bridge: Remove extra device acquisition method of i2c client in lt9611 driver.
The commit title is already in the email title, it doesn't need to be sent twice, sorry if I was unclear about this.
Quoted 2 lines
We have got the device of i2c client in probe function.So we should remove extra
This line is too long, and checkpatch.pl --strict complains about its length.
Quoted 44 lines
device acquisition method of i2c client.
Signed-off-by Zhiming Liu <[email protected]>--- drivers/gpu/drm/bridge/lontium-lt9611.c | 4 ++-- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)drivers/gpu/drm/bridge/lontium-lt9611.c +2
-2@@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,if (!lt9611)return -ENOMEM ; - lt9611->dev = &client->dev; + lt9611->dev = dev; lt9611->client = client; lt9611->sleep = false;@@ -1100,7 +1100,7 @@ static int lt9611_probe(struct i2c_client *client,return PTR_ERR (lt9611->regmap); } - ret =lt9611_parse_dt (&client->dev, lt9611); + ret =lt9611_parse_dt (dev, lt9611);if (ret) {dev_err (dev,"failed to parse device tree\n" );return ret;drivers/gpu/drm/bridge/lontium-lt9611uxc.c +1
-1@@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,if (!lt9611uxc)return -ENOMEM ; - lt9611uxc->dev = &client->dev; + lt9611uxc->dev = dev; lt9611uxc->client = client;mutex_init (<9611uxc->ocm_lock);
drivers/gpu/drm/bridge/lontium-lt9611uxc.c static int lt9611uxc_probe(struct i2c_client *client,
Quoted 9 lines
drivers/gpu/drm/bridge/lontium-lt9611uxc.c +1
-2@@ -870,7 +870,7 @@ static int lt9611uxc_probe(struct i2c_client *client,return PTR_ERR (lt9611uxc->regmap); } - ret =lt9611uxc_parse_dt (&client->dev, lt9611uxc); + ret =lt9611uxc_parse_dt (dev, lt9611uxc);if (ret) {dev_err (dev,"failed to parse device tree\n" );return ret; --
I fixed the two remaining issues in your patch, but in the future I would suggest running checkpatch.pl --strict on every patch before emailing them out. It's very easy to miss something.
Applied to drm-misc-next.