Skip to contentSkip to conversation

Remove extra device acquisition method of i2c client in lt9611 driver

PATCH Superseded lzmlzm 2 participants 4 messages Jan 11, 2022 – Jan 14, 2022

Subsystems (3)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

lzmlzm

author
#0 lore raw

PATCH 1/1 Remove extra device acquisition method of i2c client in lt9611 driver

---
 drivers/gpu/drm/bridge/lontium-lt9611.c    | 2 +-
 drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/bridge/lontium-lt9611.c +1 -1
index dafb1b47c15f..e0feb4fd9780 100644
@@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,
 	if (!lt9611)
 		return -ENOMEM;
 
-	lt9611->dev = &client->dev;
+	lt9611->dev = dev;
 	lt9611->client = client;
 	lt9611->sleep = false;
 
drivers/gpu/drm/bridge/lontium-lt9611uxc.c +1 -1
index 33f9716da0ee..e50e42312e82 100644
@@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
 	if (!lt9611uxc)
 		return -ENOMEM;
 
-	lt9611uxc->dev = &client->dev;
+	lt9611uxc->dev = dev;
 	lt9611uxc->client = client;
 	mutex_init(&lt9611uxc->ocm_lock);
 
Signature · 1 line
2.25.1
#1 lore raw

Hello,

Thanks for submitting this cleanup patch.

Quoted 1 line · lzmlzm

A commit message is necessary for all changes, no matter how trivial.

Quoted 1 line

Is your name listed correctly above? For the 'Signed-off-by' tag to be meaningful, a real name needs to be supplied.

Quoted 23 lines
---
 drivers/gpu/drm/bridge/lontium-lt9611.c    | 2 +-
 drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/bridge/lontium-lt9611.c +1 -1
index dafb1b47c15f..e0feb4fd9780 100644
@@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,
        if (!lt9611)
                return -ENOMEM;
 
-       lt9611->dev = &client->dev;
+       lt9611->dev = dev;
        lt9611->client = client;
        lt9611->sleep = false;
 
drivers/gpu/drm/bridge/lontium-lt9611uxc.c +0 -0
index 33f9716da0ee..e50e42312e82 100644

drivers/gpu/drm/bridge/lontium-lt9611uxc.c static int lt9611uxc_probe(struct i2c_client *client,

Quoted 9 lines
drivers/gpu/drm/bridge/lontium-lt9611uxc.c +1 -2
@@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
        if (!lt9611uxc)
                return -ENOMEM;
 
-       lt9611uxc->dev = &client->dev;
+       lt9611uxc->dev = dev;
        lt9611uxc->client = client;
        mutex_init(&lt9611uxc->ocm_lock);
 
--

With these two issues fixed, please submit a v2 of this patch.

Rob.

#2 lore raw

From 10b677e995ab1f32df79896dbdb7cda779d3f798 Mon Sep 17 00:00:00 2001
From: Zhiming Liu <[email protected]>
Date: Thu, 13 Jan 2022 19:09:37 +0800
Subject: [PATCH v2] Signed-off-by: Zhiming Liu <[email protected]>

bridge : drm : Remove extra device acquisition method of i2c client in lt9611 driver.

We have get the device of i2c client in probe function.So we should remove extra device acquisition method of i2c client in lt9611 driver.

---
 drivers/gpu/drm/bridge/lontium-lt9611.c    | 4 ++--
 drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/bridge/lontium-lt9611.c
index dafb1b47c15f..feb128a4557d 100644

drivers/gpu/drm/bridge/lontium-lt9611.c +2 -2
@@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,
  if (!lt9611)
  return -ENOMEM;
 
- lt9611->dev = &client->dev;
+ lt9611->dev = dev;
  lt9611->client = client;
  lt9611->sleep = false;
 
@@ -1100,7 +1100,7 @@ static int lt9611_probe(struct i2c_client *client,
  return PTR_ERR(lt9611->regmap);
  }
 
- ret = lt9611_parse_dt(&client->dev, lt9611);
+ ret = lt9611_parse_dt(dev, lt9611);
  if (ret) {
  dev_err(dev, "failed to parse device tree\n");
  return ret;
(quoted diff) +0 -0

b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
index 33f9716da0ee..3d62e6bf6892 100644

drivers/gpu/drm/bridge/lontium-lt9611uxc.c +2 -2
@@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
  if (!lt9611uxc)
  return -ENOMEM;
 
- lt9611uxc->dev = &client->dev;
+ lt9611uxc->dev = dev;
  lt9611uxc->client = client;
  mutex_init(&lt9611uxc->ocm_lock);
 
@@ -870,7 +870,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
  return PTR_ERR(lt9611uxc->regmap);
  }
 
- ret = lt9611uxc_parse_dt(&client->dev, lt9611uxc);
+ ret = lt9611uxc_parse_dt(dev, lt9611uxc);
  if (ret) {
  dev_err(dev, "failed to parse device tree\n");
  return ret;
Signature · 1 line
2.25.1
Quoted 54 lines · Robert Foss <[email protected]> 于2022年1月13日周四 18:14写道:

Hello,

Thanks for submitting this cleanup patch.

Quoted 1 line · lzmlzm

A commit message is necessary for all changes, no matter how trivial.

Quoted 1 line

Is your name listed correctly above? For the 'Signed-off-by' tag to be meaningful, a real name needs to be supplied.

Review

Quoted 6 lines
---
 drivers/gpu/drm/bridge/lontium-lt9611.c    | 2 +-
 drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/bridge/lontium-lt9611.c

Review

Quoted 13 lines

index dafb1b47c15f..e0feb4fd9780 100644

drivers/gpu/drm/bridge/lontium-lt9611.c +1 -1
@@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,
        if (!lt9611)
                return -ENOMEM;
 
-       lt9611->dev = &client->dev;
+       lt9611->dev = dev;
        lt9611->client = client;
        lt9611->sleep = false;
 
(quoted diff) +0 -0

b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c

drivers/gpu/drm/bridge/lontium-lt9611uxc.c static int lt9611uxc_probe(struct i2c_client *client,

Quoted 13 lines

index 33f9716da0ee..e50e42312e82 100644

drivers/gpu/drm/bridge/lontium-lt9611uxc.c +1 -2
@@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
        if (!lt9611uxc)
                return -ENOMEM;
 
-       lt9611uxc->dev = &client->dev;
+       lt9611uxc->dev = dev;
        lt9611uxc->client = client;
        mutex_init(&lt9611uxc->ocm_lock);
 
--

With these two issues fixed, please submit a v2 of this patch.

Rob.

#3 lore raw
In reply to Robert Foss

Hello Robert,

I am new to linux kernel development, thank you very much for your patient reply.I will attach V2 of patch in the next email.

Best regards
Zhiming Liu

Quoted 54 lines · Robert Foss <[email protected]> 于2022年1月13日周四 18:14写道:

Hello,

Thanks for submitting this cleanup patch.

Quoted 1 line · lzmlzm

A commit message is necessary for all changes, no matter how trivial.

Quoted 1 line

Is your name listed correctly above? For the 'Signed-off-by' tag to be meaningful, a real name needs to be supplied.

Review

Quoted 6 lines
---
 drivers/gpu/drm/bridge/lontium-lt9611.c    | 2 +-
 drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/bridge/lontium-lt9611.c

Review

Quoted 13 lines

index dafb1b47c15f..e0feb4fd9780 100644

drivers/gpu/drm/bridge/lontium-lt9611.c +1 -1
@@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,
        if (!lt9611)
                return -ENOMEM;
 
-       lt9611->dev = &client->dev;
+       lt9611->dev = dev;
        lt9611->client = client;
        lt9611->sleep = false;
 
(quoted diff) +0 -0

b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c

drivers/gpu/drm/bridge/lontium-lt9611uxc.c static int lt9611uxc_probe(struct i2c_client *client,

Quoted 13 lines

index 33f9716da0ee..e50e42312e82 100644

drivers/gpu/drm/bridge/lontium-lt9611uxc.c +1 -2
@@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
        if (!lt9611uxc)
                return -ENOMEM;
 
-       lt9611uxc->dev = &client->dev;
+       lt9611uxc->dev = dev;
        lt9611uxc->client = client;
        mutex_init(&lt9611uxc->ocm_lock);
 
--

With these two issues fixed, please submit a v2 of this patch.

Rob.