Skip to contentSkip to conversation

devtmpfs: drop redundant fs parameters from internal fs

PATCH In review Anthony Iliopoulos 3 participants 3 messages Jan 19, 2022 – Jan 20, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 devtmpfs: drop redundant fs parameters from internal fs

The internal_fs_type is mounted via vfs_kernel_mount() and is never registered as a filesystem, thus specifying the parameters is redundant as those params will not be validated by fs_validate_description().

Both {shmem,ramfs}_fs_parameters are anyway validated when those respective filesystems are first registered, so there is no reason to pass them to devtmpfs too, drop them.

---
 drivers/base/devtmpfs.c | 2 --
 1 file changed, 2 deletions(-)
drivers/base/devtmpfs.c +0 -2
index f41063ac1aee..ad5f304e2b30 100644
@@ -81,10 +81,8 @@ static struct file_system_type internal_fs_type = {
 	.name = "devtmpfs",
 #ifdef CONFIG_TMPFS
 	.init_fs_context = shmem_init_fs_context,
-	.parameters	= shmem_fs_parameters,
 #else
 	.init_fs_context = ramfs_init_fs_context,
-	.parameters	= ramfs_fs_parameters,
 #endif
 	.kill_sb = kill_litter_super,
 };
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Anthony Iliopoulos

The internal_fs_type is mounted via vfs_kernel_mount() and is never registered as a filesystem, thus specifying the parameters is redundant as those params will not be validated by fs_validate_description().

Both {shmem,ramfs}_fs_parameters are anyway validated when those respective filesystems are first registered, so there is no reason to pass them to devtmpfs too, drop them.

Looks good,

maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Anthony Iliopoulos
Quoted 10 lines · Anthony Iliopoulos

The internal_fs_type is mounted via vfs_kernel_mount() and is never registered as a filesystem, thus specifying the parameters is redundant as those params will not be validated by fs_validate_description().

Both {shmem,ramfs}_fs_parameters are anyway validated when those respective filesystems are first registered, so there is no reason to pass them to devtmpfs too, drop them.

---

Ah yes, I "complained" about this on the patch re-enabling reconfigure_mnt() for devtmpfs.