devtmpfs: drop redundant fs parameters from internal fs
Subsystems (2)
PATCH 1/1 devtmpfs: drop redundant fs parameters from internal fs
The internal_fs_type is mounted via vfs_kernel_mount() and is never registered as a filesystem, thus specifying the parameters is redundant as those params will not be validated by fs_validate_description().
Both {shmem,ramfs}_fs_parameters are anyway validated when those respective filesystems are first registered, so there is no reason to pass them to devtmpfs too, drop them.
--- drivers/base/devtmpfs.c | 2 -- 1 file changed, 2 deletions(-)
drivers/base/devtmpfs.c +0 -2
@@ -81,10 +81,8 @@ static struct file_system_type internal_fs_type = { .name = "devtmpfs", #ifdef CONFIG_TMPFS .init_fs_context = shmem_init_fs_context, - .parameters = shmem_fs_parameters, #else .init_fs_context = ramfs_init_fs_context, - .parameters = ramfs_fs_parameters, #endif .kill_sb = kill_litter_super, };
Signature · 1 line
2.34.1
Quoted 7 lines · Anthony Iliopoulos
The
internal_fs_typeis mounted viavfs_kernel_mount()and is never registered as a filesystem, thus specifying the parameters is redundant as those params will not be validated byfs_validate_description().Both {shmem,ramfs}_fs_parameters are anyway validated when those respective filesystems are first registered, so there is no reason to pass them to devtmpfs too, drop them.
Looks good,
Quoted 10 lines · Anthony Iliopoulos
The
internal_fs_typeis mounted viavfs_kernel_mount()and is never registered as a filesystem, thus specifying the parameters is redundant as those params will not be validated byfs_validate_description().Both {shmem,ramfs}_fs_parameters are anyway validated when those respective filesystems are first registered, so there is no reason to pass them to devtmpfs too, drop them.
Signed-off-by Anthony Iliopoulos <[email protected]>---
Ah yes, I "complained" about this on the patch re-enabling reconfigure_mnt() for devtmpfs.