ACPI: Arm Generic Diagnostic Dump and Reset device
Subsystems (2)
v4 cover ACPI: Arm Generic Diagnostic Dump and Reset device
Arm Generic Diagnostic Dump and Reset device enables a maintainer to request OS to perform a diagnostic dump and reset a system via SDEI event or an interrupt. This patchset adds support for the SDEI path.
I do have a patch to enable the interrupt path as well but I'm holding it back since AGDI table is missing interrupt configuration fields (trigger type etc.).
The recently published specification is available at
https://developer.arm.com/documentation/den0093/latest
The patchset was tested on Ampere Altra/Mt. Jade.
The patchset applies on top of
git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm bleeding-edge (fc720b592cc6)
From v1:
* Moved pdata to the stack and dropped unnecessary kzalloc() in agdi_init()
* Changed the ACPICA patch upstreaming order comment in the paragraph above
From v2:
* The first patch was split. The most of it was merged to ACPICA project at first and later ported to linux-acpi (fd919e37cb15914c6fe13e13d530a4f732407c6d). The rest are in the first patch.
From v3:
Fixed:
* Moved header files in alphabetical order and removed unnecessary ones
Not addressed:
* agdi_init() is still called from device_initcall() as it has to be
done after sdei_init() (http://lists.infradead.org/pipermail/linux-arm-kernel/2022-January/709969.html) Can be moved to acpi_init(), after Shuai Xue's patch get's approved (http://lists.infradead.org/pipermail/linux-arm-kernel/2022-January/710268.html)
Ilkka Koskinen (2):
ACPI: tables: Add AGDI to the list of known table signatures
ACPI: AGDI: Add driver for Arm Generic Diagnostic Dump and Reset
device
drivers/acpi/arm64/Kconfig | 8 +++ drivers/acpi/arm64/Makefile | 1 + drivers/acpi/arm64/agdi.c | 122 ++++++++++++++++++++++++++++++++++++ drivers/acpi/tables.c | 2 +- 4 files changed, 132 insertions(+), 1 deletion(-) create mode 100644 drivers/acpi/arm64/agdi.c
Signature · 1 line
2.17.1
PATCH v4 1/2 ACPI: tables: Add AGDI to the list of known table signatures
Add AGDI to the list of known ACPI table signatures to allow the kernel to recognize it when upgrading tables via initrd.
--- drivers/acpi/tables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/tables.c +1 -1
@@ -500,7 +500,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {ACPI_SIG_WDDT ,ACPI_SIG_WDRT ,ACPI_SIG_DSDT ,ACPI_SIG_FADT ,ACPI_SIG_PSDT ,ACPI_SIG_RSDT ,ACPI_SIG_XSDT ,ACPI_SIG_SSDT ,ACPI_SIG_IORT ,ACPI_SIG_NFIT ,ACPI_SIG_HMAT ,ACPI_SIG_PPTT , - ACPI_SIG_NHLT, ACPI_SIG_AEST }; + ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_AGDI };#define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
Signature · 1 line
2.17.1
PATCH v4 2/2 ACPI: AGDI: Add driver for Arm Generic Diagnostic Dump and Reset device
In reply to Ilkka KoskinenACPI for Arm Components 1.1 Platform Design Document v1.1 [0] specifices Arm Generic Diagnostic Device Interface (AGDI). It allows an admin to issue diagnostic dump and reset via an SDEI event or an interrupt. This patch implements SDEI path.
[0] https://developer.arm.com/documentation/den0093/latest/
--- drivers/acpi/arm64/Kconfig | 8 +++ drivers/acpi/arm64/Makefile | 1 + drivers/acpi/arm64/agdi.c | 122 ++++++++++++++++++++++++++++++++++++ 3 files changed, 131 insertions(+) create mode 100644 drivers/acpi/arm64/agdi.c
drivers/acpi/arm64/Kconfig +8 -0
@@ -8,3 +8,11 @@ config ACPI_IORT config ACPI_GTDT bool + +config ACPI_AGDI + bool "Arm Generic Diagnostic Dump and Reset Device Interface" + depends on ARM_SDE_INTERFACE + help + Arm Generic Diagnostic Dump and Reset Device Interface (AGDI) is + a standard that enables issuing a non-maskable diagnostic dump and + reset command.
drivers/acpi/arm64/Makefile +1 -0
@@ -1,4 +1,5 @@ # SPDX-License-Identifier: GPL-2.0-only +obj-$(CONFIG_ACPI_AGDI) += agdi.o obj-$(CONFIG_ACPI_IORT) += iort.o obj-$(CONFIG_ACPI_GTDT) += gtdt.o obj-y += dma.o
drivers/acpi/arm64/agdi.c new file +122 -0
122 lines not on this page · raw message
Signature · 1 line
2.17.1