Skip to contentSkip to conversation

icu: fix make_icudata dependencies

PATCH Superseded Kory Maincent 2 participants 5 messages Jan 20, 2022

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 icu: fix make_icudata dependencies

The make_icudata task is set before the configure task then the dependencies for this task are not populate yet.

Fixed it by setting autoconf, automake and ccache native dependencies to this task.

---
 meta/recipes-support/icu/icu_70.1.bb | 8 ++++++++
 1 file changed, 8 insertions(+)
meta/recipes-support/icu/icu_70.1.bb +8 -0
index 0988ae8b8e..ae985bca4f 100644
@@ -123,6 +123,14 @@ EXTRA_OECONF:append:libc-musl = " ac_cv_func_strtod_l=no"
 PACKAGECONFIG ?= ""
 PACKAGECONFIG[make-icudata] = ",,,"
 
+# Add dependencies to make_icudata
+do_make_icudata[depends] = "autoconf-native:do_populate_sysroot automake-native:do_populate_sysroot"
+python() {
+    if not (bb.data.inherits_class("native", d) or
+            bb.utils.to_boolean(d.getVar('CCACHE_DISABLE'))):
+        d.appendVarFlag('do_make_icudata', 'depends', ' ccache-native:do_populate_sysroot')
+}
+
 do_make_icudata:class-target () {
     ${@bb.utils.contains('PACKAGECONFIG', 'make-icudata', '', 'exit 0', d)}
     cd ${S}
Signature · 1 line
2.25.1
#1 lore raw

Can we rather make a dependency on the task that prepares the sysroot, instead of listing the dependencies one by one (with anonymous python too!)?

Alex

Quoted 39 lines · Kory Maincent

The make_icudata task is set before the configure task then the dependencies for this task are not populate yet.

Fixed it by setting autoconf, automake and ccache native dependencies to this task.

---
 meta/recipes-support/icu/icu_70.1.bb | 8 ++++++++
 1 file changed, 8 insertions(+)
meta/recipes-support/icu/icu_70.1.bb +0 -0
index 0988ae8b8e..ae985bca4f 100644
@@ -123,6 +123,14 @@ EXTRA_OECONF:append:libc-musl = "

ac_cv_func_strtod_l=no"
PACKAGECONFIG ?= ""
PACKAGECONFIG[make-icudata] = ",,,"

meta/recipes-support/icu/icu_70.1.bb +2 -0
+# Add dependencies to make_icudata
+do_make_icudata[depends] = "autoconf-native:do_populate_sysroot

automake-native:do_populate_sysroot"

meta/recipes-support/icu/icu_70.1.bb +4 -0
+python() {
+    if not (bb.data.inherits_class("native", d) or
+            bb.utils.to_boolean(d.getVar('CCACHE_DISABLE'))):
+        d.appendVarFlag('do_make_icudata', 'depends', '

ccache-native:do_populate_sysroot')

meta/recipes-support/icu/icu_70.1.bb +2 -0
+}
+
 do_make_icudata:class-target () {
     ${@bb.utils.contains('PACKAGECONFIG', 'make-icudata', '', 'exit 0',

d)}

     cd ${S}

--
2.25.1

#2 lore raw

Hello Alexander,

Quoted 2 lines · On Thu, 20 Jan 2022 15:37:26 +0100 Alexander Kanavin <[email protected]>…

Can we rather make a dependency on the task that prepares the sysroot, instead of listing the dependencies one by one (with anonymous python too!)?

Thanks for the review,
I do not understand your comments as the make_icudata is before the configuration task.
Could you be more explicit or use an example?

Regards,

Köry

Quoted 45 lines

Alex

Quoted 39 lines · Kory Maincent

The make_icudata task is set before the configure task then the dependencies for this task are not populate yet.

Fixed it by setting autoconf, automake and ccache native dependencies to this task.

---
 meta/recipes-support/icu/icu_70.1.bb | 8 ++++++++
 1 file changed, 8 insertions(+)
meta/recipes-support/icu/icu_70.1.bb +0 -0
index 0988ae8b8e..ae985bca4f 100644
@@ -123,6 +123,14 @@ EXTRA_OECONF:append:libc-musl = "

ac_cv_func_strtod_l=no"
PACKAGECONFIG ?= ""
PACKAGECONFIG[make-icudata] = ",,,"

meta/recipes-support/icu/icu_70.1.bb +2 -0
+# Add dependencies to make_icudata
+do_make_icudata[depends] = "autoconf-native:do_populate_sysroot

automake-native:do_populate_sysroot"

meta/recipes-support/icu/icu_70.1.bb +4 -0
+python() {
+    if not (bb.data.inherits_class("native", d) or
+            bb.utils.to_boolean(d.getVar('CCACHE_DISABLE'))):
+        d.appendVarFlag('do_make_icudata', 'depends', '

ccache-native:do_populate_sysroot')

meta/recipes-support/icu/icu_70.1.bb +2 -0
+}
+
 do_make_icudata:class-target () {
     ${@bb.utils.contains('PACKAGECONFIG', 'make-icudata', '', 'exit 0',

d)}

     cd ${S}

--
2.25.1

#3 lore raw
Quoted 5 lines · Köry Maincent

Hello Alexander,

On Thu, 20 Jan 2022 15:37:26 +0100
Alexander Kanavin <[email protected]> wrote:

Quoted 9 lines
Quoted 2 lines

Can we rather make a dependency on the task that prepares the sysroot, instead of listing the dependencies one by one (with anonymous python

too!)?

Thanks for the review,
I do not understand your comments as the make_icudata is before the configuration task.
Could you be more explicit or use an example?

I think you need something like

do_make_icudata[deptask] = "do_prepare_recipe_sysroot"

Alex

#4 lore raw
Quoted 6 lines · On Thu, 20 Jan 2022 16:09:25 +0100 Alexander Kanavin <[email protected]>…
Quoted 2 lines

Could you be more explicit or use an example?

I think you need something like

do_make_icudata[deptask] = "do_prepare_recipe_sysroot"

Oh, I didn't know this deptask flag, thanks to point me this out. I will send a v2 with this.

Köry