icu: fix make_icudata dependencies
PATCH v2 1/1 icu: fix make_icudata dependencies
The make_icudata task is set before the configure task then the dependencies for this task are not populate yet.
Fixed it by setting the deptask flag to do_populate_sysroot. With this, the do_populate_sysroot task of each item in DEPENDS must complete before do_make_icudata can execute.
---
Change in v2:
Use deptask flag instead of setting manually the task dependencies with depends flag.
meta/recipes-support/icu/icu_70.1.bb | 3 +++ 1 file changed, 3 insertions(+)
meta/recipes-support/icu/icu_70.1.bb +3 -0
@@ -123,6 +123,9 @@ EXTRA_OECONF:append:libc-musl = " ac_cv_func_strtod_l=no" PACKAGECONFIG ?= "" PACKAGECONFIG[make-icudata] = ",,," +# Add dependencies to make_icudata +do_make_icudata[deptask] += "do_populate_sysroot" + do_make_icudata:class-target () { ${@bb.utils.contains('PACKAGECONFIG', 'make-icudata', '', 'exit 0', d)} cd ${S}
Signature · 1 line
2.25.1
This isn't correct, as recipe's own sysroot is populated by prepare_recipe_sysroot() of the recipe.
I think the real correct fix is
addtask do_make_icudata before do_configure after do_patch do_prepare_recipe_sysroot
You need to tweak the line at the end of the recipe.
Alex
Quoted 38 lines · Kory Maincent
The
make_icudatatask is set before the configure task then the dependencies for this task are not populate yet.Fixed it by setting the deptask flag to
do_populate_sysroot. With this, thedo_populate_sysroottask of each item in DEPENDS must complete beforedo_make_icudatacan execute.Signed-off-by Kory Maincent <[email protected]>---
Change in v2:
Use deptask flag instead of setting manually the task dependencies with depends flag.meta/recipes-support/icu/icu_70.1.bb | 3 +++ 1 file changed, 3 insertions(+)meta/recipes-support/icu/icu_70.1.bb +0
-0@@ -123,6 +123,9 @@ EXTRA_OECONF:append:libc-musl = "ac_cv_func_strtod_l=no"
PACKAGECONFIG ?= ""
PACKAGECONFIG[make-icudata] = ",,,"meta/recipes-support/icu/icu_70.1.bb +3
-0+# Add dependencies to make_icudata +do_make_icudata[deptask] += "do_populate_sysroot" + do_make_icudata:class-target () { ${@bb.utils.contains('PACKAGECONFIG', 'make-icudata', '', 'exit 0',d)}
cd ${S}--
2.25.1