Skip to contentSkip to conversation

icu: fix make_icudata dependencies

PATCH Superseded Kory Maincent 2 participants 2 messages Jan 20, 2022

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 icu: fix make_icudata dependencies

The make_icudata task is set before the configure task then the dependencies for this task are not populate yet.

Fixed it by setting the deptask flag to do_populate_sysroot. With this, the do_populate_sysroot task of each item in DEPENDS must complete before do_make_icudata can execute.

---

Change in v2:
Use deptask flag instead of setting manually the task dependencies with depends flag.

 meta/recipes-support/icu/icu_70.1.bb | 3 +++
 1 file changed, 3 insertions(+)
meta/recipes-support/icu/icu_70.1.bb +3 -0
index 0988ae8b8e..ff5e249e9d 100644
@@ -123,6 +123,9 @@ EXTRA_OECONF:append:libc-musl = " ac_cv_func_strtod_l=no"
 PACKAGECONFIG ?= ""
 PACKAGECONFIG[make-icudata] = ",,,"
 
+# Add dependencies to make_icudata
+do_make_icudata[deptask] += "do_populate_sysroot"
+
 do_make_icudata:class-target () {
     ${@bb.utils.contains('PACKAGECONFIG', 'make-icudata', '', 'exit 0', d)}
     cd ${S}
Signature · 1 line
2.25.1
#1 lore raw

This isn't correct, as recipe's own sysroot is populated by prepare_recipe_sysroot() of the recipe.

I think the real correct fix is

addtask do_make_icudata before do_configure after do_patch do_prepare_recipe_sysroot

You need to tweak the line at the end of the recipe.

Alex

Quoted 38 lines · Kory Maincent

The make_icudata task is set before the configure task then the dependencies for this task are not populate yet.

Fixed it by setting the deptask flag to do_populate_sysroot. With this, the do_populate_sysroot task of each item in DEPENDS must complete before do_make_icudata can execute.

---

Change in v2:
Use deptask flag instead of setting manually the task dependencies with depends flag.

 meta/recipes-support/icu/icu_70.1.bb | 3 +++
 1 file changed, 3 insertions(+)
meta/recipes-support/icu/icu_70.1.bb +0 -0
index 0988ae8b8e..ff5e249e9d 100644
@@ -123,6 +123,9 @@ EXTRA_OECONF:append:libc-musl = "

ac_cv_func_strtod_l=no"
PACKAGECONFIG ?= ""
PACKAGECONFIG[make-icudata] = ",,,"

meta/recipes-support/icu/icu_70.1.bb +3 -0
+# Add dependencies to make_icudata
+do_make_icudata[deptask] += "do_populate_sysroot"
+
 do_make_icudata:class-target () {
     ${@bb.utils.contains('PACKAGECONFIG', 'make-icudata', '', 'exit 0',

d)}

     cd ${S}

--
2.25.1