5.15.17-rc1 review
Subsystems (9)
Greg Kroah-Hartman
maintainerPATCH 253/846 drm/msm/dpu: fix safe status debugfs file
In reply to Greg Kroah-HartmanFrom: Dmitry Baryshkov <[email protected]>
[ Upstream commit f31b0e24d31e18b4503eeaf0032baeacc0beaff6 ]
Make safe_status debugfs fs file actually return safe status rather than danger status data.
--- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +2 -2
@@ -73,8 +73,8 @@ static int _dpu_danger_signal_status(struct seq_file *s, &status); }else {seq_puts (s,"\nSafe signal status:\n" ); -if (kms->hw_mdp->ops.get_danger_status) - kms->hw_mdp->ops.get_danger_status (kms->hw_mdp, +if (kms->hw_mdp->ops.get_safe_status) + kms->hw_mdp->ops.get_safe_status (kms->hw_mdp, &status); }pm_runtime_put_sync (&kms->pdev->dev);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 254/846 drm/bridge: ti-sn65dsi86: Set max register for regmap
In reply to Greg Kroah-HartmanFrom: Stephen Boyd <[email protected]>
[ Upstream commit 0b665d4af35837f0a0ae63135b84a3c187c1db3b ]
Set the maximum register to 0xff so we can dump the registers for this device in debugfs.
--- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/bridge/ti-sn65dsi86.c +1 -0
@@ -188,6 +188,7 @@ static const struct regmap_config ti_sn65dsi86_regmap_config = { .val_bits = 8, .volatile_table = &ti_sn_bridge_volatile_table, .cache_type = REGCACHE_NONE, + .max_register = 0xFF, }; static void ti_sn65dsi86_write_u16(struct ti_sn65dsi86 *pdata,
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 255/846 gpu: host1x: select CONFIG_DMA_SHARED_BUFFER
In reply to Greg Kroah-HartmanFrom: Arnd Bergmann <[email protected]>
[ Upstream commit 6c7a388b62366f0de9936db3c1921d7f4e0011bc ]
Linking fails when dma-buf is disabled:
ld.lld: error: undefined symbol: dma_fence_release
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
referenced by
fence.c
gpu/host1x/fence.o:(host1x_syncpt_fence_enable_signaling) in archivedrivers/built-in.a
referenced byfence.c
gpu/host1x/fence.o:(host1x_fence_signal) in archivedrivers/built-in.a
referenced byfence.c
gpu/host1x/fence.o:(do_fence_timeout) in archivedrivers/built-in.a
--- drivers/gpu/host1x/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/host1x/Kconfig +1 -0
@@ -2,6 +2,7 @@ config TEGRA_HOST1X tristate "NVIDIA Tegra host1x driver" depends on ARCH_TEGRA || (ARM && COMPILE_TEST) + select DMA_SHARED_BUFFER select IOMMU_IOVA help Driver for the NVIDIA Tegra host1x hardware.
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 256/846 drm/tegra: gr2d: Explicitly control module reset
In reply to Greg Kroah-HartmanFrom: Thierry Reding <[email protected]>
[ Upstream commit 271fca025a6d43f1c18a48543c5aaf31a31e4694 ]
As of commit 4782c0a5dd88 ("clk: tegra: Don't deassert reset on enabling clocks"), module resets are no longer automatically deasserted when the module clock is enabled. To make sure that the gr2d module continues to work, we need to explicitly control the module reset.
--- drivers/gpu/drm/tegra/gr2d.c | 33 +++++++++++++++++++++++++++++++-- 1 file changed, 31 insertions(+), 2 deletions(-)
drivers/gpu/drm/tegra/gr2d.c +31 -2
@@ -4,9 +4,11 @@*/ #include <linux/clk.h> +#include <linux/delay.h> #include <linux/iommu.h> #include <linux/module.h> #include <linux/of_device.h> +#include <linux/reset.h> #include "drm.h" #include "gem.h"
@@ -19,6 +21,7 @@ struct gr2d_soc {struct gr2d {struct tegra_drm_client client;struct host1x_channel *channel; +struct reset_control *rst;struct clk *clk;const struct gr2d_soc *soc;
@@ -208,6 +211,12 @@ static int gr2d_probe(struct platform_device *pdev)if (!syncpts)return -ENOMEM ; + gr2d->rst =devm_reset_control_get (dev,NULL ); +if (IS_ERR (gr2d->rst)) { +dev_err (dev,"cannot get reset\n" ); +return PTR_ERR (gr2d->rst); + } + gr2d->clk =devm_clk_get (dev,NULL );if (IS_ERR (gr2d->clk)) {dev_err (dev,"cannot get clock\n" );
@@ -220,6 +229,14 @@ static int gr2d_probe(struct platform_device *pdev)return err; } +usleep_range (2000 ,4000 ); + + err =reset_control_deassert (gr2d->rst); +if (err <0 ) { +dev_err (dev,"failed to deassert reset: %d\n" , err); + goto disable_clk; + } +INIT_LIST_HEAD (&gr2d->client.base.list); gr2d->client.base.ops = &gr2d_client_ops; gr2d->client.base.dev = dev;
@@ -234,8 +251,7 @@ static int gr2d_probe(struct platform_device *pdev) err =host1x_client_register (&gr2d->client.base);if (err <0 ) {dev_err (dev,"failed to register host1x client: %d\n" , err); -clk_disable_unprepare (gr2d->clk); -return err; + goto assert_rst; }/* initialize address register map */
@@ -245,6 +261,13 @@ static int gr2d_probe(struct platform_device *pdev)platform_set_drvdata (pdev, gr2d);return 0 ; + +assert_rst: + (void )reset_control_assert (gr2d->rst); +disable_clk: +clk_disable_unprepare (gr2d->clk); + +return err; }static int gr2d_remove (struct platform_device *pdev)
@@ -259,6 +282,12 @@ static int gr2d_remove(struct platform_device *pdev)return err; } + err =reset_control_assert (gr2d->rst); +if (err <0 ) +dev_err (&pdev->dev,"failed to assert reset: %d\n" , err); + +usleep_range (2000 ,4000 ); +clk_disable_unprepare (gr2d->clk);return 0 ;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 257/846 drm/tegra: vic: Fix DMA API misuse
In reply to Greg Kroah-HartmanFrom: Robin Murphy <[email protected]>
[ Upstream commit 5566174cb10a5167d59b0793871cab7990b149b8 ]
Upon failure, dma_alloc_coherent() returns NULL. If that does happen, passing some uninitialised stack contents to dma_mapping_error() - which belongs to a different API in the first place - has precious little chance of detecting it.
Also include the correct header, because the fragile transitive inclusion currently providing it is going to break soon.
--- drivers/gpu/drm/tegra/vic.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/gpu/drm/tegra/vic.c +3 -4
@@ -5,6 +5,7 @@#include <linux/clk.h> #include <linux/delay.h> +#include <linux/dma-mapping.h> #include <linux/host1x.h> #include <linux/iommu.h> #include <linux/module.h>
@@ -232,10 +233,8 @@ static int vic_load_firmware(struct vic *vic)if (!client->group) { virt =dma_alloc_coherent (vic->dev, size, &iova,GFP_KERNEL ); - - err =dma_mapping_error (vic->dev, iova); -if (err <0 ) -return err; +if (!virt) +return -ENOMEM ; }else { virt =tegra_drm_alloc (tegra, size, &iova); }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 258/846 media: hantro: Fix probe func error path
In reply to Greg Kroah-HartmanFrom: Jernej Skrabec <[email protected]>
[ Upstream commit 37af43b250fda6162005d47bf7c959c70d52b107 ]
If clocks for some reason couldn't be enabled, probe function returns immediately, without disabling PM. This obviously leaves PM ref counters unbalanced.
Fix that by jumping to appropriate error path, so effects of PM functions are reversed.
--- drivers/staging/media/hantro/hantro_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/media/hantro/hantro_drv.c +2 -1
@@ -958,7 +958,7 @@ static int hantro_probe(struct platform_device *pdev) ret =clk_bulk_prepare (vpu->variant->num_clocks, vpu->clocks);if (ret) {dev_err (&pdev->dev,"Failed to prepare clocks\n" ); -return ret; + goto err_pm_disable; } ret =v4l2_device_register (&pdev->dev, &vpu->v4l2_dev);
@@ -1014,6 +1014,7 @@ err_v4l2_unreg:v4l2_device_unregister (&vpu->v4l2_dev); err_clk_unprepare:clk_bulk_unprepare (vpu->variant->num_clocks, vpu->clocks); +err_pm_disable:pm_runtime_dont_use_autosuspend (vpu->dev);pm_runtime_disable (vpu->dev);return ret;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 259/846 xfrm: interface with if_id 0 should return error
In reply to Greg Kroah-HartmanFrom: Antony Antony <[email protected]>
[ Upstream commit 8dce43919566f06e865f7e8949f5c10d8c2493f5 ]
xfrm interface if_id = 0 would cause xfrm policy lookup errors since Commit 9f8550e4bd9d.
Now explicitly fail to create an xfrm interface when if_id = 0
With this commit:
ip link add ipsec0 type xfrm dev lo if_id 0
Error: if_id must be non zero.
v1->v2 change:
- add Fixes: tag
--- net/xfrm/xfrm_interface.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)
net/xfrm/xfrm_interface.c +12 -2
@@ -637,11 +637,16 @@ static int xfrmi_newlink(struct net *src_net, struct net_device *dev, struct netlink_ext_ack *extack) {struct net *net =dev_net (dev); -struct xfrm_if_parms p; +struct xfrm_if_parms p = {};struct xfrm_if *xi;int err;xfrmi_netlink_parms (data, &p); +if (!p.if_id) { +NL_SET_ERR_MSG (extack,"if_id must be non zero" ); +return -EINVAL ; + } + xi =xfrmi_locate (net, &p);if (xi)return -EEXIST ;
@@ -666,7 +671,12 @@ static int xfrmi_changelink(struct net_device *dev, struct nlattr *tb[], {struct xfrm_if *xi =netdev_priv (dev);struct net *net = xi->net; -struct xfrm_if_parms p; +struct xfrm_if_parms p = {}; + +if (!p.if_id) { +NL_SET_ERR_MSG (extack,"if_id must be non zero" ); +return -EINVAL ; + }xfrmi_netlink_parms (data, &p); xi =xfrmi_locate (net, &p);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 260/846 xfrm: state and policy should fail if XFRMA_IF_ID 0
In reply to Greg Kroah-HartmanFrom: Antony Antony <[email protected]>
[ Upstream commit 68ac0f3810e76a853b5f7b90601a05c3048b8b54 ]
xfrm ineterface does not allow xfrm if_id = 0
fail to create or update xfrm state and policy.
With this commit:
ip xfrm policy add src 192.0.2.1 dst 192.0.2.2 dir out if_id 0 RTNETLINK answers: Invalid argument
ip xfrm state add src 192.0.2.1 dst 192.0.2.2 proto esp spi 1 \
reqid 1 mode tunnel aead 'rfc4106(gcm(aes))' \
0x1111111111111111111111111111111111111111 96 if_id 0RTNETLINK answers: Invalid argument
v1->v2 change:
- add Fixes: tag
--- net/xfrm/xfrm_user.c | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-)
net/xfrm/xfrm_user.c +18 -3
@@ -621,8 +621,13 @@ static struct xfrm_state *xfrm_state_construct(struct net *net,xfrm_smark_init (attrs, &x->props.smark); -if (attrs[XFRMA_IF_ID ]) +if (attrs[XFRMA_IF_ID ]) { x->if_id =nla_get_u32 (attrs[XFRMA_IF_ID ]); +if (!x->if_id) { + err = -EINVAL ; + goto error; + } + } err =__xfrm_init_state (x, false, attrs[XFRMA_OFFLOAD_DEV ]);if (err)
@@ -1413,8 +1418,13 @@ static int xfrm_alloc_userspi(struct sk_buff *skb, struct nlmsghdr *nlh, mark =xfrm_mark_get (attrs, &m); -if (attrs[XFRMA_IF_ID ]) +if (attrs[XFRMA_IF_ID ]) { if_id =nla_get_u32 (attrs[XFRMA_IF_ID ]); +if (!if_id) { + err = -EINVAL ; + goto out_noput; + } + }if (p->info.seq) { x =xfrm_find_acq_byseq (net, mark, p->info.seq);
@@ -1727,8 +1737,13 @@ static struct xfrm_policy *xfrm_policy_construct(struct net *net, struct xfrm_usxfrm_mark_get (attrs, &xp->mark); -if (attrs[XFRMA_IF_ID ]) +if (attrs[XFRMA_IF_ID ]) { xp->if_id =nla_get_u32 (attrs[XFRMA_IF_ID ]); +if (!xp->if_id) { + err = -EINVAL ; + goto error; + } + }return xp; error:
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 261/846 ARM: 9159/1: decompressor: Avoid UNPREDICTABLE NOP encoding
In reply to Greg Kroah-HartmanFrom: Andre Przywara <[email protected]>
[ Upstream commit a92882a4d270fbcc021ee6848de5e48b7f0d27f3 ]
In the decompressor's head.S we need to start with an instruction that is some kind of NOP, but also mimics as the PE/COFF header, when the kernel is linked as an UEFI application. The clever solution here is "tstne r0, #0x4d000", which in the worst case just clobbers the condition flags, and bears the magic "MZ" signature in the lowest 16 bits.
However the encoding used (0x13105a4d) is actually not valid, since bits [15:12] are supposed to be 0 (written as "(0)" in the ARM ARM). Violating this is UNPREDICTABLE, and *can* trigger an UNDEFINED exception. Common Cortex cores seem to ignore those bits, but QEMU chooses to trap, so the code goes fishing because of a missing exception handler at this point. We are just saved by the fact that commonly (with -kernel or when running from U-Boot) the "Z" bit is set, so the instruction is never executed. See [0] for more details.
To make things more robust and avoid UNPREDICTABLE behaviour in the kernel code, lets replace this with a "two-instruction NOP":
The first instruction is an exclusive OR, the effect of which the second instruction reverts. This does not leave any trace, neither in a register nor in the condition flags. Also it's a perfectly valid encoding. Kudos to Peter Maydell for coming up with this gem.
[0] https://lore.kernel.org/qemu-devel/YTPIdbUCmwagL5%[email protected]/T/
--- arch/arm/boot/compressed/efi-header.S | 22 ++++++++++++++-------- arch/arm/boot/compressed/head.S | 3 ++- 2 files changed, 16 insertions(+), 9 deletions(-)
arch/arm/boot/compressed/efi-header.S +14 -8
@@ -9,16 +9,22 @@ #include <linux/sizes.h> .macro __nop -#ifdef CONFIG_EFI_STUB - @ This is almost but not quite a NOP, since it does clobber the - @ condition flags. But it is the best we can do for EFI, since - @ PE/COFF expects the magic string "MZ" at offset 0, while the - @ ARM/Linux boot protocol expects an executable instruction - @ there. - .inst MZ_MAGIC | (0x1310 << 16) @ tstne r0, #0x4d000 -#else AR_CLASS( mov r0, r0 ) M_CLASS( nop.w ) + .endm + + .macro __initial_nops +#ifdef CONFIG_EFI_STUB + @ This is a two-instruction NOP, which happens to bear the + @ PE/COFF signature "MZ" in the first two bytes, so the kernel + @ is accepted as an EFI binary. Booting via the UEFI stub + @ will not execute those instructions, but the ARM/Linux + @ boot protocol does, so we need some NOPs here. + .inst MZ_MAGIC | (0xe225 << 16) @ eor r5, r5, 0x4d000 + eor r5, r5, 0x4d000 @ undo previous insn +#else + __nop + __nop #endif .endm
arch/arm/boot/compressed/head.S +2 -1
@@ -203,7 +203,8 @@ start: * were patching the initial instructions of the kernel, i.e * had started to exploit this "patch area". */ - .rept 7 + __initial_nops + .rept 5 __nop .endr #ifndef CONFIG_THUMB2_KERNEL
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 262/846 usb: ftdi-elan: fix memory leak on device disconnect
In reply to Greg Kroah-HartmanFrom: Wei Yongjun <[email protected]>
[ Upstream commit 1646566b5e0c556f779180a8514e521ac735de1e ]
'ftdi' is alloced when probe device, but not free on device disconnect, this cause a memory leak as follows:
unreferenced object 0xffff88800d584000 (size 8400):
comm "kworker/0:2", pid 3809, jiffies 4295453055 (age 13.784s) hex dump (first 32 bytes):
00 40 58 0d 80 88 ff ff 00 40 58 0d 80 88 ff ff .@X......@X.....
00 00 00 00 00 00 00 00 00 00 00 00 ad 4e ad de .............N..
backtrace:
[<000000000d47f947>] kmalloc_order_trace+0x19/0x110 mm/slab_common.c:960
[<000000008548ac68>] ftdi_elan_probe+0x8c/0x880 drivers/usb/misc/ftdi-elan.c:2647
[<000000007f73e422>] usb_probe_interface+0x31b/0x800 drivers/usb/core/driver.c:396
[<00000000fe8d07fc>] really_probe+0x299/0xc30 drivers/base/dd.c:517
[<0000000005da7d32>] __driver_probe_device+0x357/0x500 drivers/base/dd.c:751
[<000000003c2c9579>] driver_probe_device+0x4e/0x140 drivers/base/dd.c:781Fix it by freeing 'ftdi' after nobody use it.
--- drivers/usb/misc/ftdi-elan.c | 1 + 1 file changed, 1 insertion(+)
drivers/usb/misc/ftdi-elan.c +1 -0
@@ -202,6 +202,7 @@ static void ftdi_elan_delete(struct kref *kref)mutex_unlock (&ftdi_module_lock);kfree (ftdi->bulk_in_buffer); ftdi->bulk_in_buffer =NULL ; +kfree (ftdi); }static void ftdi_elan_put_kref (struct usb_ftdi *ftdi)
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 263/846 arm64: dts: marvell: cn9130: add GPIO and SPI aliases
In reply to Greg Kroah-HartmanFrom: Robert Marko <[email protected]>
[ Upstream commit effd42600b987c1e95f946b14fefc1c7639e7439 ]
CN9130 has one CP115 built in, which like the CP110 has 2 GPIO and 2 SPI controllers built-in.
However, unlike the Armada 7k and 8k the SoC DTSI doesn't add the required aliases as both the Orion SPI driver and MVEBU GPIO drivers require the aliases to be present.
So add the required aliases for GPIO and SPI controllers.
--- arch/arm64/boot/dts/marvell/cn9130.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)
arch/arm64/boot/dts/marvell/cn9130.dtsi +7 -0
@@ -11,6 +11,13 @@ model = "Marvell Armada CN9130 SoC"; compatible = "marvell,cn9130", "marvell,armada-ap807-quad", "marvell,armada-ap807"; + + aliases { + gpio1 = &cp0_gpio1; + gpio2 = &cp0_gpio2; + spi1 = &cp0_spi0; + spi2 = &cp0_spi1; + }; }; /*
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 264/846 arm64: dts: marvell: cn9130: enable CP0 GPIO controllers
In reply to Greg Kroah-HartmanFrom: Robert Marko <[email protected]>
[ Upstream commit 0734f8311ce72c9041e5142769eff2083889c172 ]
CN9130 has a built-in CP115 which has 2 GPIO controllers, but unlike in Armada 7k and 8k both are left disabled by the SoC DTSI.
This first of all makes no sense as they are always present due to being SoC built-in and its an issue as boards like CN9130-CRB use the CPO GPIO2 pins for regulators and SD card support without enabling them first.
So, enable both of them like Armada 7k and 8k do.
--- arch/arm64/boot/dts/marvell/cn9130.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)
arch/arm64/boot/dts/marvell/cn9130.dtsi +8 -0
@@ -42,3 +42,11 @@ #undef CP11X_PCIE0_BASE #undef CP11X_PCIE1_BASE #undef CP11X_PCIE2_BASE + +&cp0_gpio1 { + status = "okay"; +}; + +&cp0_gpio2 { + status = "okay"; +};
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 265/846 ARM: dts: armada-38x: Add generic compatible to UART nodes
In reply to Greg Kroah-HartmanFrom: Marek Behún <[email protected]>
[ Upstream commit 62480772263ab6b52e758f2346c70a526abd1d28 ]
Add generic compatible string "ns16550a" to serial port nodes of Armada 38x.
This makes it possible to use earlycon.
--- arch/arm/boot/dts/armada-38x.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/armada-38x.dtsi +2 -2
@@ -168,7 +168,7 @@ }; uart0: serial@12000 { - compatible = "marvell,armada-38x-uart"; + compatible = "marvell,armada-38x-uart", "ns16550a"; reg = <0x12000 0x100>; reg-shift = <2>; interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>;
@@ -178,7 +178,7 @@ }; uart1: serial@12100 { - compatible = "marvell,armada-38x-uart"; + compatible = "marvell,armada-38x-uart", "ns16550a"; reg = <0x12100 0x100>; reg-shift = <2>; interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 266/846 mt76: mt7921: drop offload_flags overwritten
In reply to Greg Kroah-HartmanFrom: Sean Wang <[email protected]>
[ Upstream commit 2363b6a646b65a207345b9a9024dff0eff3fec44 ]
offload_flags have to be dropped for mt7921 because mt76.omac_idx 0 would always run as station mode that would cause Tx encapsulation setting is not applied to mac80211.
Also, drop IEEE80211_OFFLOAD_ENCAP_4ADDR too because it is not really being supported.
--- drivers/net/wireless/mediatek/mt76/mt7921/main.c | 6 ------ 1 file changed, 6 deletions(-)
drivers/net/wireless/mediatek/mt76/mt7921/main.c +0 -6
@@ -285,12 +285,6 @@ static int mt7921_add_interface(struct ieee80211_hw *hw, mtxq->wcid = &mvif->sta.wcid; } -if (vif->type !=NL80211_IFTYPE_AP && - (!mvif->mt76.omac_idx || mvif->mt76.omac_idx >3 )) - vif->offload_flags =0 ; - - vif->offload_flags |=IEEE80211_OFFLOAD_ENCAP_4ADDR ; - out:mt7921_mutex_release (dev);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 267/846 wilc1000: fix double free error in probe()
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
[ Upstream commit 4894edacfa93d7046bec4fc61fc402ac6a2ac9e8 ]
Smatch complains that there is a double free in probe:
drivers/net/wireless/microchip/wilc1000/spi.c:186 wilc_bus_probe() error: double free of 'spi_priv' drivers/net/wireless/microchip/wilc1000/sdio.c:163 wilc_sdio_probe() error: double free of 'sdio_priv'
The problem is that wilc_netdev_cleanup() function frees "wilc->bus_data". That's confusing and a layering violation. Leave the frees in probe(), delete the free in wilc_netdev_cleanup(), and add some new frees to the remove() functions.
--- drivers/net/wireless/microchip/wilc1000/netdev.c | 1 - drivers/net/wireless/microchip/wilc1000/sdio.c | 2 ++ drivers/net/wireless/microchip/wilc1000/spi.c | 2 ++ 3 files changed, 4 insertions(+), 1 deletion(-)
drivers/net/wireless/microchip/wilc1000/netdev.c +0 -1
@@ -901,7 +901,6 @@ void wilc_netdev_cleanup(struct wilc *wilc)wilc_wlan_cfg_deinit (wilc);wlan_deinit_locks (wilc); -kfree (wilc->bus_data);wiphy_unregister (wilc->wiphy);wiphy_free (wilc->wiphy); }
drivers/net/wireless/microchip/wilc1000/sdio.c +2 -0
@@ -167,9 +167,11 @@ free:static void wilc_sdio_remove (struct sdio_func *func) {struct wilc *wilc =sdio_get_drvdata (func); +struct wilc_sdio *sdio_priv = wilc->bus_data;clk_disable_unprepare (wilc->rtc_clk);wilc_netdev_cleanup (wilc); +kfree (sdio_priv); }static int wilc_sdio_reset (struct wilc *wilc)
drivers/net/wireless/microchip/wilc1000/spi.c +2 -0
@@ -182,9 +182,11 @@ free:static int wilc_bus_remove (struct spi_device *spi) {struct wilc *wilc =spi_get_drvdata (spi); +struct wilc_spi *spi_priv = wilc->bus_data;clk_disable_unprepare (wilc->rtc_clk);wilc_netdev_cleanup (wilc); +kfree (spi_priv);return 0 ; }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 268/846 rtw88: add quirk to disable pci caps on HP 250 G7 Notebook PC
In reply to Greg Kroah-HartmanFrom: Ping-Ke Shih <[email protected]>
[ Upstream commit c81edb8dddaa36c4defa26240cc19127f147283f ]
8821CE causes random freezes on HP 250 G7 Notebook PC. Add a quirk to disable pci ASPM capability.
--- drivers/net/wireless/realtek/rtw88/pci.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/net/wireless/realtek/rtw88/pci.c +9 -0
@@ -1738,6 +1738,15 @@ static const struct dmi_system_id rtw88_pci_quirks[] = { }, .driver_data = (void *)BIT(QUIRK_DIS_PCI_CAP_ASPM), }, + { + .callback = disable_pci_caps, + .ident = "HP HP 250 G7 Notebook PC", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "HP"), + DMI_MATCH(DMI_PRODUCT_NAME, "HP 250 G7 Notebook PC"), + }, + .driver_data = (void *)BIT(QUIRK_DIS_PCI_CAP_ASPM), + }, {} };
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 269/846 rtw88: Disable PCIe ASPM while doing NAPI poll on 8821CE
In reply to Greg Kroah-HartmanFrom: Kai-Heng Feng <[email protected]>
[ Upstream commit 24f5e38a13b5ae2b6105cda8bb47c19108e62a9a ]
Many Intel based platforms face system random freeze after commit 9e2fd29864c5 ("rtw88: add napi support").
The commit itself shouldn't be the culprit. My guess is that the 8821CE only leaves ASPM L1 for a short period when IRQ is raised. Since IRQ is masked during NAPI polling, the PCIe link stays at L1 and makes RX DMA extremely slow. Eventually the RX ring becomes messed up:
[ 1133.194697] rtw_8821ce 0000:02:00.0: pci bus timeout, check dma status
Since the 8821CE hardware may fail to leave ASPM L1, manually do it in the driver to resolve the issue.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215131
--- drivers/net/wireless/realtek/rtw88/pci.c | 70 +++++++----------------- drivers/net/wireless/realtek/rtw88/pci.h | 2 + 2 files changed, 21 insertions(+), 51 deletions(-)
drivers/net/wireless/realtek/rtw88/pci.c +19 -51
@@ -2,7 +2,6 @@/* Copyright(c) 2018-2019 Realtek Corporation */ -#include <linux/dmi.h> #include <linux/module.h> #include <linux/pci.h> #include "main.h"
@@ -1409,7 +1408,11 @@ static void rtw_pci_link_ps(struct rtw_dev *rtwdev, bool enter)* throughput. This is probably because the ASPM behavior slightly * varies from different SOC. */ -if (rtwpci->link_ctrl &PCI_EXP_LNKCTL_ASPM_L1 ) +if (!(rtwpci->link_ctrl &PCI_EXP_LNKCTL_ASPM_L1 )) +return ; + +if ((enter &&atomic_dec_if_positive (&rtwpci->link_usage) ==0 ) || + (!enter &&atomic_inc_return (&rtwpci->link_usage) ==1 ))rtw_pci_aspm_set (rtwdev, enter); }
@@ -1658,6 +1661,9 @@ static int rtw_pci_napi_poll(struct napi_struct *napi, int budget) priv);int work_done =0 ; +if (rtwpci->rx_no_aspm) +rtw_pci_link_ps (rtwdev, false); +while (work_done < budget) {u32 work_done_once;
@@ -1681,6 +1687,8 @@ static int rtw_pci_napi_poll(struct napi_struct *napi, int budget)if (rtw_pci_get_hw_rx_ring_nr (rtwdev, rtwpci))napi_schedule (napi); } +if (rtwpci->rx_no_aspm) +rtw_pci_link_ps (rtwdev, true);return work_done; }
@@ -1702,59 +1710,13 @@ static void rtw_pci_napi_deinit(struct rtw_dev *rtwdev)netif_napi_del (&rtwpci->napi); } -enum rtw88_quirk_dis_pci_caps { -QUIRK_DIS_PCI_CAP_MSI , -QUIRK_DIS_PCI_CAP_ASPM , -}; - -static int disable_pci_caps (const struct dmi_system_id *dmi) -{ -uintptr_t dis_caps = (uintptr_t )dmi->driver_data; - -if (dis_caps &BIT (QUIRK_DIS_PCI_CAP_MSI )) - rtw_disable_msi = true; -if (dis_caps &BIT (QUIRK_DIS_PCI_CAP_ASPM )) - rtw_pci_disable_aspm = true; - -return 1 ; -} - -static const struct dmi_system_id rtw88_pci_quirks[] = { - { - .callback = disable_pci_caps, - .ident ="Protempo Ltd L116HTN6SPW" , - .matches = { -DMI_MATCH (DMI_SYS_VENDOR ,"Protempo Ltd" ), -DMI_MATCH (DMI_PRODUCT_NAME ,"L116HTN6SPW" ), - }, - .driver_data = (void *)BIT (QUIRK_DIS_PCI_CAP_ASPM ), - }, - { - .callback = disable_pci_caps, - .ident ="HP HP Pavilion Laptop 14-ce0xxx" , - .matches = { -DMI_MATCH (DMI_SYS_VENDOR ,"HP" ), -DMI_MATCH (DMI_PRODUCT_NAME ,"HP Pavilion Laptop 14-ce0xxx" ), - }, - .driver_data = (void *)BIT (QUIRK_DIS_PCI_CAP_ASPM ), - }, - { - .callback = disable_pci_caps, - .ident ="HP HP 250 G7 Notebook PC" , - .matches = { -DMI_MATCH (DMI_SYS_VENDOR ,"HP" ), -DMI_MATCH (DMI_PRODUCT_NAME ,"HP 250 G7 Notebook PC" ), - }, - .driver_data = (void *)BIT (QUIRK_DIS_PCI_CAP_ASPM ), - }, - {} -}; -int rtw_pci_probe (struct pci_dev *pdev,const struct pci_device_id *id) { +struct pci_dev *bridge =pci_upstream_bridge (pdev);struct ieee80211_hw *hw;struct rtw_dev *rtwdev; +struct rtw_pci *rtwpci;int drv_data_size;int ret;
@@ -1772,6 +1734,9 @@ int rtw_pci_probe(struct pci_dev *pdev, rtwdev->hci.ops = &rtw_pci_ops; rtwdev->hci.type =RTW_HCI_TYPE_PCIE ; + rtwpci = (struct rtw_pci *)rtwdev->priv; +atomic_set (&rtwpci->link_usage,1 ); + ret =rtw_core_init (rtwdev);if (ret) goto err_release_hw;
@@ -1800,7 +1765,10 @@ int rtw_pci_probe(struct pci_dev *pdev, goto err_destroy_pci; } -dmi_check_system (rtw88_pci_quirks); +/* Disable PCIe ASPM L1 while doing NAPI poll for 8821CE */ +if (pdev->device ==0xc821 && bridge->vendor ==PCI_VENDOR_ID_INTEL ) + rtwpci->rx_no_aspm = true; +rtw_pci_phy_cfg (rtwdev); ret =rtw_register_hw (rtwdev, hw);
drivers/net/wireless/realtek/rtw88/pci.h +2 -0
@@ -223,6 +223,8 @@ struct rtw_pci {struct rtw_pci_tx_ring tx_rings[RTK_MAX_TX_QUEUE_NUM ];struct rtw_pci_rx_ring rx_rings[RTK_MAX_RX_QUEUE_NUM ];u16 link_ctrl; +atomic_t link_usage; +bool rx_no_aspm;DECLARE_BITMAP (flags,NUM_OF_RTW_PCI_FLAGS );void __iomem *mmap;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 270/846 iwlwifi: mvm: fix 32-bit build in FTM
In reply to Greg Kroah-HartmanFrom: Johannes Berg <[email protected]>
[ Upstream commit 8b0f92549f2c2458200935c12a2e2a6e80234cf5 ]
On a 32-bit build, the division here needs to be done using do_div(), otherwise the compiler will try to call a function that doesn't exist, thus failing to build.
--- drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c +2 -1
@@ -1054,7 +1054,8 @@ static void iwl_mvm_ftm_rtt_smoothing(struct iwl_mvm *mvm, overshoot =IWL_MVM_FTM_INITIATOR_SMOOTH_OVERSHOOT ; alpha =IWL_MVM_FTM_INITIATOR_SMOOTH_ALPHA ; - rtt_avg = (alpha * rtt + (100 - alpha) * resp->rtt_avg) /100 ; + rtt_avg = alpha * rtt + (100 - alpha) * resp->rtt_avg; +do_div (rtt_avg,100 ); IWL_DEBUG_INFO(mvm, "%pM: prev rtt_avg=%lld, new rtt_avg=%lld, rtt=%lld\n",
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 271/846 iwlwifi: mvm: test roc running status bits before removing the sta
In reply to Greg Kroah-HartmanFrom: Nathan Errera <[email protected]>
[ Upstream commit 998e1aba6e5eb35370eaf30ccc1823426ec11f90 ]
In some cases the sta is being removed twice since we do not test the roc aux running before removing it. Start looking at the bit before removing the sta.
--- .../net/wireless/intel/iwlwifi/mvm/time-event.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)
drivers/net/wireless/intel/iwlwifi/mvm/time-event.c +12 -3
@@ -49,14 +49,13 @@ void iwl_mvm_roc_done_wk(struct work_struct *wk) struct iwl_mvm *mvm = container_of(wk, struct iwl_mvm, roc_done_wk);/* -* Clear the ROC_RUNNING /ROC_AUX_RUNNING status bit. +* Clear the ROC_RUNNING status bit. * This will cause the TX path to drop offchannel transmissions. * That would also be done by mac80211, but it is racy, in particular * in the case that the time event actually completed in the firmware * (which is handled in iwl_mvm_te_handle_notif). */ clear_bit (IWL_MVM_STATUS_ROC_RUNNING , &mvm->status); -clear_bit (IWL_MVM_STATUS_ROC_AUX_RUNNING , &mvm->status);synchronize_net ();
@@ -82,9 +81,19 @@ void iwl_mvm_roc_done_wk(struct work_struct *wk) mvmvif =iwl_mvm_vif_from_mac80211 (mvm->p2p_device_vif);iwl_mvm_flush_sta (mvm, &mvmvif->bcast_sta, true); } - }else { + } + +/* +* Clear the ROC_AUX_RUNNING status bit. +* This will cause the TX path to drop offchannel transmissions. +* That would also be done by mac80211, but it is racy, in particular +* in the case that the time event actually completed in the firmware +* (which is handled in iwl_mvm_te_handle_notif). +*/ +if (test_and_clear_bit (IWL_MVM_STATUS_ROC_AUX_RUNNING , &mvm->status)) {/* do the same in case of hot spot 2.0 */ iwl_mvm_flush_sta (mvm, &mvm->aux_sta, true); +/* In newer version of this command an aux station is added only * in cases of dedicated tx queue and need to be removed in end * of use */
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 272/846 iwlwifi: mvm: perform 6GHz passive scan after suspend
In reply to Greg Kroah-HartmanFrom: Avraham Stern <[email protected]>
[ Upstream commit f4745cbb17572209a7fa27a6796ed70e7ada860b ]
The 6GHz passive scan is performed only once every 50 minutes. However, in case of suspend/resume, the regulatory information is reset, so 6GHz channels may become disabled.
Fix it by performing a 6GHz passive scan within 60 seconds after suspend/resume even if the 50 minutes timeout did not expire yet.
--- drivers/net/wireless/intel/iwlwifi/mvm/scan.c | 21 ++++++++----------- 1 file changed, 9 insertions(+), 12 deletions(-)
drivers/net/wireless/intel/iwlwifi/mvm/scan.c +9 -12
@@ -1924,22 +1924,19 @@ static void iwl_mvm_scan_6ghz_passive_scan(struct iwl_mvm *mvm, }/* -* 6GHz passive scan is allowed while associated in a defined time -* interval following HW reset or resume flow +* 6GHz passive scan is allowed in a defined time interval following HW +* reset or resume flow, or while not associated and a large interval +* has passed since the last 6GHz passive scan. */ -if (vif->bss_conf.assoc && +if ((vif->bss_conf.assoc || +time_after (mvm->last_6ghz_passive_scan_jiffies + + (IWL_MVM_6GHZ_PASSIVE_SCAN_TIMEOUT *HZ ), jiffies)) && (time_before (mvm->last_reset_or_resume_time_jiffies + (IWL_MVM_6GHZ_PASSIVE_SCAN_ASSOC_TIMEOUT *HZ ), jiffies))) { -IWL_DEBUG_SCAN (mvm,"6GHz passive scan: associated\n" ); -return ; - } - -/* No need for 6GHz passive scan if not enough time elapsed */ -if (time_after (mvm->last_6ghz_passive_scan_jiffies + - (IWL_MVM_6GHZ_PASSIVE_SCAN_TIMEOUT *HZ ), jiffies)) { -IWL_DEBUG_SCAN (mvm, -"6GHz passive scan: timeout did not expire\n" ); +IWL_DEBUG_SCAN (mvm,"6GHz passive scan: %s\n" , + vif->bss_conf.assoc ?"associated" : +"timeout did not expire" );return ; }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 273/846 iwlwifi: mvm: set protected flag only for NDP ranging
In reply to Greg Kroah-HartmanFrom: Avraham Stern <[email protected]>
[ Upstream commit 6bb2ea37c02db98cb677f978cfcb833ca608c5eb ]
Don't use protected ranging negotiation for FTM ranging as responders that support only FTM ranging don't expect the FTM request to be protected.
--- drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c +1 -1
@@ -499,7 +499,7 @@ iwl_mvm_ftm_put_target(struct iwl_mvm *mvm, struct ieee80211_vif *vif,rcu_read_lock (); sta =rcu_dereference (mvm->fw_id_to_mac_id[mvmvif->ap_sta_id]); -if (sta->mfp) +if (sta->mfp && (peer->ftm.trigger_based || peer->ftm.non_trigger_based))FTM_PUT_FLAG (PMF );rcu_read_unlock ();
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 274/846 mmc: meson-mx-sdhc: add IRQ check
In reply to Greg Kroah-HartmanFrom: Sergey Shtylyov <[email protected]>
[ Upstream commit 77bed755e0f06135faccdd3948863703f9a6e640 ]
The driver neglects to check the result of platform_get_irq()'s call and blithely passes the negative error codes to devm_request_threaded_irq() (which takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original error code. Stop calling devm_request_threaded_irq() with the invalid IRQ #s.
--- drivers/mmc/host/meson-mx-sdhc-mmc.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/mmc/host/meson-mx-sdhc-mmc.c +5 -0
@@ -854,6 +854,11 @@ static int meson_mx_sdhc_probe(struct platform_device *pdev) goto err_disable_pclk; irq =platform_get_irq (pdev,0 ); +if (irq <0 ) { + ret = irq; + goto err_disable_pclk; + } + ret =devm_request_threaded_irq (dev, irq, meson_mx_sdhc_irq, meson_mx_sdhc_irq_thread,IRQF_ONESHOT ,NULL , host);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 275/846 mmc: meson-mx-sdio: add IRQ check
In reply to Greg Kroah-HartmanFrom: Sergey Shtylyov <[email protected]>
[ Upstream commit 8fc9a77bc64e1f23d07953439817d8402ac9706f ]
The driver neglects to check the result of platform_get_irq()'s call and blithely passes the negative error codes to devm_request_threaded_irq() (which takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original error code. Stop calling devm_request_threaded_irq() with the invalid IRQ #s.
--- drivers/mmc/host/meson-mx-sdio.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/mmc/host/meson-mx-sdio.c +5 -0
@@ -662,6 +662,11 @@ static int meson_mx_mmc_probe(struct platform_device *pdev) } irq =platform_get_irq (pdev,0 ); +if (irq <0 ) { + ret = irq; + goto error_free_mmc; + } + ret = devm_request_threaded_irq(host->controller_dev, irq, meson_mx_mmc_irq, meson_mx_mmc_irq_thread, IRQF_ONESHOT,
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 276/846 block: fix error unwinding in device_add_disk
In reply to Greg Kroah-HartmanFrom: Christoph Hellwig <[email protected]>
[ Upstream commit 99d8690aae4b2f0d1d90075de355ac087f820a66 ]
One device_add is called disk->ev will be freed by disk_release, so we should free it twice. Fix this by allocating disk->ev after device_add so that the extra local unwinding can be removed entirely.
Based on an earlier patch from Tetsuo Handa.
--- block/genhd.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
block/genhd.c +6 -7
@@ -432,10 +432,6 @@ int device_add_disk(struct device *parent, struct gendisk *disk, disk->flags |=GENHD_FL_EXT_DEVT ; } - ret =disk_alloc_events (disk); -if (ret) - goto out_free_ext_minor; -/* delay uevents, until we scanned partition table */ dev_set_uevent_suppress (ddev,1 );
@@ -446,7 +442,12 @@ int device_add_disk(struct device *parent, struct gendisk *disk, ddev->devt =MKDEV (disk->major, disk->first_minor); ret =device_add (ddev);if (ret) - goto out_disk_release_events; + goto out_free_ext_minor; + + ret =disk_alloc_events (disk); +if (ret) + goto out_device_del; +if (!sysfs_deprecated) { ret =sysfs_create_link (block_depr, &ddev->kobj,kobject_name (&ddev->kobj));
@@ -534,8 +535,6 @@ out_del_block_link:sysfs_remove_link (block_depr,dev_name (ddev)); out_device_del:device_del (ddev); -out_disk_release_events: -disk_release_events (disk); out_free_ext_minor:if (disk->major ==BLOCK_EXT_MAJOR )blk_free_ext_minor (disk->first_minor);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 277/846 selinux: fix potential memleak in selinux_add_opt()
In reply to Greg Kroah-HartmanFrom: Bernard Zhao <[email protected]>
[ Upstream commit 2e08df3c7c4e4e74e3dd5104c100f0bf6288aaa8 ]
This patch try to fix potential memleak in error branch.
--- security/selinux/hooks.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
security/selinux/hooks.c +10 -2
@@ -987,18 +987,22 @@ out:static int selinux_add_opt (int token,const char *s,void **mnt_opts) {struct selinux_mnt_opts *opts = *mnt_opts; +bool is_alloc_opts = false;if (token == Opt_seclabel)/* eaten and completely ignored */ return 0 ; +if (!s) +return -ENOMEM ; +if (!opts) { opts =kzalloc (sizeof (struct selinux_mnt_opts ),GFP_KERNEL );if (!opts)return -ENOMEM ; *mnt_opts = opts; + is_alloc_opts = true; } -if (!s) -return -ENOMEM ; +switch (token) {case Opt_context:if (opts->context || opts->defcontext)
@@ -1023,6 +1027,10 @@ static int selinux_add_opt(int token, const char *s, void **mnt_opts) }return 0 ; Einval: +if (is_alloc_opts) { +kfree (opts); + *mnt_opts =NULL ; + }pr_warn (SEL_MOUNT_FAIL_MSG );return -EINVAL ; }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 278/846 um: fix ndelay/udelay defines
In reply to Greg Kroah-HartmanFrom: Johannes Berg <[email protected]>
[ Upstream commit 5f8539e2ff962e25b57742ca7106456403abbc94 ]
Many places in the kernel use 'udelay' as an identifier, and are broken with the current "#define udelay um_udelay". Fix this by adding an argument to the macro, and do the same to 'ndelay' as well, just in case.
--- arch/um/include/asm/delay.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/um/include/asm/delay.h +2 -2
@@ -14,7 +14,7 @@ static inline void um_ndelay(unsigned long nsecs)ndelay (nsecs); }#undef ndelay -#define ndelay um_ndelay +#define ndelay (n) um_ndelay(n)static inline void um_udelay (unsigned long usecs) {
@@ -26,5 +26,5 @@ static inline void um_udelay(unsigned long usecs) udelay(usecs); }#undef udelay -#define udelay um_udelay +#define udelay (n) um_udelay(n)#endif /* __UM_DELAY_H */
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 279/846 um: rename set_signals() to um_set_signals()
In reply to Greg Kroah-HartmanFrom: Johannes Berg <[email protected]>
[ Upstream commit bbe33504d4a7fdab9011211e55e262c869b3f6cc ]
Rename set_signals() as there's at least one driver that uses the same name and can now be built on UM due to PCI support, and thus we can get symbol conflicts.
Also rename set_signals_trace() to be consistent.
--- arch/um/include/asm/irqflags.h | 4 ++-- arch/um/include/shared/longjmp.h | 2 +- arch/um/include/shared/os.h | 4 ++-- arch/um/kernel/ksyms.c | 2 +- arch/um/os-Linux/sigio.c | 6 +++--- arch/um/os-Linux/signal.c | 8 ++++---- 6 files changed, 13 insertions(+), 13 deletions(-)
arch/um/include/asm/irqflags.h +2 -2
@@ -3,7 +3,7 @@#define __UM_IRQFLAGS_Hextern int signals_enabled; -int set_signals (int enable); +int um_set_signals (int enable);void block_signals (void );void unblock_signals (void );
@@ -16,7 +16,7 @@ static inline unsigned long arch_local_save_flags(void)#define arch_local_irq_restore arch_local_irq_restorestatic inline void arch_local_irq_restore (unsigned long flags) { -set_signals (flags); +um_set_signals (flags); }#define arch_local_irq_enable arch_local_irq_enable
arch/um/include/shared/longjmp.h +1 -1
@@ -18,7 +18,7 @@ extern void longjmp(jmp_buf, int); enable = *(volatile int *)&signals_enabled; \ n =setjmp (*buf); \if (n !=0 ) \ -set_signals_trace (enable); \ +um_set_signals_trace (enable); \ n; })#endif
arch/um/include/shared/os.h +2 -2
@@ -238,8 +238,8 @@ extern void send_sigio_to_self(void);extern int change_sig (int signal,int on);extern void block_signals (void );extern void unblock_signals (void ); -extern int set_signals (int enable); -extern int set_signals_trace (int enable); +extern int um_set_signals (int enable); +extern int um_set_signals_trace (int enable);extern int os_is_signal_stack (void );extern void deliver_alarm (void );extern void register_pm_wake_signal (void );
arch/um/kernel/ksyms.c +1 -1
@@ -6,7 +6,7 @@#include <linux/module.h> #include <os.h> -EXPORT_SYMBOL (set_signals); +EXPORT_SYMBOL (um_set_signals);EXPORT_SYMBOL (signals_enabled);EXPORT_SYMBOL (os_stat_fd);
arch/um/os-Linux/sigio.c +3 -3
@@ -132,7 +132,7 @@ static void update_thread(void)int n;char c; - flags =set_signals_trace (0 ); + flags =um_set_signals_trace (0 );CATCH_EINTR (n =write (sigio_private[0 ], &c,sizeof (c)));if (n !=sizeof (c)) { printk(UM_KERN_ERR "update_thread : write failed, err = %d\n",
@@ -147,7 +147,7 @@ static void update_thread(void) goto fail; } -set_signals_trace (flags); +um_set_signals_trace (flags);return ; fail:/* Critical section start */
@@ -161,7 +161,7 @@ static void update_thread(void)close (write_sigio_fds[0 ]);close (write_sigio_fds[1 ]);/* Critical section end */ -set_signals_trace (flags); +um_set_signals_trace (flags); }int __add_sigio_fd (int fd)
arch/um/os-Linux/signal.c +4 -4
@@ -94,7 +94,7 @@ void sig_handler(int sig, struct siginfo *si, mcontext_t *mc)sig_handler_common (sig, si, mc); -set_signals_trace (enabled); +um_set_signals_trace (enabled); }static void timer_real_alarm_handler (mcontext_t *mc)
@@ -126,7 +126,7 @@ void timer_alarm_handler(int sig, struct siginfo *unused_si, mcontext_t *mc) signals_active &= ~SIGALRM_MASK ; -set_signals_trace (enabled); +um_set_signals_trace (enabled); }void deliver_alarm (void ) {
@@ -348,7 +348,7 @@ void unblock_signals(void) } } -int set_signals (int enable) +int um_set_signals (int enable) {int ret;if (signals_enabled == enable)
@@ -362,7 +362,7 @@ int set_signals(int enable)return ret; } -int set_signals_trace (int enable) +int um_set_signals_trace (int enable) {int ret;if (signals_enabled == enable)
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 280/846 um: virt-pci: Fix 32-bit compile
In reply to Greg Kroah-HartmanFrom: Johannes Berg <[email protected]>
[ Upstream commit d73820df6437b5d0a57be53faf39db46a0264b3a ]
There were a few 32-bit compile warnings that of course turned into errors with -Werror, fix the 32-bit build.
--- arch/um/drivers/virt-pci.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
arch/um/drivers/virt-pci.c +4 -4
@@ -181,15 +181,15 @@ static unsigned long um_pci_cfgspace_read(void *priv, unsigned int offset,/* buf->data is maximum size - we may only use parts of it */ struct um_pci_message_buffer *buf;u8 *data; -unsigned long ret = ~0ULL ; +unsigned long ret =ULONG_MAX ;if (!dev) -return ~0ULL ; +return ULONG_MAX ; buf =get_cpu_var (um_pci_msg_bufs); data = buf->data; -memset (data,0xff ,sizeof (data)); +memset (buf->data,0xff ,sizeof (buf->data));switch (size) {case 1 :
@@ -304,7 +304,7 @@ static unsigned long um_pci_bar_read(void *priv, unsigned int offset,/* buf->data is maximum size - we may only use parts of it */ struct um_pci_message_buffer *buf;u8 *data; -unsigned long ret = ~0ULL ; +unsigned long ret =ULONG_MAX ; buf =get_cpu_var (um_pci_msg_bufs); data = buf->data;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 281/846 lib/logic_iomem: Fix 32-bit build
In reply to Greg Kroah-HartmanFrom: Johannes Berg <[email protected]>
[ Upstream commit 4e84139e14af5ea60772cc4f33d7059aec76e0eb ]
On a 32-bit build, the (unsigned long long) casts throw warnings (or errors) due to being to a different integer size. Cast to uintptr_t first (with the __force for sparse) and then further to get the consistent print on 32 and 64-bit.
--- lib/logic_iomem.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
lib/logic_iomem.c +7 -6
@@ -79,7 +79,7 @@ static void __iomem *real_ioremap(phys_addr_t offset, size_t size)static void real_iounmap (void __iomem *addr) {WARN (1 ,"invalid iounmap for addr 0x%llx\n" , - (unsigned long long __force )addr); + (unsigned long long )(uintptr_t __force )addr); }#endif /* CONFIG_LOGIC_IOMEM_FALLBACK */
@@ -173,7 +173,7 @@ EXPORT_SYMBOL(iounmap); static u##sz real_raw_read ## op(const volatile void __iomem *addr) \ { \ WARN(1, "Invalid read" #op " at address %llx\n", \ - (unsigned long long __force)addr); \ + (unsigned long long)(uintptr_t __force)addr); \ return (u ## sz)~0ULL; \ } \ \
@@ -181,7 +181,8 @@ static void real_raw_write ## op(u ## sz val, \ volatile void __iomem *addr) \ { \ WARN(1, "Invalid writeq" #op " of 0x%llx at address %llx\n", \ - (unsigned long long )val, (unsigned long long __force )addr);\ + (unsigned long long)val, \ + (unsigned long long)(uintptr_t __force)addr);\ } \MAKE_FALLBACK (b,8 );
@@ -194,14 +195,14 @@ MAKE_FALLBACK(q, 64);static void real_memset_io (volatile void __iomem *addr,int value,size_t size) {WARN (1 ,"Invalid memset_io at address 0x%llx\n" , - (unsigned long long __force )addr); + (unsigned long long )(uintptr_t __force )addr); }static void real_memcpy_fromio (void *buffer,const volatile void __iomem *addr,size_t size) {WARN (1 ,"Invalid memcpy_fromio at address 0x%llx\n" , - (unsigned long long __force )addr); + (unsigned long long )(uintptr_t __force )addr);memset (buffer,0xff , size); }
@@ -210,7 +211,7 @@ static void real_memcpy_toio(volatile void __iomem *addr, const void *buffer, size_t size) {WARN (1 ,"Invalid memcpy_toio at address 0x%llx\n" , - (unsigned long long __force )addr); + (unsigned long long )(uintptr_t __force )addr); }#endif /* CONFIG_LOGIC_IOMEM_FALLBACK */
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 282/846 lib/logic_iomem: Fix operation on 32-bit
In reply to Greg Kroah-HartmanFrom: Johannes Berg <[email protected]>
[ Upstream commit 4e8a5edac5010820e7c5303fc96f5a262e096bb6 ]
On 32-bit, the first entry might be at 0/NULL, but that's strange and leads to issues, e.g. where we check "if (ret)". Use a IOREMAP_BIAS/IOREMAP_MASK of 0x80000000UL to avoid this. This then requires reducing the number of areas (via MAX_AREAS), but we still have 128 areas, which is enough.
--- lib/logic_iomem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
lib/logic_iomem.c +3 -3
@@ -21,15 +21,15 @@ struct logic_iomem_area {#define AREA_SHIFT 24#define MAX_AREA_SIZE (1 << AREA_SHIFT) -#define MAX_AREAS ((1ULL<<32) / MAX_AREA_SIZE) +#define MAX_AREAS ((1U << 31) / MAX_AREA_SIZE)#define AREA_BITS ((MAX_AREAS - 1) << AREA_SHIFT)#define AREA_MASK (MAX_AREA_SIZE - 1)#ifdef CONFIG_64BIT #define IOREMAP_BIAS 0xDEAD000000000000UL#define IOREMAP_MASK 0xFFFFFFFF00000000UL#else -#define IOREMAP_BIAS 0 -#define IOREMAP_MASK 0 +#define IOREMAP_BIAS 0x80000000UL +#define IOREMAP_MASK 0x80000000UL#endif static DEFINE_MUTEX (regions_mtx);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 283/846 um: virtio_uml: Fix time-travel external time propagation
In reply to Greg Kroah-HartmanFrom: Johannes Berg <[email protected]>
[ Upstream commit 85e73968a040c642fd38f6cba5b73b61f5d0f052 ]
When creating an external event, the current time needs to be propagated to other participants of a simulation. This is done in the places here where we kick a virtq etc.
However, it must be done for _all_ external events, and that includes making the initial socket connection and later closing it. Call time_travel_propagate_time() to do this before making or closing the socket connection.
Apparently, at least for the initial connection creation, due to the remote side in my use cases using microseconds (rather than nanoseconds), this wasn't a problem yet; only started failing between 5.14-rc1 and 5.15-rc1 (didn't test others much), or possibly depending on the configuration, where more delays happen before the virtio devices are initialized.
--- arch/um/drivers/virtio_uml.c | 4 ++++ 1 file changed, 4 insertions(+)
arch/um/drivers/virtio_uml.c +4 -0
@@ -1090,6 +1090,8 @@ static void virtio_uml_release_dev(struct device *d) container_of(d, struct virtio_device, dev);struct virtio_uml_device *vu_dev =to_virtio_uml_device (vdev); +time_travel_propagate_time (); +/* might not have been opened due to not negotiating the feature */ if (vu_dev->req_fd >=0 ) {um_free_irq (vu_dev->irq, vu_dev);
@@ -1136,6 +1138,8 @@ static int virtio_uml_probe(struct platform_device *pdev) vu_dev->pdev = pdev; vu_dev->req_fd =-1 ; +time_travel_propagate_time (); +do { rc =os_connect_socket (pdata->socket_path); }while (rc == -EINTR );
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 284/846 Bluetooth: L2CAP: Fix using wrong mode
In reply to Greg Kroah-HartmanFrom: Luiz Augusto von Dentz <[email protected]>
[ Upstream commit 30d57722732d9736554f85f75f9d7ad5402d192e ]
If user has a set to use SOCK_STREAM the socket would default to L2CAP_MODE_ERTM which later needs to be adjusted if the destination address is LE which doesn't support such mode.
--- net/bluetooth/l2cap_sock.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
net/bluetooth/l2cap_sock.c +10 -2
@@ -161,7 +161,11 @@ static int l2cap_sock_bind(struct socket *sock, struct sockaddr *addr, int alen)break ; } -if (chan->psm &&bdaddr_type_is_le (chan->src_type)) +/* Use L2CAP_MODE_LE_FLOWCTL (CoC) in case of LE address and +* L2CAP_MODE_EXT_FLOWCTL (ECRED) has not been set. +*/ +if (chan->psm &&bdaddr_type_is_le (chan->src_type) && + chan->mode !=L2CAP_MODE_EXT_FLOWCTL ) chan->mode =L2CAP_MODE_LE_FLOWCTL ; chan->state =BT_BOUND ;
@@ -255,7 +259,11 @@ static int l2cap_sock_connect(struct socket *sock, struct sockaddr *addr,return -EINVAL ; } -if (chan->psm &&bdaddr_type_is_le (chan->src_type) && !chan->mode) +/* Use L2CAP_MODE_LE_FLOWCTL (CoC) in case of LE address and +* L2CAP_MODE_EXT_FLOWCTL (ECRED) has not been set. +*/ +if (chan->psm &&bdaddr_type_is_le (chan->src_type) && + chan->mode !=L2CAP_MODE_EXT_FLOWCTL ) chan->mode =L2CAP_MODE_LE_FLOWCTL ;l2cap_sock_init_pid (sk);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 285/846 bpftool: Enable line buffering for stdout
In reply to Greg Kroah-HartmanFrom: Paul Chaignon <[email protected]>
[ Upstream commit 1a1a0b0364ad291bd8e509da104ac8b5b1afec5d ]
The output of bpftool prog tracelog is currently buffered, which is inconvenient when piping the output into other commands. A simple tracelog | grep will typically not display anything. This patch fixes it by enabling line buffering on stdout for the whole bpftool binary.
--- tools/bpf/bpftool/main.c | 2 ++ 1 file changed, 2 insertions(+)
tools/bpf/bpftool/main.c +2 -0
@@ -402,6 +402,8 @@ int main(int argc, char **argv) };int opt, ret; +setlinebuf (stdout); + last_do_help = do_help; pretty_output = false; json_output = false;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 286/846 backlight: qcom-wled: Validate enabled string indices in DT
In reply to Greg Kroah-HartmanFrom: Marijn Suijten <[email protected]>
[ Upstream commit c05b21ebc5bce3ecc78c2c71afd76d92c790a2ac ]
The strings passed in DT may possibly cause out-of-bounds register accesses and should be validated before use.
--- drivers/video/backlight/qcom-wled.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-)
drivers/video/backlight/qcom-wled.c +17 -1
@@ -1528,12 +1528,28 @@ static int wled_configure(struct wled *wled) string_len =of_property_count_elems_of_size (dev->of_node,"qcom,enabled-strings" ,sizeof (u32)); -if (string_len >0 ) +if (string_len >0 ) { +if (string_len > wled->max_string_count) { +dev_err (dev,"Cannot have more than %d strings\n" , + wled->max_string_count); +return -EINVAL ; + } +of_property_read_u32_array (dev->of_node,"qcom,enabled-strings" , wled->cfg.enabled_strings,sizeof (u32)); +for (i =0 ; i < string_len; ++i) { +if (wled->cfg.enabled_strings[i] >= wled->max_string_count) { +dev_err (dev, +"qcom,enabled-strings index %d at %d is out of bounds\n" , + wled->cfg.enabled_strings[i], i); +return -EINVAL ; + } + } + } +return 0 ; }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 287/846 backlight: qcom-wled: Pass number of elements to read to read_u32_array
In reply to Greg Kroah-HartmanFrom: Marijn Suijten <[email protected]>
[ Upstream commit e29e24bdabfeddbf8b1a4ecac1af439a85150438 ]
of_property_read_u32_array takes the number of elements to read as last argument. This does not always need to be 4 (sizeof(u32)) but should instead be the size of the array in DT as read just above with of_property_count_elems_of_size.
To not make such an error go unnoticed again the driver now bails accordingly when of_property_read_u32_array returns an error. Surprisingly the indentation of newlined arguments is lining up again after prepending rc = .
--- drivers/video/backlight/qcom-wled.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/video/backlight/qcom-wled.c +7 -2
@@ -1535,10 +1535,15 @@ static int wled_configure(struct wled *wled)return -EINVAL ; } -of_property_read_u32_array (dev->of_node, + rc =of_property_read_u32_array (dev->of_node,"qcom,enabled-strings" , wled->cfg.enabled_strings, -sizeof (u32)); + string_len); +if (rc) { +dev_err (dev,"Failed to read %d elements from qcom,enabled-strings: %d\n" , + string_len, rc); +return rc; + }for (i =0 ; i < string_len; ++i) {if (wled->cfg.enabled_strings[i] >= wled->max_string_count) {
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 288/846 backlight: qcom-wled: Fix off-by-one maximum with default num_strings
In reply to Greg Kroah-HartmanFrom: Marijn Suijten <[email protected]>
[ Upstream commit 5ada78b26f935f8751852dffa24f6b545b1d2517 ]
When not specifying num-strings in the DT the default is used, but +1 is added to it which turns WLED3 into 4 and WLED4/5 into 5 strings instead of 3 and 4 respectively, causing out-of-bounds reads and register read/writes. This +1 exists for a deficiency in the DT parsing code, and is simply omitted entirely - solving this oob issue - by parsing the property separately much like qcom,enabled-strings.
This also enables more stringent checks on the maximum value when qcom,enabled-strings is provided in the DT, by parsing num-strings after enabled-strings to allow it to check against (and in a subsequent patch override) the length of enabled-strings: it is invalid to set num-strings higher than that.
The DT currently utilizes it to get around an incorrect fixed read of four elements from that array (has been addressed in a prior patch) by setting a lower num-strings where desired.
--- drivers/video/backlight/qcom-wled.c | 48 ++++++++++------------------- 1 file changed, 16 insertions(+), 32 deletions(-)
drivers/video/backlight/qcom-wled.c +16 -32
@@ -1256,21 +1256,6 @@ static const struct wled_var_cfg wled5_ovp_cfg = { .size = 16, }; -static u32 wled3_num_strings_values_fn (u32 idx) -{ -return idx +1 ; -} - -static const struct wled_var_cfg wled3_num_strings_cfg = { - .fn = wled3_num_strings_values_fn, - .size =3 , -}; - -static const struct wled_var_cfg wled4_num_strings_cfg = { - .fn = wled3_num_strings_values_fn, - .size =4 , -}; -static u32 wled3_switch_freq_values_fn (u32 idx) {return 19200 / (2 * (1 + idx));
@@ -1344,11 +1329,6 @@ static int wled_configure(struct wled *wled) .val_ptr = &cfg->switch_freq, .cfg = &wled3_switch_freq_cfg, }, - { - .name = "qcom,num-strings", - .val_ptr = &cfg->num_strings, - .cfg = &wled3_num_strings_cfg, - }, }; const struct wled_u32_opts wled4_opts[] = {
@@ -1372,11 +1352,6 @@ static int wled_configure(struct wled *wled) .val_ptr = &cfg->switch_freq, .cfg = &wled3_switch_freq_cfg, }, - { - .name = "qcom,num-strings", - .val_ptr = &cfg->num_strings, - .cfg = &wled4_num_strings_cfg, - }, }; const struct wled_u32_opts wled5_opts[] = {
@@ -1400,11 +1375,6 @@ static int wled_configure(struct wled *wled) .val_ptr = &cfg->switch_freq, .cfg = &wled3_switch_freq_cfg, }, - { - .name = "qcom,num-strings", - .val_ptr = &cfg->num_strings, - .cfg = &wled4_num_strings_cfg, - }, { .name = "qcom,modulator-sel", .val_ptr = &cfg->mod_sel,
@@ -1523,8 +1493,6 @@ static int wled_configure(struct wled *wled) *bool_opts[i].val_ptr = true; } - cfg->num_strings = cfg->num_strings +1 ; - string_len =of_property_count_elems_of_size (dev->of_node,"qcom,enabled-strings" ,sizeof (u32));
@@ -1555,6 +1523,22 @@ static int wled_configure(struct wled *wled) } } + rc =of_property_read_u32 (dev->of_node,"qcom,num-strings" , &val); +if (!rc) { +if (val <1 || val > wled->max_string_count) { +dev_err (dev,"qcom,num-strings must be between 1 and %d\n" , + wled->max_string_count); +return -EINVAL ; + } + +if (string_len >0 && val > string_len) { +dev_err (dev,"qcom,num-strings exceeds qcom,enabled-strings\n" ); +return -EINVAL ; + } + + cfg->num_strings = val; + } +return 0 ; }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 289/846 backlight: qcom-wled: Override default length with qcom,enabled-strings
In reply to Greg Kroah-HartmanFrom: Marijn Suijten <[email protected]>
[ Upstream commit 2b4b49602f9feca7b7a84eaa33ad9e666c8aa695 ]
The length of qcom,enabled-strings as property array is enough to determine the number of strings to be enabled, without needing to set qcom,num-strings to override the default number of strings when less than the default (which is also the maximum) is provided in DT.
This also introduces an extra warning when qcom,num-strings is set, denoting that it is not necessary to set both anymore. It is usually more concise to set just qcom,num-length when a zero-based, contiguous range of strings is needed (the majority of the cases), or to only set qcom,enabled-strings when a specific set of indices is desired.
--- drivers/video/backlight/qcom-wled.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/video/backlight/qcom-wled.c +9 -3
@@ -1521,6 +1521,8 @@ static int wled_configure(struct wled *wled)return -EINVAL ; } } + + cfg->num_strings = string_len; } rc =of_property_read_u32 (dev->of_node,"qcom,num-strings" , &val);
@@ -1531,9 +1533,13 @@ static int wled_configure(struct wled *wled)return -EINVAL ; } -if (string_len >0 && val > string_len) { -dev_err (dev,"qcom,num-strings exceeds qcom,enabled-strings\n" ); -return -EINVAL ; +if (string_len >0 ) { +dev_warn (dev,"Only one of qcom,num-strings or qcom,enabled-strings" +" should be set\n" ); +if (val > string_len) { +dev_err (dev,"qcom,num-strings exceeds qcom,enabled-strings\n" ); +return -EINVAL ; + } } cfg->num_strings = val;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 290/846 backlight: qcom-wled: Use cpu_to_le16 macro to perform conversion
In reply to Greg Kroah-HartmanFrom: Marijn Suijten <[email protected]>
[ Upstream commit 0a139358548968b2ff308257b4fbeec7badcc3e1 ]
The kernel already provides appropriate primitives to perform endianness conversion which should be used in favour of manual bit-wrangling.
--- drivers/video/backlight/qcom-wled.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-)
drivers/video/backlight/qcom-wled.c +11 -12
@@ -231,14 +231,14 @@ struct wled {static int wled3_set_brightness (struct wled *wled,u16 brightness) {int rc, i; -u8 v[2 ]; +__le16 v; - v[0 ] = brightness &0xff ; - v[1 ] = (brightness >>8 ) &0xf ; + v =cpu_to_le16 (brightness &WLED3_SINK_REG_BRIGHT_MAX );for (i =0 ; i < wled->cfg.num_strings; ++i) { rc =regmap_bulk_write (wled->regmap, wled->ctrl_addr + -WLED3_SINK_REG_BRIGHT (i), v,2 ); +WLED3_SINK_REG_BRIGHT (i), + &v,sizeof (v));if (rc <0 )return rc; }
@@ -250,18 +250,18 @@ static int wled4_set_brightness(struct wled *wled, u16 brightness) {int rc, i;u16 low_limit = wled->max_brightness *4 /1000 ; -u8 v[2 ]; +__le16 v;/* WLED4's lower limit of operation is 0.4% */ if (brightness >0 && brightness < low_limit) brightness = low_limit; - v[0 ] = brightness &0xff ; - v[1 ] = (brightness >>8 ) &0xf ; + v =cpu_to_le16 (brightness &WLED3_SINK_REG_BRIGHT_MAX );for (i =0 ; i < wled->cfg.num_strings; ++i) { rc =regmap_bulk_write (wled->regmap, wled->sink_addr + -WLED4_SINK_REG_BRIGHT (i), v,2 ); +WLED4_SINK_REG_BRIGHT (i), + &v,sizeof (v));if (rc <0 )return rc; }
@@ -273,21 +273,20 @@ static int wled5_set_brightness(struct wled *wled, u16 brightness) {int rc, offset;u16 low_limit = wled->max_brightness *1 /1000 ; -u8 v[2 ]; +__le16 v;/* WLED5's lower limit is 0.1% */ if (brightness < low_limit) brightness = low_limit; - v[0 ] = brightness &0xff ; - v[1 ] = (brightness >>8 ) &0x7f ; + v =cpu_to_le16 (brightness &WLED5_SINK_REG_BRIGHT_MAX_15B ); offset = (wled->cfg.mod_sel ==MOD_A ) ?WLED5_SINK_REG_MOD_A_BRIGHTNESS_LSB :WLED5_SINK_REG_MOD_B_BRIGHTNESS_LSB ; rc =regmap_bulk_write (wled->regmap, wled->sink_addr + offset, - v,2 ); + &v,sizeof (v));return rc; }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 291/846 backlight: qcom-wled: Respect enabled-strings in set_brightness
In reply to Greg Kroah-HartmanFrom: Marijn Suijten <[email protected]>
[ Upstream commit ec961cf3241153e0f27d850f1bf0f172e7d27a21 ]
The hardware is capable of controlling any non-contiguous sequence of LEDs specified in the DT using qcom,enabled-strings as u32 array, and this also follows from the DT-bindings documentation. The numbers specified in this array represent indices of the LED strings that are to be enabled and disabled.
Its value is appropriately used to setup and enable string modules, but completely disregarded in the set_brightness paths which only iterate over the number of strings linearly.
Take an example where only string 2 is enabled with qcom,enabled_strings=<2>: this string is appropriately enabled but subsequent brightness changes would have only touched the zero'th brightness register because num_strings is 1 here. This is simply addressed by looking up the string for this index in the enabled_strings array just like the other codepaths that iterate over num_strings.
Likewise enabled_strings is now also used in the autodetection path for consistent behaviour: when a list of strings is specified in DT only those strings will be probed for autodetection, analogous to how the number of strings that need to be probed is already bound by qcom,num-strings. After all autodetection uses the set_brightness helpers to set an initial value, which could otherwise end up changing brightness on a different set of strings.
--- drivers/video/backlight/qcom-wled.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-)
drivers/video/backlight/qcom-wled.c +12 -10
@@ -237,7 +237,7 @@ static int wled3_set_brightness(struct wled *wled, u16 brightness)for (i =0 ; i < wled->cfg.num_strings; ++i) { rc =regmap_bulk_write (wled->regmap, wled->ctrl_addr + -WLED3_SINK_REG_BRIGHT (i), +WLED3_SINK_REG_BRIGHT (wled->cfg.enabled_strings[i]), &v,sizeof (v));if (rc <0 )return rc;
@@ -260,7 +260,7 @@ static int wled4_set_brightness(struct wled *wled, u16 brightness)for (i =0 ; i < wled->cfg.num_strings; ++i) { rc =regmap_bulk_write (wled->regmap, wled->sink_addr + -WLED4_SINK_REG_BRIGHT (i), +WLED4_SINK_REG_BRIGHT (wled->cfg.enabled_strings[i]), &v,sizeof (v));if (rc <0 )return rc;
@@ -571,7 +571,7 @@ unlock_mutex:static void wled_auto_string_detection (struct wled *wled) { -int rc =0 , i, delay_time_us; +int rc =0 , i, j, delay_time_us;u32 sink_config =0 ;u8 sink_test =0 , sink_valid =0 , val;bool fault_set;
@@ -618,14 +618,15 @@ static void wled_auto_string_detection(struct wled *wled)/* Iterate through the strings one by one */ for (i =0 ; i < wled->cfg.num_strings; i++) { - sink_test =BIT ((WLED4_SINK_REG_CURR_SINK_SHFT + i)); + j = wled->cfg.enabled_strings[i]; + sink_test =BIT ((WLED4_SINK_REG_CURR_SINK_SHFT + j));/* Enable feedback control */ rc =regmap_write (wled->regmap, wled->ctrl_addr + -WLED3_CTRL_REG_FEEDBACK_CONTROL , i +1 ); +WLED3_CTRL_REG_FEEDBACK_CONTROL , j +1 );if (rc <0 ) {dev_err (wled->dev,"Failed to enable feedback for SINK %d rc = %d\n" , - i +1 , rc); + j +1 , rc); goto failed_detect; }
@@ -634,7 +635,7 @@ static void wled_auto_string_detection(struct wled *wled) WLED4_SINK_REG_CURR_SINK, sink_test);if (rc <0 ) {dev_err (wled->dev,"Failed to configure SINK %d rc=%d\n" , - i +1 , rc); + j +1 , rc); goto failed_detect; }
@@ -661,7 +662,7 @@ static void wled_auto_string_detection(struct wled *wled)if (fault_set)dev_dbg (wled->dev,"WLED OVP fault detected with SINK %d\n" , - i +1 ); + j +1 );else sink_valid |= sink_test;
@@ -701,15 +702,16 @@ static void wled_auto_string_detection(struct wled *wled)/* Enable valid sinks */ if (wled->version ==4 ) {for (i =0 ; i < wled->cfg.num_strings; i++) { + j = wled->cfg.enabled_strings[i];if (sink_config & -BIT (WLED4_SINK_REG_CURR_SINK_SHFT + i)) +BIT (WLED4_SINK_REG_CURR_SINK_SHFT + j)) val =WLED4_SINK_REG_STR_MOD_MASK ;else /* Disable modulator_en for unused sink */ val =0 ; rc =regmap_write (wled->regmap, wled->sink_addr + -WLED4_SINK_REG_STR_MOD_EN (i), val); +WLED4_SINK_REG_STR_MOD_EN (j), val);if (rc <0 ) {dev_err (wled->dev,"Failed to configure MODULATOR_EN rc=%d\n" , rc);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 292/846 software node: fix wrong node passed to find nargs_prop
In reply to Greg Kroah-HartmanFrom: Clément Léger <[email protected]>
[ Upstream commit c5fc5ba8b6b7bebc05e45036a33405b4c5036c2f ]
nargs_prop refers to a property located in the reference that is found within the nargs property. Use the correct reference node in call to property_entry_read_int_array() to retrieve the correct nargs value.
--- drivers/base/swnode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/base/swnode.c +1 -1
@@ -535,7 +535,7 @@ software_node_get_reference_args(const struct fwnode_handle *fwnode,return -ENOENT ;if (nargs_prop) { - error =property_entry_read_int_array (swnode->node->properties, + error =property_entry_read_int_array (ref->node->properties, nargs_prop,sizeof (u32), &nargs_prop_val,1 );if (error)
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 293/846 Bluetooth: hci_qca: Stop IBS timer during BT OFF
In reply to Greg Kroah-HartmanFrom: Panicker Harish <[email protected]>
[ Upstream commit df1e5c51492fd93ffc293acdcc6f00698d19fedc ]
The IBS timers are not stopped properly once BT OFF is triggered. we could see IBS commands being sent along with version command, so stopped IBS timers while Bluetooth is off.
--- drivers/bluetooth/hci_qca.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/bluetooth/hci_qca.c +3 -0
@@ -1927,6 +1927,9 @@ static int qca_power_off(struct hci_dev *hdev) hu->hdev->hw_error =NULL ; hu->hdev->cmd_timeout =NULL ; +del_timer_sync (&qca->wake_retrans_timer); +del_timer_sync (&qca->tx_idle_timer); +/* Stop sending shutdown command if soc crashes. */ if (soc_type !=QCA_ROME && qca->memdump_state ==QCA_MEMDUMP_IDLE ) {
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 294/846 x86/boot/compressed: Move CLANG_FLAGS to beginning of KBUILD_CFLAGS
In reply to Greg Kroah-HartmanFrom: Nathan Chancellor <[email protected]>
[ Upstream commit 5fe392ff9d1f7254a1fbb3f72d9893088e4d23eb ]
When cross compiling i386_defconfig on an arm64 host with clang, there are a few instances of '-Waddress-of-packed-member' and '-Wgnu-variable-sized-type-not-at-end' in arch/x86/boot/compressed/, which should both be disabled with the cc-disable-warning calls in that directory's Makefile, which indicates that cc-disable-warning is failing at the point of testing these flags.
The cc-disable-warning calls fail because at the point that the flags are tested, KBUILD_CFLAGS has '-march=i386' without $(CLANG_FLAGS), which has the '--target=' flag to tell clang what architecture it is targeting. Without the '--target=' flag, the host architecture (arm64) is used and i386 is not a valid value for '-march=' in that case. This error can be seen by adding some logging to try-run:
clang-14: error: the clang compiler does not support '-march=i386'
Invoking the compiler has to succeed prior to calling cc-option or cc-disable-warning in order to accurately test whether or not the flag is supported; if it doesn't, the requested flag can never be added to the compiler flags. Move $(CLANG_FLAGS) to the beginning of KBUILD_FLAGS so that any new flags that might be added in the future can be accurately tested.
--- arch/x86/boot/compressed/Makefile | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
arch/x86/boot/compressed/Makefile +5 -2
@@ -28,7 +28,11 @@ KCOV_INSTRUMENT := n targets := vmlinux vmlinux.bin vmlinux.bin.gz vmlinux.bin.bz2 vmlinux.bin.lzma \ vmlinux.bin.xz vmlinux.bin.lzo vmlinux.bin.lz4 vmlinux.bin.zst -KBUILD_CFLAGS := -m$(BITS) -O2 +# CLANG_FLAGS must come before any cc-disable-warning or cc-option calls in +# case of cross compiling, as it has the '--target=' flag, which is needed to +# avoid errors with '-march=i386', and future flags may depend on the target to +# be valid. +KBUILD_CFLAGS := -m$(BITS) -O2 $(CLANG_FLAGS) KBUILD_CFLAGS += -fno-strict-aliasing -fPIE KBUILD_CFLAGS += -Wundef KBUILD_CFLAGS += -DDISABLE_BRANCH_PROFILING
@@ -47,7 +51,6 @@ KBUILD_CFLAGS += -D__DISABLE_EXPORTS # Disable relocation relaxation in case the link is not PIE. KBUILD_CFLAGS += $(call as-option,-Wa$(comma)-mrelax-relocations=no) KBUILD_CFLAGS += -include $(srctree)/include/linux/hidden.h -KBUILD_CFLAGS += $(CLANG_FLAGS) # sev.c indirectly inludes inat-table.h which is generated during # compilation and stored in $(objtree). Add the directory to the includes so
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 295/846 crypto: octeontx2 - prevent underflow in get_cores_bmap()
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
[ Upstream commit 10371b6212bb682f13247733d6b76b91b2b80f9a ]
If we're going to cap "eng_grp->g->engs_num" upper bounds then we should cap the lower bounds as well.
--- drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c +2 -1
@@ -29,7 +29,8 @@ static struct otx2_cpt_bitmap get_cores_bmap(struct device *dev,bool found = false;int i; -if (eng_grp->g->engs_num >OTX2_CPT_MAX_ENGINES ) { +if (eng_grp->g->engs_num <0 || + eng_grp->g->engs_num >OTX2_CPT_MAX_ENGINES ) {dev_err (dev,"unsupported number of engines %d on octeontx2\n" , eng_grp->g->engs_num);return bmap;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 296/846 regulator: qcom-labibb: OCP interrupts are not a failure while disabled
In reply to Greg Kroah-HartmanFrom: Marijn Suijten <[email protected]>
[ Upstream commit d27bb69dc83f00f86a830298c967052cded6e784 ]
Receiving the Over-Current Protection interrupt while the regulator is disabled does not count as unhandled/failure (IRQ_NONE, or 0 as it were) but a "fake event", usually due to inrush as the is regulator about to be enabled.
--- drivers/regulator/qcom-labibb-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/regulator/qcom-labibb-regulator.c +1 -1
@@ -260,7 +260,7 @@ static irqreturn_t qcom_labibb_ocp_isr(int irq, void *chip)/* If the regulator is not enabled, this is a fake event */ if (!ops->is_enabled (vreg->rdev)) -return 0 ; +return IRQ_HANDLED ;/* If we tried to recover for too many times it's not getting better */ if (vreg->ocp_irq_count >LABIBB_MAX_OCP_COUNT )
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 297/846 hwmon: (mr75203) fix wrong power-up delay value
In reply to Greg Kroah-HartmanFrom: Arseny Demidov <[email protected]>
[ Upstream commit a8d6d4992ad9d92356619ac372906bd29687bb46 ]
In the file mr75203.c we have a macro named POWER_DELAY_CYCLE_256, the correct value should be 0x100. The register ip_tmr is expressed in units of IP clk cycles, in accordance with the datasheet. Typical power-up delays for Temperature Sensor are 256 cycles i.e. 0x100.
--- drivers/hwmon/mr75203.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/mr75203.c +1 -1
@@ -93,7 +93,7 @@#define VM_CH_REQ BIT(21)#define IP_TMR 0x05 -#define POWER_DELAY_CYCLE_256 0x80 +#define POWER_DELAY_CYCLE_256 0x100#define POWER_DELAY_CYCLE_64 0x40#define PVT_POLL_DELAY_US 20
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 298/846 x86/mce/inject: Avoid out-of-bounds write when setting flags
In reply to Greg Kroah-HartmanFrom: Zhang Zixun <[email protected]>
[ Upstream commit de768416b203ac84e02a757b782a32efb388476f ]
A contrived zero-length write, for example, by using write(2):
... ret = write(fd, str, 0); ...
to the "flags" file causes:
BUG: KASAN: stack-out-of-bounds in flags_write Write of size 1 at addr ffff888019be7ddf by task writefile/3787 CPU: 4 PID: 3787 Comm: writefile Not tainted 5.16.0-rc7+ #12 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-2 04/01/2014
due to accessing buf one char before its start.
Prevent such out-of-bounds access.
[ bp: Productize into a proper patch. Link below is the next best
thing because the original mail didn't get archived on lore. ]
--- arch/x86/kernel/cpu/mce/inject.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/mce/inject.c +1 -1
@@ -350,7 +350,7 @@ static ssize_t flags_write(struct file *filp, const char __user *ubuf,char buf[MAX_FLAG_OPT_SIZE ], *__buf;int err; -if (cnt >MAX_FLAG_OPT_SIZE ) +if (!cnt || cnt >MAX_FLAG_OPT_SIZE )return -EINVAL ;if (copy_from_user (&buf, ubuf, cnt))
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 299/846 io_uring: remove double poll on poll update
In reply to Greg Kroah-HartmanFrom: Pavel Begunkov <[email protected]>
[ Upstream commit e840b4baf3cfb37e2ead4f649a45bb78178677ff ]
Before updating a poll request we should remove it from poll queues, including the double poll entry.
--- fs/io_uring.c | 1 + 1 file changed, 1 insertion(+)
fs/io_uring.c +1 -0
@@ -5925,6 +5925,7 @@ static int io_poll_update(struct io_kiocb *req, unsigned int issue_flags)* update those. For multishot, if we're racing with completion, just * let completion re-add it. */ +io_poll_remove_double (preq); completing = !__io_poll_remove_one (preq, &preq->poll, false);if (completing && (preq->poll.events &EPOLLONESHOT )) { ret = -EALREADY ;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 300/846 serial: 8250_bcm7271: Propagate error codes from brcmuart_probe()
In reply to Greg Kroah-HartmanFrom: Lad Prabhakar <[email protected]>
[ Upstream commit c195438f1e84de8fa46b4f5264d12379bee6e9a1 ]
In case of failures brcmuart_probe() always returned -ENODEV, this isn't correct for example platform_get_irq_byname() may return -EPROBE_DEFER to handle such cases propagate error codes in brcmuart_probe() in case of failures.
--- drivers/tty/serial/8250/8250_bcm7271.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
drivers/tty/serial/8250/8250_bcm7271.c +8 -3
@@ -1076,14 +1076,18 @@ static int brcmuart_probe(struct platform_device *pdev) priv->rx_bufs =dma_alloc_coherent (dev, priv->rx_size, &priv->rx_addr,GFP_KERNEL ); -if (!priv->rx_bufs) +if (!priv->rx_bufs) { + ret = -EINVAL ; goto err; + } priv->tx_size =UART_XMIT_SIZE ; priv->tx_buf =dma_alloc_coherent (dev, priv->tx_size, &priv->tx_addr,GFP_KERNEL ); -if (!priv->tx_buf) +if (!priv->tx_buf) { + ret = -EINVAL ; goto err; + } } ret =serial8250_register_8250_port (&up);
@@ -1097,6 +1101,7 @@ static int brcmuart_probe(struct platform_device *pdev)if (priv->dma_enabled) { dma_irq =platform_get_irq_byname (pdev,"dma" );if (dma_irq <0 ) { + ret = dma_irq;dev_err (dev,"no IRQ resource info\n" ); goto err1; }
@@ -1116,7 +1121,7 @@ err1: err:brcmuart_free_bufs (dev, priv);brcmuart_arbitration (priv,0 ); -return -ENODEV ; +return ret; }static int brcmuart_remove (struct platform_device *pdev)
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 301/846 ACPI: scan: Create platform device for BCM4752 and LNV4752 ACPI nodes
In reply to Greg Kroah-HartmanFrom: Hans de Goede <[email protected]>
[ Upstream commit f85196bdd5a50da74670250564740fc852b3c239 ]
BCM4752 and LNV4752 ACPI nodes describe a Broadcom 4752 GPS module attached to an UART of the system.
The GPS modules talk a custom protocol which only works with a closed- source Android gpsd daemon which knows this protocol.
The ACPI nodes also describe GPIOs to turn the GPS on/off these are handled by the net/rfkill/rfkill-gpio.c code. This handling predates the addition of enumeration of ACPI instantiated serdevs to the kernel and was broken by that addition, because the ACPI scan code now no longer instantiates platform_device-s for these nodes.
Rename the i2c_multi_instantiate_ids HID list to ignore_serial_bus_ids and add the BCM4752 and LNV4752 HIDs, so that rfkill-gpio gets a platform_device to bind to again; and so that a tty cdev for gpsd gets created for these.
--- drivers/acpi/scan.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
drivers/acpi/scan.c +10 -3
@@ -1690,6 +1690,7 @@ static bool acpi_device_enumeration_by_parent(struct acpi_device *device) {struct list_head resource_list;bool is_serial_bus_slave = false; +static const struct acpi_device_id ignore_serial_bus_ids[] = {/* * These devices have multiple I2cSerialBus resources and an i2c-client * must be instantiated for each, each with its own i2c_device_id.
@@ -1698,11 +1699,18 @@ static bool acpi_device_enumeration_by_parent(struct acpi_device *device)* drivers/platform/x86/i2c-multi-instantiate.c driver, which knows * which i2c_device_id to use for each resource. */ -static const struct acpi_device_id i2c_multi_instantiate_ids[] = { {"BSG1160", }, {"BSG2150", }, {"INT33FE", }, {"INT3515", }, + /* + * HIDs of device with an UartSerialBusV2 resource for which userspace + * expects a regular tty cdev to be created (instead of the in kernel + * serdev) and which have a kernel driver which expects a platform_dev + * such as the rfkill-gpio driver. + */ + {"BCM4752", }, + {"LNV4752", }, {} };
@@ -1716,8 +1724,7 @@ static bool acpi_device_enumeration_by_parent(struct acpi_device *device) fwnode_property_present(&device->fwnode, "baud")))return true; -/* Instantiate a pdev for the i2c-multi-instantiate drv to bind to */ -if (!acpi_match_device_ids (device, i2c_multi_instantiate_ids)) +if (!acpi_match_device_ids (device, ignore_serial_bus_ids))return false;INIT_LIST_HEAD (&resource_list);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 302/846 pcmcia: rsrc_nonstatic: Fix a NULL pointer dereference in __nonstatic_find_io_region()
In reply to Greg Kroah-HartmanFrom: Zhou Qingyang <[email protected]>
[ Upstream commit ca0fe0d7c35c97528bdf621fdca75f13157c27af ]
In __nonstatic_find_io_region(), pcmcia_make_resource() is assigned to res and used in pci_bus_alloc_resource(). There is a dereference of res in pci_bus_alloc_resource(), which could lead to a NULL pointer dereference on failure of pcmcia_make_resource().
Fix this bug by adding a check of res.
This bug was found by a static analyzer. The analysis employs differential checking to identify inconsistent security operations (e.g., checks or kfrees) between two code paths and confirms that the inconsistent operations are not recovered in the current function or the callers, so they constitute bugs.
Note that, as a bug found by static analysis, it can be a false positive or hard to trigger. Multiple researchers have cross-reviewed the bug.
Builds with CONFIG_PCCARD_NONSTATIC=y show no new warnings, and our static analyzer no longer warns about this code.
--- drivers/pcmcia/rsrc_nonstatic.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/pcmcia/rsrc_nonstatic.c +3 -0
@@ -690,6 +690,9 @@ static struct resource *__nonstatic_find_io_region(struct pcmcia_socket *s,unsigned long min = base;int ret; +if (!res) +return NULL ; + data.mask = align -1 ; data.offset = base & data.mask; data.map = &s_data->io_db;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 303/846 pcmcia: rsrc_nonstatic: Fix a NULL pointer dereference in nonstatic_find_mem_region()
In reply to Greg Kroah-HartmanFrom: Zhou Qingyang <[email protected]>
[ Upstream commit 977d2e7c63c3d04d07ba340b39987742e3241554 ]
In nonstatic_find_mem_region(), pcmcia_make_resource() is assigned to res and used in pci_bus_alloc_resource(). There a dereference of res in pci_bus_alloc_resource(), which could lead to a NULL pointer dereference on failure of pcmcia_make_resource().
Fix this bug by adding a check of res.
This bug was found by a static analyzer. The analysis employs differential checking to identify inconsistent security operations (e.g., checks or kfrees) between two code paths and confirms that the inconsistent operations are not recovered in the current function or the callers, so they constitute bugs.
Note that, as a bug found by static analysis, it can be a false positive or hard to trigger. Multiple researchers have cross-reviewed the bug.
Builds with CONFIG_PCCARD_NONSTATIC=y show no new warnings, and our static analyzer no longer warns about this code.
--- drivers/pcmcia/rsrc_nonstatic.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/pcmcia/rsrc_nonstatic.c +3 -0
@@ -812,6 +812,9 @@ static struct resource *nonstatic_find_mem_region(u_long base, u_long num,unsigned long min, max;int ret, i, j; +if (!res) +return NULL ; + low = low || !(s->features &SS_CAP_PAGE_REGS ); data.mask = align -1 ;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 304/846 power: reset: mt6397: Check for null res pointer
In reply to Greg Kroah-HartmanFrom: Jiasheng Jiang <[email protected]>
[ Upstream commit 1c1348bf056dee665760a3bd1cd30b0be7554fc2 ]
The return value of platform_get_resource() needs to be checked. To avoid use of error pointer in case that there is no suitable resource.
--- drivers/power/reset/mt6323-poweroff.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/power/reset/mt6323-poweroff.c +3 -0
@@ -57,6 +57,9 @@ static int mt6323_pwrc_probe(struct platform_device *pdev)return -ENOMEM ; res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); +if (!res) +return -EINVAL ; + pwrc->base = res->start; pwrc->regmap = mt6397_chip->regmap; pwrc->dev = &pdev->dev;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 305/846 net/xfrm: IPsec tunnel mode fix inner_ipproto setting in sec_path
In reply to Greg Kroah-HartmanFrom: Raed Salem <[email protected]>
[ Upstream commit 45a98ef4922def8c679ca7c454403d1957fe70e7 ]
The inner_ipproto saves the inner IP protocol of the plain text packet. This allows vendor's IPsec feature making offload decision at skb's features_check and configuring hardware at ndo_start_xmit, current code implenetation did not handle the case where IPsec is used in tunnel mode.
Fix by handling the case when IPsec is used in tunnel mode by reading the protocol of the plain text packet IP protocol.
--- net/xfrm/xfrm_output.c | 30 +++++++++++++++++++++++++----- 1 file changed, 25 insertions(+), 5 deletions(-)
net/xfrm/xfrm_output.c +25 -5
@@ -647,10 +647,12 @@ static int xfrm_output_gso(struct net *net, struct sock *sk, struct sk_buff *skb* This requires hardware to know the inner packet type to calculate * the inner header checksum. Save inner ip protocol here to avoid * traversing the packet in the vendor's xmit code. -* If the encap type is IPIP, just save skb->inner_ipproto. Otherwise, -* get the ip protocol from the IP header. +* For IPsec tunnel mode save the ip protocol from the IP header of the +* plain text packet. Otherwise If the encap type is IPIP, just save +* skb->inner_ipproto in any other case get the ip protocol from the IP +* header. */ -static void xfrm_get_inner_ipproto (struct sk_buff *skb) +static void xfrm_get_inner_ipproto (struct sk_buff *skb,struct xfrm_state *x) {struct xfrm_offload *xo =xfrm_offload (skb);const struct ethhdr *eth;
@@ -658,6 +660,25 @@ static void xfrm_get_inner_ipproto(struct sk_buff *skb)if (!xo)return ; +if (x->outer_mode.encap ==XFRM_MODE_TUNNEL ) { +switch (x->outer_mode.family) { +case AF_INET : + xo->inner_ipproto =ip_hdr (skb)->protocol; +break ; +case AF_INET6 : + xo->inner_ipproto =ipv6_hdr (skb)->nexthdr; +break ; +default : +break ; + } + +return ; + } + +/* non-Tunnel Mode */ +if (!skb->encapsulation) +return ; +if (skb->inner_protocol_type ==ENCAP_TYPE_IPPROTO ) { xo->inner_ipproto = skb->inner_ipproto;return ;
@@ -712,8 +733,7 @@ int xfrm_output(struct sock *sk, struct sk_buff *skb) sp->xvec[sp->len++] = x;xfrm_state_hold (x); -if (skb->encapsulation) -xfrm_get_inner_ipproto (skb); +xfrm_get_inner_ipproto (skb, x); skb->encapsulation =1 ;if (skb_is_gso (skb)) {
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 306/846 net: ethernet: mtk_eth_soc: fix return values and refactor MDIO ops
In reply to Greg Kroah-HartmanFrom: Daniel Golle <[email protected]>
[ Upstream commit eda80b249df7bbc7b3dd13907343a3e59bfc57fd ]
Instead of returning -1 (-EPERM) when MDIO bus is stuck busy while writing or 0xffff if it happens while reading, return the appropriate -ETIMEDOUT. Also fix return type to int instead of u32. Refactor functions to use bitfield helpers instead of having various masking and shifting constants in the code, which also results in the register definitions in the header file being more obviously related to what is stated in the MediaTek's Reference Manual.
--- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 53 ++++++++++++--------- drivers/net/ethernet/mediatek/mtk_eth_soc.h | 16 +++++-- 2 files changed, 41 insertions(+), 28 deletions(-)
drivers/net/ethernet/mediatek/mtk_eth_soc.c +30 -23
@@ -91,46 +91,53 @@ static int mtk_mdio_busy_wait(struct mtk_eth *eth) }dev_err (eth->dev,"mdio: MDIO timeout\n" ); -return -1 ; +return -ETIMEDOUT ; } -static u32 _mtk_mdio_write (struct mtk_eth *eth,u32 phy_addr, -u32 phy_register,u32 write_data) +static int _mtk_mdio_write (struct mtk_eth *eth,u32 phy_addr,u32 phy_reg, +u32 write_data) { -if (mtk_mdio_busy_wait (eth)) -return -1 ; +int ret; - write_data &=0xffff ; + ret =mtk_mdio_busy_wait (eth); +if (ret <0 ) +return ret; -mtk_w32 (eth,PHY_IAC_ACCESS |PHY_IAC_START |PHY_IAC_WRITE | - (phy_register <<PHY_IAC_REG_SHIFT ) | - (phy_addr <<PHY_IAC_ADDR_SHIFT ) | write_data, +mtk_w32 (eth,PHY_IAC_ACCESS | +PHY_IAC_START_C22 | +PHY_IAC_CMD_WRITE | +PHY_IAC_REG (phy_reg) | +PHY_IAC_ADDR (phy_addr) | +PHY_IAC_DATA (write_data),MTK_PHY_IAC ); -if (mtk_mdio_busy_wait (eth)) -return -1 ; + ret =mtk_mdio_busy_wait (eth); +if (ret <0 ) +return ret;return 0 ; } -static u32 _mtk_mdio_read (struct mtk_eth *eth,int phy_addr,int phy_reg) +static int _mtk_mdio_read (struct mtk_eth *eth,u32 phy_addr,u32 phy_reg) { -u32 d; +int ret; -if (mtk_mdio_busy_wait (eth)) -return 0xffff ; + ret =mtk_mdio_busy_wait (eth); +if (ret <0 ) +return ret; -mtk_w32 (eth,PHY_IAC_ACCESS |PHY_IAC_START |PHY_IAC_READ | - (phy_reg <<PHY_IAC_REG_SHIFT ) | - (phy_addr <<PHY_IAC_ADDR_SHIFT ), +mtk_w32 (eth,PHY_IAC_ACCESS | +PHY_IAC_START_C22 | +PHY_IAC_CMD_C22_READ | +PHY_IAC_REG (phy_reg) | +PHY_IAC_ADDR (phy_addr),MTK_PHY_IAC ); -if (mtk_mdio_busy_wait (eth)) -return 0xffff ; - - d =mtk_r32 (eth,MTK_PHY_IAC ) &0xffff ; + ret =mtk_mdio_busy_wait (eth); +if (ret <0 ) +return ret; -return d; +return mtk_r32 (eth,MTK_PHY_IAC ) &PHY_IAC_DATA_MASK ; } static int mtk_mdio_write(struct mii_bus *bus, int phy_addr,
drivers/net/ethernet/mediatek/mtk_eth_soc.h +11 -5
@@ -341,11 +341,17 @@/* PHY Indirect Access Control registers */ #define MTK_PHY_IAC 0x10004#define PHY_IAC_ACCESS BIT(31) -#define PHY_IAC_READ BIT(19) -#define PHY_IAC_WRITE BIT(18) -#define PHY_IAC_START BIT(16) -#define PHY_IAC_ADDR_SHIFT 20 -#define PHY_IAC_REG_SHIFT 25 +#define PHY_IAC_REG_MASK GENMASK(29, 25) +#define PHY_IAC_REG (x) FIELD_PREP(PHY_IAC_REG_MASK, (x)) +#define PHY_IAC_ADDR_MASK GENMASK(24, 20) +#define PHY_IAC_ADDR (x) FIELD_PREP(PHY_IAC_ADDR_MASK, (x)) +#define PHY_IAC_CMD_MASK GENMASK(19, 18) +#define PHY_IAC_CMD_WRITE FIELD_PREP(PHY_IAC_CMD_MASK, 1) +#define PHY_IAC_CMD_C22_READ FIELD_PREP(PHY_IAC_CMD_MASK, 2) +#define PHY_IAC_START_MASK GENMASK(17, 16) +#define PHY_IAC_START_C22 FIELD_PREP(PHY_IAC_START_MASK, 1) +#define PHY_IAC_DATA_MASK GENMASK(15, 0) +#define PHY_IAC_DATA (x) FIELD_PREP(PHY_IAC_DATA_MASK, (x))#define PHY_IAC_TIMEOUT HZ#define MTK_MAC_MISC 0x1000c
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 307/846 net: dsa: fix incorrect function pointer check for MRP ring roles
In reply to Greg Kroah-HartmanFrom: Vladimir Oltean <[email protected]>
[ Upstream commit ff91e1b68490b97c18c649b769618815eb945f11 ]
The cross-chip notifier boilerplate code meant to check the presence of ds->ops->port_mrp_add_ring_role before calling it, but checked ds->ops->port_mrp_add instead, before calling ds->ops->port_mrp_add_ring_role.
Therefore, a driver which implements one operation but not the other would trigger a NULL pointer dereference.
There isn't any such driver in DSA yet, so there is no reason to backport the change. Issue found through code inspection.
--- net/dsa/switch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/dsa/switch.c +2 -2
@@ -644,7 +644,7 @@ static int dsa_switch_mrp_add_ring_role(struct dsa_switch *ds, struct dsa_notifier_mrp_ring_role_info *info) { -if (!ds->ops->port_mrp_add) +if (!ds->ops->port_mrp_add_ring_role)return -EOPNOTSUPP ;if (ds->index == info->sw_index)
@@ -658,7 +658,7 @@ static int dsa_switch_mrp_del_ring_role(struct dsa_switch *ds, struct dsa_notifier_mrp_ring_role_info *info) { -if (!ds->ops->port_mrp_del) +if (!ds->ops->port_mrp_del_ring_role)return -EOPNOTSUPP ;if (ds->index == info->sw_index)
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 308/846 netfilter: ipt_CLUSTERIP: fix refcount leak in clusterip_tg_check()
In reply to Greg Kroah-HartmanFrom: Xin Xiong <[email protected]>
[ Upstream commit d94a69cb2cfa77294921aae9afcfb866e723a2da ]
The issue takes place in one error path of clusterip_tg_check(). When memcmp() returns nonzero, the function simply returns the error code, forgetting to decrease the reference count of a clusterip_config object, which is bumped earlier by clusterip_config_find_get(). This may incur reference count leak.
Fix this issue by decrementing the refcount of the object in specific error path.
--- net/ipv4/netfilter/ipt_CLUSTERIP.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
net/ipv4/netfilter/ipt_CLUSTERIP.c +4 -1
@@ -520,8 +520,11 @@ static int clusterip_tg_check(const struct xt_tgchk_param *par)if (IS_ERR (config))return PTR_ERR (config); } - }else if (memcmp (&config->clustermac, &cipinfo->clustermac,ETH_ALEN )) + }else if (memcmp (&config->clustermac, &cipinfo->clustermac,ETH_ALEN )) { +clusterip_config_entry_put (config); +clusterip_config_put (config);return -EINVAL ; + } ret =nf_ct_netns_get (par->net, par->family);if (ret <0 ) {
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 309/846 bpf, sockmap: Fix return codes from tcp_bpf_recvmsg_parser()
In reply to Greg Kroah-HartmanFrom: John Fastabend <[email protected]>
[ Upstream commit 5b2c5540b8110eea0d67a78fb0ddb9654c58daeb ]
Applications can be confused slightly because we do not always return the same error code as expected, e.g. what the TCP stack normally returns. For example on a sock err sk->sk_err instead of returning the sock_error we return EAGAIN. This usually means the application will 'try again' instead of aborting immediately. Another example, when a shutdown event is received we should immediately abort instead of waiting for data when the user provides a timeout.
These tend to not be fatal, applications usually recover, but introduces bogus errors to the user or introduces unexpected latency. Before 'c5d2177a72a16' we fell back to the TCP stack when no data was available so we managed to catch many of the cases here, although with the extra latency cost of calling tcp_msg_wait_data() first.
To fix lets duplicate the error handling in TCP stack into tcp_bpf so that we get the same error codes.
These were found in our CI tests that run applications against sockmap and do longer lived testing, at least compared to test_sockmap that does short-lived ping/pong tests, and in some of our test clusters we deploy.
Its non-trivial to do these in a shorter form CI tests that would be appropriate for BPF selftests, but we are looking into it so we can ensure this keeps working going forward. As a preview one idea is to pull in the packetdrill testing which catches some of this.
--- net/ipv4/tcp_bpf.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)
net/ipv4/tcp_bpf.c +27 -0
@@ -196,12 +196,39 @@ msg_bytes_ready:long timeo;int data; +if (sock_flag (sk,SOCK_DONE )) + goto out; + +if (sk->sk_err) { + copied =sock_error (sk); + goto out; + } + +if (sk->sk_shutdown &RCV_SHUTDOWN ) + goto out; + +if (sk->sk_state ==TCP_CLOSE ) { + copied = -ENOTCONN ; + goto out; + } + timeo =sock_rcvtimeo (sk, nonblock); +if (!timeo) { + copied = -EAGAIN ; + goto out; + } + +if (signal_pending (current)) { + copied =sock_intr_errno (timeo); + goto out; + } + data =tcp_msg_wait_data (sk, psock, timeo);if (data && !sk_psock_queue_empty (psock)) goto msg_bytes_ready; copied = -EAGAIN ; } +out:release_sock (sk);sk_psock_put (sk, psock);return copied;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 310/846 bpf, sockmap: Fix double bpf_prog_put on error case in map_link
In reply to Greg Kroah-HartmanFrom: John Fastabend <[email protected]>
[ Upstream commit 218d747a4142f281a256687bb513a135c905867b ]
sock_map_link() is called to update a sockmap entry with a sk. But, if the sock_map_init_proto() call fails then we return an error to the map_update op against the sockmap. In the error path though we need to cleanup psock and dec the refcnt on any programs associated with the map, because we refcnt them early in the update process to ensure they are pinned for the psock. (This avoids a race where user deletes programs while also updating the map with new socks.)
In current code we do the prog refcnt dec explicitely by calling bpf_prog_put() when the program was found in the map. But, after commit '38207a5e81230' in this error path we've already done the prog to psock assignment so the programs have a reference from the psock as well. This then causes the psock tear down logic, invoked by sk_psock_put() in the error path, to similarly call bpf_prog_put on the programs there.
To be explicit this logic does the prog->psock assignment:
if (msg_*)
psock_set_prog(...)
Then the error path under the out_progs label does a similar check and dec with:
if (msg_*)
bpf_prog_put(...)
And the teardown logic sk_psock_put() does ...
psock_set_prog(msg_*, NULL)
... triggering another bpf_prog_put(...). Then KASAN gives us this splat, found by syzbot because we've created an inbalance between bpf_prog_inc and bpf_prog_put calling put twice on the program.
BUG: KASAN: vmalloc-out-of-bounds in __bpf_prog_put kernel/bpf/syscall.c:1812 [inline] BUG: KASAN: vmalloc-out-of-bounds in __bpf_prog_put kernel/bpf/syscall.c:1812 [inline] kernel/bpf/syscall.c:1829 BUG: KASAN: vmalloc-out-of-bounds in bpf_prog_put+0x8c/0x4f0 kernel/bpf/syscall.c:1829 kernel/bpf/syscall.c:1829 Read of size 8 at addr ffffc90000e76038 by task syz-executor020/3641
To fix clean up error path so it doesn't try to do the bpf_prog_put in the error path once progs are assigned then it relies on the normal psock tear down logic to do complete cleanup.
For completness we also cover the case whereh sk_psock_init_strp() fails, but this is not expected because it indicates an incorrect socket type and should be caught earlier.
--- net/core/sock_map.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-)
net/core/sock_map.c +13 -8
@@ -292,15 +292,23 @@ static int sock_map_link(struct bpf_map *map, struct sock *sk)if (skb_verdict)psock_set_prog (&psock->progs.skb_verdict, skb_verdict); +/* msg_* and stream_* programs references tracked in psock after this +* point. Reference dec and cleanup will occur through psock destructor +*/ ret =sock_map_init_proto (sk, psock); -if (ret <0 ) - goto out_drop; +if (ret <0 ) { +sk_psock_put (sk, psock); + goto out; + }write_lock_bh (&sk->sk_callback_lock);if (stream_parser && stream_verdict && !psock->saved_data_ready) { ret =sk_psock_init_strp (sk, psock); -if (ret) - goto out_unlock_drop; +if (ret) { +write_unlock_bh (&sk->sk_callback_lock); +sk_psock_put (sk, psock); + goto out; + }sk_psock_start_strp (sk, psock); }else if (!stream_parser && stream_verdict && !psock->saved_data_ready) {sk_psock_start_verdict (sk,psock);
@@ -309,10 +317,6 @@ static int sock_map_link(struct bpf_map *map, struct sock *sk) }write_unlock_bh (&sk->sk_callback_lock);return 0 ; -out_unlock_drop: -write_unlock_bh (&sk->sk_callback_lock); -out_drop: -sk_psock_put (sk, psock); out_progs:if (skb_verdict)bpf_prog_put (skb_verdict);
@@ -325,6 +329,7 @@ out_put_stream_parser: out_put_stream_verdict:if (stream_verdict)bpf_prog_put (stream_verdict); +out:return ret; }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 311/846 bpf: Dont promote bogus looking registers after null check.
In reply to Greg Kroah-HartmanFrom: Daniel Borkmann <[email protected]>
[ Upstream commit e60b0d12a95dcf16a63225cead4541567f5cb517 ]
If we ever get to a point again where we convert a bogus looking <ptr>_or_null typed register containing a non-zero fixed or variable offset, then lets not reset these bounds to zero since they are not and also don't promote the register to a <ptr> type, but instead leave it as <ptr>_or_null. Converting to a unknown register could be an avenue as well, but then if we run into this case it would allow to leak a kernel pointer this way.
--- kernel/bpf/verifier.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
kernel/bpf/verifier.c +6 -6
@@ -8771,15 +8771,15 @@ static void mark_ptr_or_null_reg(struct bpf_func_state *state, {if (reg_type_may_be_null (reg->type) && reg->id == id && !WARN_ON_ONCE (!reg->id)) { -/* Old offset (both fixed and variable parts) should -* have been known-zero, because we don't allow pointer -* arithmetic on pointers that might be NULL. -*/ if (WARN_ON_ONCE (reg->smin_value || reg->smax_value || !tnum_equals_const (reg->var_off,0 ) || reg->off)) { -__mark_reg_known_zero (reg); - reg->off =0 ; +/* Old offset (both fixed and variable parts) should +* have been known-zero, because we don't allow pointer +* arithmetic on pointers that might be NULL. If we +* see this happening, don't convert the register. +*/ +return ; }if (is_null) { reg->type =SCALAR_VALUE ;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 312/846 bpf: Fix verifier support for validation of async callbacks
In reply to Greg Kroah-HartmanFrom: Kris Van Hees <[email protected]>
[ Upstream commit a5bebc4f00dee47113eed48098c68e88b5ba70e8 ]
Commit bfc6bb74e4f1 ("bpf: Implement verifier support for validation of async callbacks.") added support for BPF_FUNC_timer_set_callback to
the __check_func_call() function. The test in __check_func_call() is flaweed because it can mis-interpret a regular BPF-to-BPF pseudo-call
as a BPF_FUNC_timer_set_callback callback call.
Consider the conditional in the code:
if (insn->code == (BPF_JMP | BPF_CALL) &&
insn->imm == BPF_FUNC_timer_set_callback) {The BPF_FUNC_timer_set_callback has value 170. This means that if you have a BPF program that contains a pseudo-call with an instruction delta of 170, this conditional will be found to be true by the verifier, and it will interpret the pseudo-call as a callback. This leads to a mess with the verification of the program because it makes the wrong assumptions about the nature of this call.
Solution: include an explicit check to ensure that insn->src_reg == 0. This ensures that calls cannot be mis-interpreted as an async callback call.
--- kernel/bpf/verifier.c | 1 + 1 file changed, 1 insertion(+)
kernel/bpf/verifier.c +1 -0
@@ -5785,6 +5785,7 @@ static int __check_func_call(struct bpf_verifier_env *env, struct bpf_insn *insn }if (insn->code == (BPF_JMP |BPF_CALL ) && + insn->src_reg ==0 && insn->imm == BPF_FUNC_timer_set_callback) {struct bpf_verifier_state *async_cb;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 313/846 bpf: Fix SO_RCVBUF/SO_SNDBUF handling in _bpf_setsockopt().
In reply to Greg Kroah-HartmanFrom: Kuniyuki Iwashima <[email protected]>
[ Upstream commit 04c350b1ae6bdb12b84009a4d0bf5ab4e621c47b ]
The commit 4057765f2dee ("sock: consistent handling of extreme SO_SNDBUF/SO_RCVBUF values") added a change to prevent underflow in setsockopt() around SO_SNDBUF/SO_RCVBUF.
This patch adds the same change to _bpf_setsockopt().
--- net/core/filter.c | 2 ++ 1 file changed, 2 insertions(+)
net/core/filter.c +2 -0
@@ -4742,12 +4742,14 @@ static int _bpf_setsockopt(struct sock *sk, int level, int optname,switch (optname) {case SO_RCVBUF : val =min_t (u32, val, sysctl_rmem_max); + val =min_t (int, val,INT_MAX /2 ); sk->sk_userlocks |=SOCK_RCVBUF_LOCK ;WRITE_ONCE (sk->sk_rcvbuf,max_t (int, val *2 ,SOCK_MIN_RCVBUF ));break ;case SO_SNDBUF : val =min_t (u32, val, sysctl_wmem_max); + val =min_t (int, val,INT_MAX /2 ); sk->sk_userlocks |=SOCK_SNDBUF_LOCK ;WRITE_ONCE (sk->sk_sndbuf,max_t (int, val *2 ,SOCK_MIN_SNDBUF ));
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 314/846 netfilter: nft_payload: do not update layer 4 checksum when mangling fragments
In reply to Greg Kroah-HartmanFrom: Pablo Neira Ayuso <[email protected]>
[ Upstream commit 4e1860a3863707e8177329c006d10f9e37e097a8 ]
IP fragments do not come with the transport header, hence skip bogus layer 4 checksum updates.
--- net/netfilter/nft_payload.c | 3 +++ 1 file changed, 3 insertions(+)
net/netfilter/nft_payload.c +3 -0
@@ -502,6 +502,9 @@ static int nft_payload_l4csum_offset(const struct nft_pktinfo *pkt, struct sk_buff *skb, unsigned int *l4csum_offset) { +if (pkt->fragoff) +return -1 ; +switch (pkt->tprot) {case IPPROTO_TCP : *l4csum_offset = offsetof(struct tcphdr , check);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 315/846 netfilter: nft_set_pipapo: allocate pcpu scratch maps on clone
In reply to Greg Kroah-HartmanFrom: Florian Westphal <[email protected]>
[ Upstream commit 23c54263efd7cb605e2f7af72717a2a951999217 ]
This is needed in case a new transaction is made that doesn't insert any new elements into an already existing set.
Else, after second 'nft -f ruleset.txt', lookups in such a set will fail because ->lookup() encounters raw_cpu_ptr(m->scratch) == NULL.
For the initial rule load, insertion of elements takes care of the allocation, but for rule reloads this isn't guaranteed: we might not have additions to the set.
--- net/netfilter/nft_set_pipapo.c | 8 ++++++++ 1 file changed, 8 insertions(+)
net/netfilter/nft_set_pipapo.c +8 -0
@@ -1290,6 +1290,11 @@ static struct nft_pipapo_match *pipapo_clone(struct nft_pipapo_match *old)if (!new->scratch_aligned) goto out_scratch;#endif +for_each_possible_cpu (i) + *per_cpu_ptr (new->scratch, i) =NULL ; + +if (pipapo_realloc_scratch (new, old->bsize_max)) + goto out_scratch_realloc;rcu_head_init (&new->rcu);
@@ -1334,6 +1339,9 @@ out_lt:kvfree (dst->lt); dst--; } +out_scratch_realloc: +for_each_possible_cpu (i) +kfree (*per_cpu_ptr (new->scratch, i));#ifdef NFT_PIPAPO_ALIGN free_percpu (new->scratch_aligned);#endif
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 316/846 net: fix SOF_TIMESTAMPING_BIND_PHC to work with multiple sockets
In reply to Greg Kroah-HartmanFrom: Miroslav Lichvar <[email protected]>
[ Upstream commit 007747a984ea5e895b7d8b056b24ebf431e1e71d ]
When multiple sockets using the SOF_TIMESTAMPING_BIND_PHC flag received a packet with a hardware timestamp (e.g. multiple PTP instances in different PTP domains using the UDPv4/v6 multicast or L2 transport), the timestamps received on some sockets were corrupted due to repeated conversion of the same timestamp (by the same or different vclocks).
Fix ptp_convert_timestamp() to not modify the shared skb timestamp and return the converted timestamp as a ktime_t instead. If the conversion fails, return 0 to not confuse the application with timestamps corresponding to an unexpected PHC.
--- drivers/ptp/ptp_vclock.c | 10 +++++----- include/linux/ptp_clock_kernel.h | 12 +++++++----- net/socket.c | 9 ++++++--- 3 files changed, 18 insertions(+), 13 deletions(-)
drivers/ptp/ptp_vclock.c +5 -5
@@ -185,8 +185,8 @@ out: }EXPORT_SYMBOL (ptp_get_vclocks_index); -void ptp_convert_timestamp (struct skb_shared_hwtstamps *hwtstamps, -int vclock_index) +ktime_t ptp_convert_timestamp (const struct skb_shared_hwtstamps *hwtstamps, +int vclock_index) {char name[PTP_CLOCK_NAME_LEN ] ="" ;struct ptp_vclock *vclock;
@@ -198,12 +198,12 @@ void ptp_convert_timestamp(struct skb_shared_hwtstamps *hwtstamps,snprintf (name,PTP_CLOCK_NAME_LEN ,"ptp%d" , vclock_index); dev =class_find_device_by_name (ptp_class, name);if (!dev) -return ; +return 0 ; ptp =dev_get_drvdata (dev);if (!ptp->is_virtual_clock) {put_device (dev); -return ; +return 0 ; } vclock =info_to_vclock (ptp->info);
@@ -215,7 +215,7 @@ void ptp_convert_timestamp(struct skb_shared_hwtstamps *hwtstamps,spin_unlock_irqrestore (&vclock->lock, flags);put_device (dev); - hwtstamps->hwtstamp = ns_to_ktime(ns); + return ns_to_ktime(ns); }EXPORT_SYMBOL (ptp_convert_timestamp);#endif
include/linux/ptp_clock_kernel.h +7 -5
@@ -351,15 +351,17 @@ int ptp_get_vclocks_index(int pclock_index, int **vclock_index);* * @hwtstamps: skb_shared_hwtstamps structure pointer * @vclock_index: phc index of ptp vclock. +* +* Returns converted timestamp, or 0 on error. */ -void ptp_convert_timestamp (struct skb_shared_hwtstamps *hwtstamps, -int vclock_index); +ktime_t ptp_convert_timestamp (const struct skb_shared_hwtstamps *hwtstamps, +int vclock_index);#else static inline int ptp_get_vclocks_index (int pclock_index,int **vclock_index) {return 0 ; } -static inline void ptp_convert_timestamp (struct skb_shared_hwtstamps *hwtstamps, -int vclock_index) -{ } +static inline ktime_t ptp_convert_timestamp (const struct skb_shared_hwtstamps *hwtstamps, +int vclock_index) +{return 0 ; }#endif
net/socket.c +6 -3
@@ -829,6 +829,7 @@ void __sock_recv_timestamp(struct msghdr *msg, struct sock *sk,int empty =1 , false_tstamp =0 ;struct skb_shared_hwtstamps *shhwtstamps =skb_hwtstamps (skb); +ktime_t hwtstamp;/* Race occurred between timestamp enabling and packet receiving. Fill in the current time for now. */
@@ -877,10 +878,12 @@ void __sock_recv_timestamp(struct msghdr *msg, struct sock *sk, (sk->sk_tsflags & SOF_TIMESTAMPING_RAW_HARDWARE) && !skb_is_swtx_tstamp(skb, false_tstamp)) {if (sk->sk_tsflags &SOF_TIMESTAMPING_BIND_PHC ) -ptp_convert_timestamp (shhwtstamps, sk->sk_bind_phc); + hwtstamp =ptp_convert_timestamp (shhwtstamps, + sk->sk_bind_phc); +else + hwtstamp = shhwtstamps->hwtstamp; -if (ktime_to_timespec64_cond (shhwtstamps->hwtstamp, - tss.ts +2 )) { +if (ktime_to_timespec64_cond (hwtstamp, tss.ts +2 )) { empty =0 ; if ((sk->sk_tsflags & SOF_TIMESTAMPING_OPT_PKTINFO) &&
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 317/846 ppp: ensure minimum packet size in ppp_write()
In reply to Greg Kroah-HartmanFrom: Eric Dumazet <[email protected]>
[ Upstream commit 44073187990d5629804ce0627525f6ea5cfef171 ]
It seems pretty clear ppp layer assumed user space would always be kind to provide enough data in their write() to a ppp device.
This patch makes sure user provides at least 2 bytes.
It adds PPP_PROTO_LEN macro that could replace in net-next many occurrences of hard-coded 2 value.
I replaced only one occurrence to ease backports to stable kernels.
The bug manifests in the following report:
BUG: KMSAN: uninit-value in ppp_send_frame+0x28d/0x27c0 drivers/net/ppp/ppp_generic.c:1740 ppp_send_frame+0x28d/0x27c0 drivers/net/ppp/ppp_generic.c:1740 __ppp_xmit_process+0x23e/0x4b0 drivers/net/ppp/ppp_generic.c:1640 ppp_xmit_process+0x1fe/0x480 drivers/net/ppp/ppp_generic.c:1661 ppp_write+0x5cb/0x5e0 drivers/net/ppp/ppp_generic.c:513 do_iter_write+0xb0c/0x1500 fs/read_write.c:853 vfs_writev fs/read_write.c:924 [inline] do_writev+0x645/0xe00 fs/read_write.c:967 __do_sys_writev fs/read_write.c:1040 [inline] __se_sys_writev fs/read_write.c:1037 [inline] __x64_sys_writev+0xe5/0x120 fs/read_write.c:1037 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x54/0xd0 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x44/0xae
Uninit was created at:
slab_post_alloc_hook mm/slab.h:524 [inline] slab_alloc_node mm/slub.c:3251 [inline] __kmalloc_node_track_caller+0xe0c/0x1510 mm/slub.c:4974 kmalloc_reserve net/core/skbuff.c:354 [inline] __alloc_skb+0x545/0xf90 net/core/skbuff.c:426 alloc_skb include/linux/skbuff.h:1126 [inline] ppp_write+0x11d/0x5e0 drivers/net/ppp/ppp_generic.c:501 do_iter_write+0xb0c/0x1500 fs/read_write.c:853 vfs_writev fs/read_write.c:924 [inline] do_writev+0x645/0xe00 fs/read_write.c:967 __do_sys_writev fs/read_write.c:1040 [inline] __se_sys_writev fs/read_write.c:1037 [inline] __x64_sys_writev+0xe5/0x120 fs/read_write.c:1037 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x54/0xd0 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x44/0xae
--- drivers/net/ppp/ppp_generic.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/net/ppp/ppp_generic.c +6 -1
@@ -69,6 +69,8 @@#define MPHDRLEN 6/* multilink protocol header length */ #define MPHDRLEN_SSN 4/* ditto with short sequence numbers */ +#define PPP_PROTO_LEN 2 +/* * An instance of /dev/ppp can be associated with either a ppp * interface unit or a ppp channel. In both cases, file->private_data
@@ -497,6 +499,9 @@ static ssize_t ppp_write(struct file *file, const char __user *buf,if (!pf)return -ENXIO ; +/* All PPP packets should start with the 2-byte protocol */ +if (count <PPP_PROTO_LEN ) +return -EINVAL ; ret = -ENOMEM ; skb =alloc_skb (count + pf->hdrlen,GFP_KERNEL );if (!skb)
@@ -1764,7 +1769,7 @@ ppp_send_frame(struct ppp *ppp, struct sk_buff *skb) } ++ppp->stats64.tx_packets; - ppp->stats64.tx_bytes += skb->len -2 ; + ppp->stats64.tx_bytes += skb->len -PPP_PROTO_LEN ;switch (proto) {case PPP_IP :
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 318/846 rocker: fix a sleeping in atomic bug
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
[ Upstream commit 43d012123122cc69feacab55b71369f386c19566 ]
This code is holding the &ofdpa->flow_tbl_lock spinlock so it is not allowed to sleep. That means we have to pass the OFDPA_OP_FLAG_NOWAIT flag to ofdpa_flow_tbl_del().
--- drivers/net/ethernet/rocker/rocker_ofdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ethernet/rocker/rocker_ofdpa.c +2 -1
@@ -2783,7 +2783,8 @@ static void ofdpa_fib4_abort(struct rocker *rocker)if (!ofdpa_port)continue ; nh->fib_nh_flags &= ~RTNH_F_OFFLOAD ; -ofdpa_flow_tbl_del (ofdpa_port,OFDPA_OP_FLAG_REMOVE , +ofdpa_flow_tbl_del (ofdpa_port, +OFDPA_OP_FLAG_REMOVE |OFDPA_OP_FLAG_NOWAIT , flow_entry); }spin_unlock_irqrestore (&ofdpa->flow_tbl_lock, flags);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 319/846 staging: greybus: audio: Check null pointer
In reply to Greg Kroah-HartmanFrom: Jiasheng Jiang <[email protected]>
[ Upstream commit 2e81948177d769106754085c3e03534e6cc1f623 ]
As the possible alloc failure of devm_kcalloc(), it could return null pointer.
Therefore, 'strings' should be checked and return NULL if alloc fails to prevent the dereference of the NULL pointer.
Also, the caller should also deal with the return value of the gb_generate_enum_strings() and return -ENOMEM if returns NULL. Moreover, because the memory allocated with devm_kzalloc() will be freed automatically when the last reference to the device is dropped, the 'gbe' in gbaudio_tplg_create_enum_kctl() and gbaudio_tplg_create_enum_ctl() do not need to free manually. But the 'control' in gbaudio_tplg_create_widget() and gbaudio_tplg_process_kcontrols() has a specially error handle to cleanup.
So it should be better to cleanup 'control' when fails.
--- drivers/staging/greybus/audio_topology.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
drivers/staging/greybus/audio_topology.c +15 -0
@@ -147,6 +147,9 @@ static const char **gb_generate_enum_strings(struct gbaudio_module_info *gb, items =le32_to_cpu (gbenum->items); strings =devm_kcalloc (gb->dev, items,sizeof (char *),GFP_KERNEL ); +if (!strings) +return NULL ; + data = gbenum->names;for (i =0 ; i < items; i++) {
@@ -655,6 +658,8 @@ static int gbaudio_tplg_create_enum_kctl(struct gbaudio_module_info *gb,/* since count=1, and reg is dummy */ gbe->items =le32_to_cpu (gb_enum->items); gbe->texts =gb_generate_enum_strings (gb, gb_enum); +if (!gbe->texts) +return -ENOMEM ;/* debug enum info */ dev_dbg(gb->dev, "Max:%d, name_length:%d\n", gbe->items,
@@ -862,6 +867,8 @@ static int gbaudio_tplg_create_enum_ctl(struct gbaudio_module_info *gb,/* since count=1, and reg is dummy */ gbe->items =le32_to_cpu (gb_enum->items); gbe->texts =gb_generate_enum_strings (gb, gb_enum); +if (!gbe->texts) +return -ENOMEM ;/* debug enum info */ dev_dbg(gb->dev, "Max:%d, name_length:%d\n", gbe->items,
@@ -1072,6 +1079,10 @@ static int gbaudio_tplg_create_widget(struct gbaudio_module_info *module, csize +=le16_to_cpu (gbenum->names_length); control->texts = (const char *const *)gb_generate_enum_strings (module, gbenum); +if (!control->texts) { + ret = -ENOMEM ; + goto error; + } control->items =le32_to_cpu (gbenum->items); }else { csize =sizeof (struct gb_audio_control );
@@ -1181,6 +1192,10 @@ static int gbaudio_tplg_process_kcontrols(struct gbaudio_module_info *module, csize +=le16_to_cpu (gbenum->names_length); control->texts = (const char *const *)gb_generate_enum_strings (module, gbenum); +if (!control->texts) { + ret = -ENOMEM ; + goto error; + } control->items =le32_to_cpu (gbenum->items); }else { csize =sizeof (struct gb_audio_control );
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 320/846 fsl/fman: Check for null pointer after calling devm_ioremap
In reply to Greg Kroah-HartmanFrom: Jiasheng Jiang <[email protected]>
[ Upstream commit d5a73ec96cc57cf67e51b12820fc2354e7ca46f8 ]
As the possible failure of the allocation, the devm_ioremap() may return NULL pointer.
Take tgec_initialization() as an example.
If allocation fails, the params->base_addr will be NULL pointer and will be assigned to tgec->regs in tgec_config().
Then it will cause the dereference of NULL pointer in set_mac_address(), which is called by tgec_init().
Therefore, it should be better to add the sanity check after the calling of the devm_ioremap().
--- drivers/net/ethernet/freescale/fman/mac.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-)
drivers/net/ethernet/freescale/fman/mac.c +16 -5
@@ -94,14 +94,17 @@ static void mac_exception(void *handle, enum fman_mac_exceptions ex) __func__, ex); } -static void set_fman_mac_params (struct mac_device *mac_dev, -struct fman_mac_params *params) +static int set_fman_mac_params (struct mac_device *mac_dev, +struct fman_mac_params *params) {struct mac_priv_s *priv = mac_dev->priv; params->base_addr = (typeof(params->base_addr))devm_ioremap (priv->dev, mac_dev->res->start,resource_size (mac_dev->res)); +if (!params->base_addr) +return -ENOMEM ; +memcpy (¶ms->addr, mac_dev->addr,sizeof (mac_dev->addr)); params->max_speed = priv->max_speed; params->phy_if = mac_dev->phy_if;
@@ -112,6 +115,8 @@ static void set_fman_mac_params(struct mac_device *mac_dev, params->event_cb = mac_exception; params->dev_id = mac_dev; params->internal_phy_node = priv->internal_phy_node; + +return 0 ; }static int tgec_initialization (struct mac_device *mac_dev)
@@ -123,7 +128,9 @@ static int tgec_initialization(struct mac_device *mac_dev) priv = mac_dev->priv; -set_fman_mac_params (mac_dev, ¶ms); + err =set_fman_mac_params (mac_dev, ¶ms); +if (err) + goto _return; mac_dev->fman_mac =tgec_config (¶ms);if (!mac_dev->fman_mac) {
@@ -169,7 +176,9 @@ static int dtsec_initialization(struct mac_device *mac_dev) priv = mac_dev->priv; -set_fman_mac_params (mac_dev, ¶ms); + err =set_fman_mac_params (mac_dev, ¶ms); +if (err) + goto _return; mac_dev->fman_mac =dtsec_config (¶ms);if (!mac_dev->fman_mac) {
@@ -218,7 +227,9 @@ static int memac_initialization(struct mac_device *mac_dev) priv = mac_dev->priv; -set_fman_mac_params (mac_dev, ¶ms); + err =set_fman_mac_params (mac_dev, ¶ms); +if (err) + goto _return;if (priv->max_speed ==SPEED_10000 ) params.phy_if =PHY_INTERFACE_MODE_XGMII ;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 321/846 Bluetooth: hci_bcm: Check for error irq
In reply to Greg Kroah-HartmanFrom: Jiasheng Jiang <[email protected]>
[ Upstream commit b38cd3b42fba66cc538edb9cf77e07881f43f8e2 ]
For the possible failure of the platform_get_irq(), the returned irq could be error number and will finally cause the failure of the request_irq().
Consider that platform_get_irq() can now in certain cases return -EPROBE_DEFER, and the consequences of letting request_irq() effectively convert that into -EINVAL, even at probe time rather than later on. So it might be better to check just now.
--- drivers/bluetooth/hci_bcm.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/bluetooth/hci_bcm.c +6 -1
@@ -1188,7 +1188,12 @@ static int bcm_probe(struct platform_device *pdev)return -ENOMEM ; dev->dev = &pdev->dev; - dev->irq =platform_get_irq (pdev,0 ); + + ret =platform_get_irq (pdev,0 ); +if (ret <0 ) +return ret; + + dev->irq = ret;/* Initialize routing field to an unused value */ dev->pcm_int_params[0 ] =0xff ;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 322/846 Bluetooth: hci_qca: Fix NULL vs IS_ERR_OR_NULL check in qca_serdev_probe
In reply to Greg Kroah-HartmanFrom: Miaoqian Lin <[email protected]>
[ Upstream commit 6845667146a28c09b5dfc401c1ad112374087944 ]
The function devm_gpiod_get_index() return error pointers on error. Thus devm_gpiod_get_index_optional() could return NULL and error pointers. The same as devm_gpiod_get_optional() function. Using IS_ERR_OR_NULL() check to catch error pointers.
--- drivers/bluetooth/hci_qca.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/bluetooth/hci_qca.c +3 -3
@@ -2058,14 +2058,14 @@ static int qca_serdev_probe(struct serdev_device *serdev) qcadev->bt_en =devm_gpiod_get_optional (&serdev->dev,"enable" ,GPIOD_OUT_LOW ); -if (!qcadev->bt_en && data->soc_type ==QCA_WCN6750 ) { +if (IS_ERR_OR_NULL (qcadev->bt_en) && data->soc_type ==QCA_WCN6750 ) {dev_err (&serdev->dev,"failed to acquire BT_EN gpio\n" ); power_ctrl_enabled = false; } qcadev->sw_ctrl =devm_gpiod_get_optional (&serdev->dev,"swctrl" ,GPIOD_IN ); -if (!qcadev->sw_ctrl && data->soc_type ==QCA_WCN6750 ) +if (IS_ERR_OR_NULL (qcadev->sw_ctrl) && data->soc_type ==QCA_WCN6750 )dev_warn (&serdev->dev,"failed to acquire SW_CTRL gpio\n" ); qcadev->susclk =devm_clk_get_optional (&serdev->dev,NULL );
@@ -2087,7 +2087,7 @@ static int qca_serdev_probe(struct serdev_device *serdev) qcadev->bt_en =devm_gpiod_get_optional (&serdev->dev,"enable" ,GPIOD_OUT_LOW ); -if (!qcadev->bt_en) { +if (IS_ERR_OR_NULL (qcadev->bt_en)) {dev_warn (&serdev->dev,"failed to acquire enable gpio\n" ); power_ctrl_enabled = false; }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 323/846 net/smc: Reset conn->lgr when link group registration fails
In reply to Greg Kroah-HartmanFrom: Wen Gu <[email protected]>
[ Upstream commit 36595d8ad46d9e4c41cc7c48c4405b7c3322deac ]
SMC connections might fail to be registered in a link group due to unable to find a usable link during its creation. As a result, smc_conn_create() will return a failure and most resources related to the connection won't be applied or initialized, such as conn->abort_work or conn->lnk.
If smc_conn_free() is invoked later, it will try to access the uninitialized resources related to the connection, thus causing a warning or crash.
This patch tries to fix this by resetting conn->lgr to NULL if an abnormal exit occurs in smc_lgr_register_conn(), thus avoiding the access to uninitialized resources in smc_conn_free().
Meanwhile, the new created link group should be terminated if smc connections can't be registered in it. So smc_lgr_cleanup_early() is modified to take care of link group only and invoked to terminate unusable link group by smc_conn_create(). The call to smc_conn_free() is moved out from smc_lgr_cleanup_early() to smc_conn_abort().
--- net/smc/af_smc.c | 8 +++++--- net/smc/smc_core.c | 12 +++++++----- net/smc/smc_core.h | 2 +- 3 files changed, 13 insertions(+), 9 deletions(-)
net/smc/af_smc.c +5 -3
@@ -613,10 +613,12 @@ static int smc_connect_decline_fallback(struct smc_sock *smc, int reason_code,static void smc_conn_abort (struct smc_sock *smc,int local_first) { +struct smc_connection *conn = &smc->conn; +struct smc_link_group *lgr = conn->lgr; + +smc_conn_free (conn);if (local_first) -smc_lgr_cleanup_early (&smc->conn); -else -smc_conn_free (&smc->conn); +smc_lgr_cleanup_early (lgr); }/* check if there is a rdma device available for this connection. */
net/smc/smc_core.c +7 -5
@@ -170,8 +170,10 @@ static int smc_lgr_register_conn(struct smc_connection *conn, bool first)if (!conn->lgr->is_smcd) { rc =smcr_lgr_conn_assign_link (conn, first); -if (rc) +if (rc) { + conn->lgr =NULL ;return rc; + } }/* find a new alert_token_local value not yet used by some connection * in this link group
@@ -579,15 +581,13 @@ int smcd_nl_get_lgr(struct sk_buff *skb, struct netlink_callback *cb)return skb->len; } -void smc_lgr_cleanup_early (struct smc_connection *conn) +void smc_lgr_cleanup_early (struct smc_link_group *lgr) { -struct smc_link_group *lgr = conn->lgr;spinlock_t *lgr_lock;if (!lgr)return ; -smc_conn_free (conn);smc_lgr_list_head (lgr, &lgr_lock);spin_lock_bh (lgr_lock);/* do not use this link group for new connections */
@@ -1750,8 +1750,10 @@ create:write_lock_bh (&lgr->conns_lock); rc =smc_lgr_register_conn (conn, true);write_unlock_bh (&lgr->conns_lock); -if (rc) +if (rc) { +smc_lgr_cleanup_early (lgr); goto out; + } } conn->local_tx_ctrl.common.type =SMC_CDC_MSG_TYPE ; conn->local_tx_ctrl.len =SMC_WR_TX_SIZE ;
net/smc/smc_core.h +1 -1
@@ -419,7 +419,7 @@ static inline void smc_set_pci_values(struct pci_dev *pci_dev,struct smc_sock ;struct smc_clc_msg_accept_confirm ; -void smc_lgr_cleanup_early (struct smc_connection *conn); +void smc_lgr_cleanup_early (struct smc_link_group *lgr);void smc_lgr_terminate_sched (struct smc_link_group *lgr);void smcr_port_add (struct smc_ib_device *smcibdev,u8 ibport);void smcr_port_err (struct smc_ib_device *smcibdev,u8 ibport);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 324/846 usb: dwc3: qcom: Fix NULL vs IS_ERR checking in dwc3_qcom_probe
In reply to Greg Kroah-HartmanFrom: Miaoqian Lin <[email protected]>
[ Upstream commit b52fe2dbb3e655eb1483000adfab68a219549e13 ]
Since the acpi_create_platform_device() function may return error pointers, dwc3_qcom_create_urs_usb_platdev() function may return error pointers too. Using IS_ERR_OR_NULL() to check the return value to fix this.
--- drivers/usb/dwc3/dwc3-qcom.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/usb/dwc3/dwc3-qcom.c +5 -2
@@ -769,9 +769,12 @@ static int dwc3_qcom_probe(struct platform_device *pdev)if (qcom->acpi_pdata->is_urs) { qcom->urs_usb =dwc3_qcom_create_urs_usb_platdev (dev); -if (!qcom->urs_usb) { +if (IS_ERR_OR_NULL (qcom->urs_usb)) {dev_err (dev,"failed to create URS USB platdev\n" ); -return -ENODEV ; +if (!qcom->urs_usb) +return -ENODEV ; +else +return PTR_ERR (qcom->urs_usb); } } }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 325/846 usb: dwc2: do not gate off the hardware if it does not support clock gating
In reply to Greg Kroah-HartmanFrom: Dinh Nguyen <[email protected]>
[ Upstream commit 34146c68083f1aef6709196b3dc888c1ceffd357 ]
We should not be clearing the HCD_FLAG_HW_ACCESSIBLE bit if the hardware does not support clock gating.
--- drivers/usb/dwc2/hcd.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/usb/dwc2/hcd.c +4 -3
@@ -4403,11 +4403,12 @@ static int _dwc2_hcd_suspend(struct usb_hcd *hcd)* If not hibernation nor partial power down are supported, * clock gating is used to save power. */ -if (!hsotg->params.no_clock_gating) +if (!hsotg->params.no_clock_gating) {dwc2_host_enter_clock_gating (hsotg); -/* After entering suspend, hardware is not accessible */ -clear_bit (HCD_FLAG_HW_ACCESSIBLE , &hcd->flags); +/* After entering suspend, hardware is not accessible */ +clear_bit (HCD_FLAG_HW_ACCESSIBLE , &hcd->flags); + }break ;default : goto skip_power_saving;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 326/846 usb: dwc2: gadget: initialize max_speed from params
In reply to Greg Kroah-HartmanFrom: John Keeping <[email protected]>
[ Upstream commit 92ef98a4caacad6d4a1490dda45d81ae5ccf5bc9 ]
DWC2 may be paired with a full-speed PHY which is not capable of high-speed operation. Report this correctly to the gadget core by setting max_speed from the core parameters.
Prior to commit 5324bad66f09f ("usb: dwc2: gadget: implement udc_set_speed()") this didn't cause the hardware to be configured incorrectly, although the speed may have been reported incorrectly. But after that commit params.speed is updated based on a value passed in by the gadget core which may set it to a faster speed than is supported by the hardware. Initialising the max_speed parameter ensures the speed passed to dwc2_gadget_set_speed() will be one supported by the hardware.
--- drivers/usb/dwc2/gadget.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
drivers/usb/dwc2/gadget.c +12 -1
@@ -4974,7 +4974,18 @@ int dwc2_gadget_init(struct dwc2_hsotg *hsotg) hsotg->params.g_np_tx_fifo_size);dev_dbg (dev,"RXFIFO size: %d\n" , hsotg->params.g_rx_fifo_size); - hsotg->gadget.max_speed =USB_SPEED_HIGH ; +switch (hsotg->params.speed) { +case DWC2_SPEED_PARAM_LOW : + hsotg->gadget.max_speed =USB_SPEED_LOW ; +break ; +case DWC2_SPEED_PARAM_FULL : + hsotg->gadget.max_speed =USB_SPEED_FULL ; +break ; +default : + hsotg->gadget.max_speed =USB_SPEED_HIGH ; +break ; + } + hsotg->gadget.ops = &dwc2_hsotg_gadget_ops; hsotg->gadget.name =dev_name (dev); hsotg->remote_wakeup_allowed =0 ;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 327/846 usb: gadget: u_audio: Subdevice 0 for capture ctls
In reply to Greg Kroah-HartmanFrom: Pavel Hofman <[email protected]>
[ Upstream commit 601a5bc1aeef772ab1f47582fd322957799f5ab5 ]
Both capture and playback alsa devices use subdevice 0. Yet capture-side ctls are defined for subdevice 1. The patch sets subdevice 0 for them.
--- drivers/usb/gadget/function/u_audio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/gadget/function/u_audio.c +2 -2
@@ -1097,7 +1097,7 @@ int g_audio_setup(struct g_audio *g_audio, const char *pcm_name, } kctl->id.device = pcm->device; - kctl->id.subdevice = i; + kctl->id.subdevice =0 ; err =snd_ctl_add (card, kctl);if (err <0 )
@@ -1120,7 +1120,7 @@ int g_audio_setup(struct g_audio *g_audio, const char *pcm_name, } kctl->id.device = pcm->device; - kctl->id.subdevice = i; + kctl->id.subdevice =0 ; kctl->tlv.c = u_audio_volume_tlv;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 328/846 HID: hid-uclogic-params: Invalid parameter check in uclogic_params_init
In reply to Greg Kroah-HartmanFrom: José Expósito <[email protected]>
[ Upstream commit f364c571a5c77e96de2d32062ff019d6b8d2e2bc ]
The function performs a check on its input parameters, however, the hdev parameter is used before the check.
Initialize the stack variables after checking the input parameters to avoid a possible NULL pointer dereference.
Addresses-Coverity-ID: 1443831 ("Null pointer dereference")
--- drivers/hid/hid-uclogic-params.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)
drivers/hid/hid-uclogic-params.c +9 -4
@@ -834,10 +834,10 @@ int uclogic_params_init(struct uclogic_params *params, struct hid_device *hdev) {int rc; -struct usb_device *udev =hid_to_usb_dev (hdev); -__u8 bNumInterfaces = udev->config->desc.bNumInterfaces; -struct usb_interface *iface =to_usb_interface (hdev->dev.parent); -__u8 bInterfaceNumber = iface->cur_altsetting->desc.bInterfaceNumber; +struct usb_device *udev; +__u8 bNumInterfaces; +struct usb_interface *iface; +__u8 bInterfaceNumber;bool found;/* The resulting parameters (noop) */ struct uclogic_params p = {0 , };
@@ -848,6 +848,11 @@ int uclogic_params_init(struct uclogic_params *params, goto cleanup; } + udev =hid_to_usb_dev (hdev); + bNumInterfaces = udev->config->desc.bNumInterfaces; + iface =to_usb_interface (hdev->dev.parent); + bInterfaceNumber = iface->cur_altsetting->desc.bInterfaceNumber; +/* * Set replacement report descriptor if the original matches the * specified size. Otherwise keep interface unchanged.
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 329/846 HID: hid-uclogic-params: Invalid parameter check in uclogic_params_get_str_desc
In reply to Greg Kroah-HartmanFrom: José Expósito <[email protected]>
[ Upstream commit 0a94131d6920916ccb6a357037c535533af08819 ]
The function performs a check on the hdev input parameters, however, it is used before the check.
Initialize the udev variable after the sanity check to avoid a possible NULL pointer dereference.
Addresses-Coverity-ID: 1443827 ("Null pointer dereference")
--- drivers/hid/hid-uclogic-params.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/hid/hid-uclogic-params.c +3 -1
@@ -66,7 +66,7 @@ static int uclogic_params_get_str_desc(__u8 **pbuf, struct hid_device *hdev, __u8 idx, size_t len) {int rc; -struct usb_device *udev =hid_to_usb_dev (hdev); +struct usb_device *udev;__u8 *buf =NULL ;/* Check arguments */
@@ -75,6 +75,8 @@ static int uclogic_params_get_str_desc(__u8 **pbuf, struct hid_device *hdev, goto cleanup; } + udev =hid_to_usb_dev (hdev); + buf =kmalloc (len,GFP_KERNEL );if (buf ==NULL ) { rc = -ENOMEM ;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 330/846 HID: hid-uclogic-params: Invalid parameter check in uclogic_params_huion_init
In reply to Greg Kroah-HartmanFrom: José Expósito <[email protected]>
[ Upstream commit ff6b548afe4d9d1ff3a0f6ef79e8cbca25d8f905 ]
The function performs a check on its input parameters, however, the hdev parameter is used before the check.
Initialize the stack variables after checking the input parameters to avoid a possible NULL pointer dereference.
Addresses-Coverity-ID: 1443804 ("Null pointer dereference")
--- drivers/hid/hid-uclogic-params.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/hid/hid-uclogic-params.c +7 -3
@@ -709,9 +709,9 @@ static int uclogic_params_huion_init(struct uclogic_params *params, struct hid_device *hdev) {int rc; -struct usb_device *udev =hid_to_usb_dev (hdev); -struct usb_interface *iface =to_usb_interface (hdev->dev.parent); -__u8 bInterfaceNumber = iface->cur_altsetting->desc.bInterfaceNumber; +struct usb_device *udev; +struct usb_interface *iface; +__u8 bInterfaceNumber;bool found;/* The resulting parameters (noop) */ struct uclogic_params p = {0 , };
@@ -725,6 +725,10 @@ static int uclogic_params_huion_init(struct uclogic_params *params, goto cleanup; } + udev =hid_to_usb_dev (hdev); + iface =to_usb_interface (hdev->dev.parent); + bInterfaceNumber = iface->cur_altsetting->desc.bInterfaceNumber; +/* If it's not a pen interface */ if (bInterfaceNumber !=0 ) {/* TODO: Consider marking the interface invalid */
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 331/846 HID: hid-uclogic-params: Invalid parameter check in uclogic_params_frame_init_v1_buttonpad
In reply to Greg Kroah-HartmanFrom: José Expósito <[email protected]>
[ Upstream commit aa320fdbbbb482c19100f51461bd0069753ce3d7 ]
The function performs a check on the hdev input parameters, however, it is used before the check.
Initialize the udev variable after the sanity check to avoid a possible NULL pointer dereference.
Addresses-Coverity-ID: 1443763 ("Null pointer dereference")
--- drivers/hid/hid-uclogic-params.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/hid/hid-uclogic-params.c +3 -1
@@ -452,7 +452,7 @@ static int uclogic_params_frame_init_v1_buttonpad( {int rc;bool found = false; -struct usb_device *usb_dev =hid_to_usb_dev (hdev); +struct usb_device *usb_dev;char *str_buf =NULL ;const size_t str_len =16 ;
@@ -462,6 +462,8 @@ static int uclogic_params_frame_init_v1_buttonpad( goto cleanup; } + usb_dev =hid_to_usb_dev (hdev); +/* * Enable generic button mode */
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 332/846 debugfs: lockdown: Allow reading debugfs files that are not world readable
In reply to Greg Kroah-HartmanFrom: Michal Suchanek <[email protected]>
[ Upstream commit 358fcf5ddbec4e6706405847d6a666f5933a6c25 ]
When the kernel is locked down the kernel allows reading only debugfs files with mode 444. Mode 400 is also valid but is not allowed.
Make the 444 into a mask.
--- fs/debugfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/debugfs/file.c +1 -1
@@ -147,7 +147,7 @@ static int debugfs_locked_down(struct inode *inode, struct file *filp, const struct file_operations *real_fops) { - if ((inode->i_mode & 07777) == 0444 && + if ((inode->i_mode & 07777 & ~0444) == 0 && !(filp->f_mode & FMODE_WRITE) && !real_fops->unlocked_ioctl && !real_fops->compat_ioctl &&
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 333/846 drivers/firmware: Add missing platform_device_put() in sysfb_create_simplefb
In reply to Greg Kroah-HartmanFrom: Miaoqian Lin <[email protected]>
[ Upstream commit 0589e8889dce8e0f0ea5bbf757f38865e2a469c1 ]
Add the missing platform_device_put() before return from sysfb_create_simplefb() in the error handling case.
--- drivers/firmware/sysfb_simplefb.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/firmware/sysfb_simplefb.c +6 -2
@@ -113,12 +113,16 @@ __init int sysfb_create_simplefb(const struct screen_info *si,sysfb_apply_efi_quirks (pd); ret =platform_device_add_resources (pd, &res,1 ); -if (ret) +if (ret) { +platform_device_put (pd);return ret; + } ret =platform_device_add_data (pd, mode,sizeof (*mode)); -if (ret) +if (ret) { +platform_device_put (pd);return ret; + }return platform_device_add (pd); }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 334/846 serial: liteuart: fix MODULE_ALIAS
In reply to Greg Kroah-HartmanFrom: Alyssa Ross <[email protected]>
[ Upstream commit 556172fabd226ba14b70c1740d0826a4717473dc ]
modprobe can't handle spaces in aliases.
--- drivers/tty/serial/liteuart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/liteuart.c +1 -1
@@ -436,4 +436,4 @@ module_exit(liteuart_exit);MODULE_AUTHOR ("Antmicro <www.antmicro.com>" );MODULE_DESCRIPTION ("LiteUART serial driver" );MODULE_LICENSE ("GPL v2" ); -MODULE_ALIAS ("platform: liteuart" ); +MODULE_ALIAS ("platform:liteuart" );
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 335/846 serial: stm32: move tx dma terminate DMA to shutdown
In reply to Greg Kroah-HartmanFrom: Valentin Caron <[email protected]>
[ Upstream commit 56a23f9319e86e1d62a109896e2c7e52c414e67d ]
Terminate DMA transaction and clear CR3_DMAT when shutdown is requested, instead of when remove is requested. If DMA transfer is not stopped in shutdown ops, driver will fail to start a new DMA transfer after next startup ops.
--- drivers/tty/serial/stm32-usart.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/tty/serial/stm32-usart.c +5 -1
@@ -691,6 +691,11 @@ static void stm32_usart_shutdown(struct uart_port *port)u32 val, isr;int ret; +if (stm32_port->tx_dma_busy) { +dmaengine_terminate_async (stm32_port->tx_ch); +stm32_usart_clr_bits (port, ofs->cr3,USART_CR3_DMAT ); + } +/* Disable modem control interrupts */ stm32_usart_disable_ms (port);
@@ -1385,7 +1390,6 @@ static int stm32_usart_serial_remove(struct platform_device *pdev)stm32_usart_clr_bits (port, ofs->cr3,USART_CR3_DMAR );if (stm32_port->tx_ch) { -dmaengine_terminate_async (stm32_port->tx_ch);stm32_usart_of_dma_tx_remove (stm32_port, pdev);dma_release_channel (stm32_port->tx_ch); }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 336/846 x86, sched: Fix undefined reference to init_freq_invariance_cppc() build error
In reply to Greg Kroah-HartmanFrom: Huang Rui <[email protected]>
[ Upstream commit 6c4ab1b86dac3954d15c00c1a6396d60a1023fab ]
The init_freq_invariance_cppc function is implemented in smpboot and depends on CONFIG_SMP.
MODPOST vmlinux.symvers
MODINFO modules.builtin.modinfo
GEN modules.builtin
LD .tmp_vmlinux.kallsyms1
ld: drivers/acpi/cppc_acpi.o: in function `acpi_cppc_processor_probe':/home/ray/brahma3/linux/drivers/acpi/cppc_acpi.c:819: undefined reference to `init_freq_invariance_cppc'
make: *** [Makefile:1161: vmlinux] Error 1
See https://lore.kernel.org/lkml/[email protected]/.
--- arch/x86/include/asm/topology.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/include/asm/topology.h +1 -1
@@ -218,7 +218,7 @@ static inline void arch_set_max_freq_ratio(bool turbo_disabled) }#endif -#ifdef CONFIG_ACPI_CPPC_LIB +#if defined(CONFIG_ACPI_CPPC_LIB ) && defined(CONFIG_SMP )void init_freq_invariance_cppc (void );#define init_freq_invariance_cppc init_freq_invariance_cppc#endif
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 337/846 net/mlx5e: Fix page DMA map/unmap attributes
In reply to Greg Kroah-HartmanFrom: Aya Levin <[email protected]>
[ Upstream commit 0b7cfa4082fbf550595bc0e40f05614bd83bf0cd ]
Driver initiates DMA sync, hence it may skip CPU sync. Add DMA_ATTR_SKIP_CPU_SYNC as input attribute both to dma_map_page and dma_unmap_page to avoid redundant sync with the CPU.
When forcing the device to work with SWIOTLB, the extra sync might cause data corruption. The driver unmaps the whole page while the hardware used just a part of the bounce buffer. So syncing overrides the entire page with bounce buffer that only partially contains real data.
--- drivers/net/ethernet/mellanox/mlx5/core/en/xsk/pool.c | 4 ++-- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 7 ++++--- 2 files changed, 6 insertions(+), 5 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/pool.c +2 -2
@@ -11,13 +11,13 @@ static int mlx5e_xsk_map_pool(struct mlx5e_priv *priv, {struct device *dev =mlx5_core_dma_dev (priv->mdev); -return xsk_pool_dma_map (pool, dev,0 ); +return xsk_pool_dma_map (pool, dev,DMA_ATTR_SKIP_CPU_SYNC ); }static void mlx5e_xsk_unmap_pool (struct mlx5e_priv *priv,struct xsk_buff_pool *pool) { -return xsk_pool_dma_unmap (pool,0 ); +return xsk_pool_dma_unmap (pool,DMA_ATTR_SKIP_CPU_SYNC ); }static int mlx5e_xsk_get_pools (struct mlx5e_xsk *xsk)
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c +4 -3
@@ -271,8 +271,8 @@ static inline int mlx5e_page_alloc_pool(struct mlx5e_rq *rq,if (unlikely (!dma_info->page))return -ENOMEM ; - dma_info->addr =dma_map_page (rq->pdev, dma_info->page,0 , -PAGE_SIZE , rq->buff.map_dir); + dma_info->addr =dma_map_page_attrs (rq->pdev, dma_info->page,0 ,PAGE_SIZE , + rq->buff.map_dir,DMA_ATTR_SKIP_CPU_SYNC );if (unlikely (dma_mapping_error (rq->pdev, dma_info->addr))) {page_pool_recycle_direct (rq->page_pool, dma_info->page); dma_info->page =NULL ;
@@ -293,7 +293,8 @@ static inline int mlx5e_page_alloc(struct mlx5e_rq *rq,void mlx5e_page_dma_unmap (struct mlx5e_rq *rq,struct mlx5e_dma_info *dma_info) { -dma_unmap_page (rq->pdev, dma_info->addr,PAGE_SIZE , rq->buff.map_dir); +dma_unmap_page_attrs (rq->pdev, dma_info->addr,PAGE_SIZE , rq->buff.map_dir, +DMA_ATTR_SKIP_CPU_SYNC ); } void mlx5e_page_release_dynamic(struct mlx5e_rq *rq,
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 338/846 net/mlx5e: Fix wrong usage of fib_info_nh when routes with nexthop objects are used
In reply to Greg Kroah-HartmanFrom: Maor Dickman <[email protected]>
[ Upstream commit 885751eb1b01d276e38f57d78c583e4ce006c5ed ]
Creating routes with nexthop objects while in switchdev mode leads to access to un-allocated memory and trigger bellow call trace due to hitting WARN_ON. This is caused due to illegal usage of fib_info_nh in TC tunnel FIB event handling to resolve the FIB device while fib_info built in with nexthop.
Fixed by ignoring attempts to use nexthop objects with routes until support can be properly added.
WARNING: CPU: 1 PID: 1724 at include/net/nexthop.h:468 mlx5e_tc_tun_fib_event+0x448/0x570 [mlx5_core] CPU: 1 PID: 1724 Comm: ip Not tainted 5.15.0_for_upstream_min_debug_2021_11_09_02_04 #1 RIP: 0010:mlx5e_tc_tun_fib_event+0x448/0x570 [mlx5_core] RSP: 0018:ffff8881349f7910 EFLAGS: 00010202 RAX: ffff8881492f1980 RBX: ffff8881349f79e8 RCX: 0000000000000000 RDX: ffff8881349f79e8 RSI: 0000000000000000 RDI: 0000000000000000 RBP: ffff8881349f7950 R08: 00000000000000fe R09: 0000000000000001 R10: 0000000000000000 R11: 0000000000000000 R12: ffff88811e9d0000 R13: ffff88810eb62000 R14: ffff888106710268 R15: 0000000000000018 FS: 00007f1d5ca6e800(0000) GS:ffff88852c880000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007ffedba44ff8 CR3: 0000000129808004 CR4: 0000000000370ea0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: <TASK> atomic_notifier_call_chain+0x42/0x60 call_fib_notifiers+0x21/0x40 fib_table_insert+0x479/0x6d0 ? try_charge_memcg+0x480/0x6d0 inet_rtm_newroute+0x65/0xb0 rtnetlink_rcv_msg+0x2af/0x360 ? page_add_file_rmap+0x13/0x130 ? do_set_pte+0xcd/0x120 ? rtnl_calcit.isra.0+0x120/0x120 netlink_rcv_skb+0x4e/0xf0 netlink_unicast+0x1ee/0x2b0 netlink_sendmsg+0x22e/0x460 sock_sendmsg+0x33/0x40 ____sys_sendmsg+0x1d1/0x1f0 ___sys_sendmsg+0xab/0xf0 ? __mod_memcg_lruvec_state+0x40/0x60 ? __mod_lruvec_page_state+0x95/0xd0 ? page_add_new_anon_rmap+0x4e/0xf0 ? __handle_mm_fault+0xec6/0x1470 __sys_sendmsg+0x51/0x90 ? internal_get_user_pages_fast+0x480/0xa10 do_syscall_64+0x3d/0x90 entry_SYSCALL_64_after_hwframe+0x44/0xae
--- drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c +2 -0
@@ -1544,6 +1544,8 @@ mlx5e_init_fib_work_ipv4(struct mlx5e_priv *priv,struct net_device *fib_dev; fen_info = container_of(info, struct fib_entry_notifier_info, info); +if (fen_info->fi->nh) +return NULL ; fib_dev =fib_info_nh (fen_info->fi,0 )->fib_nh_dev;if (!fib_dev || fib_dev->netdev_ops != &mlx5e_netdev_ops || fen_info->dst_len !=32 )
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 339/846 net/mlx5e: Dont block routes with nexthop objects in SW
In reply to Greg Kroah-HartmanFrom: Maor Dickman <[email protected]>
[ Upstream commit 9e72a55a3c9d54b38a704bb7292d984574a81d9d ]
Routes with nexthop objects is currently not supported by multipath offload and any attempts to use it is blocked, however this also block adding SW routes with nexthop.
Resolve this by returning NOTIFY_DONE instead of an error which will allow such a route to be created in SW but not offloaded.
This fix also solve an issue which block adding such routes on different devices due to missing check if the route FIB device is one of multipath devices.
--- drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c +2 -4
@@ -268,10 +268,8 @@ static int mlx5_lag_fib_event(struct notifier_block *nb, fen_info = container_of(info, struct fib_entry_notifier_info, info); fi = fen_info->fi; -if (fi->nh) { -NL_SET_ERR_MSG_MOD (info->extack,"IPv4 route with nexthop objects is not supported" ); -return notifier_from_errno (-EINVAL ); - } +if (fi->nh) +return NOTIFY_DONE ; fib_dev =fib_info_nh (fen_info->fi,0 )->fib_nh_dev;if (fib_dev != ldev->pf[MLX5_LAG_P1 ].netdev && fib_dev != ldev->pf[MLX5_LAG_P2 ].netdev) {
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 340/846 Revert "net/mlx5e: Block offload of outer header csum for UDP tunnels"
In reply to Greg Kroah-HartmanFrom: Aya Levin <[email protected]>
[ Upstream commit 64050cdad0983ad8060e33c3f4b5aee2366bcebd ]
This reverts commit 6d6727dddc7f93fcc155cb8d0c49c29ae0e71122.
Although the NIC doesn't support offload of outer header CSUM, using gso_partial_features allows offloading the tunnel's segmentation. The driver relies on the stack CSUM calculation of the outer header. For this, NETIF_F_GSO_UDP_TUNNEL_CSUM must be a member of the device's features.
--- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/en_main.c +7 -3
@@ -4485,9 +4485,13 @@ static void mlx5e_build_nic_netdev(struct net_device *netdev) }if (mlx5_vxlan_allowed (mdev->vxlan) ||mlx5_geneve_tx_allowed (mdev)) { - netdev->hw_features |=NETIF_F_GSO_UDP_TUNNEL ; - netdev->hw_enc_features |=NETIF_F_GSO_UDP_TUNNEL ; - netdev->vlan_features |=NETIF_F_GSO_UDP_TUNNEL ; + netdev->hw_features |=NETIF_F_GSO_UDP_TUNNEL | +NETIF_F_GSO_UDP_TUNNEL_CSUM ; + netdev->hw_enc_features |=NETIF_F_GSO_UDP_TUNNEL | +NETIF_F_GSO_UDP_TUNNEL_CSUM ; + netdev->gso_partial_features =NETIF_F_GSO_UDP_TUNNEL_CSUM ; + netdev->vlan_features |=NETIF_F_GSO_UDP_TUNNEL | +NETIF_F_GSO_UDP_TUNNEL_CSUM ; }if (mlx5e_tunnel_proto_supported_tx (mdev,IPPROTO_GRE )) {
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 341/846 Revert "net/mlx5e: Block offload of outer header csum for GRE tunnel"
In reply to Greg Kroah-HartmanFrom: Aya Levin <[email protected]>
[ Upstream commit 01c3fd113ef50490ffd43f78f347ef6bb008510b ]
This reverts commit 54e1217b90486c94b26f24dcee1ee5ef5372f832.
Although the NIC doesn't support offload of outer header CSUM, using gso_partial_features allows offloading the tunnel's segmentation. The driver relies on the stack CSUM calculation of the outer header. For this, NETIF_F_GSO_GRE_CSUM must be a member of the device's features.
--- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/en_main.c +6 -3
@@ -4495,9 +4495,12 @@ static void mlx5e_build_nic_netdev(struct net_device *netdev) }if (mlx5e_tunnel_proto_supported_tx (mdev,IPPROTO_GRE )) { - netdev->hw_features |=NETIF_F_GSO_GRE ; - netdev->hw_enc_features |=NETIF_F_GSO_GRE ; - netdev->gso_partial_features |=NETIF_F_GSO_GRE ; + netdev->hw_features |=NETIF_F_GSO_GRE | +NETIF_F_GSO_GRE_CSUM ; + netdev->hw_enc_features |=NETIF_F_GSO_GRE | +NETIF_F_GSO_GRE_CSUM ; + netdev->gso_partial_features |=NETIF_F_GSO_GRE | +NETIF_F_GSO_GRE_CSUM ; }if (mlx5e_tunnel_proto_supported_tx (mdev,IPPROTO_IPIP )) {
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 342/846 net/mlx5e: Fix matching on modified inner ip_ecn bits
In reply to Greg Kroah-HartmanFrom: Paul Blakey <[email protected]>
[ Upstream commit b6dfff21a170af5c695ebaa153b7f5e297ddca03 ]
Tunnel device follows RFC 6040, and during decapsulation inner ip_ecn might change depending on inner and outer ip_ecn as follows:
+---------+----------------------------------------+ |Arriving | Arriving Outer Header | | Inner +---------+---------+---------+----------+ | Header | Not-ECT | ECT(0) | ECT(1) | CE | +---------+---------+---------+---------+----------+ | Not-ECT | Not-ECT | Not-ECT | Not-ECT | <drop> | | ECT(0) | ECT(0) | ECT(0) | ECT(1) | CE* | | ECT(1) | ECT(1) | ECT(1) | ECT(1)* | CE* | | CE | CE | CE | CE | CE | +---------+---------+---------+---------+----------+
Cells marked above are changed from original inner packet ip_ecn value.
Tc then matches on the modified inner ip_ecn, but hw offload which matches the inner ip_ecn value before decap, will fail.
Fix that by mapping all the cases of outer and inner ip_ecn matching, and only supporting cases where we know inner wouldn't be changed by decap, or in the outer ip_ecn=CE case, inner ip_ecn didn't matter.
--- .../net/ethernet/mellanox/mlx5/core/en_tc.c | 120 +++++++++++++++++- 1 file changed, 116 insertions(+), 4 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +116 -4
@@ -1874,6 +1874,111 @@ u8 mlx5e_tc_get_ip_version(struct mlx5_flow_spec *spec, bool outer)return ip_version; } +/* Tunnel device follows RFC 6040, see include/net/inet_ecn.h. +* And changes inner ip_ecn depending on inner and outer ip_ecn as follows: +* +---------+----------------------------------------+ +* |Arriving | Arriving Outer Header | +* | Inner +---------+---------+---------+----------+ +* | Header | Not-ECT | ECT(0) | ECT(1) | CE | +* +---------+---------+---------+---------+----------+ +* | Not-ECT | Not-ECT | Not-ECT | Not-ECT | <drop> | +* | ECT(0) | ECT(0) | ECT(0) | ECT(1) | CE* | +* | ECT(1) | ECT(1) | ECT(1) | ECT(1)* | CE* | +* | CE | CE | CE | CE | CE | +* +---------+---------+---------+---------+----------+ +* +* Tc matches on inner after decapsulation on tunnel device, but hw offload matches +* the inner ip_ecn value before hardware decap action. +* +* Cells marked are changed from original inner packet ip_ecn value during decap, and +* so matching those values on inner ip_ecn before decap will fail. +* +* The following helper allows offload when inner ip_ecn won't be changed by outer ip_ecn, +* except for the outer ip_ecn = CE, where in all cases inner ip_ecn will be changed to CE, +* and such we can drop the inner ip_ecn=CE match. +*/ + +static int mlx5e_tc_verify_tunnel_ecn (struct mlx5e_priv *priv, +struct flow_cls_offload *f, +bool *match_inner_ecn) +{ +u8 outer_ecn_mask =0 , outer_ecn_key =0 , inner_ecn_mask =0 , inner_ecn_key =0 ; +struct flow_rule *rule =flow_cls_offload_flow_rule (f); +struct netlink_ext_ack *extack = f->common.extack; +struct flow_match_ip match; + + *match_inner_ecn = true; + +if (flow_rule_match_key (rule,FLOW_DISSECTOR_KEY_ENC_IP )) { +flow_rule_match_enc_ip (rule, &match); + outer_ecn_key = match.key->tos &INET_ECN_MASK ; + outer_ecn_mask = match.mask->tos &INET_ECN_MASK ; + } + +if (flow_rule_match_key (rule,FLOW_DISSECTOR_KEY_IP )) { +flow_rule_match_ip (rule, &match); + inner_ecn_key = match.key->tos &INET_ECN_MASK ; + inner_ecn_mask = match.mask->tos &INET_ECN_MASK ; + } + +if (outer_ecn_mask !=0 && outer_ecn_mask !=INET_ECN_MASK ) { +NL_SET_ERR_MSG_MOD (extack,"Partial match on enc_tos ecn bits isn't supported" ); +netdev_warn (priv->netdev,"Partial match on enc_tos ecn bits isn't supported" ); +return -EOPNOTSUPP ; + } + +if (!outer_ecn_mask) { +if (!inner_ecn_mask) +return 0 ; + +NL_SET_ERR_MSG_MOD (extack, +"Matching on tos ecn bits without also matching enc_tos ecn bits isn't supported" ); +netdev_warn (priv->netdev, +"Matching on tos ecn bits without also matching enc_tos ecn bits isn't supported" ); +return -EOPNOTSUPP ; + } + +if (inner_ecn_mask && inner_ecn_mask !=INET_ECN_MASK ) { +NL_SET_ERR_MSG_MOD (extack, +"Partial match on tos ecn bits with match on enc_tos ecn bits isn't supported" ); +netdev_warn (priv->netdev, +"Partial match on tos ecn bits with match on enc_tos ecn bits isn't supported" ); +return -EOPNOTSUPP ; + } + +if (!inner_ecn_mask) +return 0 ; + +/* Both inner and outer have full mask on ecn */ + +if (outer_ecn_key ==INET_ECN_ECT_1 ) { +/* inner ecn might change by DECAP action */ + +NL_SET_ERR_MSG_MOD (extack,"Match on enc_tos ecn = ECT(1) isn't supported" ); +netdev_warn (priv->netdev,"Match on enc_tos ecn = ECT(1) isn't supported" ); +return -EOPNOTSUPP ; + } + +if (outer_ecn_key !=INET_ECN_CE ) +return 0 ; + +if (inner_ecn_key !=INET_ECN_CE ) { +/* Can't happen in software, as packet ecn will be changed to CE after decap */ +NL_SET_ERR_MSG_MOD (extack, +"Match on tos enc_tos ecn = CE while match on tos ecn != CE isn't supported" ); +netdev_warn (priv->netdev, +"Match on tos enc_tos ecn = CE while match on tos ecn != CE isn't supported" ); +return -EOPNOTSUPP ; + } + +/* outer ecn = CE, inner ecn = CE, as decap will change inner ecn to CE in anycase, +* drop match on inner ecn +*/ + *match_inner_ecn = false; + +return 0 ; +} + static int parse_tunnel_attr(struct mlx5e_priv *priv, struct mlx5e_tc_flow *flow, struct mlx5_flow_spec *spec,
@@ -2067,6 +2172,7 @@ static int __parse_cls_flower(struct mlx5e_priv *priv,struct flow_rule *rule =flow_cls_offload_flow_rule (f);struct flow_dissector *dissector = rule->match.dissector;enum fs_flow_table_type fs_type; +bool match_inner_ecn = true;u16 addr_type =0 ;u8 ip_proto =0 ;u8 *match_level;
@@ -2120,6 +2226,10 @@ static int __parse_cls_flower(struct mlx5e_priv *priv, headers_c =get_match_inner_headers_criteria (spec); headers_v =get_match_inner_headers_value (spec); } + + err =mlx5e_tc_verify_tunnel_ecn (priv, f, &match_inner_ecn); +if (err) +return err; } err =mlx5e_flower_parse_meta (filter_dev, f);
@@ -2341,10 +2451,12 @@ static int __parse_cls_flower(struct mlx5e_priv *priv,struct flow_match_ip match;flow_rule_match_ip (rule, &match); -MLX5_SET (fte_match_set_lyr_2_4, headers_c, ip_ecn, - match.mask->tos &0x3 ); -MLX5_SET (fte_match_set_lyr_2_4, headers_v, ip_ecn, - match.key->tos &0x3 ); +if (match_inner_ecn) { +MLX5_SET (fte_match_set_lyr_2_4, headers_c, ip_ecn, + match.mask->tos &0x3 ); +MLX5_SET (fte_match_set_lyr_2_4, headers_v, ip_ecn, + match.key->tos &0x3 ); + }MLX5_SET (fte_match_set_lyr_2_4, headers_c, ip_dscp, match.mask->tos >>2 );
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 343/846 net/mlx5: Fix access to sf_dev_table on allocation failure
In reply to Greg Kroah-HartmanFrom: Shay Drory <[email protected]>
[ Upstream commit a1c7c49c2091926962f8c1c866d386febffec5d8 ]
Even when SF devices are supported, the SF device table allocation can still fail.
In such case mlx5_sf_dev_supported still reports true, but SF device table is invalid. This can result in NULL table access.
Hence, fix it by adding NULL table check.
--- drivers/net/ethernet/mellanox/mlx5/core/sf/dev/dev.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/sf/dev/dev.c +1 -4
@@ -28,10 +28,7 @@ bool mlx5_sf_dev_allocated(const struct mlx5_core_dev *dev) {struct mlx5_sf_dev_table *table = dev->priv.sf_dev_table; -if (!mlx5_sf_dev_supported (dev)) -return false; - -return !xa_empty (&table->devices); +return table && !xa_empty (&table->devices); }static ssize_t sfnum_show (struct device *dev,struct device_attribute *attr,char *buf)
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 344/846 net/mlx5e: Sync VXLAN udp ports during uplink representor profile change
In reply to Greg Kroah-HartmanFrom: Maor Dickman <[email protected]>
[ Upstream commit 07f6dc4024ea1d2314b9c8b81fd4e492864fcca1 ]
Currently during NIC profile disablement all VXLAN udp ports offloaded to the HW are flushed and during its enablement the driver send notification to the stack to inform the core that the entire UDP tunnel port state has been lost, uplink representor doesn't have the same behavior which can cause VXLAN udp ports offload to be in bad state while moving between modes while VXLAN interface exist.
Fixed by aligning the uplink representor profile behavior to the NIC behavior.
--- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c +3 -0
@@ -50,6 +50,7 @@#include "fs_core.h" #include "lib/mlx5.h" #include "lib/devcom.h" +#include "lib/vxlan.h" #define CREATE_TRACE_POINTS #include "diag/en_rep_tracepoint.h" #include "en_accel/ipsec.h"
@@ -1016,6 +1017,7 @@ static void mlx5e_uplink_rep_enable(struct mlx5e_priv *priv)rtnl_lock ();if (netif_running (netdev))mlx5e_open (netdev); +udp_tunnel_nic_reset_ntf (priv->netdev);netif_device_attach (netdev);rtnl_unlock (); }
@@ -1037,6 +1039,7 @@ static void mlx5e_uplink_rep_disable(struct mlx5e_priv *priv)mlx5_notifier_unregister (mdev, &priv->events_nb);mlx5e_rep_tc_disable (priv);mlx5_lag_remove_netdev (mdev, priv->netdev); +mlx5_vxlan_reset_to_default (mdev->vxlan); } static MLX5E_DEFINE_STATS_GRP(sw_rep, 0);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 345/846 net/mlx5: Set command entry semaphore up once got index free
In reply to Greg Kroah-HartmanFrom: Moshe Shemesh <[email protected]>
[ Upstream commit 8e715cd613a1e872b9d918e912d90b399785761a ]
Avoid a race where command work handler may fail to allocate command entry index, by holding the command semaphore down till command entry index is being freed.
--- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/cmd.c +6 -9
@@ -147,8 +147,12 @@ static void cmd_ent_put(struct mlx5_cmd_work_ent *ent)if (!refcount_dec_and_test (&ent->refcnt))return ; -if (ent->idx >=0 ) -cmd_free_index (ent->cmd, ent->idx); +if (ent->idx >=0 ) { +struct mlx5_cmd *cmd = ent->cmd; + +cmd_free_index (cmd, ent->idx); +up (ent->page_queue ? &cmd->pages_sem : &cmd->sem); + }cmd_free_ent (ent); }
@@ -1594,8 +1598,6 @@ static void mlx5_cmd_comp_handler(struct mlx5_core_dev *dev, u64 vec, bool force vector = vec &0xffffffff ;for (i =0 ; i < (1 << cmd->log_sz); i++) {if (test_bit (i, &vector)) { -struct semaphore *sem; - ent = cmd->ent_arr[i];/* if we already completed the command, ignore it */
@@ -1618,10 +1620,6 @@ static void mlx5_cmd_comp_handler(struct mlx5_core_dev *dev, u64 vec, bool force dev->state == MLX5_DEVICE_STATE_INTERNAL_ERROR)cmd_ent_put (ent); -if (ent->page_queue) - sem = &cmd->pages_sem; -else - sem = &cmd->sem; ent->ts2 =ktime_get_ns ();memcpy (ent->out->first.data, ent->lay->out,sizeof (ent->lay->out));dump_command (dev, ent,0 );
@@ -1675,7 +1673,6 @@ static void mlx5_cmd_comp_handler(struct mlx5_core_dev *dev, u64 vec, bool force*/ complete (&ent->done); } -up (sem); } } }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 346/846 lib/mpi: Add the return value check of kcalloc()
In reply to Greg Kroah-HartmanFrom: Zizhuang Deng <[email protected]>
[ Upstream commit dd827abe296fe4249b2f8c9b95f72f814ea8348c ]
Add the return value check of kcalloc() to avoid potential NULL ptr dereference.
--- lib/mpi/mpi-mod.c | 2 ++ 1 file changed, 2 insertions(+)
lib/mpi/mpi-mod.c +2 -0
@@ -40,6 +40,8 @@ mpi_barrett_t mpi_barrett_init(MPI m, int copy)mpi_normalize (m); ctx =kcalloc (1 ,sizeof (*ctx),GFP_KERNEL ); +if (!ctx) +return NULL ;if (copy) { ctx->m =mpi_copy (m);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 347/846 Bluetooth: L2CAP: uninitialized variables in l2cap_sock_setsockopt()
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
[ Upstream commit 2b70d4f9b20635ac328836e50d183632e1930f94 ]
The "opt" variable is a u32, but on some paths only the top bytes were initialized and the others contained random stack data.
--- net/bluetooth/l2cap_sock.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)
net/bluetooth/l2cap_sock.c +8 -6
@@ -903,6 +903,8 @@ static int l2cap_sock_setsockopt(struct socket *sock, int level, int optname,struct l2cap_conn *conn;int len, err =0 ;u32 opt; +u16 mtu; +u8 mode;BT_DBG ("sk %p" , sk);
@@ -1085,16 +1087,16 @@ static int l2cap_sock_setsockopt(struct socket *sock, int level, int optname,break ; } -if (copy_from_sockptr (&opt, optval,sizeof (u16))) { +if (copy_from_sockptr (&mtu, optval,sizeof (u16))) { err = -EFAULT ;break ; }if (chan->mode ==L2CAP_MODE_EXT_FLOWCTL && sk->sk_state ==BT_CONNECTED ) - err =l2cap_chan_reconfigure (chan, opt); + err =l2cap_chan_reconfigure (chan, mtu);else - chan->imtu = opt; + chan->imtu = mtu;break ;
@@ -1116,14 +1118,14 @@ static int l2cap_sock_setsockopt(struct socket *sock, int level, int optname,break ; } -if (copy_from_sockptr (&opt, optval,sizeof (u8))) { +if (copy_from_sockptr (&mode, optval,sizeof (u8))) { err = -EFAULT ;break ; } -BT_DBG ("opt %u" , opt); +BT_DBG ("mode %u" , mode); - err =l2cap_set_mode (chan, opt); + err =l2cap_set_mode (chan, mode);if (err)break ;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 348/846 mptcp: fix per socket endpoint accounting
In reply to Greg Kroah-HartmanFrom: Paolo Abeni <[email protected]>
[ Upstream commit f7d6a237d7422809d458d754016de2844017cb4d ]
Since full-mesh endpoint support, the reception of a single ADD_ADDR option can cause multiple subflows creation. When such option is accepted we increment 'add_addr_accepted' by one. When we received a paired RM_ADDR option, we deleted all the relevant subflows, decrementing 'add_addr_accepted' by one for each of them.
We have a similar issue for 'local_addr_used'
Fix them moving the pm endpoint accounting outside the subflow traversal.
--- net/mptcp/pm_netlink.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-)
net/mptcp/pm_netlink.c +12 -6
@@ -710,6 +710,8 @@ static void mptcp_pm_nl_rm_addr_or_subflow(struct mptcp_sock *msk,return ;for (i =0 ; i < rm_list->nr; i++) { +bool removed = false; +list_for_each_entry_safe (subflow, tmp, &msk->conn_list, node) {struct sock *ssk =mptcp_subflow_tcp_sock (subflow);int how =RCV_SHUTDOWN |SEND_SHUTDOWN ;
@@ -729,15 +731,19 @@ static void mptcp_pm_nl_rm_addr_or_subflow(struct mptcp_sock *msk,mptcp_close_ssk (sk, ssk, subflow);spin_lock_bh (&msk->pm.lock); -if (rm_type ==MPTCP_MIB_RMADDR ) { - msk->pm.add_addr_accepted--; -WRITE_ONCE (msk->pm.accept_addr, true); - }else if (rm_type ==MPTCP_MIB_RMSUBFLOW ) { - msk->pm.local_addr_used--; - } + removed = true; msk->pm.subflows--;__MPTCP_INC_STATS (sock_net (sk), rm_type); } +if (!removed) +continue ; + +if (rm_type ==MPTCP_MIB_RMADDR ) { + msk->pm.add_addr_accepted--; +WRITE_ONCE (msk->pm.accept_addr, true); + }else if (rm_type ==MPTCP_MIB_RMSUBFLOW ) { + msk->pm.local_addr_used--; + } } }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 349/846 mptcp: fix opt size when sending DSS + MP_FAIL
In reply to Greg Kroah-HartmanFrom: Matthieu Baerts <[email protected]>
[ Upstream commit 04fac2cae9422a3401c172571afbcfdd58fa5c7e ]
When these two options had to be sent -- which is not common -- the DSS size was not being taken into account in the remaining size.
Additionally in this situation, the reported size was only the one of the MP_FAIL which can cause issue if at the end, we need to write more in the TCP options than previously said.
Here we use a dedicated variable for MP_FAIL size to keep the WARN_ON_ONCE() just after.
--- net/mptcp/options.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
net/mptcp/options.c +6 -3
@@ -823,10 +823,13 @@ bool mptcp_established_options(struct sock *sk, struct sk_buff *skb,if (mptcp_established_options_mp (sk, skb, snd_data_fin, &opt_size, remaining, opts)) ret = true;else if (mptcp_established_options_dss (sk, skb, snd_data_fin, &opt_size, remaining, opts)) { +unsigned int mp_fail_size; + ret = true; -if (mptcp_established_options_mp_fail (sk, &opt_size, remaining, opts)) { - *size += opt_size; - remaining -= opt_size; +if (mptcp_established_options_mp_fail (sk, &mp_fail_size, + remaining - opt_size, opts)) { + *size += opt_size + mp_fail_size; + remaining -= opt_size - mp_fail_size;return true; } }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 350/846 mptcp: fix a DSS option writing error
In reply to Greg Kroah-HartmanFrom: Geliang Tang <[email protected]>
[ Upstream commit 110b6d1fe98fd7af9893992459b651594d789293 ]
'ptr += 1;' was omitted in the original code.
If the DSS is the last option -- which is what we have most of the time -- that's not an issue. But it is if we need to send something else after like a RM_ADDR or an MP_PRIO.
--- net/mptcp/options.c | 1 + 1 file changed, 1 insertion(+)
net/mptcp/options.c +1 -0
@@ -1321,6 +1321,7 @@ void mptcp_write_options(__be32 *ptr, const struct tcp_sock *tp,put_unaligned_be32 (mpext->data_len <<16 |TCPOPT_NOP <<8 |TCPOPT_NOP , ptr); } + ptr +=1 ; } }else if ((OPTION_MPTCP_MPC_SYN |OPTION_MPTCP_MPC_SYNACK |OPTION_MPTCP_MPC_ACK ) & opts->suboptions) {
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 351/846 spi: spi-meson-spifc: Add missing pm_runtime_disable() in meson_spifc_probe
In reply to Greg Kroah-HartmanFrom: Miaoqian Lin <[email protected]>
[ Upstream commit 69c1b87516e327a60b39f96b778fe683259408bf ]
If the probe fails, we should use pm_runtime_disable() to balance pm_runtime_enable().
Add missing pm_runtime_disable() for meson_spifc_probe.
--- drivers/spi/spi-meson-spifc.c | 1 + 1 file changed, 1 insertion(+)
drivers/spi/spi-meson-spifc.c +1 -0
@@ -349,6 +349,7 @@ static int meson_spifc_probe(struct platform_device *pdev)return 0 ; out_clk:clk_disable_unprepare (spifc->clk); +pm_runtime_disable (spifc->dev); out_err:spi_master_put (master);return ret;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 352/846 octeontx2-af: Increment ptp refcount before use
In reply to Greg Kroah-HartmanFrom: Subbaraya Sundeep <[email protected]>
[ Upstream commit 93440f4888cf049dbd22b41aaf94d2e2153b3eb8 ]
Before using the ptp pci device by AF driver increment the reference count of it.
--- drivers/net/ethernet/marvell/octeontx2/af/ptp.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/ethernet/marvell/octeontx2/af/ptp.c +2 -0
@@ -85,6 +85,8 @@ struct ptp *ptp_get(void)/* Check driver is bound to PTP block */ if (!ptp) ptp =ERR_PTR (-EPROBE_DEFER ); +else +pci_dev_get (ptp->pdev);return ptp; }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 353/846 ax25: uninitialized variable in ax25_setsockopt()
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
[ Upstream commit 9371937092d5fd502032c1bb4475b36b39b1f1b3 ]
The "opt" variable is unsigned long but we only copy 4 bytes from the user so the lower 4 bytes are uninitialized.
I have changed the integer overflow checks from ULONG to UINT as well. This is a slight API change but I don't expect it to break anything.
--- net/ax25/af_ax25.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
net/ax25/af_ax25.c +5 -5
@@ -536,7 +536,7 @@ static int ax25_setsockopt(struct socket *sock, int level, int optname,ax25_cb *ax25;struct net_device *dev;char devname[IFNAMSIZ ]; -unsigned long opt; +unsigned int opt;int res =0 ;if (level !=SOL_AX25 )
@@ -568,7 +568,7 @@ static int ax25_setsockopt(struct socket *sock, int level, int optname,break ;case AX25_T1 : -if (opt <1 || opt >ULONG_MAX /HZ ) { +if (opt <1 || opt >UINT_MAX /HZ ) { res = -EINVAL ;break ; }
@@ -577,7 +577,7 @@ static int ax25_setsockopt(struct socket *sock, int level, int optname,break ;case AX25_T2 : -if (opt <1 || opt >ULONG_MAX /HZ ) { +if (opt <1 || opt >UINT_MAX /HZ ) { res = -EINVAL ;break ; }
@@ -593,7 +593,7 @@ static int ax25_setsockopt(struct socket *sock, int level, int optname,break ;case AX25_T3 : -if (opt <1 || opt >ULONG_MAX /HZ ) { +if (opt <1 || opt >UINT_MAX /HZ ) { res = -EINVAL ;break ; }
@@ -601,7 +601,7 @@ static int ax25_setsockopt(struct socket *sock, int level, int optname,break ;case AX25_IDLE : -if (opt >ULONG_MAX / (60 *HZ )) { +if (opt >UINT_MAX / (60 *HZ )) { res = -EINVAL ;break ; }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 354/846 netrom: fix api breakage in nr_setsockopt()
In reply to Greg Kroah-HartmanFrom: Dan Carpenter <[email protected]>
[ Upstream commit dc35616e6c2907b0c0c391a205802d8880f7fd85 ]
This needs to copy an unsigned int from user space instead of a long to avoid breaking user space with an API change.
I have updated all the integer overflow checks from ULONG to UINT as well. This is a slight API change but I do not expect it to affect anything in real life.
--- net/netrom/af_netrom.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
net/netrom/af_netrom.c +6 -6
@@ -298,7 +298,7 @@ static int nr_setsockopt(struct socket *sock, int level, int optname, {struct sock *sk = sock->sk;struct nr_sock *nr =nr_sk (sk); -unsigned long opt; +unsigned int opt;if (level !=SOL_NETROM )return -ENOPROTOOPT ;
@@ -306,18 +306,18 @@ static int nr_setsockopt(struct socket *sock, int level, int optname,if (optlen <sizeof (unsigned int ))return -EINVAL ; -if (copy_from_sockptr (&opt, optval,sizeof (unsigned long ))) +if (copy_from_sockptr (&opt, optval,sizeof (opt)))return -EFAULT ;switch (optname) {case NETROM_T1 : -if (opt <1 || opt >ULONG_MAX /HZ ) +if (opt <1 || opt >UINT_MAX /HZ )return -EINVAL ; nr->t1 = opt *HZ ;return 0 ;case NETROM_T2 : -if (opt <1 || opt >ULONG_MAX /HZ ) +if (opt <1 || opt >UINT_MAX /HZ )return -EINVAL ; nr->t2 = opt *HZ ;return 0 ;
@@ -329,13 +329,13 @@ static int nr_setsockopt(struct socket *sock, int level, int optname,return 0 ;case NETROM_T4 : -if (opt <1 || opt >ULONG_MAX /HZ ) +if (opt <1 || opt >UINT_MAX /HZ )return -EINVAL ; nr->t4 = opt *HZ ;return 0 ;case NETROM_IDLE : -if (opt >ULONG_MAX / (60 *HZ )) +if (opt >UINT_MAX / (60 *HZ ))return -EINVAL ; nr->idle = opt *60 *HZ ;return 0 ;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 355/846 regmap: Call regmap_debugfs_exit() prior to _init()
In reply to Greg Kroah-HartmanFrom: Fabio Estevam <[email protected]>
[ Upstream commit 530792efa6cb86f5612ff093333fec735793b582 ]
Since commit cffa4b2122f5 ("regmap: debugfs: Fix a memory leak when calling regmap_attach_dev"), the following debugfs error is seen on i.MX boards:
debugfs: Directory 'dummy-iomuxc-gpr@20e0000' with parent 'regmap' already present!
In the attempt to fix the memory leak, the above commit added a NULL check for map->debugfs_name. For the first debufs entry, map->debugfs_name is NULL and then the new name is allocated via kasprintf().
For the second debugfs entry, map->debugfs_name() is no longer NULL, so it will keep using the old entry name and the duplicate name error is seen.
Quoting Mark Brown:
"That means that if the device gets freed we'll end up with the old debugfs file hanging around pointing at nothing.
...
To be more explicit this means we need a call to regmap_debugfs_exit() which will clean up all the existing debugfs stuff before we loose references to it."
Call regmap_debugfs_exit() prior to regmap_debugfs_init() to fix the problem.
Tested on i.MX6Q and i.MX6SX boards.
--- drivers/base/regmap/regmap.c | 1 + 1 file changed, 1 insertion(+)
drivers/base/regmap/regmap.c +1 -0
@@ -647,6 +647,7 @@ int regmap_attach_dev(struct device *dev, struct regmap *map,if (ret)return ret; +regmap_debugfs_exit (map);regmap_debugfs_init (map);/* Add a devres resource for dev_get_regmap() */
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 356/846 net: mscc: ocelot: fix incorrect balancing with down LAG ports
In reply to Greg Kroah-HartmanFrom: Vladimir Oltean <[email protected]>
[ Upstream commit a14e6b69f393d651913edcbe4ec0dec27b8b4b40 ]
Assuming the test setup described here:
https://patchwork.kernel.org/project/netdevbpf/cover/[email protected]/
(swp1 and swp2 are in bond0, and bond0 is in a bridge with swp0)
it can be seen that when swp1 goes down (on either board A or B), then traffic that should go through that port isn't forwarded anywhere.
A dump of the PGID table shows the following:
PGID_DST[0] = ports 0
PGID_DST[1] = ports 1
PGID_DST[2] = ports 2
PGID_DST[3] = ports 3
PGID_DST[4] = ports 4
PGID_DST[5] = ports 5
PGID_DST[6] = no ports
PGID_AGGR[0] = ports 0, 1, 2, 3, 4, 5
PGID_AGGR[1] = ports 0, 1, 2, 3, 4, 5
PGID_AGGR[2] = ports 0, 1, 2, 3, 4, 5
PGID_AGGR[3] = ports 0, 1, 2, 3, 4, 5
PGID_AGGR[4] = ports 0, 1, 2, 3, 4, 5
PGID_AGGR[5] = ports 0, 1, 2, 3, 4, 5
PGID_AGGR[6] = ports 0, 1, 2, 3, 4, 5
PGID_AGGR[7] = ports 0, 1, 2, 3, 4, 5
PGID_AGGR[8] = ports 0, 1, 2, 3, 4, 5
PGID_AGGR[9] = ports 0, 1, 2, 3, 4, 5
PGID_AGGR[10] = ports 0, 1, 2, 3, 4, 5
PGID_AGGR[11] = ports 0, 1, 2, 3, 4, 5
PGID_AGGR[12] = ports 0, 1, 2, 3, 4, 5
PGID_AGGR[13] = ports 0, 1, 2, 3, 4, 5
PGID_AGGR[14] = ports 0, 1, 2, 3, 4, 5
PGID_AGGR[15] = ports 0, 1, 2, 3, 4, 5
PGID_SRC[0] = ports 1, 2
PGID_SRC[1] = ports 0
PGID_SRC[2] = ports 0
PGID_SRC[3] = no ports
PGID_SRC[4] = no ports
PGID_SRC[5] = no ports
PGID_SRC[6] = ports 0, 1, 2, 3, 4, 5
Whereas a "good" PGID configuration for that setup should have looked like this:
PGID_DST[0] = ports 0
PGID_DST[1] = ports 1, 2
PGID_DST[2] = ports 1, 2
PGID_DST[3] = ports 3
PGID_DST[4] = ports 4
PGID_DST[5] = ports 5
PGID_DST[6] = no ports
PGID_AGGR[0] = ports 0, 2, 3, 4, 5
PGID_AGGR[1] = ports 0, 2, 3, 4, 5
PGID_AGGR[2] = ports 0, 2, 3, 4, 5
PGID_AGGR[3] = ports 0, 2, 3, 4, 5
PGID_AGGR[4] = ports 0, 2, 3, 4, 5
PGID_AGGR[5] = ports 0, 2, 3, 4, 5
PGID_AGGR[6] = ports 0, 2, 3, 4, 5
PGID_AGGR[7] = ports 0, 2, 3, 4, 5
PGID_AGGR[8] = ports 0, 2, 3, 4, 5
PGID_AGGR[9] = ports 0, 2, 3, 4, 5
PGID_AGGR[10] = ports 0, 2, 3, 4, 5
PGID_AGGR[11] = ports 0, 2, 3, 4, 5
PGID_AGGR[12] = ports 0, 2, 3, 4, 5
PGID_AGGR[13] = ports 0, 2, 3, 4, 5
PGID_AGGR[14] = ports 0, 2, 3, 4, 5
PGID_AGGR[15] = ports 0, 2, 3, 4, 5
PGID_SRC[0] = ports 1, 2
PGID_SRC[1] = ports 0
PGID_SRC[2] = ports 0
PGID_SRC[3] = no ports
PGID_SRC[4] = no ports
PGID_SRC[5] = no ports
PGID_SRC[6] = ports 0, 1, 2, 3, 4, 5
In other words, in the "bad" configuration, the attempt is to remove the inactive swp1 from the destination ports via PGID_DST. But when a MAC table entry is learned, it is learned towards PGID_DST 1, because that is the logical port id of the LAG itself (it is equal to the lowest numbered member port). So when swp1 becomes inactive, if we set PGID_DST[1] to contain just swp1 and not swp2, the packet will not have any chance to reach the destination via swp2.
The "correct" way to remove swp1 as a destination is via PGID_AGGR (remove swp1 from the aggregation port groups for all aggregation codes). This means that PGID_DST[1] and PGID_DST[2] must still contain both swp1 and swp2. This makes the MAC table still treat packets destined towards the single-port LAG as "multicast", and the inactive ports are removed via the aggregation code tables.
The change presented here is a design one: the ocelot_get_bond_mask() function used to take an "only_active_ports" argument. We don't need that. The only call site that specifies only_active_ports=true, ocelot_set_aggr_pgids(), must retrieve the entire bonding mask, because it must program that into PGID_DST. Additionally, it must also clear the inactive ports from the bond mask here, which it can't do if bond_mask just contains the active ports:
ac = ocelot_read_rix(ocelot, ANA_PGID_PGID, i); ac &= ~bond_mask; <---- here /* Don't do division by zero if there was no active * port. Just make all aggregation codes zero. */ if (num_active_ports) ac |= BIT(aggr_idx[i % num_active_ports]); ocelot_write_rix(ocelot, ac, ANA_PGID_PGID, i);
So it becomes the responsibility of ocelot_set_aggr_pgids() to take ocelot_port->lag_tx_active into consideration when populating the aggr_idx array.
--- drivers/net/ethernet/mscc/ocelot.c | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-)
drivers/net/ethernet/mscc/ocelot.c +11 -15
@@ -1302,8 +1302,7 @@ int ocelot_get_ts_info(struct ocelot *ocelot, int port, }EXPORT_SYMBOL (ocelot_get_ts_info); -static u32 ocelot_get_bond_mask (struct ocelot *ocelot,struct net_device *bond, -bool only_active_ports) +static u32 ocelot_get_bond_mask (struct ocelot *ocelot,struct net_device *bond) {u32 mask =0 ;int port;
@@ -1314,12 +1313,8 @@ static u32 ocelot_get_bond_mask(struct ocelot *ocelot, struct net_device *bond,if (!ocelot_port)continue ; -if (ocelot_port->bond == bond) { -if (only_active_ports && !ocelot_port->lag_tx_active) -continue ; - +if (ocelot_port->bond == bond) mask |=BIT (port); - } }return mask;
@@ -1406,10 +1401,8 @@ void ocelot_apply_bridge_fwd_mask(struct ocelot *ocelot) mask =ocelot_get_bridge_fwd_mask (ocelot, port, bridge); mask |= cpu_fwd_mask; mask &= ~BIT (port); -if (bond) { - mask &= ~ocelot_get_bond_mask (ocelot, bond, - false); - } +if (bond) + mask &= ~ocelot_get_bond_mask (ocelot, bond); }else {/* Standalone ports forward only to DSA tag_8021q CPU * ports (if those exist), or to the hardware CPU port
@@ -1727,13 +1720,17 @@ static void ocelot_set_aggr_pgids(struct ocelot *ocelot)if (!bond || (visited &BIT (lag)))continue ; - bond_mask =ocelot_get_bond_mask (ocelot, bond, true); + bond_mask =ocelot_get_bond_mask (ocelot, bond);for_each_set_bit (port, &bond_mask, ocelot->num_phys_ports) { +struct ocelot_port *ocelot_port = ocelot->ports[port]; +// Destination mask ocelot_write_rix (ocelot, bond_mask,ANA_PGID_PGID , port); - aggr_idx[num_active_ports++] = port; + +if (ocelot_port->lag_tx_active) + aggr_idx[num_active_ports++] = port; }for_each_aggr_pgid (ocelot, i) {
@@ -1782,8 +1779,7 @@ static void ocelot_setup_logical_port_ids(struct ocelot *ocelot) bond = ocelot_port->bond;if (bond) { -int lag =__ffs (ocelot_get_bond_mask (ocelot, bond, - false)); +int lag =__ffs (ocelot_get_bond_mask (ocelot, bond)); ocelot_rmw_gix(ocelot, ANA_PORT_PORT_CFG_PORTID_VAL(lag),
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 357/846 can: mcp251xfd: add missing newline to printed strings
In reply to Greg Kroah-HartmanFrom: Marc Kleine-Budde <[email protected]>
[ Upstream commit 3bd9d8ce6f8c5c43ee2f1106021db0f98882cc75 ]
This patch adds the missing newline to printed strings.
--- drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c +2 -2
@@ -2625,7 +2625,7 @@ static int mcp251xfd_register_chip_detect(struct mcp251xfd_priv *priv)if (!mcp251xfd_is_251X (priv) && priv->devtype_data.model != devtype_data->model) {netdev_info (ndev, -"Detected %s, but firmware specifies a %s. Fixing up." , +"Detected %s, but firmware specifies a %s. Fixing up.\n" ,__mcp251xfd_get_model_str (devtype_data->model),mcp251xfd_get_model_str (priv)); }
@@ -2662,7 +2662,7 @@ static int mcp251xfd_register_check_rx_int(struct mcp251xfd_priv *priv)return 0 ;netdev_info (priv->ndev, -"RX_INT active after softreset, disabling RX_INT support." ); +"RX_INT active after softreset, disabling RX_INT support.\n" );devm_gpiod_put (&priv->spi->dev, priv->rx_int); priv->rx_int =NULL ;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 358/846 tpm: add request_locality before write TPM_INT_ENABLE
In reply to Greg Kroah-HartmanFrom: Chen Jun <[email protected]>
[ Upstream commit 0ef333f5ba7f24f5d8478425c163d3097f1c7afd ]
Locality is not appropriately requested before writing the int mask. Add the missing boilerplate.
--- drivers/char/tpm/tpm_tis_core.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/char/tpm/tpm_tis_core.c +8 -0
@@ -994,7 +994,15 @@ int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq, intmask |=TPM_INTF_CMD_READY_INT |TPM_INTF_LOCALITY_CHANGE_INT |TPM_INTF_DATA_AVAIL_INT |TPM_INTF_STS_VALID_INT ; intmask &= ~TPM_GLOBAL_INT_ENABLE ; + + rc =request_locality (chip,0 ); +if (rc <0 ) { + rc = -ENODEV ; + goto out_err; + } +tpm_tis_write32 (priv,TPM_INT_ENABLE (priv->locality), intmask); +release_locality (chip,0 ); rc =tpm_chip_start (chip);if (rc)
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 359/846 tpm_tis: Fix an error handling path in tpm_tis_core_init()
In reply to Greg Kroah-HartmanFrom: Christophe Jaillet <[email protected]>
[ Upstream commit e96d52822f5ac0a25de78f95cd23421bcbc93584 ]
Commit 79ca6f74dae0 ("tpm: fix Atmel TPM crash caused by too frequent queries") has moved some code around without updating the error handling path.
This is now pointless to 'goto out_err' when neither 'clk_enable()' nor 'ioremap()' have been called yet.
Make a direct return instead to avoid undoing things that have not been done.
--- drivers/char/tpm/tpm_tis_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/tpm/tpm_tis_core.c +1 -1
@@ -952,7 +952,7 @@ int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq, rc =tpm_tis_read32 (priv,TPM_DID_VID (0 ), &vendor);if (rc <0 ) - goto out_err; +return rc; priv->manufacturer_id = vendor;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 360/846 can: softing: softing_startstop(): fix set but not used variable warning
In reply to Greg Kroah-HartmanFrom: Marc Kleine-Budde <[email protected]>
[ Upstream commit 370d988cc529598ebaec6487d4f84c2115dc696b ]
In the function softing_startstop() the variable error_reporting is assigned but not used. The code that uses this variable is commented out. Its stated that the functionality is not finally verified.
To fix the warning:
| drivers/net/can/softing/softing_fw.c:424:9: error: variable 'error_reporting' set but not used [-Werror,-Wunused-but-set-variable]
remove the comment, activate the code, but add a "0 &&" to the if expression and rely on the optimizer rather than the preprocessor to remove the code.
--- drivers/net/can/softing/softing_fw.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/net/can/softing/softing_fw.c +6 -5
@@ -565,18 +565,19 @@ int softing_startstop(struct net_device *dev, int up)if (ret <0 ) goto failed; } -/* enable_error_frame */ -/* + +/* enable_error_frame +* * Error reporting is switched off at the moment since * the receiving of them is not yet 100% verified * This should be enabled sooner or later -* -if (error_reporting) { +*/ +if (0 && error_reporting) { ret =softing_fct_cmd (card,51 ,"enable_error_frame" );if (ret <0 ) goto failed; } -*/ +/* initialize interface */ iowrite16 (1 , &card->dpram[DPRAM_FCT_PARAM +2 ]);iowrite16 (1 , &card->dpram[DPRAM_FCT_PARAM +4 ]);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 361/846 can: xilinx_can: xcan_probe(): check for error irq
In reply to Greg Kroah-HartmanFrom: Jiasheng Jiang <[email protected]>
[ Upstream commit c6564c13dae25cd7f8e1de5127b4da4500ee5844 ]
For the possible failure of the platform_get_irq(), the returned irq could be error number and will finally cause the failure of the request_irq().
Consider that platform_get_irq() can now in certain cases return -EPROBE_DEFER, and the consequences of letting request_irq() effectively convert that into -EINVAL, even at probe time rather than later on. So it might be better to check just now.
--- drivers/net/can/xilinx_can.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/net/can/xilinx_can.c +6 -1
@@ -1762,7 +1762,12 @@ static int xcan_probe(struct platform_device *pdev)spin_lock_init (&priv->tx_lock);/* Get IRQ for the device */ - ndev->irq =platform_get_irq (pdev,0 ); + ret =platform_get_irq (pdev,0 ); +if (ret <0 ) + goto err_free; + + ndev->irq = ret; + ndev->flags |=IFF_ECHO ;/* We support local echo */ platform_set_drvdata (pdev, ndev);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 362/846 can: rcar_canfd: rcar_canfd_channel_probe(): make sure we free CAN network device
In reply to Greg Kroah-HartmanFrom: Lad Prabhakar <[email protected]>
[ Upstream commit 72b1e360572f9fa7d08ee554f1da29abce23f288 ]
Make sure we free CAN network device in the error path. There are several jumps to fail label after allocating the CAN network device successfully. This patch places the free_candev() under fail label so that in failure path a jump to fail label frees the CAN network device.
--- drivers/net/can/rcar/rcar_canfd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/net/can/rcar/rcar_canfd.c +2 -3
@@ -1640,8 +1640,7 @@ static int rcar_canfd_channel_probe(struct rcar_canfd_global *gpriv, u32 ch, ndev =alloc_candev (sizeof (*priv),RCANFD_FIFO_DEPTH );if (!ndev) {dev_err (&pdev->dev,"alloc_candev() failed\n" ); - err = -ENOMEM ; - goto fail; +return -ENOMEM ; } priv =netdev_priv (ndev);
@@ -1735,8 +1734,8 @@ static int rcar_canfd_channel_probe(struct rcar_canfd_global *gpriv, u32 ch, fail_candev:netif_napi_del (&priv->napi); -free_candev (ndev); fail: +free_candev (ndev);return err; }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 363/846 pcmcia: fix setting of kthread task states
In reply to Greg Kroah-HartmanFrom: Dominik Brodowski <[email protected]>
[ Upstream commit fbb3485f1f931102d8ba606f1c28123f5b48afa3 ]
We need to set TASK_INTERRUPTIBLE before calling kthread_should_stop(). Otherwise, kthread_stop() might see that the pccardd thread is still in TASK_RUNNING state and fail to wake it up.
Additionally, we only need to set the state back to TASK_RUNNING if kthread_should_stop() breaks the loop.
--- drivers/pcmcia/cs.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/pcmcia/cs.c +3 -5
@@ -666,18 +666,16 @@ static int pccardd(void *__skt)if (events || sysfs_events)continue ; +set_current_state (TASK_INTERRUPTIBLE );if (kthread_should_stop ())break ; -set_current_state (TASK_INTERRUPTIBLE ); -schedule (); -/* make sure we are running */ -__set_current_state (TASK_RUNNING ); -try_to_freeze (); } +/* make sure we are running before we exit */ +__set_current_state (TASK_RUNNING );/* shut down socket, if a device is still present */ if (skt->state &SOCKET_PRESENT ) {
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 364/846 net/sched: flow_dissector: Fix matching on zone id for invalid conns
In reply to Greg Kroah-HartmanFrom: Paul Blakey <[email protected]>
[ Upstream commit 3849595866166b23bf6a0cb9ff87e06423167f67 ]
If ct rejects a flow, it removes the conntrack info from the skb. act_ct sets the post_ct variable so the dissector will see this case as an +tracked +invalid state, but the zone id is lost with the conntrack info.
To restore the zone id on such cases, set the last executed zone, via the tc control block, when passing ct, and read it back in the dissector if there is no ct info on the skb (invalid connection).
--- include/linux/skbuff.h | 2 +- include/net/pkt_sched.h | 1 + net/core/flow_dissector.c | 3 ++- net/sched/act_ct.c | 1 + net/sched/cls_flower.c | 3 ++- 5 files changed, 7 insertions(+), 3 deletions(-)
include/linux/skbuff.h +1 -1
@@ -1370,7 +1370,7 @@ skb_flow_dissect_ct(const struct sk_buff *skb,struct flow_dissector *flow_dissector, void *target_container, u16 *ctinfo_map, size_t mapsize, - bool post_ct); + bool post_ct, u16 zone); void skb_flow_dissect_tunnel_info(const struct sk_buff *skb, struct flow_dissector *flow_dissector,
include/net/pkt_sched.h +1 -0
@@ -198,6 +198,7 @@ struct tc_skb_cb {u16 mru;bool post_ct; +u16 zone;/* Only valid if post_ct = true */ };static inline struct tc_skb_cb *tc_skb_cb (const struct sk_buff *skb)
net/core/flow_dissector.c +2 -1
@@ -238,7 +238,7 @@ void skb_flow_dissect_ct(const struct sk_buff *skb, struct flow_dissector *flow_dissector, void *target_container, u16 *ctinfo_map, - size_t mapsize, bool post_ct) + size_t mapsize, bool post_ct, u16 zone) { #if IS_ENABLED(CONFIG_NF_CONNTRACK) struct flow_dissector_key_ct *key;
@@ -260,6 +260,7 @@ skb_flow_dissect_ct(const struct sk_buff *skb,if (!ct) { key->ct_state =TCA_FLOWER_KEY_CT_FLAGS_TRACKED |TCA_FLOWER_KEY_CT_FLAGS_INVALID ; + key->ct_zone = zone;return ; }
net/sched/act_ct.c +1 -0
@@ -1049,6 +1049,7 @@ out_push:skb_push_rcsum (skb, nh_ofs);tc_skb_cb (skb)->post_ct = true; +tc_skb_cb (skb)->zone = p->zone; out_clear:if (defrag)qdisc_skb_cb (skb)->pkt_len = skb->len;
net/sched/cls_flower.c +2 -1
@@ -311,6 +311,7 @@ static int fl_classify(struct sk_buff *skb, const struct tcf_proto *tp, {struct cls_fl_head *head =rcu_dereference_bh (tp->root);bool post_ct =tc_skb_cb (skb)->post_ct; +u16 zone =tc_skb_cb (skb)->zone;struct fl_flow_key skb_key;struct fl_flow_mask *mask;struct cls_fl_filter *f;
@@ -328,7 +329,7 @@ static int fl_classify(struct sk_buff *skb, const struct tcf_proto *tp,skb_flow_dissect_ct (skb, &mask->dissector, &skb_key, fl_ct_info_to_flower_map,ARRAY_SIZE (fl_ct_info_to_flower_map), - post_ct); + post_ct, zone);skb_flow_dissect_hash (skb, &mask->dissector, &skb_key);skb_flow_dissect (skb, &mask->dissector, &skb_key,0 );
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 365/846 net: openvswitch: Fix matching zone id for invalid conns arriving from tc
In reply to Greg Kroah-HartmanFrom: Paul Blakey <[email protected]>
[ Upstream commit 635d448a1cce4b4ebee52b351052c70434fa90ea ]
Zone id is not restored if we passed ct and ct rejected the connection, as there is no ct info on the skb.
Save the zone from tc skb cb to tc skb extension and pass it on to ovs, use that info to restore the zone id for invalid connections.
--- include/linux/skbuff.h | 1 + net/openvswitch/flow.c | 8 +++++++- net/sched/cls_api.c | 1 + 3 files changed, 9 insertions(+), 1 deletion(-)
include/linux/skbuff.h +1 -0
@@ -286,6 +286,7 @@ struct nf_bridge_info {struct tc_skb_ext {__u32 chain;__u16 mru; +__u16 zone;bool post_ct; };#endif
net/openvswitch/flow.c +7 -1
@@ -34,6 +34,7 @@#include <net/mpls.h> #include <net/ndisc.h> #include <net/nsh.h> +#include <net/netfilter/nf_conntrack_zones.h> #include "conntrack.h" #include "datapath.h"
@@ -860,6 +861,7 @@ int ovs_flow_key_extract(const struct ip_tunnel_info *tun_info,#endif bool post_ct = false;int res, err; +u16 zone =0 ;/* Extract metadata from packet. */ if (tun_info) {
@@ -898,6 +900,7 @@ int ovs_flow_key_extract(const struct ip_tunnel_info *tun_info, key->recirc_id = tc_ext ? tc_ext->chain :0 ;OVS_CB (skb)->mru = tc_ext ? tc_ext->mru :0 ; post_ct = tc_ext ? tc_ext->post_ct : false; + zone = post_ct ? tc_ext->zone :0 ; }else { key->recirc_id =0 ; }
@@ -906,8 +909,11 @@ int ovs_flow_key_extract(const struct ip_tunnel_info *tun_info,#endif err =key_extract (skb, key); -if (!err) +if (!err) {ovs_ct_fill_key (skb, key, post_ct);/* Must be after key_extract(). */ +if (post_ct && !skb_get_nfct (skb)) + key->ct_zone = zone; + }return err; }
net/sched/cls_api.c +1 -0
@@ -1625,6 +1625,7 @@ int tcf_classify(struct sk_buff *skb, ext->chain = last_executed_chain; ext->mru = cb->mru; ext->post_ct = cb->post_ct; + ext->zone = cb->zone; }return ret;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 366/846 net: openvswitch: Fix ct_state nat flags for conns arriving from tc
In reply to Greg Kroah-HartmanFrom: Paul Blakey <[email protected]>
[ Upstream commit 6f022c2ddbcefaee79502ce5386dfe351d457070 ]
Netfilter conntrack maintains NAT flags per connection indicating whether NAT was configured for the connection. Openvswitch maintains NAT flags on the per packet flow key ct_state field, indicating whether NAT was actually executed on the packet.
When a packet misses from tc to ovs the conntrack NAT flags are set. However, NAT was not necessarily executed on the packet because the connection's state might still be in NEW state. As such, openvswitch wrongly assumes that NAT was executed and sets an incorrect flow key NAT flags.
Fix this, by flagging to openvswitch which NAT was actually done in act_ct via tc_skb_ext and tc_skb_cb to the openvswitch module, so the packet flow key NAT flags will be correctly set.
--- include/linux/skbuff.h | 4 +++- include/net/pkt_sched.h | 4 +++- net/openvswitch/flow.c | 16 +++++++++++++--- net/sched/act_ct.c | 6 ++++++ net/sched/cls_api.c | 2 ++ 5 files changed, 27 insertions(+), 5 deletions(-)
include/linux/skbuff.h +3 -1
@@ -287,7 +287,9 @@ struct tc_skb_ext {__u32 chain;__u16 mru;__u16 zone; - bool post_ct; + u8 post_ct:1; + u8 post_ct_snat:1; + u8 post_ct_dnat:1; };#endif
include/net/pkt_sched.h +3 -1
@@ -197,7 +197,9 @@ struct tc_skb_cb {struct qdisc_skb_cb qdisc_cb;u16 mru; -bool post_ct; + u8 post_ct:1; + u8 post_ct_snat:1; + u8 post_ct_dnat:1;u16 zone;/* Only valid if post_ct = true */ };
net/openvswitch/flow.c +13 -3
@@ -859,7 +859,7 @@ int ovs_flow_key_extract(const struct ip_tunnel_info *tun_info,#if IS_ENABLED (CONFIG_NET_TC_SKB_EXT )struct tc_skb_ext *tc_ext;#endif -bool post_ct = false; +bool post_ct = false, post_ct_snat = false, post_ct_dnat = false;int res, err;u16 zone =0 ;
@@ -900,6 +900,8 @@ int ovs_flow_key_extract(const struct ip_tunnel_info *tun_info, key->recirc_id = tc_ext ? tc_ext->chain :0 ;OVS_CB (skb)->mru = tc_ext ? tc_ext->mru :0 ; post_ct = tc_ext ? tc_ext->post_ct : false; + post_ct_snat = post_ct ? tc_ext->post_ct_snat : false; + post_ct_dnat = post_ct ? tc_ext->post_ct_dnat : false; zone = post_ct ? tc_ext->zone :0 ; }else { key->recirc_id =0 ;
@@ -911,8 +913,16 @@ int ovs_flow_key_extract(const struct ip_tunnel_info *tun_info, err =key_extract (skb, key);if (!err) {ovs_ct_fill_key (skb, key, post_ct);/* Must be after key_extract(). */ -if (post_ct && !skb_get_nfct (skb)) - key->ct_zone = zone; +if (post_ct) { +if (!skb_get_nfct (skb)) { + key->ct_zone = zone; + }else { +if (!post_ct_dnat) + key->ct_state &= ~OVS_CS_F_DST_NAT ; +if (!post_ct_snat) + key->ct_state &= ~OVS_CS_F_SRC_NAT ; + } + } }return err; }
net/sched/act_ct.c +6 -0
@@ -839,6 +839,12 @@ static int ct_nat_execute(struct sk_buff *skb, struct nf_conn *ct, } err =nf_nat_packet (ct, ctinfo, hooknum, skb); +if (err ==NF_ACCEPT ) { +if (maniptype ==NF_NAT_MANIP_SRC ) +tc_skb_cb (skb)->post_ct_snat =1 ; +if (maniptype ==NF_NAT_MANIP_DST ) +tc_skb_cb (skb)->post_ct_dnat =1 ; + } out:return err; }
net/sched/cls_api.c +2 -0
@@ -1625,6 +1625,8 @@ int tcf_classify(struct sk_buff *skb, ext->chain = last_executed_chain; ext->mru = cb->mru; ext->post_ct = cb->post_ct; + ext->post_ct_snat = cb->post_ct_snat; + ext->post_ct_dnat = cb->post_ct_dnat; ext->zone = cb->zone; }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 367/846 iwlwifi: mvm: Use div_s64 instead of do_div in iwl_mvm_ftm_rtt_smoothing()
In reply to Greg Kroah-HartmanFrom: Nathan Chancellor <[email protected]>
[ Upstream commit 4ccdcc8ffd955490feec05380223db6a48961eb5 ]
When building ARCH=arm allmodconfig:
drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c: In function ‘iwl_mvm_ftm_rtt_smoothing’:./include/asm-generic/div64.h:222:35: error: comparison of distinct pointer types lacks a cast [-Werror]
222 | (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
| ^~drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c:1070:9: note: in expansion of macro ‘do_div’
1070 | do_div(rtt_avg, 100);
| ^~~~~~do_div() has to be used with an unsigned 64-bit integer dividend but rtt_avg is a signed 64-bit integer.
div_s64() expects a signed 64-bit integer dividend and signed 32-bit divisor, which fits this scenario, so use that function here to fix the warning.
--- drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/wireless/intel/iwlwifi/mvm/ftm-initiator.c +1 -2
@@ -1054,8 +1054,7 @@ static void iwl_mvm_ftm_rtt_smoothing(struct iwl_mvm *mvm, overshoot =IWL_MVM_FTM_INITIATOR_SMOOTH_OVERSHOOT ; alpha =IWL_MVM_FTM_INITIATOR_SMOOTH_ALPHA ; - rtt_avg = alpha * rtt + (100 - alpha) * resp->rtt_avg; -do_div (rtt_avg,100 ); + rtt_avg =div_s64 (alpha * rtt + (100 - alpha) * resp->rtt_avg,100 ); IWL_DEBUG_INFO(mvm, "%pM: prev rtt_avg=%lld, new rtt_avg=%lld, rtt=%lld\n",
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 368/846 bnxt_en: Refactor coredump functions
In reply to Greg Kroah-HartmanFrom: Edwin Peer <[email protected]>
[ Upstream commit 9a575c8c25ae2372112db6d6b3e553cd90e9f02b ]
The coredump functionality will be used by devlink health. Refactor these functions that get coredump and coredump length. There is no functional change, but the following checkpatch warnings were addressed:
- strscpy is preferred over strlcpy.
- sscanf results should be checked, with an additional warning.
--- .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 48 ++++++++++++------- 1 file changed, 31 insertions(+), 17 deletions(-)
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +31 -17
@@ -3803,7 +3803,7 @@ bnxt_fill_coredump_record(struct bnxt *bp, struct bnxt_coredump_record *record, record->low_version =0 ; record->high_version =1 ; record->asic_state =0 ; -strlcpy (record->system_name,utsname ()->nodename, +strscpy (record->system_name,utsname ()->nodename,sizeof (record->system_name)); record->year =cpu_to_le16 (tm.tm_year +1900 ); record->month =cpu_to_le16 (tm.tm_mon +1 );
@@ -3815,11 +3815,12 @@ bnxt_fill_coredump_record(struct bnxt *bp, struct bnxt_coredump_record *record,strcpy (record->commandline,"ethtool -w" ); record->total_segments =cpu_to_le32 (total_segs); -sscanf (utsname ()->release,"%u.%u" , &os_ver_major, &os_ver_minor); +if (sscanf (utsname ()->release,"%u.%u" , &os_ver_major, &os_ver_minor) !=2 ) +netdev_warn (bp->dev,"Unknown OS release in coredump\n" ); record->os_ver_major =cpu_to_le32 (os_ver_major); record->os_ver_minor =cpu_to_le32 (os_ver_minor); -strlcpy (record->os_name,utsname ()->sysname,32 ); +strscpy (record->os_name,utsname ()->sysname,sizeof (record->os_name));time64_to_tm (end,0 , &tm); record->end_year =cpu_to_le16 (tm.tm_year +1900 ); record->end_month =cpu_to_le16 (tm.tm_mon +1 );
@@ -3837,7 +3838,7 @@ bnxt_fill_coredump_record(struct bnxt *bp, struct bnxt_coredump_record *record, record->ioctl_high_version =0 ; } -static int bnxt_get_coredump (struct bnxt *bp,void *buf,u32 *dump_len) +static int __bnxt_get_coredump (struct bnxt *bp,void *buf,u32 *dump_len) {u32 ver_get_resp_len =sizeof (struct hwrm_ver_get_output );u32 offset =0 , seg_hdr_len, seg_record_len, buf_len =0 ;
@@ -3940,6 +3941,30 @@ err:return rc; } +static int bnxt_get_coredump (struct bnxt *bp,u16 dump_type,void *buf,u32 *dump_len) +{ +if (dump_type ==BNXT_DUMP_CRASH ) { +#ifdef CONFIG_TEE_BNXT_FW +return tee_bnxt_copy_coredump (buf,0 , *dump_len); +#else +return -EOPNOTSUPP ; +#endif + }else { +return __bnxt_get_coredump (bp, buf, dump_len); + } +} + +static u32 bnxt_get_coredump_length (struct bnxt *bp,u16 dump_type) +{ +u32 len =0 ; + +if (dump_type ==BNXT_DUMP_CRASH ) + len =BNXT_CRASH_DUMP_LEN ; +else +__bnxt_get_coredump (bp,NULL , &len); +return len; +} +static int bnxt_set_dump (struct net_device *dev,struct ethtool_dump *dump) {struct bnxt *bp =netdev_priv (dev);
@@ -3971,10 +3996,7 @@ static int bnxt_get_dump_flag(struct net_device *dev, struct ethtool_dump *dump) bp->ver_resp.hwrm_fw_rsvd_8b; dump->flag = bp->dump_flag; -if (bp->dump_flag ==BNXT_DUMP_CRASH ) - dump->len =BNXT_CRASH_DUMP_LEN ; -else -bnxt_get_coredump (bp,NULL , &dump->len); + dump->len =bnxt_get_coredump_length (bp, bp->dump_flag);return 0 ; }
@@ -3989,15 +4011,7 @@ static int bnxt_get_dump_data(struct net_device *dev, struct ethtool_dump *dump,memset (buf,0 , dump->len); dump->flag = bp->dump_flag; -if (dump->flag ==BNXT_DUMP_CRASH ) { -#ifdef CONFIG_TEE_BNXT_FW -return tee_bnxt_copy_coredump (buf,0 , dump->len); -#endif - }else { -return bnxt_get_coredump (bp, buf, &dump->len); - } - -return 0 ; +return bnxt_get_coredump (bp, dump->flag, buf, &dump->len); } static int bnxt_get_ts_info(struct net_device *dev,
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 369/846 bnxt_en: move coredump functions into dedicated file
In reply to Greg Kroah-HartmanFrom: Edwin Peer <[email protected]>
[ Upstream commit b032228e58ea2477955058ad4d70a636ce1dec51 ]
Change bnxt_get_coredump() and bnxt_get_coredump_length() to non-static functions.
--- drivers/net/ethernet/broadcom/bnxt/Makefile | 2 +- .../ethernet/broadcom/bnxt/bnxt_coredump.c | 372 ++++++++++++++++++ .../ethernet/broadcom/bnxt/bnxt_coredump.h | 51 +++ .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 356 ----------------- .../net/ethernet/broadcom/bnxt/bnxt_ethtool.h | 43 -- 5 files changed, 424 insertions(+), 400 deletions(-) create mode 100644 drivers/net/ethernet/broadcom/bnxt/bnxt_coredump.c
drivers/net/ethernet/broadcom/bnxt/Makefile +1 -1
@@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only obj-$(CONFIG_BNXT) += bnxt_en.o -bnxt_en-y := bnxt.o bnxt_hwrm.o bnxt_sriov.o bnxt_ethtool.o bnxt_dcb.o bnxt_ulp.o bnxt_xdp.o bnxt_ptp.o bnxt_vfr.o bnxt_devlink.o bnxt_dim.o +bnxt_en-y := bnxt.o bnxt_hwrm.o bnxt_sriov.o bnxt_ethtool.o bnxt_dcb.o bnxt_ulp.o bnxt_xdp.o bnxt_ptp.o bnxt_vfr.o bnxt_devlink.o bnxt_dim.o bnxt_coredump.o bnxt_en-$(CONFIG_BNXT_FLOWER_OFFLOAD) += bnxt_tc.o bnxt_en-$(CONFIG_DEBUG_FS) += bnxt_debugfs.o
drivers/net/ethernet/broadcom/bnxt/bnxt_coredump.c new file +372 -0
372 lines not on this page · raw message
drivers/net/ethernet/broadcom/bnxt/bnxt_coredump.h +51 -0
61 lines not on this page · raw message
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +0 -356
362 lines not on this page · raw message
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.h +0 -43
49 lines not on this page · raw message
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 370/846 bnxt_en: use firmware provided max timeout for messages
In reply to Greg Kroah-HartmanFrom: Edwin Peer <[email protected]>
[ Upstream commit bce9a0b7900836df223ab638090df0cb8430d9e8 ]
Some older devices cannot accommodate the 40 seconds timeout cap for long running commands (such as NVRAM commands) due to hardware limitations. Allow these devices to request more time for these long running commands, but print a warning, since the longer timeout may cause the hung task watchdog to trigger. In the case of a firmware update operation, this is preferable to failing outright.
v2: Use bp->hwrm_cmd_max_timeout directly without the constants.
--- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 ++++++ drivers/net/ethernet/broadcom/bnxt/bnxt.h | 3 ++- drivers/net/ethernet/broadcom/bnxt/bnxt_coredump.c | 4 ++-- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 9 +++------ drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.h | 3 +-- 6 files changed, 15 insertions(+), 12 deletions(-)
drivers/net/ethernet/broadcom/bnxt/bnxt.c +6 -0
@@ -8004,6 +8004,12 @@ static int bnxt_hwrm_ver_get(struct bnxt *bp) bp->hwrm_cmd_timeout =le16_to_cpu (resp->def_req_timeout);if (!bp->hwrm_cmd_timeout) bp->hwrm_cmd_timeout =DFLT_HWRM_CMD_TIMEOUT ; + bp->hwrm_cmd_max_timeout =le16_to_cpu (resp->max_req_timeout) *1000 ; +if (!bp->hwrm_cmd_max_timeout) + bp->hwrm_cmd_max_timeout =HWRM_CMD_MAX_TIMEOUT ; +else if (bp->hwrm_cmd_max_timeout >HWRM_CMD_MAX_TIMEOUT ) +netdev_warn (bp->dev,"Device requests max timeout of %d seconds, may trigger hung task watchdog\n" , + bp->hwrm_cmd_max_timeout /1000 );if (resp->hwrm_intf_maj_8b >=1 ) { bp->hwrm_max_req_len =le16_to_cpu (resp->max_req_win_len);
drivers/net/ethernet/broadcom/bnxt/bnxt.h +2 -1
@@ -1901,7 +1901,8 @@ struct bnxt {u16 hwrm_max_req_len;u16 hwrm_max_ext_req_len; -int hwrm_cmd_timeout; +unsigned int hwrm_cmd_timeout; +unsigned int hwrm_cmd_max_timeout;struct mutex hwrm_cmd_lock;/* serialize hwrm messages */ struct hwrm_ver_get_output ver_resp;#define FW_VER_STR_LEN 32
drivers/net/ethernet/broadcom/bnxt/bnxt_coredump.c +2 -2
@@ -32,7 +32,7 @@ static int bnxt_hwrm_dbg_dma_data(struct bnxt *bp, void *msg,return -ENOMEM ; } -hwrm_req_timeout (bp, msg,HWRM_COREDUMP_TIMEOUT ); +hwrm_req_timeout (bp, msg, bp->hwrm_cmd_max_timeout); cmn_resp =hwrm_req_hold (bp, msg); resp = cmn_resp;
@@ -125,7 +125,7 @@ static int bnxt_hwrm_dbg_coredump_initiate(struct bnxt *bp, u16 component_id,if (rc)return rc; -hwrm_req_timeout (bp, req,HWRM_COREDUMP_TIMEOUT ); +hwrm_req_timeout (bp, req, bp->hwrm_cmd_max_timeout); req->component_id =cpu_to_le16 (component_id); req->segment_id =cpu_to_le16 (segment_id);
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +3 -6
@@ -31,9 +31,6 @@#include "bnxt_nvm_defs.h" /* NVRAM content constant and structure defs */ #include "bnxt_fw_hdr.h" /* Firmware hdr constant and structure defs */ #include "bnxt_coredump.h" -#define FLASH_NVRAM_TIMEOUT ((HWRM_CMD_TIMEOUT) * 100) -#define FLASH_PACKAGE_TIMEOUT ((HWRM_CMD_TIMEOUT) * 200) -#define INSTALL_PACKAGE_TIMEOUT ((HWRM_CMD_TIMEOUT) * 200)static u32 bnxt_get_msglevel (struct net_device *dev) {
@@ -2167,7 +2164,7 @@ static int bnxt_flash_nvram(struct net_device *dev, u16 dir_type, req->host_src_addr =cpu_to_le64 (dma_handle); } -hwrm_req_timeout (bp, req,FLASH_NVRAM_TIMEOUT ); +hwrm_req_timeout (bp, req, bp->hwrm_cmd_max_timeout); req->dir_type =cpu_to_le16 (dir_type); req->dir_ordinal =cpu_to_le16 (dir_ordinal); req->dir_ext =cpu_to_le16 (dir_ext);
@@ -2508,8 +2505,8 @@ int bnxt_flash_package_from_fw_obj(struct net_device *dev, const struct firmwarereturn rc; } -hwrm_req_timeout (bp, modify,FLASH_PACKAGE_TIMEOUT ); -hwrm_req_timeout (bp, install,INSTALL_PACKAGE_TIMEOUT ); +hwrm_req_timeout (bp, modify, bp->hwrm_cmd_max_timeout); +hwrm_req_timeout (bp, install, bp->hwrm_cmd_max_timeout);hwrm_req_hold (bp, modify); modify->host_src_addr =cpu_to_le64 (dma_handle);
drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.c +1 -1
@@ -496,7 +496,7 @@ static int __hwrm_send(struct bnxt *bp, struct bnxt_hwrm_ctx *ctx) }/* Limit timeout to an upper limit */ - timeout =min_t (uint, ctx->timeout,HWRM_CMD_MAX_TIMEOUT ); + timeout =min (ctx->timeout, bp->hwrm_cmd_max_timeout ?:HWRM_CMD_MAX_TIMEOUT );/* convert timeout to usec */ timeout *=1000 ;
drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.h +1 -2
@@ -58,11 +58,10 @@ void hwrm_update_token(struct bnxt *bp, u16 seq, enum bnxt_hwrm_wait_state s);#define BNXT_HWRM_MAX_REQ_LEN (bp->hwrm_max_req_len)#define BNXT_HWRM_SHORT_REQ_LEN sizeof(struct hwrm_short_input) -#define HWRM_CMD_MAX_TIMEOUT 40000 +#define HWRM_CMD_MAX_TIMEOUT 40000U#define SHORT_HWRM_CMD_TIMEOUT 20#define HWRM_CMD_TIMEOUT (bp->hwrm_cmd_timeout)#define HWRM_RESET_TIMEOUT ((HWRM_CMD_TIMEOUT) * 4) -#define HWRM_COREDUMP_TIMEOUT ((HWRM_CMD_TIMEOUT) * 12)#define BNXT_HWRM_TARGET 0xffff#define BNXT_HWRM_NO_CMPL_RING -1#define BNXT_HWRM_REQ_MAX_SIZE 128
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 371/846 net: mcs7830: handle usb read errors properly
In reply to Greg Kroah-HartmanFrom: Pavel Skripkin <[email protected]>
[ Upstream commit d668769eb9c52b150753f1653f7f5a0aeb8239d2 ]
Syzbot reported uninit value in mcs7830_bind(). The problem was in missing validation check for bytes read via usbnet_read_cmd().
usbnet_read_cmd() internally calls usb_control_msg(), that returns number of bytes read. Code should validate that requested number of bytes was actually read.
So, this patch adds missing size validation check inside mcs7830_get_reg() to prevent uninit value bugs
--- drivers/net/usb/mcs7830.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
drivers/net/usb/mcs7830.c +10 -2
@@ -108,8 +108,16 @@ static const char driver_name[] = "MOSCHIP usb-ethernet driver";static int mcs7830_get_reg (struct usbnet *dev,u16 index,u16 size,void *data) { -return usbnet_read_cmd (dev,MCS7830_RD_BREQ ,MCS7830_RD_BMREQ , -0x0000 , index, data, size); +int ret; + + ret =usbnet_read_cmd (dev,MCS7830_RD_BREQ ,MCS7830_RD_BMREQ , +0x0000 , index, data, size); +if (ret <0 ) +return ret; +else if (ret < size) +return -ENODATA ; + +return ret; }static int mcs7830_set_reg (struct usbnet *dev,u16 index,u16 size,const void *data)
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 372/846 ext4: avoid trim error on fs with small groups
In reply to Greg Kroah-HartmanFrom: Jan Kara <[email protected]>
[ Upstream commit 173b6e383d2a204c9921ffc1eca3b87aa2106c33 ]
A user reported FITRIM ioctl failing for him on ext4 on some devices without apparent reason. After some debugging we've found out that these devices (being LVM volumes) report rather large discard granularity of 42MB and the filesystem had 1k blocksize and thus group size of 8MB. Because ext4 FITRIM implementation puts discard granularity into minlen, ext4_trim_fs() declared the trim request as invalid. However just silently doing nothing seems to be a more appropriate reaction to such combination of parameters since user did not specify anything wrong.
--- fs/ext4/ioctl.c | 2 -- fs/ext4/mballoc.c | 8 ++++++++ 2 files changed, 8 insertions(+), 2 deletions(-)
fs/ext4/ioctl.c +0 -2
@@ -1117,8 +1117,6 @@ resizefs_out: sizeof(range)))return -EFAULT ; - range.minlen =max ((unsigned int )range.minlen, - q->limits.discard_granularity); ret =ext4_trim_fs (sb, &range);if (ret <0 )return ret;
fs/ext4/mballoc.c +8 -0
@@ -6405,6 +6405,7 @@ ext4_trim_all_free(struct super_block *sb, ext4_group_t group,*/ int ext4_trim_fs (struct super_block *sb,struct fstrim_range *range) { +struct request_queue *q =bdev_get_queue (sb->s_bdev);struct ext4_group_info *grp;ext4_group_t group, first_group, last_group;ext4_grpblk_t cnt =0 , first_cluster, last_cluster;
@@ -6423,6 +6424,13 @@ int ext4_trim_fs(struct super_block *sb, struct fstrim_range *range) start >= max_blks || range->len < sb->s_blocksize) return -EINVAL; +/* No point to try to trim less than discard granularity */ +if (range->minlen < q->limits.discard_granularity) { + minlen =EXT4_NUM_B2C (EXT4_SB (sb), + q->limits.discard_granularity >> sb->s_blocksize_bits); +if (minlen >EXT4_CLUSTERS_PER_GROUP (sb)) + goto out; + }if (end >= max_blks) end = max_blks -1 ;if (end <= first_data_blk)
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 373/846 ASoC: Intel: sof_sdw: fix jack detection on HP Spectre x360 convertible
In reply to Greg Kroah-HartmanFrom: Pierre-Louis Bossart <[email protected]>
[ Upstream commit 0527b19fa4f390a6054612e1fa1dd4f8efc96739 ]
Tests on device show the JD2 mode does not work at all, the 'Headphone Jack' and 'Headset Mic Jack' are shown as 'on' always.
JD1 seems to be the better option, with at least a change between the two cases.
Jack not plugged-in:
[root@fedora ~]# amixer -Dhw:0 cget numid=12
numid=12,iface=CARD,name='Headphone Jack'
; type=BOOLEAN,access=r-------,values=1
: values=off
[root@fedora ~]# amixer -Dhw:0 cget numid=13
numid=13,iface=CARD,name='Headset Mic Jack'
; type=BOOLEAN,access=r-------,values=1
: values=off
Jack plugged-in:
[root@fedora ~]# amixer -Dhw:0 cget numid=13
numid=13,iface=CARD,name='Headset Mic Jack'
; type=BOOLEAN,access=r-------,values=1
: values=on
[root@fedora ~]# amixer -Dhw:0 cget numid=13
numid=13,iface=CARD,name='Headset Mic Jack'
; type=BOOLEAN,access=r-------,values=1
: values=on
The 'Headset Mic Jack' is updated with a delay which seems normal with additional calibration needed.
--- sound/soc/intel/boards/sof_sdw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/intel/boards/sof_sdw.c +1 -1
@@ -188,7 +188,7 @@ static const struct dmi_system_id sof_sdw_quirk_table[] = { }, .driver_data = (void *)(SOF_SDW_TGL_HDMI | SOF_SDW_PCH_DMIC | - RT711_JD2), + RT711_JD1), }, {/* NUC15 'Bishop County' LAPBC510 and LAPBC710 skews */
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 374/846 ALSA: jack: Add missing rwsem around snd_ctl_remove() calls
In reply to Greg Kroah-HartmanFrom: Takashi Iwai <[email protected]>
[ Upstream commit 06764dc931848c3a9bc01a63bbf76a605408bb54 ]
snd_ctl_remove() has to be called with card->controls_rwsem held (when called after the card instantiation). This patch add the missing rwsem calls around it.
--- sound/core/jack.c | 3 +++ 1 file changed, 3 insertions(+)
sound/core/jack.c +3 -0
@@ -62,10 +62,13 @@ static int snd_jack_dev_free(struct snd_device *device)struct snd_card *card = device->card;struct snd_jack_kctl *jack_kctl, *tmp_jack_kctl; +down_write (&card->controls_rwsem);list_for_each_entry_safe (jack_kctl, tmp_jack_kctl, &jack->kctl_list, list) {list_del_init (&jack_kctl->list);snd_ctl_remove (card, jack_kctl->kctl); } +up_write (&card->controls_rwsem); +if (jack->private_free) jack->private_free (jack);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 375/846 ALSA: PCM: Add missing rwsem around snd_ctl_remove() calls
In reply to Greg Kroah-HartmanFrom: Takashi Iwai <[email protected]>
[ Upstream commit 5471e9762e1af4b7df057a96bfd46cc250979b88 ]
snd_ctl_remove() has to be called with card->controls_rwsem held (when called after the card instantiation). This patch add the missing rwsem calls around it.
--- sound/core/pcm.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
sound/core/pcm.c +5 -1
@@ -810,7 +810,11 @@ EXPORT_SYMBOL(snd_pcm_new_internal);static void free_chmap (struct snd_pcm_str *pstr) {if (pstr->chmap_kctl) { -snd_ctl_remove (pstr->pcm->card, pstr->chmap_kctl); +struct snd_card *card = pstr->pcm->card; + +down_write (&card->controls_rwsem); +snd_ctl_remove (card, pstr->chmap_kctl); +up_write (&card->controls_rwsem); pstr->chmap_kctl =NULL ; } }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 376/846 ALSA: hda: Add missing rwsem around snd_ctl_remove() calls
In reply to Greg Kroah-HartmanFrom: Takashi Iwai <[email protected]>
[ Upstream commit 80bd64af75b4bb11c0329bc66c35da2ddfb66d88 ]
snd_ctl_remove() has to be called with card->controls_rwsem held (when called after the card instantiation). This patch add the missing rwsem calls around it.
--- sound/pci/hda/hda_codec.c | 3 +++ 1 file changed, 3 insertions(+)
sound/pci/hda/hda_codec.c +3 -0
@@ -1727,8 +1727,11 @@ void snd_hda_ctls_clear(struct hda_codec *codec) {int i;struct hda_nid_item *items = codec->mixers.list; + +down_write (&codec->card->controls_rwsem);for (i =0 ; i < codec->mixers.used; i++)snd_ctl_remove (codec->card, items[i].kctl); +up_write (&codec->card->controls_rwsem);snd_array_free (&codec->mixers);snd_array_free (&codec->nids); }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 377/846 ALSA: hda: Fix potential deadlock at codec unbinding
In reply to Greg Kroah-HartmanFrom: Takashi Iwai <[email protected]>
[ Upstream commit 7206998f578d5553989bc01ea2e544b622e79539 ]
When a codec is unbound dynamically via sysfs while its stream is in use, we may face a potential deadlock at the proc remove or a UAF. This happens since the hda_pcm is managed by a linked list, as it handles the hda_pcm object release via kref.
When a PCM is opened at the unbinding time, the release of hda_pcm gets delayed and it ends up with the close of the PCM stream releasing the associated hda_pcm object of its own. The hda_pcm destructor contains the PCM device release that includes the removal of procfs entries. And, this removal has the sync of the close of all in-use files -- which would never finish because it's called from the PCM file descriptor itself, i.e. it's trying to shoot its foot.
For addressing the deadlock above, this patch changes the way to manage and release the hda_pcm object. The kref of hda_pcm is dropped, and instead a simple refcount is introduced in hda_codec for keeping the track of the active PCM streams, and at each PCM open and close, this refcount is adjusted accordingly. At unbinding, the driver calls snd_device_disconnect() for each PCM stream, then synchronizes with the refcount finish, and finally releases the object resources.
--- include/sound/hda_codec.h | 8 +++++--- sound/pci/hda/hda_bind.c | 5 +++++ sound/pci/hda/hda_codec.c | 42 ++++++++++++++++++++++++--------------- sound/pci/hda/hda_local.h | 1 + 4 files changed, 37 insertions(+), 19 deletions(-)
include/sound/hda_codec.h +5 -3
@@ -8,7 +8,7 @@#ifndef __SOUND_HDA_CODEC_H#define __SOUND_HDA_CODEC_H -#include <linux/kref.h> +#include <linux/refcount.h> #include <linux/mod_devicetable.h> #include <sound/info.h> #include <sound/control.h>
@@ -166,8 +166,8 @@ struct hda_pcm {bool own_chmap;/* codec driver provides own channel maps */ /* private: */ struct hda_codec *codec; -struct kref kref;struct list_head list; + unsigned int disconnected:1; };/* codec information */
@@ -187,6 +187,8 @@ struct hda_codec {/* PCM to create, set by patch_ops.build_pcms callback */ struct list_head pcm_list_head; +refcount_t pcm_ref; +wait_queue_head_t remove_sleep;/* codec specific info */ void *spec;
@@ -420,7 +422,7 @@ void snd_hda_codec_cleanup_for_unbind(struct hda_codec *codec);static inline void snd_hda_codec_pcm_get (struct hda_pcm *pcm) { -kref_get (&pcm->kref); +refcount_inc (&pcm->codec->pcm_ref); }void snd_hda_codec_pcm_put (struct hda_pcm *pcm);
sound/pci/hda/hda_bind.c +5 -0
@@ -156,6 +156,11 @@ static int hda_codec_driver_remove(struct device *dev)return codec->bus->core.ext_ops->hdev_detach (&codec->core); } +refcount_dec (&codec->pcm_ref); +snd_hda_codec_disconnect_pcms (codec); +wait_event (codec->remove_sleep, !refcount_read (&codec->pcm_ref)); +snd_power_sync_ref (codec->bus->card); +if (codec->patch_ops.free) codec->patch_ops.free (codec);snd_hda_codec_cleanup_for_unbind (codec);
sound/pci/hda/hda_codec.c +26 -16
92 lines not on this page · raw message
sound/pci/hda/hda_local.h +1 -0
@@ -137,6 +137,7 @@ int __snd_hda_add_vmaster(struct hda_codec *codec, char *name,int snd_hda_codec_reset (struct hda_codec *codec);void snd_hda_codec_register (struct hda_codec *codec);void snd_hda_codec_cleanup_for_unbind (struct hda_codec *codec); +void snd_hda_codec_disconnect_pcms (struct hda_codec *codec);#define snd_hda_regmap_sync (codec) snd_hdac_regmap_sync(&(codec)->core)
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 378/846 RDMA/bnxt_re: Scan the whole bitmap when checking if "disabling RCFW with pending cmd-bit"
In reply to Greg Kroah-HartmanFrom: Christophe JAILLET <[email protected]>
[ Upstream commit a917dfb66c0a1fa1caacf3d71edcafcab48e6ff0 ]
The 'cmdq->cmdq_bitmap' bitmap is 'rcfw->cmdq_depth' bits long. The size stored in 'cmdq->bmap_size' is the size of the bitmap in bytes.
Remove this erroneous 'bmap_size' and use 'rcfw->cmdq_depth' directly in 'bnxt_qplib_disable_rcfw_channel()'. Otherwise some error messages may be missing.
Other uses of 'cmdq_bitmap' already take into account 'rcfw->cmdq_depth' directly.
--- drivers/infiniband/hw/bnxt_re/qplib_rcfw.c | 6 ++---- drivers/infiniband/hw/bnxt_re/qplib_rcfw.h | 1 - 2 files changed, 2 insertions(+), 5 deletions(-)
drivers/infiniband/hw/bnxt_re/qplib_rcfw.c +2 -4
@@ -618,8 +618,6 @@ int bnxt_qplib_alloc_rcfw_channel(struct bnxt_qplib_res *res,if (!cmdq->cmdq_bitmap) goto fail; - cmdq->bmap_size = bmap_size; -/* Allocate one extra to hold the QP1 entries */ rcfw->qp_tbl_size = qp_tbl_sz +1 ; rcfw->qp_tbl = kcalloc(rcfw->qp_tbl_size, sizeof(struct bnxt_qplib_qp_node),
@@ -667,8 +665,8 @@ void bnxt_qplib_disable_rcfw_channel(struct bnxt_qplib_rcfw *rcfw)iounmap (cmdq->cmdq_mbox.reg.bar_reg);iounmap (creq->creq_db.reg.bar_reg); - indx =find_first_bit (cmdq->cmdq_bitmap, cmdq->bmap_size); -if (indx != cmdq->bmap_size) + indx =find_first_bit (cmdq->cmdq_bitmap, rcfw->cmdq_depth); +if (indx != rcfw->cmdq_depth)dev_err (&rcfw->pdev->dev,"disabling RCFW with pending cmd-bit %lx\n" , indx);
drivers/infiniband/hw/bnxt_re/qplib_rcfw.h +0 -1
@@ -152,7 +152,6 @@ struct bnxt_qplib_cmdq_ctx {wait_queue_head_t waitq;unsigned long flags;unsigned long *cmdq_bitmap; -u32 bmap_size;u32 seq_num; };
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 379/846 RDMA/hns: Validate the pkey index
In reply to Greg Kroah-HartmanFrom: Kamal Heib <[email protected]>
[ Upstream commit 2a67fcfa0db6b4075515bd23497750849b88850f ]
Before query pkey, make sure that the queried index is valid.
--- drivers/infiniband/hw/hns/hns_roce_main.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/infiniband/hw/hns/hns_roce_main.c +3 -0
@@ -269,6 +269,9 @@ static enum rdma_link_layer hns_roce_get_link_layer(struct ib_device *device,static int hns_roce_query_pkey (struct ib_device *ib_dev,u32 port,u16 index,u16 *pkey) { +if (index >0 ) +return -EINVAL ; + *pkey =PKEY_ID ;return 0 ;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 380/846 scsi: pm80xx: Update WARN_ON check in pm8001_mpi_build_cmd()
In reply to Greg Kroah-HartmanFrom: Igor Pylypiv <[email protected]>
[ Upstream commit 606c54ae975ad3af540b505b46b55a687501711f ]
Starting from commit 05c6c029a44d ("scsi: pm80xx: Increase number of supported queues") driver initializes only max_q_num queues. Do not use an invalid queue if the WARN_ON condition is true.
--- drivers/scsi/pm8001/pm8001_hwi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/scsi/pm8001/pm8001_hwi.c +3 -1
@@ -1325,7 +1325,9 @@ int pm8001_mpi_build_cmd(struct pm8001_hba_info *pm8001_ha,int q_index = circularQ - pm8001_ha->inbnd_q_tbl;int rv; -WARN_ON (q_index >=PM8001_MAX_INB_NUM ); +if (WARN_ON (q_index >= pm8001_ha->max_q_num)) +return -EINVAL ; +spin_lock_irqsave (&circularQ->iq_lock, flags); rv =pm8001_mpi_msg_free_get (circularQ, pm8001_ha->iomb_size, &pMessage);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 381/846 clk: renesas: rzg2l: Check return value of pm_genpd_init()
In reply to Greg Kroah-HartmanFrom: Lad Prabhakar <[email protected]>
[ Upstream commit 27527a3d3b162e4512798c058c0e8a216c721187 ]
Make sure we check the return value of pm_genpd_init() which might fail. Also add a devres action to remove the power-domain in-case the probe callback fails further down in the code flow.
--- drivers/clk/renesas/rzg2l-cpg.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
drivers/clk/renesas/rzg2l-cpg.c +13 -1
@@ -638,10 +638,16 @@ static void rzg2l_cpg_detach_dev(struct generic_pm_domain *unused, struct devicepm_clk_destroy (dev); } +static void rzg2l_cpg_genpd_remove (void *data) +{ +pm_genpd_remove (data); +} +static int __init rzg2l_cpg_add_clk_domain (struct device *dev) {struct device_node *np = dev->of_node;struct generic_pm_domain *genpd; +int ret; genpd =devm_kzalloc (dev,sizeof (*genpd),GFP_KERNEL );if (!genpd)
@@ -652,7 +658,13 @@ static int __init rzg2l_cpg_add_clk_domain(struct device *dev)GENPD_FLAG_ACTIVE_WAKEUP ; genpd->attach_dev = rzg2l_cpg_attach_dev; genpd->detach_dev = rzg2l_cpg_detach_dev; -pm_genpd_init (genpd, &pm_domain_always_on_gov, false); + ret =pm_genpd_init (genpd, &pm_domain_always_on_gov, false); +if (ret) +return ret; + + ret =devm_add_action_or_reset (dev, rzg2l_cpg_genpd_remove, genpd); +if (ret) +return ret;of_genpd_add_provider_simple (np, genpd);return 0 ;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 382/846 clk: renesas: rzg2l: propagate return value of_genpd_add_provider_simple()
In reply to Greg Kroah-HartmanFrom: Lad Prabhakar <[email protected]>
[ Upstream commit 33748744f15a110a233b6ae0380f476006e770f0 ]
of_genpd_add_provider_simple() might fail, this patch makes sure we check the return value of of_genpd_add_provider_simple() by propagating the return value to the caller of rzg2l_cpg_add_clk_domain().
--- drivers/clk/renesas/rzg2l-cpg.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/clk/renesas/rzg2l-cpg.c +1 -2
@@ -666,8 +666,7 @@ static int __init rzg2l_cpg_add_clk_domain(struct device *dev)if (ret)return ret; -of_genpd_add_provider_simple (np, genpd); -return 0 ; +return of_genpd_add_provider_simple (np, genpd); }static int __init rzg2l_cpg_probe (struct platform_device *pdev)
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 383/846 clk: imx8mn: Fix imx8mn_clko1_sels
In reply to Greg Kroah-HartmanFrom: Adam Ford <[email protected]>
[ Upstream commit 570727e9acfac1c2330a01dd5e1272e9c3acec08 ]
When attempting to use sys_pll1_80m as the parent for clko1, the system hangs. This is due to the fact that the source select for sys_pll1_80m was incorrectly pointing to m7_alt_pll_clk, which doesn't yet exist.
According to Rev 3 of the TRM, The imx8mn_clko1_sels also incorrectly references an osc_27m which does not exist, nor does an entry for source select bits 010b. Fix both by inserting a dummy clock into the missing space in the table and renaming the incorrectly name clock with dummy.
--- drivers/clk/imx/clk-imx8mn.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/clk/imx/clk-imx8mn.c +3 -3
@@ -277,9 +277,9 @@ static const char * const imx8mn_pdm_sels[] = {"osc_24m", "sys_pll2_100m", "audistatic const char *const imx8mn_dram_core_sels[] = {"dram_pll_out" ,"dram_alt_root" , }; -static const char *const imx8mn_clko1_sels[] = {"osc_24m" ,"sys_pll1_800m" ,"osc_27m" , -"sys_pll1_200m" ,"audio_pll2_out" ,"vpu_pll" , -"sys_pll1_80m" , }; +static const char *const imx8mn_clko1_sels[] = {"osc_24m" ,"sys_pll1_800m" ,"dummy" , +"sys_pll1_200m" ,"audio_pll2_out" ,"sys_pll2_500m" , +"dummy" ,"sys_pll1_80m" , };static const char *const imx8mn_clko2_sels[] = {"osc_24m" ,"sys_pll2_200m" ,"sys_pll1_400m" ,"sys_pll2_166m" ,"sys_pll3_out" ,"audio_pll1_out" ,"video_pll1_out" ,"osc_32k" , };
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 384/846 powerpc/prom_init: Fix improper check of prom_getprop()
In reply to Greg Kroah-HartmanFrom: Peiwei Hu <[email protected]>
[ Upstream commit 869fb7e5aecbc163003f93f36dcc26d0554319f6 ]
prom_getprop() can return PROM_ERROR. Binary operator can not identify it.
--- arch/powerpc/kernel/prom_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/kernel/prom_init.c +1 -1
@@ -2991,7 +2991,7 @@ static void __init fixup_device_tree_efika_add_phy(void)/* Check if the phy-handle property exists - bail if it does */ rv =prom_getprop (node,"phy-handle" , prop,sizeof (prop)); -if (!rv) +if (rv <=0 )return ;/*
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 385/846 ASoC: uniphier: drop selecting non-existing SND_SOC_UNIPHIER_AIO_DMA
In reply to Greg Kroah-HartmanFrom: Lukas Bulwahn <[email protected]>
[ Upstream commit 49f893253ab43566e34332a969324531fea463f6 ]
Commit f37fe2f9987b ("ASoC: uniphier: add support for UniPhier AIO common driver") adds configs SND_SOC_UNIPHIER_{LD11,PXS2}, which select the non-existing config SND_SOC_UNIPHIER_AIO_DMA.
Hence, ./scripts/checkkconfigsymbols.py warns:
SND_SOC_UNIPHIER_AIO_DMA
Referencing files: sound/soc/uniphier/Kconfig
Probably, there is actually no further config intended to be selected here. So, just drop selecting the non-existing config.
--- sound/soc/uniphier/Kconfig | 2 -- 1 file changed, 2 deletions(-)
sound/soc/uniphier/Kconfig +0 -2
@@ -23,7 +23,6 @@ config SND_SOC_UNIPHIER_LD11 tristate "UniPhier LD11/LD20 Device Driver" depends on SND_SOC_UNIPHIER select SND_SOC_UNIPHIER_AIO - select SND_SOC_UNIPHIER_AIO_DMA help This adds ASoC driver for Socionext UniPhier LD11/LD20 input and output that can be used with other codecs.
@@ -34,7 +33,6 @@ config SND_SOC_UNIPHIER_PXS2 tristate "UniPhier PXs2 Device Driver" depends on SND_SOC_UNIPHIER select SND_SOC_UNIPHIER_AIO - select SND_SOC_UNIPHIER_AIO_DMA help This adds ASoC driver for Socionext UniPhier PXs2 input and output that can be used with other codecs.
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 386/846 ASoC: codecs: wcd938x: add SND_SOC_WCD938_SDW to codec list instead
In reply to Greg Kroah-HartmanFrom: Lukas Bulwahn <[email protected]>
[ Upstream commit 2039cc1da4bee1fd0df644e26b28ed769cd32a81 ]
Commit 045442228868 ("ASoC: codecs: wcd938x: add audio routing and Kconfig") adds SND_SOC_WCD937X, which does not exist, and SND_SOC_WCD938X, which seems not really to be the intended config to be selected, but only a supporting config symbol to the actual config SND_SOC_WCD938X_SDW for the codec.
Add SND_SOC_WCD938_SDW to the list instead of SND_SOC_WCD93{7,8}X.
The issue was identified with ./scripts/checkkconfigsymbols.py.
--- sound/soc/codecs/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
sound/soc/codecs/Kconfig +1 -2
@@ -235,8 +235,7 @@ config SND_SOC_ALL_CODECS imply SND_SOC_UDA1380 imply SND_SOC_WCD9335 imply SND_SOC_WCD934X - imply SND_SOC_WCD937X - imply SND_SOC_WCD938X + imply SND_SOC_WCD938X_SDW imply SND_SOC_LPASS_RX_MACRO imply SND_SOC_LPASS_TX_MACRO imply SND_SOC_WL1273
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 387/846 RDMA/rtrs-clt: Fix the initial value of min_latency
In reply to Greg Kroah-HartmanFrom: Jack Wang <[email protected]>
[ Upstream commit 925cac6358677d3d64f9b25f205eeb3d31c9f7f8 ]
The type of min_latency is ktime_t, so use KTIME_MAX to initialize the initial value.
--- drivers/infiniband/ulp/rtrs/rtrs-clt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/ulp/rtrs/rtrs-clt.c +1 -1
@@ -867,7 +867,7 @@ static struct rtrs_clt_sess *get_next_path_min_latency(struct path_it *it)struct rtrs_clt_sess *min_path =NULL ;struct rtrs_clt *clt = it->clt;struct rtrs_clt_sess *sess; -ktime_t min_latency =INT_MAX ; +ktime_t min_latency =KTIME_MAX ;ktime_t latency;list_for_each_entry_rcu (sess, &clt->paths_list, s.entry) {
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 388/846 ALSA: hda: Make proper use of timecounter
In reply to Greg Kroah-HartmanFrom: Thomas Gleixner <[email protected]>
[ Upstream commit 6dd21ad81bf96478db3403b1bbe251c0612d0431 ]
HDA uses a timecounter to read a hardware clock running at 24 MHz. The conversion factor is set with a mult value of 125 and a shift value of 0, which is not converting the hardware clock to nanoseconds, it is converting to 1/3 nanoseconds because the conversion factor from 24Mhz to nanoseconds is 125/3. The usage sites divide the "nanoseconds" value returned by timecounter_read() by 3 to get a real nanoseconds value.
There is a lengthy comment in azx_timecounter_init() explaining this choice. That comment makes blatantly wrong assumptions about how timecounters work and what can overflow.
The comment says:
* Applying the 1/3 factor as part of the multiplication
* requires at least 20 bits for a decent precision, however
* overflows occur after about 4 hours or less, not a option.
timecounters operate on time deltas between two readouts of a clock and use the mult/shift pair to calculate a precise nanoseconds value:
delta_nsec = (delta_clock * mult) >> shift;
The fractional part is also taken into account and preserved to prevent accumulated rounding errors. For details see cyclecounter_cyc2ns().
The mult/shift pair has to be chosen so that the multiplication of the maximum expected delta value does not result in a 64bit overflow. As the counter wraps around on 32bit, the maximum observable delta between two reads is (1 << 32) - 1 which is about 178.9 seconds.
That in turn means the maximum multiplication factor which fits into an u32 will not cause a 64bit overflow ever because it's guaranteed that:
((1 << 32) - 1) ^ 2 < (1 << 64)
The resulting correct multiplication factor is 2796202667 and the shift value is 26, i.e. 26 bit precision. The overflow of the multiplication would happen exactly at a clock readout delta of 6597069765 which is way after the wrap around of the hardware clock at around 274.8 seconds which is off from the claimed 4 hours by more than an order of magnitude.
If the counter ever wraps around the last read value then the calculation is off by the number of wrap arounds times 178.9 seconds because the overflow cannot be observed.
Use clocks_calc_mult_shift(), which calculates the most accurate mult/shift pair based on the given clock frequency, and remove the bogus comment along with the divisions at the readout sites.
--- sound/hda/hdac_stream.c | 14 ++++---------- sound/pci/hda/hda_controller.c | 1 - sound/soc/intel/skylake/skl-pcm.c | 1 - 3 files changed, 4 insertions(+), 12 deletions(-)
sound/hda/hdac_stream.c +4 -10
@@ -534,17 +534,11 @@ static void azx_timecounter_init(struct hdac_stream *azx_dev, cc->mask =CLOCKSOURCE_MASK (32 );/* -* Converting from 24 MHz to ns means applying a 125/3 factor. -* To avoid any saturation issues in intermediate operations, -* the 125 factor is applied first. The division is applied -* last after reading the timecounter value. -* Applying the 1/3 factor as part of the multiplication -* requires at least 20 bits for a decent precision, however -* overflows occur after about 4 hours or less, not a option. +* Calculate the optimal mult/shift values. The counter wraps +* around after ~178.9 seconds. */ - - cc->mult =125 ;/* saturation after 195 years */ - cc->shift =0 ; +clocks_calc_mult_shift (&cc->mult, &cc->shift,24000000 , +NSEC_PER_SEC ,178 ); nsec =0 ;/* audio time is elapsed time since trigger */ timecounter_init (tc, cc, nsec);
sound/pci/hda/hda_controller.c +0 -1
@@ -504,7 +504,6 @@ static int azx_get_time_info(struct snd_pcm_substream *substream,snd_pcm_gettime (substream->runtime, system_ts); nsec =timecounter_read (&azx_dev->core.tc); - nsec =div_u64 (nsec,3 );/* can be optimized */ if (audio_tstamp_config->report_delay) nsec =azx_adjust_codec_delay (substream, nsec);
sound/soc/intel/skylake/skl-pcm.c +0 -1
@@ -1251,7 +1251,6 @@ static int skl_platform_soc_get_time_info(snd_pcm_gettime (substream->runtime, system_ts); nsec =timecounter_read (&hstr->tc); - nsec =div_u64 (nsec,3 );/* can be optimized */ if (audio_tstamp_config->report_delay) nsec =skl_adjust_codec_delay (substream, nsec);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 389/846 dt-bindings: thermal: Fix definition of cooling-maps contribution property
In reply to Greg Kroah-HartmanFrom: Niklas Söderlund <[email protected]>
[ Upstream commit 49bcb1506f2e095262c01bda7fd1c0db524c91e2 ]
When converting the thermal-zones bindings to yaml the definition of the contribution property changed. The intention is the same, an integer value expressing a ratio of a sum on how much cooling is provided by the device to the zone. But after the conversion the integer value is limited to the range 0 to 100 and expressed as a percentage.
This is problematic for two reasons.
- This do not match how the binding is used. Out of the 18 files that make use of the property only two (ste-dbx5x0.dtsi and ste-hrefv60plus.dtsi) sets it at a value that satisfy the binding,
100. The remaining 16 files set the value higher and fail to validate.
- Expressing the value as a percentage instead of a ratio of the sum is confusing as there is nothing to enforce the sum in the zone is not greater then 100.
This patch restore the pre yaml conversion description and removes the value limitation allowing the usage of the bindings to validate.
--- .../devicetree/bindings/thermal/thermal-zones.yaml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
Documentation/devicetree/bindings/thermal/thermal-zones.yaml +4 -5
@@ -199,12 +199,11 @@ patternProperties: contribution: $ref: /schemas/types.yaml#/definitions/uint32 - minimum: 0 - maximum: 100 description: - The percentage contribution of the cooling devices at the - specific trip temperature referenced in this map - to this thermal zone + The cooling contribution to the thermal zone of the referred + cooling device at the referred trip point. The contribution is + a ratio of the sum of all cooling contributions within a + thermal zone. required: - trip
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 390/846 powerpc/perf: Fix PMU callbacks to clear pending PMI before resetting an overflown PMC
In reply to Greg Kroah-HartmanFrom: Athira Rajeev <[email protected]>
[ Upstream commit 2c9ac51b850d84ee496b0a5d832ce66d411ae552 ]
Running perf fuzzer showed below in dmesg logs:
"Can't find PMC that caused IRQ"
This means a PMU exception happened, but none of the PMC's (Performance Monitor Counter) were found to be overflown. There are some corner cases that clears the PMCs after PMI gets masked. In such cases, the perf interrupt handler will not find the active PMC values that had caused the overflow and thus leads to this message while replaying.
Case 1: PMU Interrupt happens during replay of other interrupts and counter values gets cleared by PMU callbacks before replay:
During replay of interrupts like timer, __do_irq() and doorbell exception, we conditionally enable interrupts via may_hard_irq_enable(). This could potentially create a window to generate a PMI. Since irq soft mask is set to ALL_DISABLED, the PMI will get masked here. We could get IPIs run before perf interrupt is replayed and the PMU events could be deleted or stopped. This will change the PMU SPR values and resets the counters. Snippet of ftrace log showing PMU callbacks invoked in __do_irq():
<idle>-0 [051] dns. 132025441306354: __do_irq <-call_do_irq
<idle>-0 [051] dns. 132025441306430: irq_enter <-__do_irq
<idle>-0 [051] dns. 132025441306503: irq_enter_rcu <-__do_irq
<idle>-0 [051] dnH. 132025441306599: xive_get_irq <-__do_irq
<<>>
<idle>-0 [051] dnH. 132025441307770: generic_smp_call_function_single_interrupt <-smp_ipi_demux_relaxed <idle>-0 [051] dnH. 132025441307839: flush_smp_call_function_queue <-smp_ipi_demux_relaxed <idle>-0 [051] dnH. 132025441308057: _raw_spin_lock <-event_function
<idle>-0 [051] dnH. 132025441308206: power_pmu_disable <-perf_pmu_disable
<idle>-0 [051] dnH. 132025441308337: power_pmu_del <-event_sched_out
<idle>-0 [051] dnH. 132025441308407: power_pmu_read <-power_pmu_del
<idle>-0 [051] dnH. 132025441308477: read_pmc <-power_pmu_read
<idle>-0 [051] dnH. 132025441308590: isa207_disable_pmc <-power_pmu_del
<idle>-0 [051] dnH. 132025441308663: write_pmc <-power_pmu_del
<idle>-0 [051] dnH. 132025441308787: power_pmu_event_idx <-perf_event_update_userpage <idle>-0 [051] dnH. 132025441308859: rcu_read_unlock_strict <-perf_event_update_userpage <idle>-0 [051] dnH. 132025441308975: power_pmu_enable <-perf_pmu_enable
<<>>
<idle>-0 [051] dnH. 132025441311108: irq_exit <-__do_irq
<idle>-0 [051] dns. 132025441311319: performance_monitor_exception <-replay_soft_interrupts
Case 2: PMI's masked during local_* operations, example local_add(). If the local_add() operation happens within a local_irq_save(), replay of PMI will be during local_irq_restore(). Similar to case 1, this could also create a window before replay where PMU events gets deleted or stopped.
Fix it by updating the PMU callback function power_pmu_disable() to check for pending perf interrupt. If there is an overflown PMC and pending perf interrupt indicated in paca, clear the PMI bit in paca to drop that sample. Clearing of PMI bit is done in power_pmu_disable() since disable is invoked before any event gets deleted/stopped. With this fix, if there are more than one event running in the PMU, there is a chance that we clear the PMI bit for the event which is not getting deleted/stopped. The other events may still remain active. Hence to make sure we don't drop valid sample in such cases, another check is added in power_pmu_enable. This checks if there is an overflown PMC found among the active events and if so enable back the PMI bit. Two new helper functions are introduced to clear/set the PMI, ie clear_pmi_irq_pending() and set_pmi_irq_pending(). Helper function pmi_irq_pending() is introduced to give a warning if there is pending PMI bit in paca, but no PMC is overflown.
Also there are corner cases which result in performance monitor interrupts being triggered during power_pmu_disable(). This happens since PMXE bit is not cleared along with disabling of other MMCR0 bits in the pmu_disable. Such PMI's could leave the PMU running and could trigger PMI again which will set MMCR0 PMAO bit. This could lead to spurious interrupts in some corner cases. Example, a timer after power_pmu_del() which will re-enable interrupts and triggers a PMI again since PMAO bit is still set. But fails to find valid overflow since PMC was cleared in power_pmu_del(). Fix that by disabling PMXE along with disabling of other MMCR0 bits in power_pmu_disable().
We can't just replay PMI any time. Hence this approach is preferred rather than replaying PMI before resetting overflown PMC. Patch also documents core-book3s on a race condition which can trigger these PMC messages during idle path in PowerNV.
--- arch/powerpc/include/asm/hw_irq.h | 40 +++++++++++++++++++++ arch/powerpc/perf/core-book3s.c | 58 ++++++++++++++++++++++++++++++- 2 files changed, 97 insertions(+), 1 deletion(-)
arch/powerpc/include/asm/hw_irq.h +40 -0
@@ -224,6 +224,42 @@ static inline bool arch_irqs_disabled(void)return arch_irqs_disabled_flags (arch_local_save_flags ()); } +static inline void set_pmi_irq_pending (void ) +{ +/* +* Invoked from PMU callback functions to set PMI bit in the paca. +* This has to be called with irq's disabled (via hard_irq_disable()). +*/ +if (IS_ENABLED (CONFIG_PPC_IRQ_SOFT_MASK_DEBUG )) +WARN_ON_ONCE (mfmsr () &MSR_EE ); + +get_paca ()->irq_happened |=PACA_IRQ_PMI ; +} + +static inline void clear_pmi_irq_pending (void ) +{ +/* +* Invoked from PMU callback functions to clear the pending PMI bit +* in the paca. +*/ +if (IS_ENABLED (CONFIG_PPC_IRQ_SOFT_MASK_DEBUG )) +WARN_ON_ONCE (mfmsr () &MSR_EE ); + +get_paca ()->irq_happened &= ~PACA_IRQ_PMI ; +} + +static inline bool pmi_irq_pending (void ) +{ +/* +* Invoked from PMU callback functions to check if there is a pending +* PMI bit in the paca. +*/ +if (get_paca ()->irq_happened &PACA_IRQ_PMI ) +return true; + +return false; +} +#ifdef CONFIG_PPC_BOOK3S /* * To support disabling and enabling of irq with PMI, set of
@@ -408,6 +444,10 @@ static inline void do_hard_irq_enable(void)BUILD_BUG (); } +static inline void clear_pmi_irq_pending (void ) { } +static inline void set_pmi_irq_pending (void ) { } +static inline bool pmi_irq_pending (void ) {return false; } +static inline void irq_soft_mask_regs_set_state (struct pt_regs *regs,unsigned long val) { }
arch/powerpc/perf/core-book3s.c +57 -1
98 lines not on this page · raw message
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 391/846 powerpc/modules: Dont WARN on first module allocation attempt
In reply to Greg Kroah-HartmanFrom: Christophe Leroy <[email protected]>
[ Upstream commit f1797e4de1146009c888bcf8b6bb6648d55394f1 ]
module_alloc() first tries to allocate module text within 24 bits direct jump from kernel text, and tries a wider allocation if first one fails.
When first allocation fails the following is observed in kernel logs:
vmap allocation for size 2400256 failed: use vmalloc=<size> to increase size
systemd-udevd: vmalloc error: size 2395133, vm_struct allocation failed, mode:0xcc0(GFP_KERNEL), nodemask=(null)
CPU: 0 PID: 127 Comm: systemd-udevd Tainted: G W 5.15.5-gentoo-PowerMacG4 #9 Call Trace: [e2a53a50] [c0ba0048] dump_stack_lvl+0x80/0xb0 (unreliable) [e2a53a70] [c0540128] warn_alloc+0x11c/0x2b4 [e2a53b50] [c0531be8] __vmalloc_node_range+0xd8/0x64c [e2a53c10] [c00338c0] module_alloc+0xa0/0xac [e2a53c40] [c027a368] load_module+0x2ae0/0x8148 [e2a53e30] [c027fc78] sys_finit_module+0xfc/0x130 [e2a53f30] [c0035098] ret_from_syscall+0x0/0x28 ...
Add __GFP_NOWARN flag to first allocation so that no warning appears when it fails.
--- arch/powerpc/kernel/module.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
arch/powerpc/kernel/module.c +6 -5
@@ -90,16 +90,17 @@ int module_finalize(const Elf_Ehdr *hdr, } static __always_inline void * -__module_alloc (unsigned long size,unsigned long start,unsigned long end) +__module_alloc (unsigned long size,unsigned long start,unsigned long end,bool nowarn) {pgprot_t prot =strict_module_rwx_enabled () ?PAGE_KERNEL :PAGE_KERNEL_EXEC ; +gfp_t gfp =GFP_KERNEL | (nowarn ? __GFP_NOWARN :0 );/* * Don't do huge page allocations for modules yet until more testing * is done. STRICT_MODULE_RWX may require extra work to support this * too. */ -return __vmalloc_node_range (size,1 , start, end,GFP_KERNEL , prot, +return __vmalloc_node_range (size,1 , start, end, gfp, prot,VM_FLUSH_RESET_PERMS |VM_NO_HUGE_VMAP ,NUMA_NO_NODE ,__builtin_return_address (0 )); }
@@ -114,13 +115,13 @@ void *module_alloc(unsigned long size)/* First try within 32M limit from _etext to avoid branch trampolines */ if (MODULES_VADDR <PAGE_OFFSET &&MODULES_END > limit) - ptr =__module_alloc (size, limit,MODULES_END ); + ptr =__module_alloc (size, limit,MODULES_END , true);if (!ptr) - ptr =__module_alloc (size,MODULES_VADDR ,MODULES_END ); + ptr =__module_alloc (size,MODULES_VADDR ,MODULES_END , false);return ptr;#else -return __module_alloc (size,VMALLOC_START ,VMALLOC_END ); +return __module_alloc (size,VMALLOC_START ,VMALLOC_END , false);#endif }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 392/846 powerpc/32s: Fix shift-out-of-bounds in KASAN init
In reply to Greg Kroah-HartmanFrom: Christophe Leroy <[email protected]>
[ Upstream commit af11dee4361b3519981fa04d014873f9d9edd6ac ]
================================================================================
UBSAN: shift-out-of-bounds in arch/powerpc/mm/kasan/book3s_32.c:22:23 shift exponent -1 is negative CPU: 0 PID: 0 Comm: swapper Not tainted 5.15.5-gentoo-PowerMacG4 #9 Call Trace: [c214be60] [c0ba0048] dump_stack_lvl+0x80/0xb0 (unreliable) [c214be80] [c0b99288] ubsan_epilogue+0x10/0x5c [c214be90] [c0b98fe0] __ubsan_handle_shift_out_of_bounds+0x94/0x138 [c214bf00] [c1c0f010] kasan_init_region+0xd8/0x26c [c214bf30] [c1c0ed84] kasan_init+0xc0/0x198 [c214bf70] [c1c08024] setup_arch+0x18/0x54c [c214bfc0] [c1c037f0] start_kernel+0x90/0x33c
[c214bff0] [00003610] 0x3610
================================================================================
This happens when the directly mapped memory is a power of 2.
Fix it by checking the shift and set the result to 0 when shift is -1
--- arch/powerpc/mm/kasan/book3s_32.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/powerpc/mm/kasan/book3s_32.c +2 -1
@@ -19,7 +19,8 @@ int __init kasan_init_region(void *start, size_t size) block =memblock_alloc (k_size, k_size_base);if (block && k_size_base >=SZ_128K && k_start ==ALIGN (k_start, k_size_base)) { -int k_size_more =1 << (ffs (k_size - k_size_base) -1 ); +int shift =ffs (k_size - k_size_base); +int k_size_more = shift ?1 << (shift -1 ) :0 ;setbat (-1 , k_start,__pa (block), k_size_base,PAGE_KERNEL );if (k_size_more >=SZ_128K )
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 393/846 clocksource: Avoid accidental unstable marking of clocksources
In reply to Greg Kroah-HartmanFrom: Waiman Long <[email protected]>
[ Upstream commit c86ff8c55b8ae68837b2fa59dc0c203907e9a15f ]
Since commit db3a34e17433 ("clocksource: Retry clock read if long delays detected") and commit 2e27e793e280 ("clocksource: Reduce clocksource-skew threshold"), it is found that tsc clocksource fallback to hpet can sometimes happen on both Intel and AMD systems especially when they are running stressful benchmarking workloads. Of the 23 systems tested with a v5.14 kernel, 10 of them have switched to hpet clock source during the test run.
The result of falling back to hpet is a drastic reduction of performance when running benchmarks. For example, the fio performance tests can drop up to 70% whereas the iperf3 performance can drop up to 80%.
4 hpet fallbacks happened during bootup. They were:
[ 8.749399] clocksource: timekeeping watchdog on CPU13: hpet read-back delay of 263750ns, attempt 4, marking unstable [ 12.044610] clocksource: timekeeping watchdog on CPU19: hpet read-back delay of 186166ns, attempt 4, marking unstable [ 17.336941] clocksource: timekeeping watchdog on CPU28: hpet read-back delay of 182291ns, attempt 4, marking unstable [ 17.518565] clocksource: timekeeping watchdog on CPU34: hpet read-back delay of 252196ns, attempt 4, marking unstable
Other fallbacks happen when the systems were running stressful benchmarks. For example:
[ 2685.867873] clocksource: timekeeping watchdog on CPU117: hpet read-back delay of 57269ns, attempt 4, marking unstable [46215.471228] clocksource: timekeeping watchdog on CPU8: hpet read-back delay of 61460ns, attempt 4, marking unstable
Commit 2e27e793e280 ("clocksource: Reduce clocksource-skew threshold"), changed the skew margin from 100us to 50us. I think this is too small and can easily be exceeded when running some stressful workloads on a thermally stressed system. So it is switched back to 100us.
Even a maximum skew margin of 100us may be too small in for some systems when booting up especially if those systems are under thermal stress. To eliminate the case that the large skew is due to the system being too busy slowing down the reading of both the watchdog and the clocksource, an extra consecutive read of watchdog clock is being done to check this.
The consecutive watchdog read delay is compared against WATCHDOG_MAX_SKEW/2. If the delay exceeds the limit, we assume that the system is just too busy. A warning will be printed to the console and the clock skew check is skipped for this round.
--- kernel/time/clocksource.c | 50 ++++++++++++++++++++++++++++++++------- 1 file changed, 41 insertions(+), 9 deletions(-)
kernel/time/clocksource.c +41 -9
@@ -107,7 +107,7 @@ static u64 suspend_start;* This delay could be due to SMIs, NMIs, or to VCPU preemptions. Used as * a lower bound for cs->uncertainty_margin values when registering clocks. */ -#define WATCHDOG_MAX_SKEW (50 * NSEC_PER_USEC) +#define WATCHDOG_MAX_SKEW (100 * NSEC_PER_USEC)#ifdef CONFIG_CLOCKSOURCE_WATCHDOG static void clocksource_watchdog_work (struct work_struct *work);
@@ -205,17 +205,24 @@ EXPORT_SYMBOL_GPL(max_cswd_read_retries);static int verify_n_cpus =8 ;module_param (verify_n_cpus, int,0644 ); -static bool cs_watchdog_read (struct clocksource *cs,u64 *csnow,u64 *wdnow) +enum wd_read_status { +WD_READ_SUCCESS , +WD_READ_UNSTABLE , +WD_READ_SKIP +}; + +static enum wd_read_status cs_watchdog_read (struct clocksource *cs,u64 *csnow,u64 *wdnow) {unsigned int nretries; -u64 wd_end, wd_delta; -int64_t wd_delay; +u64 wd_end, wd_end2, wd_delta; +int64_t wd_delay, wd_seq_delay;for (nretries =0 ; nretries <= max_cswd_read_retries; nretries++) {local_irq_disable (); *wdnow = watchdog->read (watchdog); *csnow = cs->read (cs); wd_end = watchdog->read (watchdog); + wd_end2 = watchdog->read (watchdog);local_irq_enable (); wd_delta =clocksource_delta (wd_end, *wdnow, watchdog->mask);
@@ -226,13 +233,34 @@ static bool cs_watchdog_read(struct clocksource *cs, u64 *csnow, u64 *wdnow)pr_warn ("timekeeping watchdog on CPU%d: %s retried %d times before success\n" ,smp_processor_id (), watchdog->name, nretries); } -return true; +return WD_READ_SUCCESS ; } + +/* +* Now compute delay in consecutive watchdog read to see if +* there is too much external interferences that cause +* significant delay in reading both clocksource and watchdog. +* +* If consecutive WD read-back delay > WATCHDOG_MAX_SKEW/2, +* report system busy, reinit the watchdog and skip the current +* watchdog test. +*/ + wd_delta =clocksource_delta (wd_end2, wd_end, watchdog->mask); + wd_seq_delay =clocksource_cyc2ns (wd_delta, watchdog->mult, watchdog->shift); +if (wd_seq_delay >WATCHDOG_MAX_SKEW /2 ) + goto skip_test; }pr_warn ("timekeeping watchdog on CPU%d: %s read-back delay of %lldns, attempt %d, marking unstable\n" ,smp_processor_id (), watchdog->name, wd_delay, nretries); -return false; +return WD_READ_UNSTABLE ; + +skip_test: +pr_info ("timekeeping watchdog on CPU%d: %s wd-wd read-back delay of %lldns\n" , +smp_processor_id (), watchdog->name, wd_seq_delay); +pr_info ("wd-%s-wd read-back delay of %lldns, clock-skew test skipped!\n" , + cs->name, wd_delay); +return WD_READ_SKIP ; }static u64 csnow_mid;
@@ -356,6 +384,7 @@ static void clocksource_watchdog(struct timer_list *unused)int next_cpu, reset_pending;int64_t wd_nsec, cs_nsec;struct clocksource *cs; +enum wd_read_status read_ret;u32 md;spin_lock (&watchdog_lock);
@@ -373,9 +402,12 @@ static void clocksource_watchdog(struct timer_list *unused)continue ; } -if (!cs_watchdog_read (cs, &csnow, &wdnow)) { -/* Clock readout unreliable, so give it up. */ -__clocksource_unstable (cs); + read_ret =cs_watchdog_read (cs, &csnow, &wdnow); + +if (read_ret !=WD_READ_SUCCESS ) { +if (read_ret ==WD_READ_UNSTABLE ) +/* Clock readout unreliable, so give it up. */ +__clocksource_unstable (cs);continue ; }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 394/846 ALSA: oss: fix compile error when OSS_DEBUG is enabled
In reply to Greg Kroah-HartmanFrom: Bixuan Cui <[email protected]>
[ Upstream commit 8e7daf318d97f25e18b2fc7eb5909e34cd903575 ]
Fix compile error when OSS_DEBUG is enabled:
sound/core/oss/pcm_oss.c: In function 'snd_pcm_oss_set_trigger':
sound/core/oss/pcm_oss.c:2055:10: error: 'substream' undeclared (first
use in this function); did you mean 'csubstream'?
pcm_dbg(substream->pcm, "pcm_oss: trigger = 0x%x\n", trigger);
^--- sound/core/oss/pcm_oss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/core/oss/pcm_oss.c +1 -1
@@ -2065,7 +2065,7 @@ static int snd_pcm_oss_set_trigger(struct snd_pcm_oss_file *pcm_oss_file, int trint err, cmd;#ifdef OSS_DEBUG -pcm_dbg (substream->pcm,"pcm_oss: trigger = 0x%x\n" , trigger); +pr_debug ("pcm_oss: trigger = 0x%x\n" , trigger);#endif psubstream = pcm_oss_file->streams[SNDRV_PCM_STREAM_PLAYBACK ];
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 395/846 ALSA: usb-audio: Drop superfluous 0 in Presonus Studio 1810cs ID
In reply to Greg Kroah-HartmanFrom: Takashi Iwai <[email protected]>
[ Upstream commit 1e583aef12aa74afd37c1418255cc4b74e023236 ]
The vendor ID of Presonus Studio 1810c had a superfluous '0' in its USB ID. Drop it.
--- sound/usb/format.c | 2 +- sound/usb/mixer_quirks.c | 2 +- sound/usb/quirks.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
sound/usb/format.c +1 -1
@@ -375,7 +375,7 @@ static int parse_uac2_sample_rate_range(struct snd_usb_audio *chip,for (rate = min; rate <= max; rate += res) {/* Filter out invalid rates on Presonus Studio 1810c */ -if (chip->usb_id ==USB_ID (0x0194f ,0x010c ) && +if (chip->usb_id ==USB_ID (0x194f ,0x010c ) && !s1810c_valid_sample_rate (fp, rate)) goto skip_rate;
sound/usb/mixer_quirks.c +1 -1
@@ -3254,7 +3254,7 @@ int snd_usb_mixer_apply_create_quirk(struct usb_mixer_interface *mixer) err =snd_rme_controls_create (mixer);break ; -case USB_ID (0x0194f ,0x010c ):/* Presonus Studio 1810c */ +case USB_ID (0x194f ,0x010c ):/* Presonus Studio 1810c */ err =snd_sc1810_init_mixer (mixer);break ;case USB_ID (0x2a39 ,0x3fb0 ):/* RME Babyface Pro FS */
sound/usb/quirks.c +1 -1
@@ -1290,7 +1290,7 @@ int snd_usb_apply_interface_quirk(struct snd_usb_audio *chip,if (chip->usb_id ==USB_ID (0x0763 ,0x2012 ))return fasttrackpro_skip_setting_quirk (chip, iface, altno);/* presonus studio 1810c: skip altsets incompatible with device_setup */ -if (chip->usb_id ==USB_ID (0x0194f ,0x010c )) +if (chip->usb_id ==USB_ID (0x194f ,0x010c ))return s1810c_skip_setting_quirk (chip, iface, altno);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 396/846 misc: at25: Make driver OF independent again
In reply to Greg Kroah-HartmanFrom: Andy Shevchenko <[email protected]>
[ Upstream commit 5b557298d7d09cce04e0565a535fbca63661724a ]
The commit f60e7074902a ("misc: at25: Make use of device property API") made a good job by enabling the driver for non-OF platforms, but the recent commit 604288bc6196 ("nvmem: eeprom: at25: fix type compiler warnings") brought that back.
Restore greatness of the driver once again.
--- drivers/misc/eeprom/at25.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
drivers/misc/eeprom/at25.c +6 -7
@@ -17,8 +17,6 @@#include <linux/spi/spi.h> #include <linux/spi/eeprom.h> #include <linux/property.h> -#include <linux/of.h> -#include <linux/of_device.h> #include <linux/math.h> /*
@@ -380,13 +378,14 @@ static int at25_probe(struct spi_device *spi)int sr;u8 id[FM25_ID_LEN ];u8 sernum[FM25_SN_LEN ]; +bool is_fram;int i; -const struct of_device_id *match; -bool is_fram =0 ; - match =of_match_device (of_match_ptr (at25_of_match), &spi->dev); -if (match && !strcmp (match->compatible,"cypress,fm25" )) - is_fram =1 ; + err =device_property_match_string (&spi->dev,"compatible" ,"cypress,fm25" ); +if (err >=0 ) + is_fram = true; +else + is_fram = false; at25 =devm_kzalloc (&spi->dev,sizeof (struct at25_data ),GFP_KERNEL );if (!at25)
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 397/846 char/mwave: Adjust io port register size
In reply to Greg Kroah-HartmanFrom: Kees Cook <[email protected]>
[ Upstream commit f5912cc19acd7c24b2dbf65a6340bf194244f085 ]
Using MKWORD() on a byte-sized variable results in OOB read. Expand the size of the reserved area so both MKWORD and MKBYTE continue to work without overflow. Silences this warning on a -Warray-bounds build:
drivers/char/mwave/3780i.h:346:22: error: array subscript 'short unsigned int[0]' is partly outside array bounds of 'DSP_ISA_SLAVE_CONTROL[1]' [-Werror=array-bounds]
346 | #define MKWORD(var) (*((unsigned short *)(&var)))
| ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/char/mwave/3780i.h:356:40: note: in definition of macro 'OutWordDsp'
356 | #define OutWordDsp(index,value) outw(value,usDspBaseIO+index)
| ^~~~~drivers/char/mwave/3780i.c:373:41: note: in expansion of macro 'MKWORD'
373 | OutWordDsp(DSP_IsaSlaveControl, MKWORD(rSlaveControl));
| ^~~~~~drivers/char/mwave/3780i.c:358:31: note: while referencing 'rSlaveControl'
358 | DSP_ISA_SLAVE_CONTROL rSlaveControl;
| ^~~~~~~~~~~~~--- drivers/char/mwave/3780i.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/mwave/3780i.h +1 -1
@@ -68,7 +68,7 @@ typedef struct { unsigned char ClockControl:1; /* RW: Clock control: 0=normal, 1=stop 3780i clocks */ unsigned char SoftReset:1; /* RW: Soft reset 0=normal, 1=soft reset active */ unsigned char ConfigMode:1; /* RW: Configuration mode, 0=normal, 1=config mode */ - unsigned char Reserved:5; /* 0: Reserved */ + unsigned short Reserved:13; /* 0: Reserved */ }DSP_ISA_SLAVE_CONTROL ;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 398/846 binder: fix handling of error during copy
In reply to Greg Kroah-HartmanFrom: Todd Kjos <[email protected]>
[ Upstream commit fe6b1869243f23a485a106c214bcfdc7aa0ed593 ]
If a memory copy function fails to copy the whole buffer, a positive integar with the remaining bytes is returned. In binder_translate_fd_array() this can result in an fd being skipped due to the failed copy, but the loop continues processing fds since the early return condition expects a negative integer on error.
Fix by returning "ret > 0 ? -EINVAL : ret" to handle this case.
--- drivers/android/binder.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/android/binder.c +2 -2
@@ -2269,8 +2269,8 @@ static int binder_translate_fd_array(struct binder_fd_array_object *fda,if (!ret) ret =binder_translate_fd (fd, offset, t, thread, in_reply_to); -if (ret <0 ) -return ret; +if (ret) +return ret >0 ? -EINVAL : ret; }return 0 ; }
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 399/846 binder: avoid potential data leakage when copying txn
In reply to Greg Kroah-HartmanFrom: Todd Kjos <[email protected]>
[ Upstream commit 6d98eb95b450a75adb4516a1d33652dc78d2b20c ]
Transactions are copied from the sender to the target first and objects like BINDER_TYPE_PTR and BINDER_TYPE_FDA are then fixed up. This means there is a short period where the sender's version of these objects are visible to the target prior to the fixups.
Instead of copying all of the data first, copy data only after any needed fixups have been applied.
--- drivers/android/binder.c | 94 ++++++++++++++++++++++++++++++---------- 1 file changed, 70 insertions(+), 24 deletions(-)
drivers/android/binder.c +70 -24
@@ -1608,15 +1608,21 @@ static void binder_cleanup_transaction(struct binder_transaction *t,/** * binder_get_object() - gets object and checks for valid metadata * @proc: binder_proc owning the buffer +* @u: sender's user pointer to base of buffer * @buffer: binder_buffer that we're parsing. * @offset: offset in the @buffer at which to validate an object. * @object: struct binder_object to read into * -* Return: If there's a valid metadata object at @offset in @buffer, the +* Copy the binder object at the given offset into @object. If @u is +* provided then the copy is from the sender's buffer. If not, then +* it is copied from the target's @buffer. +* +* Return: If there's a valid metadata object at @offset, the * size of that object. Otherwise, it returns zero. The object * is read into the struct binder_object pointed to by @object. */ static size_t binder_get_object (struct binder_proc *proc, +const void __user *u,struct binder_buffer *buffer,unsigned long offset,struct binder_object *object)
@@ -1626,10 +1632,16 @@ static size_t binder_get_object(struct binder_proc *proc,size_t object_size =0 ; read_size =min_t (size_t,sizeof (*object), buffer->data_size - offset); -if (offset > buffer->data_size || read_size <sizeof (*hdr) || -binder_alloc_copy_from_buffer (&proc->alloc, object, buffer, - offset, read_size)) +if (offset > buffer->data_size || read_size <sizeof (*hdr))return 0 ; +if (u) { +if (copy_from_user (object, u + offset, read_size)) +return 0 ; + }else { +if (binder_alloc_copy_from_buffer (&proc->alloc, object, buffer, + offset, read_size)) +return 0 ; + }/* Ok, now see if we read a complete object. */ hdr = &object->hdr;
@@ -1702,7 +1714,7 @@ static struct binder_buffer_object *binder_validate_ptr( b, buffer_offset, sizeof(object_offset)))return NULL ; - object_size =binder_get_object (proc, b, object_offset, object); + object_size =binder_get_object (proc,NULL , b, object_offset, object);if (!object_size || object->hdr.type !=BINDER_TYPE_PTR )return NULL ;if (object_offsetp)
@@ -1767,7 +1779,8 @@ static bool binder_validate_fixup(struct binder_proc *proc,unsigned long buffer_offset;struct binder_object last_object;struct binder_buffer_object *last_bbo; -size_t object_size =binder_get_object (proc, b, last_obj_offset, +size_t object_size =binder_get_object (proc,NULL , b, + last_obj_offset, &last_object);if (object_size !=sizeof (*last_bbo))return false;
@@ -1882,7 +1895,7 @@ static void binder_transaction_buffer_release(struct binder_proc *proc,if (!binder_alloc_copy_from_buffer (&proc->alloc, &object_offset, buffer, buffer_offset,sizeof (object_offset))) - object_size =binder_get_object (proc, buffer, + object_size =binder_get_object (proc,NULL , buffer, object_offset, &object);if (object_size ==0 ) { pr_err("transaction release %d bad object at offset %lld, size %zd\n",
@@ -2455,6 +2468,7 @@ static void binder_transaction(struct binder_proc *proc,binder_size_t off_start_offset, off_end_offset;binder_size_t off_min;binder_size_t sg_buf_offset, sg_buf_end_offset; +binder_size_t user_offset =0 ;struct binder_proc *target_proc =NULL ;struct binder_thread *target_thread =NULL ;struct binder_node *target_node =NULL ;
@@ -2469,6 +2483,8 @@ static void binder_transaction(struct binder_proc *proc,int t_debug_id =atomic_inc_return (&binder_last_id);char *secctx =NULL ;u32 secctx_sz =0 ; +const void __user *user_buffer = (const void __user *) + (uintptr_t )tr->data.ptr.buffer; e =binder_transaction_log_add (&binder_transaction_log); e->debug_id = t_debug_id;
@@ -2780,19 +2796,6 @@ static void binder_transaction(struct binder_proc *proc, t->buffer->clear_on_free = !!(t->flags &TF_CLEAR_BUF );trace_binder_transaction_alloc_buf (t->buffer); -if (binder_alloc_copy_user_to_buffer ( - &target_proc->alloc, - t->buffer,0 , - (const void __user *) - (uintptr_t )tr->data.ptr.buffer, - tr->data_size)) { -binder_user_error ("%d:%d got transaction with invalid data ptr\n" , - proc->pid, thread->pid); - return_error =BR_FAILED_REPLY ; - return_error_param = -EFAULT ; - return_error_line = __LINE__; - goto err_copy_data_failed; - } if (binder_alloc_copy_user_to_buffer( &target_proc->alloc, t->buffer,
@@ -2837,6 +2840,7 @@ static void binder_transaction(struct binder_proc *proc,size_t object_size;struct binder_object object;binder_size_t object_offset; +binder_size_t copy_size; if (binder_alloc_copy_from_buffer(&target_proc->alloc, &object_offset,
@@ -2848,8 +2852,27 @@ static void binder_transaction(struct binder_proc *proc, return_error_line = __LINE__; goto err_bad_offset; } - object_size =binder_get_object (target_proc, t->buffer, - object_offset, &object); + +/* +* Copy the source user buffer up to the next object +* that will be processed. +*/ + copy_size = object_offset - user_offset; +if (copy_size && (user_offset > object_offset || +binder_alloc_copy_user_to_buffer ( + &target_proc->alloc, + t->buffer, user_offset, + user_buffer + user_offset, + copy_size))) { +binder_user_error ("%d:%d got transaction with invalid data ptr\n" , + proc->pid, thread->pid); + return_error =BR_FAILED_REPLY ; + return_error_param = -EFAULT ; + return_error_line = __LINE__; + goto err_copy_data_failed; + } + object_size =binder_get_object (target_proc, user_buffer, + t->buffer, object_offset, &object);if (object_size ==0 || object_offset < off_min) { binder_user_error("%d:%d got transaction with invalid offset (%lld, min %lld max %lld) or object.\n", proc->pid, thread->pid,
@@ -2861,6 +2884,11 @@ static void binder_transaction(struct binder_proc *proc, return_error_line = __LINE__; goto err_bad_offset; } +/* +* Set offset to the next buffer fragment to be +* copied +*/ + user_offset = object_offset + object_size; hdr = &object.hdr; off_min = object_offset + object_size;
@@ -2956,9 +2984,14 @@ static void binder_transaction(struct binder_proc *proc, } ret =binder_translate_fd_array (fda, parent, t, thread, in_reply_to); -if (ret <0 ) { +if (!ret) + ret =binder_alloc_copy_to_buffer (&target_proc->alloc, + t->buffer, + object_offset, + fda,sizeof (*fda)); +if (ret) { return_error =BR_FAILED_REPLY ; - return_error_param = ret; + return_error_param = ret >0 ? -EINVAL : ret; return_error_line = __LINE__; goto err_translate_failed; }
@@ -3028,6 +3061,19 @@ static void binder_transaction(struct binder_proc *proc, goto err_bad_object_type; } } +/* Done processing objects, copy the rest of the buffer */ +if (binder_alloc_copy_user_to_buffer ( + &target_proc->alloc, + t->buffer, user_offset, + user_buffer + user_offset, + tr->data_size - user_offset)) { +binder_user_error ("%d:%d got transaction with invalid data ptr\n" , + proc->pid, thread->pid); + return_error =BR_FAILED_REPLY ; + return_error_param = -EFAULT ; + return_error_line = __LINE__; + goto err_copy_data_failed; + }if (t->buffer->oneway_spam_suspect) tcomplete->type =BINDER_WORK_TRANSACTION_ONEWAY_SPAM_SUSPECT ;else
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 400/846 openrisc: Add clone3 ABI wrapper
In reply to Greg Kroah-HartmanFrom: Stafford Horne <[email protected]>
[ Upstream commit 433fe39f674d58bc7a3e8254a5d2ffc290b7e04e ]
Like fork and clone the clone3 syscall needs a wrapper to save callee saved registers, which is required by the OpenRISC ABI. This came up after auditing code following a discussion with Rob Landley and Arnd Bergmann [0].
Tested with the clone3 kselftests and there were no issues.
[0] https://lore.kernel.org/all/[email protected]/T/#m9c0cdb2703813b9df4da04cf6b30de1f1aa89944
--- arch/openrisc/include/asm/syscalls.h | 2 ++ arch/openrisc/kernel/entry.S | 5 +++++ 2 files changed, 7 insertions(+)
arch/openrisc/include/asm/syscalls.h +2 -0
@@ -22,9 +22,11 @@ asmlinkage long sys_or1k_atomic(unsigned long type, unsigned long *v1,asmlinkage long __sys_clone (unsigned long clone_flags,unsigned long newsp,void __user *parent_tid,void __user *child_tid,int tls); +asmlinkage long __sys_clone3 (struct clone_args __user *uargs,size_t size);asmlinkage long __sys_fork (void );#define sys_clone __sys_clone +#define sys_clone3 __sys_clone3#define sys_fork __sys_fork#endif /* __ASM_OPENRISC_SYSCALLS_H */
arch/openrisc/kernel/entry.S +5 -0
@@ -1170,6 +1170,11 @@ ENTRY(__sys_clone) l.j _fork_save_extra_regs_and_call l.nop +ENTRY(__sys_clone3) + l.movhi r29,hi(sys_clone3) + l.j _fork_save_extra_regs_and_call + l.ori r29,r29,lo(sys_clone3) + ENTRY(__sys_fork) l.movhi r29,hi(sys_fork) l.ori r29,r29,lo(sys_fork)
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 401/846 uio: uio_dmem_genirq: Catch the Exception
In reply to Greg Kroah-HartmanFrom: Jiasheng Jiang <[email protected]>
[ Upstream commit eec91694f927d1026974444eb6a3adccd4f1cbc2 ]
The return value of dma_set_coherent_mask() is not always 0. To catch the exception in case that dma is not support the mask.
--- drivers/uio/uio_dmem_genirq.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/uio/uio_dmem_genirq.c +5 -1
@@ -188,7 +188,11 @@ static int uio_dmem_genirq_probe(struct platform_device *pdev)return -ENOMEM ; } -dma_set_coherent_mask (&pdev->dev,DMA_BIT_MASK (32 )); + ret =dma_set_coherent_mask (&pdev->dev,DMA_BIT_MASK (32 )); +if (ret) { +dev_err (&pdev->dev,"DMA enable failed\n" ); +return ret; + } priv->uioinfo = uioinfo;spin_lock_init (&priv->lock);
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 402/846 iommu: Extend mutex lock scope in iommu_probe_device()
In reply to Greg Kroah-HartmanFrom: Lu Baolu <[email protected]>
[ Upstream commit 556f99ac886635e8da15528995f06d1d7028cfca ]
Extend the scope of holding group->mutex so that it can cover the default domain check/attachment and direct mappings of reserved regions.
--- drivers/iommu/iommu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/iommu/iommu.c +2 -1
@@ -287,11 +287,11 @@ int iommu_probe_device(struct device *dev)*/ mutex_lock (&group->mutex);iommu_alloc_default_domain (group, dev); -mutex_unlock (&group->mutex);if (group->default_domain) { ret =__iommu_attach_device (group->default_domain, dev);if (ret) { +mutex_unlock (&group->mutex);iommu_group_put (group); goto err_release; }
@@ -299,6 +299,7 @@ int iommu_probe_device(struct device *dev)iommu_create_device_direct_mappings (group, dev); +mutex_unlock (&group->mutex);iommu_group_put (group);if (ops->probe_finalize)
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 403/846 iommu/io-pgtable-arm: Fix table descriptor paddr formatting
In reply to Greg Kroah-HartmanFrom: Hector Martin <[email protected]>
[ Upstream commit 9abe2ac834851a7d0b0756e295cf7a292c45ca53 ]
Table descriptors were being installed without properly formatting the address using paddr_to_iopte, which does not match up with the iopte_deref in __arm_lpae_map. This is incorrect for the LPAE pte format, as it does not handle the high bits properly.
This was found on Apple T6000 DARTs, which require a new pte format (different shift); adding support for that to paddr_to_iopte/iopte_to_paddr caused it to break badly, as even <48-bit addresses would end up incorrect in that case.
--- drivers/iommu/io-pgtable-arm.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/iommu/io-pgtable-arm.c +5 -4
@@ -315,11 +315,12 @@ static int arm_lpae_init_pte(struct arm_lpae_io_pgtable *data,static arm_lpae_iopte arm_lpae_install_table (arm_lpae_iopte *table,arm_lpae_iopte *ptep,arm_lpae_iopte curr, -struct io_pgtable_cfg *cfg) +struct arm_lpae_io_pgtable *data) {arm_lpae_iopte old, new; +struct io_pgtable_cfg *cfg = &data->iop.cfg; - new =__pa (table) |ARM_LPAE_PTE_TYPE_TABLE ; + new =paddr_to_iopte (__pa (table), data) |ARM_LPAE_PTE_TYPE_TABLE ;if (cfg->quirks &IO_PGTABLE_QUIRK_ARM_NS ) new |=ARM_LPAE_PTE_NSTABLE ;
@@ -380,7 +381,7 @@ static int __arm_lpae_map(struct arm_lpae_io_pgtable *data, unsigned long iova,if (!cptep)return -ENOMEM ; - pte =arm_lpae_install_table (cptep, ptep,0 , cfg); + pte =arm_lpae_install_table (cptep, ptep,0 , data);if (pte)__arm_lpae_free_pages (cptep, tblsz, cfg); }else if (!cfg->coherent_walk && !(pte &ARM_LPAE_PTE_SW_SYNC )) {
@@ -592,7 +593,7 @@ static size_t arm_lpae_split_blk_unmap(struct arm_lpae_io_pgtable *data,__arm_lpae_init_pte (data, blk_paddr, pte, lvl,1 , &tablep[i]); } - pte =arm_lpae_install_table (tablep, ptep, blk_pte, cfg); + pte =arm_lpae_install_table (tablep, ptep, blk_pte, data);if (pte != blk_pte) {__arm_lpae_free_pages (tablep, tablesz, cfg);/*
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 404/846 scsi: core: Fix scsi_device_max_queue_depth()
In reply to Greg Kroah-HartmanFrom: Bart Van Assche <[email protected]>
[ Upstream commit 4bc3bffc1a885eb5cb259e4a25146a4c7b1034e3 ]
The comment above scsi_device_max_queue_depth() and also the description of commit ca4453213951 ("scsi: core: Make sure sdev->queue_depth is <= max(shost->can_queue, 1024)") contradict the implementation of the function scsi_device_max_queue_depth(). Additionally, the maximum queue depth of a SCSI LUN never exceeds host->can_queue. Fix scsi_device_max_queue_depth() by changing max_t() into min_t().
--- drivers/scsi/scsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/scsi.c +2 -2
@@ -209,11 +209,11 @@ void scsi_finish_command(struct scsi_cmnd *cmd)/* -* 1024 is big enough for saturating the fast scsi LUN now +* 1024 is big enough for saturating fast SCSI LUNs. */ int scsi_device_max_queue_depth (struct scsi_device *sdev) { -return max_t (int, sdev->host->can_queue,1024 ); +return min_t (int, sdev->host->can_queue,1024 ); }/**
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 405/846 scsi: ufs: Fix race conditions related to driver data
In reply to Greg Kroah-HartmanFrom: Bart Van Assche <[email protected]>
[ Upstream commit 21ad0e49085deb22c094f91f9da57319a97188e4 ]
The driver data pointer must be set before any callbacks are registered that use that pointer. Hence move the initialization of that pointer from after the ufshcd_init() call to inside ufshcd_init().
--- drivers/scsi/ufs/tc-dwc-g210-pci.c | 1 - drivers/scsi/ufs/ufshcd-pci.c | 2 -- drivers/scsi/ufs/ufshcd-pltfrm.c | 2 -- drivers/scsi/ufs/ufshcd.c | 7 +++++++ 4 files changed, 7 insertions(+), 5 deletions(-)
drivers/scsi/ufs/tc-dwc-g210-pci.c +0 -1
@@ -110,7 +110,6 @@ tc_dwc_g210_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)return err; } -pci_set_drvdata (pdev, hba);pm_runtime_put_noidle (&pdev->dev);pm_runtime_allow (&pdev->dev);
drivers/scsi/ufs/ufshcd-pci.c +0 -2
@@ -538,8 +538,6 @@ ufshcd_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)return err; } -pci_set_drvdata (pdev, hba); - hba->vops = (struct ufs_hba_variant_ops *)id->driver_data; err =ufshcd_init (hba, mmio_base, pdev->irq);
drivers/scsi/ufs/ufshcd-pltfrm.c +0 -2
@@ -361,8 +361,6 @@ int ufshcd_pltfrm_init(struct platform_device *pdev, goto dealloc_host; } -platform_set_drvdata (pdev, hba); -pm_runtime_set_active (&pdev->dev);pm_runtime_enable (&pdev->dev);
drivers/scsi/ufs/ufshcd.c +7 -0
@@ -9366,6 +9366,13 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq)struct device *dev = hba->dev;char eh_wq_name[sizeof ("ufs_eh_wq_00" )]; +/* +* dev_set_drvdata() must be called before any callbacks are registered +* that use dev_get_drvdata() (frequency scaling, clock scaling, hwmon, +* sysfs). +*/ +dev_set_drvdata (dev, hba); +if (!mmio_base) {dev_err (hba->dev,"Invalid memory reference for mmio_base is NULL\n" );
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 406/846 RDMA/qedr: Fix reporting max_{send/recv}_wr attrs
In reply to Greg Kroah-HartmanFrom: Kamal Heib <[email protected]>
[ Upstream commit b1a4da64bfc189510e08df1ccb1c589e667dc7a3 ]
Fix the wrongly reported max_send_wr and max_recv_wr attributes for user QP by making sure to save their valuse on QP creation, so when query QP is called the attributes will be reported correctly.
--- drivers/infiniband/hw/qedr/verbs.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/infiniband/hw/qedr/verbs.c +2 -0
@@ -1941,6 +1941,7 @@ static int qedr_create_user_qp(struct qedr_dev *dev,/* db offset was calculated in copy_qp_uresp, now set in the user q */ if (qedr_qp_has_sq (qp)) { qp->usq.db_addr = ctx->dpi_addr + uresp.sq_db_offset; + qp->sq.max_wr = attrs->cap.max_send_wr; rc = qedr_db_recovery_add(dev, qp->usq.db_addr, &qp->usq.db_rec_data->db_data, DB_REC_WIDTH_32B,
@@ -1951,6 +1952,7 @@ static int qedr_create_user_qp(struct qedr_dev *dev,if (qedr_qp_has_rq (qp)) { qp->urq.db_addr = ctx->dpi_addr + uresp.rq_db_offset; + qp->rq.max_wr = attrs->cap.max_recv_wr; rc = qedr_db_recovery_add(dev, qp->urq.db_addr, &qp->urq.db_rec_data->db_data, DB_REC_WIDTH_32B,
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 407/846 PCI/MSI: Fix pci_irq_vector()/pci_irq_get_affinity()
In reply to Greg Kroah-HartmanFrom: Thomas Gleixner <[email protected]>
[ Upstream commit 29bbc35e29d9b6347780dcacde2deb4b39344167 ]
pci_irq_vector() and pci_irq_get_affinity() use the list position to find the MSI-X descriptor at a given index. That's correct for the normal case where the entry number is the same as the list position.
But it's wrong for cases where MSI-X was allocated with an entries array describing sparse entry numbers into the hardware message descriptor table. That's inconsistent at best.
Make it always check the entry number because that's what the zero base index really means. This change won't break existing users which use a sparse entries array for allocation because these users retrieve the Linux interrupt number from the entries array after allocation and none of them uses pci_irq_vector() or pci_irq_get_affinity().
--- drivers/pci/msi.c | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-)
drivers/pci/msi.c +18 -8
@@ -1193,19 +1193,24 @@ EXPORT_SYMBOL(pci_free_irq_vectors);/** * pci_irq_vector - return Linux IRQ number of a device vector -* @dev: PCI device to operate on -* @nr: device-relative interrupt vector index (0-based). +* @dev: PCI device to operate on +* @nr: Interrupt vector index (0-based) +* +* @nr has the following meanings depending on the interrupt mode: +* MSI-X: The index in the MSI-X vector table +* MSI: The index of the enabled MSI vectors +* INTx: Must be 0 +* +* Return: The Linux interrupt number or -EINVAl if @nr is out of range. */ int pci_irq_vector (struct pci_dev *dev,unsigned int nr) {if (dev->msix_enabled) {struct msi_desc *entry; -int i =0 ;for_each_pci_msi_entry (entry, dev) { -if (i == nr) +if (entry->msi_attrib.entry_nr == nr)return entry->irq; - i++; }WARN_ON_ONCE (1 );return -EINVAL ;
@@ -1229,17 +1234,22 @@ EXPORT_SYMBOL(pci_irq_vector);* pci_irq_get_affinity - return the affinity of a particular MSI vector * @dev: PCI device to operate on * @nr: device-relative interrupt vector index (0-based). +* +* @nr has the following meanings depending on the interrupt mode: +* MSI-X: The index in the MSI-X vector table +* MSI: The index of the enabled MSI vectors +* INTx: Must be 0 +* +* Return: A cpumask pointer or NULL if @nr is out of range */ const struct cpumask *pci_irq_get_affinity (struct pci_dev *dev,int nr) {if (dev->msix_enabled) {struct msi_desc *entry; -int i =0 ;for_each_pci_msi_entry (entry, dev) { -if (i == nr) +if (entry->msi_attrib.entry_nr == nr)return &entry->affinity->mask; - i++; }WARN_ON_ONCE (1 );return NULL ;
Signature · 1 line
2.34.1
Greg Kroah-Hartman
maintainerPATCH 408/846 powerpc/powermac: Add additional missing lockdep_register_key()
In reply to Greg Kroah-HartmanFrom: Christophe Leroy <[email protected]>
[ Upstream commit b149d5d45ac9171ed699a256f026c8ebef901112 ]
Commit df1f679d19ed ("powerpc/powermac: Add missing lockdep_register_key()") fixed a problem that was causing a WARNING.
There are two other places in the same file with the same problem originating from commit 9e607f72748d ("i2c_powermac: shut up lockdep warning").
Add missing lockdep_register_key()
Depends-on: df1f679d19ed ("powerpc/powermac: Add missing lockdep_register_key()")
--- arch/powerpc/platforms/powermac/low_i2c.c | 2 ++ 1 file changed, 2 insertions(+)
arch/powerpc/platforms/powermac/low_i2c.c +2 -0
@@ -810,6 +810,7 @@ static void __init pmu_i2c_probe(void) bus->hostdata = bus +1 ; bus->xfer = pmu_i2c_xfer;mutex_init (&bus->mutex); +lockdep_register_key (&bus->lock_key);lockdep_set_class (&bus->mutex, &bus->lock_key); bus->flags = pmac_i2c_multibus;list_add (&bus->link, &pmac_i2c_busses);
@@ -933,6 +934,7 @@ static void __init smu_i2c_probe(void) bus->hostdata = bus +1 ; bus->xfer = smu_i2c_xfer;mutex_init (&bus->mutex); +lockdep_register_key (&bus->lock_key);lockdep_set_class (&bus->mutex, &bus->lock_key); bus->flags =0 ;list_add (&bus->link, &pmac_i2c_busses);
Signature · 1 line
2.34.1