Skip to contentSkip to conversation

tests/i915/gem_ctx_engines: Added out fence for execute-one subtest

PATCH In review Arjun Melkaveri 3 participants 3 messages Feb 4, 2022 – Feb 7, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/i915/gem_ctx_engines: Added out fence for execute-one subtest

Resolved __gem_execbuf error seen, by passing spin->execbuf.rsvd2 >> 32.
As we are creating ctx for each engine .
Error resolved:-
(gem_ctx_engines:4117) CRITICAL: Failed assertion: __gem_execbuf(i915, &execbuf) == expected (gem_ctx_engines:4117) CRITICAL: Failed to report the valid engine for slot 0 (valid at 0)

Introducing IGT_SPIN_FENCE_OUT means we can stop using the no-preemption in spinner. Added I915_EXEC_FENCE_IN to the execbuf.flags so that it is executed after the spinner.
This is enhancement to the code .

Cc Chris Wilson <[email protected]>
Cc Thomas Hellström <[email protected]>
---
 tests/i915/gem_ctx_engines.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
tests/i915/gem_ctx_engines.c +3 -3
index 003dd171..de4b822c 100644
@@ -298,7 +298,7 @@ static void execute_one(int i915)
 			spin = igt_spin_new(i915,
 					    .ahnd = ahnd,
 					    .ctx = ctx,
-					    .flags = (IGT_SPIN_NO_PREEMPTION |
+					    .flags = (IGT_SPIN_FENCE_OUT |
 						      IGT_SPIN_POLL_RUN));
 
 			do_ioctl(i915, DRM_IOCTL_I915_GEM_BUSY, &busy);
@@ -314,13 +314,13 @@ static void execute_one(int i915)
 			}
 			cfg.num_engines = GEM_MAX_ENGINES;
 			ctx = intel_ctx_create(i915, &cfg);
+			execbuf.rsvd2 = spin->execbuf.rsvd2 >> 32;
 
-			igt_spin_busywait_until_started(spin);
 			for (int j = 0; j <= I915_EXEC_RING_MASK; j++) {
 				int expected = j == i ? 0 : -EINVAL;
 
 				execbuf.rsvd1 = ctx->id;
-				execbuf.flags = j;
+				execbuf.flags = j | I915_EXEC_FENCE_IN;
 				igt_assert_f(__gem_execbuf(i915, &execbuf) == expected,
 					     "Failed to report the %s engine for slot %d (valid at %d)\n",
 					     j == i ? "valid" : "invalid", j, i);
Signature · 1 line
2.25.1
#1 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/i915/gem_ctx_engines: Added out fence for execute-one subtest (rev5)

== Series Details ==

== Series Details ==

Series: tests/i915/gem_ctx_engines: Added out fence for execute-one subtest (rev5)
URL : https://patchwork.freedesktop.org/series/97623/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11189 -> IGTPW_6597
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_6597 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_6597, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6597/index.html

Participating hosts (47 -> 43)
------------------------------

Missing (4): fi-ctg-p8600 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_6597:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@hangcheck:
- fi-rkl-guc: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11189/fi-rkl-guc/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6597/fi-rkl-guc/igt@i915_selftest@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@i915_selftest@live@hangcheck:
- {fi-ehl-2}: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11189/fi-ehl-2/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6597/fi-ehl-2/igt@i915_selftest@[email protected]

Known issues
------------

Here are the changes found in IGTPW_6597 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_cs_nop@sync-fork-gfx0:
- fi-skl-6600u: NOTRUN -> [SKIP][5] ([fdo#109271]) +18 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6597/fi-skl-6600u/igt@amdgpu/[email protected]

* igt@amdgpu/amd_prime@amd-to-i915:
- fi-pnv-d510: NOTRUN -> [SKIP][6] ([fdo#109271]) +17 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6597/fi-pnv-d510/igt@amdgpu/[email protected]

* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][7] -> [INCOMPLETE][8] ([i915#4785])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11189/fi-hsw-4770/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6597/fi-hsw-4770/igt@i915_selftest@[email protected]
- bat-dg1-6: [PASS][9] -> [DMESG-FAIL][10] ([i915#4957])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11189/bat-dg1-6/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6597/bat-dg1-6/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@requests:
- fi-blb-e6850: [PASS][11] -> [DMESG-FAIL][12] ([i915#5026])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11189/fi-blb-e6850/igt@i915_selftest@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6597/fi-blb-e6850/igt@i915_selftest@[email protected]

* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][13] ([fdo#109271] / [i915#1436] / [i915#4312])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6597/fi-hsw-4770/igt@[email protected]
- fi-blb-e6850: NOTRUN -> [FAIL][14] ([fdo#109271] / [i915#2403] / [i915#2426] / [i915#4312])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6597/fi-blb-e6850/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@requests:
- fi-pnv-d510: [DMESG-FAIL][15] ([i915#2927] / [i915#4528]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11189/fi-pnv-d510/igt@i915_selftest@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6597/fi-pnv-d510/igt@i915_selftest@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [DMESG-WARN][17] ([i915#4269]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11189/fi-cml-u2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6597/fi-cml-u2/igt@[email protected]

* igt@kms_psr@primary_page_flip:
- fi-skl-6600u: [FAIL][19] ([i915#4547]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11189/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6597/fi-skl-6600u/igt@kms_psr@primary_page_flip.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4897]: https://gitlab.freedesktop.org/drm/intel/issues/4897
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5026]: https://gitlab.freedesktop.org/drm/intel/issues/5026

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6339 -> IGTPW_6597

CI-20190529: 20190529
CI_DRM_11189: c0fc917bc92837300b1991d53b835c6876f465a2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6597: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6597/index.html
IGT_6339: 9cd99d763440ae75d9981ce4e361d3deb5edb4e4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6597/index.html

Reviewed-by on v1 1/1
#2 lore raw
In reply to Arjun Melkaveri
Quoted 15 lines · Arjun Melkaveri

Resolved __gem_execbuf error seen, by passing spin->execbuf.rsvd2 >> 32.
As we are creating ctx for each engine .
Error resolved:-
(gem_ctx_engines:4117) CRITICAL: Failed assertion:
__gem_execbuf(i915, &execbuf) == expected (gem_ctx_engines:4117) CRITICAL: Failed to report the valid engine for slot 0 (valid at 0)

Introducing IGT_SPIN_FENCE_OUT means we can stop using the no-preemption in spinner. Added I915_EXEC_FENCE_IN to the execbuf.flags so that it is executed after the spinner.
This is enhancement to the code .

Quoted 3 lines
Cc Chris Wilson <[email protected]>
Cc Thomas Hellström <[email protected]>