Skip to contentSkip to conversation

dt-bindings: watchdog: convert faraday,ftwdt010 to yaml

PATCH Superseded Corentin Labbe 2 participants 2 messages Feb 10, 2022

Subsystems (2)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dt-bindings: watchdog: convert faraday,ftwdt010 to yaml

Convert watchdog/faraday,ftwdt010.txt to yaml.
This permits to detect missing properties like clocks and resets or compatible like moxa,moxart-watchdog.

---
Changes since v1:
- Added myself as maintainer as requested by Linus
- Added $ref to watchdog.yaml
- Removed useless quotes
- Added blank lines between properties
- Removed timeout-sec as already provided by watchdog.yaml

 .../bindings/watchdog/faraday,ftwdt010.txt    | 22 ------
 .../bindings/watchdog/faraday,ftwdt010.yaml   | 67 +++++++++++++++++++
 2 files changed, 67 insertions(+), 22 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.txt
 create mode 100644 Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.txt deleted +0 -22
deleted file mode 100644
index 9ecdb502e605..000000000000
@@ -1,22 +0,0 @@
-Faraday Technology FTWDT010 watchdog
-
-This is an IP part from Faraday Technology found in the Gemini
-SoCs and others.
-
-Required properties:
-- compatible : must be one of
-  "faraday,ftwdt010"
-  "cortina,gemini-watchdog", "faraday,ftwdt010"
-- reg : shall contain base register location and length
-- interrupts : shall contain the interrupt for the watchdog
-
-Optional properties:
-- timeout-sec : the default watchdog timeout in seconds.
-
-Example:
-
-watchdog@41000000 {
-	compatible = "faraday,ftwdt010";
-	reg = <0x41000000 0x1000>;
-	interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
-};
Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml new file +67 -0

67 lines not on this page · raw message

Signature · 1 line
2.34.1
#1 lore raw
Quoted 73 lines · Corentin Labbe

Convert watchdog/faraday,ftwdt010.txt to yaml.
This permits to detect missing properties like clocks and resets or compatible like moxa,moxart-watchdog.

---
Changes since v1:
- Added myself as maintainer as requested by Linus
- Added $ref to watchdog.yaml
- Removed useless quotes
- Added blank lines between properties
- Removed timeout-sec as already provided by watchdog.yaml

 .../bindings/watchdog/faraday,ftwdt010.txt    | 22 ------
 .../bindings/watchdog/faraday,ftwdt010.yaml   | 67 +++++++++++++++++++
 2 files changed, 67 insertions(+), 22 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.txt
 create mode 100644 Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml
Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.txt deleted +0 -22
deleted file mode 100644
index 9ecdb502e605..000000000000
@@ -1,22 +0,0 @@
-Faraday Technology FTWDT010 watchdog
-
-This is an IP part from Faraday Technology found in the Gemini
-SoCs and others.
-
-Required properties:
-- compatible : must be one of
-  "faraday,ftwdt010"
-  "cortina,gemini-watchdog", "faraday,ftwdt010"
-- reg : shall contain base register location and length
-- interrupts : shall contain the interrupt for the watchdog
-
-Optional properties:
-- timeout-sec : the default watchdog timeout in seconds.
-
-Example:
-
-watchdog@41000000 {
-	compatible = "faraday,ftwdt010";
-	reg = <0x41000000 0x1000>;
-	interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
-};
Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml new file +19 -0
new file mode 100644
index 000000000000..64e9c414cc60
@@ -0,0 +1,67 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/watchdog/faraday,ftwdt010.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Faraday Technology FTWDT010 watchdog
+
+maintainers:
+  - Linus Walleij <[email protected]>
+  - Corentin Labbe <[email protected]>
+
+description: |
+  This is an IP part from Faraday Technology found in the Gemini
+  SoCs and others.
+
+allOf:
+  - $ref: "watchdog.yaml#"
+

Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml line 29

Quoted 10 lines
Documentation/devicetree/bindings/watchdog/faraday,ftwdt010.yaml new file +10 -0
+properties:
+  compatible:
+    oneOf:
+      - const: faraday,ftwdt010
+      - items:
+          - const: cortina,gemini-watchdog
+          - const: faraday,ftwdt010
+      - items:
+          - const: moxa,moxart-watchdog
+          - const: faraday,ftwdt010

It looks like you duplicated these two entries. This should be an enum followed by a const.

Best regards,
Krzysztof