Skip to contentSkip to conversation

pinctrl: mediatek: Support pinctrl driver on mt8186

PATCH Superseded Guodong Liu 2 participants 8 messages Feb 14, 2022 – Feb 16, 2022

Subsystems (5)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v4 cover pinctrl: mediatek: Support pinctrl driver on mt8186

changes since v3:
- remove generic descriptions for common properties
- remove quotes
- drop "."
- drop "-" on description
- move partial "bias-pull-up" description info to the example
- don't break the code into two lines, maximux 84 columns is fine
- add the required fixes tag

changes since v2:
- update reg property
- update reg-names property
- sync rsel resistance selection property same as patch 3
- repair constraints is not indented correctly for bias-pull-{up,down}
- add "type: boolean" to the list of valid values. This corresponds to having bias-pull-{up,down} without any arguments.
- add dual file license for file "mt8186-pinfunc.h"
- add patch 3 to change "mediatek,rsel_resistance_in_si_unit" to "mediatek,rsel-resistance-in-si-unit"

changes since v1:
- add default pinctrl config to consistent with other MTK pinctrl drivers

Patch 1 add pinctrl file and binding document.

Patch 2 add pinctrl chip driver on mt8186.

Patch 3 canonical rsel resistance selection property.

Guodong Liu (3):
dt-bindings: pinctrl: mt8186: add pinctrl file and binding document
pinctrl: add pinctrl driver on mt8186
pinctrl: canonical rsel resistance selection property

 .../bindings/pinctrl/pinctrl-mt8186.yaml      |  302 +++
 drivers/pinctrl/mediatek/Kconfig              |    7 +
 drivers/pinctrl/mediatek/Makefile             |    1 +
 drivers/pinctrl/mediatek/pinctrl-mt8186.c     | 1311 ++++++++++
 drivers/pinctrl/mediatek/pinctrl-mtk-mt8186.h | 2186 +++++++++++++++++
 drivers/pinctrl/mediatek/pinctrl-paris.c      |    2 +-
 include/dt-bindings/pinctrl/mt8186-pinfunc.h  | 1174 +++++++++
 7 files changed, 4982 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
 create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt8186.c
 create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt8186.h
 create mode 100644 include/dt-bindings/pinctrl/mt8186-pinfunc.h
Signature · 1 line
2.25.1
#1 lore raw

PATCH v4 1/3 dt-bindings: pinctrl: mt8186: add pinctrl file and binding document

1. This patch adds pinctrl file for mt8186.
2. This patch adds mt8186 compatible node in binding document.

---
 .../bindings/pinctrl/pinctrl-mt8186.yaml      |  302 +++++
 include/dt-bindings/pinctrl/mt8186-pinfunc.h  | 1174 +++++++++++++++++
 2 files changed, 1476 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
 create mode 100644 include/dt-bindings/pinctrl/mt8186-pinfunc.h
Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml new file +302 -0
new file mode 100644
index 000000000000..582d131af4e3
@@ -0,0 +1,302 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pinctrl/pinctrl-mt8186.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek MT8186 Pin Controller
+
+maintainers:
+  - Sean Wang <[email protected]>
+
+description: |
+  The Mediatek's Pin controller is used to control SoC pins.
+
+properties:
+  compatible:
+    const: mediatek,mt8186-pinctrl
+
+  gpio-controller: true
+
+  '#gpio-cells':
+    description: |
+      Number of cells in GPIO specifier. Since the generic GPIO binding is used,
+      the amount of cells must be specified as 2. See the below
+      mentioned gpio binding representation for description of particular cells.
+    const: 2
+
+  gpio-ranges:
+    maxItems: 1
+
+  reg:
+    description: |
+      Physical address base for gpio base registers. There are 8 different GPIO
+      physical address base in mt8186.
+    maxItems: 8
+
+  reg-names:
+    description: |
+      Gpio base register names.
+    items:
+      - const: iocfg0
+      - const: iocfg_bm
+      - const: iocfg_bl
+      - const: iocfg_br
+      - const: iocfg_lm
+      - const: iocfg_rb
+      - const: iocfg_tl
+      - const: eint
+
+  interrupt-controller: true
+
+  '#interrupt-cells':
+    const: 2
+
+  interrupts:
+    description: The interrupt outputs to sysirq
+    maxItems: 1
+
+  mediatek,rsel-resistance-in-si-unit:
+    type: boolean
+    description: |
+      Identifying i2c pins pull up/down type which is RSEL. It can support
+      RSEL define or si unit value(ohm) to set different resistance.
+
+# PIN CONFIGURATION NODES
+patternProperties:
+  '-pins$':
+    type: object
+    additionalProperties: false
+    patternProperties:
+      '^pins':
+        type: object
+        additionalProperties: false
+        description: |
+          A pinctrl node should contain at least one subnodes representing the
+          pinctrl groups available on the machine. Each subnode will list the
+          pins it needs, and how they should be configured, with regard to muxer
+          configuration, pullups, drive strength, input enable/disable and
+          input schmitt.
+          An example of using macro:
+          pincontroller {
+            /* GPIO0 set as multifunction GPIO0 */
+            gpio-pins {
+              pins {
+                pinmux = <PINMUX_GPIO0__FUNC_GPIO0>;
+              }
+            };
+            /* GPIO128 set as multifunction SDA0 */
+            i2c0-pins {
+              pins {
+                pinmux = <PINMUX_GPIO128__FUNC_SDA0>;
+              }
+            };
+          };
+        $ref: "pinmux-node.yaml"
+
+        properties:
+          pinmux:
+            description: |
+              Integer array, represents gpio pin number and mux setting.
+              Supported pin number and mux varies for different SoCs, and are
+              defined as macros in dt-bindings/pinctrl/<soc>-pinfunc.h
+              directly.
+
+          drive-strength:
+            enum: [2, 4, 6, 8, 10, 12, 14, 16]
+
+          mediatek,drive-strength-adv:
+            description: |
+              Describe the specific driving setup property.
+              For I2C pins, the existing generic driving setup can only support
+              2/4/6/8/10/12/14/16mA driving. But in specific driving setup, they
+              can support 0.125/0.25/0.5/1mA adjustment. If we enable specific
+              driving setup, the existing generic setup will be disabled.
+              The specific driving setup is controlled by E1E0EN.
+              When E1=0/E0=0, the strength is 0.125mA.
+              When E1=0/E0=1, the strength is 0.25mA.
+              When E1=1/E0=0, the strength is 0.5mA.
+              When E1=1/E0=1, the strength is 1mA.
+              EN is used to enable or disable the specific driving setup.
+              Valid arguments are described as below:
+              0: (E1, E0, EN) = (0, 0, 0)
+              1: (E1, E0, EN) = (0, 0, 1)
+              2: (E1, E0, EN) = (0, 1, 0)
+              3: (E1, E0, EN) = (0, 1, 1)
+              4: (E1, E0, EN) = (1, 0, 0)
+              5: (E1, E0, EN) = (1, 0, 1)
+              6: (E1, E0, EN) = (1, 1, 0)
+              7: (E1, E0, EN) = (1, 1, 1)
+              So the valid arguments are from 0 to 7.
+            $ref: /schemas/types.yaml#/definitions/uint32
+            enum: [0, 1, 2, 3, 4, 5, 6, 7]
+
+          bias-pull-down:
+            oneOf:
+              - type: boolean
+              - enum: [100, 101, 102, 103]
+                description: mt8186 pull down PUPD/R0/R1 type define value.
+              - enum: [200, 201, 202, 203, 204, 205, 206, 207]
+                description: mt8186 pull down RSEL type define value.
+              - enum: [75000, 5000]
+                description: mt8186 pull down RSEL type si unit value(ohm).
+            description: |
+              For pull down type is normal, it don't need add RSEL & R1R0 define
+              and resistance value.
+              For pull down type is PUPD/R0/R1 type, it can add R1R0 define to
+              set different resistance. It can support "MTK_PUPD_SET_R1R0_00" &
+              "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" &
+              "MTK_PUPD_SET_R1R0_11" define in mt8186.
+              For pull down type is RSEL, it can add RSEL define & resistance
+              value(ohm) to set different resistance by identifying property
+              "mediatek,rsel-resistance-in-si-unit".
+              It can support "MTK_PULL_SET_RSEL_000" & "MTK_PULL_SET_RSEL_001"
+              & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011"
+              & "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101"
+              & "MTK_PULL_SET_RSEL_110" & "MTK_PULL_SET_RSEL_111"
+              define in mt8186. It can also support resistance value(ohm)
+              "75000" & "5000" in mt8186.
+              An example of using RSEL define:
+              pincontroller {
+                i2c0_pin {
+                  pins {
+                    pinmux = <PINMUX_GPIO128__FUNC_SDA0>;
+                    bias-pull-down = <MTK_PULL_SET_RSEL_001>;
+                  }
+                };
+              };
+              An example of using si unit resistance value(ohm):
+              &pio {
+                mediatek,rsel-resistance-in-si-unit;
+              }
+              pincontroller {
+                i2c0_pin {
+                  pins {
+                    pinmux = <PINMUX_GPIO128__FUNC_SDA0>;
+                    bias-pull-down = <75000>;
+                  }
+                };
+              };
+
+          bias-pull-up:
+            oneOf:
+              - type: boolean
+              - enum: [100, 101, 102, 103]
+                description: mt8186 pull up PUPD/R0/R1 type define value.
+              - enum: [200, 201, 202, 203, 204, 205, 206, 207]
+                description: mt8186 pull up RSEL type define value.
+              - enum: [1000, 1500, 2000, 3000, 4000, 5000, 10000, 75000]
+                description: mt8186 pull up RSEL type si unit value(ohm).
+            description: |
+              For pull up type is normal, it don't need add RSEL & R1R0 define
+              and resistance value.
+              For pull up type is PUPD/R0/R1 type, it can add R1R0 define to
+              set different resistance. It can support "MTK_PUPD_SET_R1R0_00" &
+              "MTK_PUPD_SET_R1R0_01" & "MTK_PUPD_SET_R1R0_10" &
+              "MTK_PUPD_SET_R1R0_11" define in mt8186.
+              For pull up type is RSEL, it can add RSEL define & resistance
+              value(ohm) to set different resistance by identifying property
+              "mediatek,rsel-resistance-in-si-unit".
+              It can support "MTK_PULL_SET_RSEL_000" & "MTK_PULL_SET_RSEL_001"
+              & "MTK_PULL_SET_RSEL_010" & "MTK_PULL_SET_RSEL_011"
+              & "MTK_PULL_SET_RSEL_100" & "MTK_PULL_SET_RSEL_101"
+              & "MTK_PULL_SET_RSEL_110" & "MTK_PULL_SET_RSEL_111"
+              define in mt8186. It can also support resistance value(ohm)
+              "1000" & "1500" & "2000" & "3000" & "4000" & "5000" & "10000" &
+              "75000" in mt8186.
+              An example of using si unit resistance value(ohm):
+              &pio {
+                mediatek,rsel-resistance-in-si-unit;
+              }
+              pincontroller {
+                i2c0-pins {
+                  pins {
+                    pinmux = <PINMUX_GPIO128__FUNC_SDA0>;
+                    bias-pull-up = <1000>;
+                  }
+                };
+              };
+
+          bias-disable: true
+
+          output-high: true
+
+          output-low: true
+
+          input-enable: true
+
+          input-disable: true
+
+          input-schmitt-enable: true
+
+          input-schmitt-disable: true
+
+        required:
+          - pinmux
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-controller
+  - '#interrupt-cells'
+  - gpio-controller
+  - '#gpio-cells'
+  - gpio-ranges
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/pinctrl/mt8186-pinfunc.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+    pio: pinctrl@10005000 {
+      compatible = "mediatek,mt8186-pinctrl";
+      reg = <0x10005000 0x1000>,
+            <0x10002000 0x0200>,
+            <0x10002200 0x0200>,
+            <0x10002400 0x0200>,
+            <0x10002600 0x0200>,
+            <0x10002A00 0x0200>,
+            <0x10002c00 0x0200>,
+            <0x1000b000 0x1000>;
+      reg-names = "iocfg0", "iocfg_bm", "iocfg_bl",
+                  "iocfg_br", "iocfg_lm", "iocfg_rb",
+                  "iocfg_tl", "eint";
+      gpio-controller;
+      #gpio-cells = <2>;
+      gpio-ranges = <&pio 0 0 185>;
+      interrupt-controller;
+      interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH 0>;
+      #interrupt-cells = <2>;
+
+      pio-pins {
+        pins {
+          pinmux = <PINMUX_GPIO0__FUNC_GPIO0>;
+          output-low;
+        };
+      };
+
+      spi0-pins {
+        pins-spi {
+          pinmux = <PINMUX_GPIO0__FUNC_SPI0_CLK_B>,
+                   <PINMUX_GPIO1__FUNC_SPI0_CSB_B>,
+                   <PINMUX_GPIO2__FUNC_SPI0_MO_B>;
+          bias-disable;
+        };
+        pins-spi-mi {
+          pinmux = <PINMUX_GPIO3__FUNC_SPI0_MI_B>;
+          bias-pull-down;
+        };
+      };
+
+      i2c0-pins {
+        pins {
+          pinmux = <PINMUX_GPIO127__FUNC_SCL0>,
+                   <PINMUX_GPIO128__FUNC_SDA0>;
+          bias-pull-up = <MTK_PULL_SET_RSEL_001>;
+          mediatek,drive-strength-adv = <7>;
+        };
+      };
+    };
include/dt-bindings/pinctrl/mt8186-pinfunc.h new file +1174 -0

1,174 lines not on this page · raw message

Signature · 1 line
2.25.1
#2 lore raw

Re: [PATCH v4 1/3] dt-bindings: pinctrl: mt8186: add pinctrl file and binding document

Il 14/02/22 04:06, Guodong Liu ha scritto:

Quoted 16 lines

1. This patch adds pinctrl file for mt8186.
2. This patch adds mt8186 compatible node in binding document.

---
  .../bindings/pinctrl/pinctrl-mt8186.yaml      |  302 +++++
  include/dt-bindings/pinctrl/mt8186-pinfunc.h  | 1174 +++++++++++++++++
  2 files changed, 1476 insertions(+)

create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml create mode 100644 include/dt-bindings/pinctrl/mt8186-pinfunc.h

Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml new file +0 -0
new file mode 100644
index 000000000000..582d131af4e3

...snip...

include/dt-bindings/pinctrl/mt8186-pinfunc.h line 7

Quoted 13 lines
include/dt-bindings/pinctrl/mt8186-pinfunc.h new file +7 -0
new file mode 100644
index 000000000000..dcff86201a61
@@ -0,0 +1,1174 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+/*
+ * Copyright (C) 2021 MediaTek Inc.
+ * Author: Guodong Liu <[email protected]>
+ *
+ */
+

Hello,
I've just noticed that we have a typo here....

You wrote "MT8168", but this should be "MT8186" instead; please fix it.

P.S.: I'm sorry for not seeing that before!

Quoted 3 lines
include/dt-bindings/pinctrl/mt8186-pinfunc.h new file +3 -0
+#ifndef __MT8168_PINFUNC_H
+#define __MT8168_PINFUNC_H
+

..snip..

include/dt-bindings/pinctrl/mt8186-pinfunc.h line 1174

Quoted 2 lines
include/dt-bindings/pinctrl/mt8186-pinfunc.h new file +2 -0
+
+#endif /* __MT8168-PINFUNC_H */

Thank you,
Angelo

#3 lore raw

Re: [PATCH v4 1/3] dt-bindings: pinctrl: mt8186: add pinctrl file and binding document

-----Original Message-----
From: AngeloGioacchino Del Regno < [email protected]>
To: Guodong Liu <[email protected]>, Linus Walleij < [email protected]>, Rob Herring <[email protected]>, Matthias Brugger <[email protected]>, Sean Wang <[email protected]>
Cc: Sean Wang <[email protected]>, [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH v4 1/3] dt-bindings: pinctrl: mt8186: add pinctrl file and binding document
Date: Mon, 14 Feb 2022 10:58:58 +0100

Il 14/02/22 04:06, Guodong Liu ha scritto:

Quoted 20 lines

1. This patch adds pinctrl file for mt8186.
2. This patch adds mt8186 compatible node in binding document.

---
  .../bindings/pinctrl/pinctrl-mt8186.yaml      |  302 +++++
  include/dt-bindings/pinctrl/mt8186-pinfunc.h  | 1174
+++++++++++++++++
  2 files changed, 1476 insertions(+)

create mode 100644
Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
create mode 100644 include/dt-bindings/pinctrl/mt8186-pinfunc.h

(quoted diff) +0 -0

mt8186.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl- mt8186.yaml
new file mode 100644
index 000000000000..582d131af4e3

Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml new file +0 -0

...snip...

Quoted 7 lines
include/dt-bindings/pinctrl/mt8186-pinfunc.h new file +0 -0
new file mode 100644
index 000000000000..dcff86201a61

include/dt-bindings/pinctrl/mt8186-pinfunc.h line 7

Quoted 7 lines
include/dt-bindings/pinctrl/mt8186-pinfunc.h new file +7 -0
@@ -0,0 +1,1174 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+/*
+ * Copyright (C) 2021 MediaTek Inc.
+ * Author: Guodong Liu <[email protected]>
+ *
+ */
+

Hello,
I've just noticed that we have a typo here....

You wrote "MT8168", but this should be "MT8186" instead; please fix it.

P.S.: I'm sorry for not seeing that before!

Quoted 3 lines
include/dt-bindings/pinctrl/mt8186-pinfunc.h new file +3 -0
+#ifndef __MT8168_PINFUNC_H
+#define __MT8168_PINFUNC_H
+

..snip..

include/dt-bindings/pinctrl/mt8186-pinfunc.h line 1174

Quoted 2 lines
include/dt-bindings/pinctrl/mt8186-pinfunc.h new file +2 -0
+
+#endif /* __MT8168-PINFUNC_H */

Thank you,
Angelo

Hello Angelo,

we will update it for next version.

Thanks
Guodong

#4 lore raw

PATCH v4 2/3 pinctrl: add pinctrl driver on mt8186

In reply to Guodong Liu

This commit includes pinctrl driver for mt8186.

---
 drivers/pinctrl/mediatek/Kconfig              |    7 +
 drivers/pinctrl/mediatek/Makefile             |    1 +
 drivers/pinctrl/mediatek/pinctrl-mt8186.c     | 1311 ++++++++++
 drivers/pinctrl/mediatek/pinctrl-mtk-mt8186.h | 2186 +++++++++++++++++
 4 files changed, 3505 insertions(+)
 create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt8186.c
 create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt8186.h
drivers/pinctrl/mediatek/Kconfig +7 -0
index 66db4ac5d169..8dca1ef04965 100644
@@ -147,6 +147,13 @@ config PINCTRL_MT8183
 	default ARM64 && ARCH_MEDIATEK
 	select PINCTRL_MTK_PARIS
 
+config PINCTRL_MT8186
+	bool "Mediatek MT8186 pin control"
+	depends on OF
+	depends on ARM64 || COMPILE_TEST
+	default ARM64 && ARCH_MEDIATEK
+	select PINCTRL_MTK_PARIS
+
 config PINCTRL_MT8192
 	bool "Mediatek MT8192 pin control"
 	depends on OF
drivers/pinctrl/mediatek/Makefile +1 -0
index 90f43bb9d9a7..31c3784c6089 100644
@@ -21,6 +21,7 @@ obj-$(CONFIG_PINCTRL_MT7986)	+= pinctrl-mt7986.o
 obj-$(CONFIG_PINCTRL_MT8167)	+= pinctrl-mt8167.o
 obj-$(CONFIG_PINCTRL_MT8173)	+= pinctrl-mt8173.o
 obj-$(CONFIG_PINCTRL_MT8183)	+= pinctrl-mt8183.o
+obj-$(CONFIG_PINCTRL_MT8186)	+= pinctrl-mt8186.o
 obj-$(CONFIG_PINCTRL_MT8192)	+= pinctrl-mt8192.o
 obj-$(CONFIG_PINCTRL_MT8195)    += pinctrl-mt8195.o
 obj-$(CONFIG_PINCTRL_MT8365)	+= pinctrl-mt8365.o
drivers/pinctrl/mediatek/pinctrl-mt8186.c new file +1311 -0

1,311 lines not on this page · raw message

drivers/pinctrl/mediatek/pinctrl-mtk-mt8186.h new file +2186 -0

1,669 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.25.1

Part of the diff is not shown here. View the raw message.

maintainer Reviewed-by on v4 2/3
#5 lore raw

Re: [PATCH v4 2/3] pinctrl: add pinctrl driver on mt8186

Il 14/02/22 04:06, Guodong Liu ha scritto:

Quoted 3 lines

This commit includes pinctrl driver for mt8186.

Quoted 9 lines
---
  drivers/pinctrl/mediatek/Kconfig              |    7 +
  drivers/pinctrl/mediatek/Makefile             |    1 +
  drivers/pinctrl/mediatek/pinctrl-mt8186.c     | 1311 ++++++++++
  drivers/pinctrl/mediatek/pinctrl-mtk-mt8186.h | 2186 +++++++++++++++++
  4 files changed, 3505 insertions(+)

create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt8186.c create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt8186.h

#6 lore raw

PATCH v4 3/3 pinctrl: canonical rsel resistance selection property

In reply to Guodong Liu

Change "mediatek,rsel_resistance_in_si_unit" to
"mediatek,rsel-resistance-in-si-unit"

Fixes fb34a9ae383a ("pinctrl: mediatek: support rsel feature")
---
 drivers/pinctrl/mediatek/pinctrl-paris.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/mediatek/pinctrl-paris.c +1 -1
index d4e02c5d74a8..38c0f0c4cf95 100644
@@ -989,7 +989,7 @@ int mtk_paris_pinctrl_probe(struct platform_device *pdev,
 	hw->nbase = hw->soc->nbase_names;
 
 	if (of_find_property(hw->dev->of_node,
-			     "mediatek,rsel_resistance_in_si_unit", NULL))
+			     "mediatek,rsel-resistance-in-si-unit", NULL))
 		hw->rsel_si_unit = true;
 	else
 		hw->rsel_si_unit = false;
Signature · 1 line
2.25.1
maintainer Reviewed-by on v4 3/3
#7 lore raw

Re: [PATCH v4 3/3] pinctrl: canonical rsel resistance selection property

Il 14/02/22 04:06, Guodong Liu ha scritto:

Quoted 5 lines

Change "mediatek,rsel_resistance_in_si_unit" to
"mediatek,rsel-resistance-in-si-unit"

Fixes fb34a9ae383a ("pinctrl: mediatek: support rsel feature")

A note for maintainers: luckily, this property hasn't been used in any device-tree yet, so we luckily (since naming convention was not compliant) don't have to worry about retro-compatibility for old DTs; so...

Quoted 18 lines
---
  drivers/pinctrl/mediatek/pinctrl-paris.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/mediatek/pinctrl-paris.c +1 -1
index d4e02c5d74a8..38c0f0c4cf95 100644
@@ -989,7 +989,7 @@ int mtk_paris_pinctrl_probe(struct platform_device *pdev,
  	hw->nbase = hw->soc->nbase_names;
 
  	if (of_find_property(hw->dev->of_node,
-			     "mediatek,rsel_resistance_in_si_unit", NULL))
+			     "mediatek,rsel-resistance-in-si-unit", NULL))
  		hw->rsel_si_unit = true;
  	else
  		hw->rsel_si_unit = false;