Skip to contentSkip to conversation

i40e: Fix interface init with MSI interrupts (no MSI-X)

PATCH Superseded Michal Maloszewski 2 participants 2 messages Feb 15, 2022

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i40e: Fix interface init with MSI interrupts (no MSI-X)

Fix the inability to bring an interface up on a setup with only MSI interrupts enabled (no MSI-X).
Solution is to add a default number of QPs = 1. This is enough, since without MSI-X support driver enables only a basic feature set.

Fixes bc6d33c8d93f ("i40e: Fix the number of queues available to be mapped for use")
---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/net/ethernet/intel/i40e/i40e_main.c +3 -0
index 8572993972ef..dfaa56235b60 100644
@@ -1840,6 +1840,9 @@ static void i40e_vsi_setup_queue_map(struct i40e_vsi *vsi,
 			vsi->num_queue_pairs = vsi->req_queue_pairs;
 		else if (pf->flags & I40E_FLAG_MSIX_ENABLED)
 			vsi->num_queue_pairs = pf->num_lan_msix;
+		else
+			/* We need at least one queue pair for the interface to be usable */
+			vsi->num_queue_pairs = 1;
 	}
 
 	/* Number of queues per enabled TC */
Signature · 1 line
2.27.0
#1 lore raw

PATCH 1/1 i40e: Fix interface init with MSI interrupts (no MSI-X)

Dear Michal,

Am 15.02.22 um 14:35 schrieb Michal Maloszewski:

Just a note, that the time is from the future again. (Some Intel employee told me, the Intel firewall (in Poland offices?) blocks NTP, and you have to configure an internal NTP server, which should now also be documented your intranet.)

Quoted 2 lines

Fix the inability to bring an interface up on a setup with only MSI interrupts enabled (no MSI-X).

Is there an error logged?

Quoted 2 lines

Solution is to add a default number of QPs = 1. This is enough, since without MSI-X support driver enables only a basic feature set.

Please reflow for 75 characters per line (and maybe add a blank line between paragraphs).

Quoted 1 line
Fixes bc6d33c8d93f ("i40e: Fix the number of queues available to be mapped for use")

Wow, that went into 4.16-rc1. Any idea, why it hasn?t been reported until now?

Quoted 11 lines
---
  drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +++
  1 file changed, 3 insertions(+)
drivers/net/ethernet/intel/i40e/i40e_main.c +0 -0
index 8572993972ef..dfaa56235b60 100644

drivers/net/ethernet/intel/i40e/i40e_main.c static void i40e_vsi_setup_queue_map(struct i40e_vsi *vsi, · line 1845

Quoted 6 lines
drivers/net/ethernet/intel/i40e/i40e_main.c +3 -0
@@ -1840,6 +1840,9 @@ static void i40e_vsi_setup_queue_map(struct i40e_vsi *vsi,
  			vsi->num_queue_pairs = vsi->req_queue_pairs;
  		else if (pf->flags & I40E_FLAG_MSIX_ENABLED)
  			vsi->num_queue_pairs = pf->num_lan_msix;
+		else
+			/* We need at least one queue pair for the interface to be usable */
+			vsi->num_queue_pairs = 1;

Maybe you could rewrite the comment above the if statement (not in this diff), and integrate the information about MSI and MSI-X.

drivers/net/ethernet/intel/i40e/i40e_main.c static void i40e_vsi_setup_queue_map(struct i40e_vsi *vsi, · line 1848

Quoted 3 lines
drivers/net/ethernet/intel/i40e/i40e_main.c +0 -0
  	}
 
  	/* Number of queues per enabled TC */

Kind regards,

Paul