soc: add microchip polarfire soc system controller
Subsystems (3)
[email protected]
maintainerv3 cover soc: add microchip polarfire soc system controller
From: Conor Dooley <[email protected]>
Since I submitted version 1 of this driver, I attempted to upstream bindings for devices dependant on the system controller [0]. In that process, Rob said that since they were devices with no resources, other than a reference to the system controller, the devices should not be in the device tree & instead they should be created by the system controller (which it now does).
Since the sub devices using mpfs_sys_controller_get will now have the system controller as their parent, this function now just checks if the parent device is compatible. If the parent is compatible, the sub- device then attempts to register as a consumer of the system controller
@Arnd Hopefully this clears up the issues you had with reference counting & the lack of checks as to whether the device found by mpfs_sys_controller_get was in fact a system controller.
Depends on [0] to change the compatible string in the dt-binding. Thanks,
Conor.
Changes since v2:
- system controller is no longer an mfd, system controller now creates sub devices for itself.
- specify that a mpfs_mss_msg is used in mpfs_blocking_transaction rather than using a void pointer.
- as the subdevices are now all created by the system controller, the get() function now checks that the requesting device's parent is compatible.
- mpfs_sys_controller_get now passes a pointer to the device that is trying to register as a consumer rather than a device node.
Changes since v1:
- system controller is now an mfd
- parentage is now used to get the device node on the system controller
- mpfs_sys_controller_get() now updates the reference count
- "polarfire-soc" in compat string changed to "mpfs"
[0] https://lore.kernel.org/linux-riscv/[email protected]/
Conor Dooley (1):
soc: add microchip polarfire soc system controller
drivers/soc/Kconfig | 1 + drivers/soc/Makefile | 1 + drivers/soc/microchip/Kconfig | 10 + drivers/soc/microchip/Makefile | 1 + drivers/soc/microchip/mpfs-sys-controller.c | 194 ++++++++++++++++++++ include/soc/microchip/mpfs.h | 4 +- 6 files changed, 209 insertions(+), 2 deletions(-) create mode 100644 drivers/soc/microchip/Kconfig create mode 100644 drivers/soc/microchip/Makefile create mode 100644 drivers/soc/microchip/mpfs-sys-controller.c
Signature · 1 line
2.35.1
[email protected]
maintainerPATCH v3 1/1 soc: add microchip polarfire soc system controller
From: Conor Dooley <[email protected]>
This driver provides an interface for other drivers to access the functions of the system controller on the Microchip PolarFire SoC.
--- drivers/soc/Kconfig | 1 + drivers/soc/Makefile | 1 + drivers/soc/microchip/Kconfig | 10 + drivers/soc/microchip/Makefile | 1 + drivers/soc/microchip/mpfs-sys-controller.c | 194 ++++++++++++++++++++ include/soc/microchip/mpfs.h | 4 +- 6 files changed, 209 insertions(+), 2 deletions(-) create mode 100644 drivers/soc/microchip/Kconfig create mode 100644 drivers/soc/microchip/Makefile create mode 100644 drivers/soc/microchip/mpfs-sys-controller.c
drivers/soc/Kconfig +1 -0
@@ -13,6 +13,7 @@ source "drivers/soc/imx/Kconfig" source "drivers/soc/ixp4xx/Kconfig" source "drivers/soc/litex/Kconfig" source "drivers/soc/mediatek/Kconfig" +source "drivers/soc/microchip/Kconfig" source "drivers/soc/qcom/Kconfig" source "drivers/soc/renesas/Kconfig" source "drivers/soc/rockchip/Kconfig"
drivers/soc/Makefile +1 -0
@@ -18,6 +18,7 @@ obj-y += ixp4xx/ obj-$(CONFIG_SOC_XWAY) += lantiq/ obj-$(CONFIG_LITEX_SOC_CONTROLLER) += litex/ obj-y += mediatek/ +obj-y += microchip/ obj-y += amlogic/ obj-y += qcom/ obj-y += renesas/
drivers/soc/microchip/Kconfig new file +10 -0
@@ -0,0 +1,10 @@ +config POLARFIRE_SOC_SYS_CTRL + tristate "POLARFIRE_SOC_SYS_CTRL" + depends on POLARFIRE_SOC_MAILBOX + help + This driver adds support for the PolarFire SoC (MPFS) system controller. + + To compile this driver as a module, choose M here. the + module will be called mpfs_system_controller. + + If unsure, say N.
drivers/soc/microchip/Makefile new file +1 -0
@@ -0,0 +1 @@ +obj-$(CONFIG_POLARFIRE_SOC_SYS_CTRL) += mpfs-sys-controller.o
drivers/soc/microchip/mpfs-sys-controller.c new file +194 -0
194 lines not on this page · raw message
include/soc/microchip/mpfs.h +2 -2
@@ -34,9 +34,9 @@ struct mpfs_mss_response {#if IS_ENABLED (CONFIG_POLARFIRE_SOC_SYS_CTRL ) -int mpfs_blocking_transaction (struct mpfs_sys_controller *mpfs_client,void *msg); +int mpfs_blocking_transaction (struct mpfs_sys_controller *mpfs_client,struct mpfs_mss_msg *msg); -struct mpfs_sys_controller *mpfs_sys_controller_get (struct device_node *mailbox_node); +struct mpfs_sys_controller *mpfs_sys_controller_get (struct device *dev);#endif /* if IS_ENABLED(CONFIG_POLARFIRE_SOC_SYS_CTRL) */
Signature · 1 line
2.35.1