Skip to content

soc: add microchip polarfire soc system controller

[email protected] linux-arm-kernel linux-riscv lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest1 patch 1 replyIn review
  2. v31 patch 0 repliesSuperseded
  3. v21 patch 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch8 repliesSuperseded

Changes in v4 from the cover letter

- switch to devm_kzalloc in probe
- unify exports to use the non GPL version

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1soc: add microchip polarfire soc system controllerdrivers/soc/Kconfig drivers/soc/Makefile drivers/soc/microchip/Kconfig +3 more+209 -21 reply

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchNicolas Ferre
1/1A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/1] soc: add microchip polarfire soc system controller

From: Conor Dooley <[email protected]>

Since I submitted version 1 of this driver, I attempted to upstream bindings for devices dependant on the system controller [0]. In that process, Rob said that since they were devices with no resources, other than a reference to the system controller, the devices should not be in the device tree & instead they should be created by the system controller (which it now does).

Since the sub devices using mpfs_sys_controller_get will now have the system controller as their parent, this function now just checks if the parent device is compatible. If the parent is compatible, the sub- device then attempts to register as a consumer of the system controller

@Arnd Hopefully this clears up the issues you had with reference counting & the lack of checks as to whether the device found by mpfs_sys_controller_get was in fact a system controller.

Depends on [0] to change the compatible string in the dt-binding. Thanks,
Conor.

Changes since v3:
- switch to devm_kzalloc in probe
- unify exports to use the non GPL version

Changes since v2:
- system controller is no longer an mfd, system controller now creates sub devices for itself.
- specify that a mpfs_mss_msg is used in mpfs_blocking_transaction rather than using a void pointer.
- as the subdevices are now all created by the system controller, the get() function now checks that the requesting device's parent is compatible.
- mpfs_sys_controller_get now passes a pointer to the device that is trying to register as a consumer rather than a device node.

Changes since v1:
- system controller is now an mfd
- parentage is now used to get the device node on the system controller
- mpfs_sys_controller_get() now updates the reference count
- "polarfire-soc" in compat string changed to "mpfs"

[0] https://lore.kernel.org/linux-riscv/[email protected]/

Conor Dooley (1):
soc: add microchip polarfire soc system controller

 drivers/soc/Kconfig                         |   1 +
 drivers/soc/Makefile                        |   1 +
 drivers/soc/microchip/Kconfig               |  10 +
 drivers/soc/microchip/Makefile              |   1 +
 drivers/soc/microchip/mpfs-sys-controller.c | 194 ++++++++++++++++++++
 include/soc/microchip/mpfs.h                |   4 +-
 6 files changed, 209 insertions(+), 2 deletions(-)
 create mode 100644 drivers/soc/microchip/Kconfig
 create mode 100644 drivers/soc/microchip/Makefile
 create mode 100644 drivers/soc/microchip/mpfs-sys-controller.c
Signature · 1 line
2.35.1