Skip to contentSkip to conversation

ARM: mvebu: x530: clearfog: Add ODT configuration

PATCH In review Chris Packham 3 participants 4 messages Mar 1, 2022 – Mar 4, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: mvebu: x530: clearfog: Add ODT configuration

Commit 369e532691e0 ("ddr: marvell: a38x: allow board specific ODT configuration") added the odt_config member to struct mv_ddr_topology_map ahead of the clk_enable and ck_delay members. This means that any boards that configured either of clk_enable or ck_delay needed to have their board topology updated. This affects the x530 and clearfog boards. Other A38x boards don't touch any of the trailing members of mv_ddr_topology_map so don't need updating.

Fixes 369e532691e0 ("ddr: marvell: a38x: allow board specific ODT configuration")

---

 board/alliedtelesis/x530/x530.c    | 1 +
 board/solidrun/clearfog/clearfog.c | 1 +
 2 files changed, 2 insertions(+)
board/alliedtelesis/x530/x530.c +1 -0
index 8b31045a0743..c0ec2afa3011 100644
@@ -73,6 +73,7 @@ static struct mv_ddr_topology_map board_topology_map = {
 	{0},				/* timing parameters */
 	{ {0} },			/* electrical configuration */
 	{0},				/* electrical parameters */
+	0,				/* ODT configuration */
 	0,				/* Clock enable mask */
 	160				/* Clock delay */
 };
board/solidrun/clearfog/clearfog.c +1 -0
index c920cf8d6b50..03adb591d826 100644
@@ -147,6 +147,7 @@ static struct mv_ddr_topology_map board_topology_map = {
 	{0},				/* timing parameters */
 	{ {0} },			/* electrical configuration */
 	{0,},				/* electrical parameters */
+	0,				/* ODT configuration */
 	0x3,				/* clock enable mask */
 };
 
Signature · 1 line
2.35.1
Acked-by on v1 1/1
#1 lore raw

Hi Chris,

Quoted 10 lines · Chris Packham

Commit 369e532691e0 ("ddr: marvell: a38x: allow board specific ODT configuration") added the odt_config member to struct mv_ddr_topology_map ahead of the clk_enable and ck_delay members. This means that any boards that configured either of clk_enable or ck_delay needed to have their board topology updated. This affects the x530 and clearfog boards. Other A38x boards don't touch any of the trailing members of mv_ddr_topology_map so don't need updating.

Fixes 369e532691e0 ("ddr: marvell: a38x: allow board specific ODT configuration")

Thanks,
baruch

Quoted 29 lines

---

 board/alliedtelesis/x530/x530.c    | 1 +
 board/solidrun/clearfog/clearfog.c | 1 +
 2 files changed, 2 insertions(+)
board/alliedtelesis/x530/x530.c +1 -0
index 8b31045a0743..c0ec2afa3011 100644
@@ -73,6 +73,7 @@ static struct mv_ddr_topology_map board_topology_map = {
 	{0},				/* timing parameters */
 	{ {0} },			/* electrical configuration */
 	{0},				/* electrical parameters */
+	0,				/* ODT configuration */
 	0,				/* Clock enable mask */
 	160				/* Clock delay */
 };
board/solidrun/clearfog/clearfog.c +1 -0
index c920cf8d6b50..03adb591d826 100644
@@ -147,6 +147,7 @@ static struct mv_ddr_topology_map board_topology_map = {
 	{0},				/* timing parameters */
 	{ {0} },			/* electrical configuration */
 	{0,},				/* electrical parameters */
+	0,				/* ODT configuration */
 	0x3,				/* clock enable mask */
 };
Signature · 3 lines
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - [email protected] - tel: +972.52.368.4656, http://www.tkos.co.il -
Reviewed-by on v1 1/1
#2 lore raw
In reply to Chris Packham
Quoted 10 lines · Chris Packham

Commit 369e532691e0 ("ddr: marvell: a38x: allow board specific ODT configuration") added the odt_config member to struct mv_ddr_topology_map ahead of the clk_enable and ck_delay members. This means that any boards that configured either of clk_enable or ck_delay needed to have their board topology updated. This affects the x530 and clearfog boards. Other A38x boards don't touch any of the trailing members of mv_ddr_topology_map so don't need updating.

Fixes 369e532691e0 ("ddr: marvell: a38x: allow board specific ODT configuration")

Thanks,
Stefan

Quoted 23 lines

---

  board/alliedtelesis/x530/x530.c    | 1 +
  board/solidrun/clearfog/clearfog.c | 1 +
  2 files changed, 2 insertions(+)
board/alliedtelesis/x530/x530.c +1 -0
index 8b31045a0743..c0ec2afa3011 100644
@@ -73,6 +73,7 @@ static struct mv_ddr_topology_map board_topology_map = {
  	{0},				/* timing parameters */
  	{ {0} },			/* electrical configuration */
  	{0},				/* electrical parameters */
+	0,				/* ODT configuration */
  	0,				/* Clock enable mask */
  	160				/* Clock delay */
  };
board/solidrun/clearfog/clearfog.c +0 -0
index c920cf8d6b50..03adb591d826 100644

board/solidrun/clearfog/clearfog.c static struct mv_ddr_topology_map board_topology_map = { · line 153

Quoted 7 lines
board/solidrun/clearfog/clearfog.c +1 -0
@@ -147,6 +147,7 @@ static struct mv_ddr_topology_map board_topology_map = {
  	{0},				/* timing parameters */
  	{ {0} },			/* electrical configuration */
  	{0,},				/* electrical parameters */
+	0,				/* ODT configuration */
  	0x3,				/* clock enable mask */
  };
 

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
#3 lore raw
In reply to Chris Packham
Quoted 10 lines · Chris Packham

Commit 369e532691e0 ("ddr: marvell: a38x: allow board specific ODT configuration") added the odt_config member to struct mv_ddr_topology_map ahead of the clk_enable and ck_delay members. This means that any boards that configured either of clk_enable or ck_delay needed to have their board topology updated. This affects the x530 and clearfog boards. Other A38x boards don't touch any of the trailing members of mv_ddr_topology_map so don't need updating.

Fixes 369e532691e0 ("ddr: marvell: a38x: allow board specific ODT configuration")

Applied to u-boot-marvell/master

Thanks,
Stefan

Quoted 23 lines

---

  board/alliedtelesis/x530/x530.c    | 1 +
  board/solidrun/clearfog/clearfog.c | 1 +
  2 files changed, 2 insertions(+)
board/alliedtelesis/x530/x530.c +1 -0
index 8b31045a0743..c0ec2afa3011 100644
@@ -73,6 +73,7 @@ static struct mv_ddr_topology_map board_topology_map = {
  	{0},				/* timing parameters */
  	{ {0} },			/* electrical configuration */
  	{0},				/* electrical parameters */
+	0,				/* ODT configuration */
  	0,				/* Clock enable mask */
  	160				/* Clock delay */
  };
board/solidrun/clearfog/clearfog.c +0 -0
index c920cf8d6b50..03adb591d826 100644

board/solidrun/clearfog/clearfog.c static struct mv_ddr_topology_map board_topology_map = { · line 153

Quoted 7 lines
board/solidrun/clearfog/clearfog.c +1 -0
@@ -147,6 +147,7 @@ static struct mv_ddr_topology_map board_topology_map = {
  	{0},				/* timing parameters */
  	{ {0} },			/* electrical configuration */
  	{0,},				/* electrical parameters */
+	0,				/* ODT configuration */
  	0x3,				/* clock enable mask */
  };
 

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]