mailbox: tegra-hsp: Flush whole channel
Subsystems (2)
PATCH v2 1/1 mailbox: tegra-hsp: Flush whole channel
From: Pekka Pessi <[email protected]>
The txdone can re-fill the mailbox. Keep polling the mailbox during the flush until all the messages have been delivered.
This fixes an issue with the Tegra Combined UART (TCU) where output can get truncated under high traffic load.
---
Changes in v2:
- add Fixes: line
- Cc stable
drivers/mailbox/tegra-hsp.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/mailbox/tegra-hsp.c +5 -0
@@ -412,6 +412,11 @@ static int tegra_hsp_mailbox_flush(struct mbox_chan *chan, value =tegra_hsp_channel_readl (ch,HSP_SM_SHRD_MBOX );if ((value &HSP_SM_SHRD_MBOX_FULL ) ==0 ) {mbox_chan_txdone (chan,0 ); + +/* Wait until channel is empty */ +if (chan->active_req !=NULL ) +continue ; +return 0 ; }
Signature · 1 line
2.35.1
Jon Hunter
maintainerHi Jassi,
Quoted 27 lines · Thierry Reding
From: Pekka Pessi <[email protected]>
The txdone can re-fill the mailbox. Keep polling the mailbox during the flush until all the messages have been delivered.
This fixes an issue with the Tegra Combined UART (TCU) where output can get truncated under high traffic load.
Signed-off-by Pekka Pessi <[email protected]>Tested-by Jon Hunter <[email protected]>Fixes 91b1b1c3da8a ("mailbox: tegra-hsp: Add support for shared mailboxes")Signed-off-by Thierry Reding <[email protected]>---
Changes in v2:
- add Fixes: line
- Cc stabledrivers/mailbox/tegra-hsp.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/mailbox/tegra-hsp.c +0
-0@@ -412,6 +412,11 @@ static int tegra_hsp_mailbox_flush(struct mbox_chan *chan, value =tegra_hsp_channel_readl (ch,HSP_SM_SHRD_MBOX );
drivers/mailbox/tegra-hsp.c static int tegra_hsp_mailbox_flush(struct mbox_chan *chan, · line 422
Quoted 10 lines
drivers/mailbox/tegra-hsp.c +5
-0if ((value &HSP_SM_SHRD_MBOX_FULL ) ==0 ) {mbox_chan_txdone (chan,0 ); + +/* Wait until channel is empty */ +if (chan->active_req !=NULL ) +continue ; +return 0 ; }
Any feedback on this? Can we queue this up for v5.18?
Thanks
Jon
Signature · 1 line
nvpublic
Quoted 35 lines · Jon Hunter
Hi Jassi,
Quoted 32 lines · Thierry Reding
From: Pekka Pessi <[email protected]>
The txdone can re-fill the mailbox. Keep polling the mailbox during the flush until all the messages have been delivered.
This fixes an issue with the Tegra Combined UART (TCU) where output can get truncated under high traffic load.
Signed-off-by Pekka Pessi <[email protected]>Tested-by Jon Hunter <[email protected]>Fixes 91b1b1c3da8a ("mailbox: tegra-hsp: Add support for shared mailboxes")Signed-off-by Thierry Reding <[email protected]>---
Changes in v2:
- add Fixes: line
- Cc stable
drivers/mailbox/tegra-hsp.c| 5 +++++1 file changed, 5 insertions(+)drivers/mailbox/tegra-hsp.c +2
-0@@ -412,6 +412,11 @@ static int tegra_hsp_mailbox_flush(structmbox_chan *chan, value = tegra_hsp_channel_readl(ch, HSP_SM_SHRD_MBOX); if ((value & HSP_SM_SHRD_MBOX_FULL) == 0) { mbox_chan_txdone(chan, 0); + + /* Wait until channel is empty */
Quoted 8 lines
drivers/mailbox/tegra-hsp.c static int tegra_hsp_mailbox_flush(struct mbox_chan *chan, · line 421
Quoted 5 lines
drivers/mailbox/tegra-hsp.c +3
-0+ if (chan->active_req != NULL) + continue; + return 0; }Any feedback on this? Can we queue this up for v5.18?
Feel free to add my ...
Jon
Signature · 1 line
nvpublic
Jon Hunter
maintainerJassi,
Quoted 47 lines · Jon Hunter
Quoted 35 lines · Jon Hunter
Hi Jassi,
Quoted 32 lines · Thierry Reding
From: Pekka Pessi <[email protected]>
The txdone can re-fill the mailbox. Keep polling the mailbox during the flush until all the messages have been delivered.
This fixes an issue with the Tegra Combined UART (TCU) where output can get truncated under high traffic load.
Signed-off-by Pekka Pessi <[email protected]>Tested-by Jon Hunter <[email protected]>Fixes 91b1b1c3da8a ("mailbox: tegra-hsp: Add support for shared mailboxes")Signed-off-by Thierry Reding <[email protected]>---
Changes in v2:
- add Fixes: line
- Cc stable
drivers/mailbox/tegra-hsp.c| 5 +++++1 file changed, 5 insertions(+)drivers/mailbox/tegra-hsp.c +2
-0@@ -412,6 +412,11 @@ static int tegra_hsp_mailbox_flush(structmbox_chan *chan, value = tegra_hsp_channel_readl(ch, HSP_SM_SHRD_MBOX); if ((value & HSP_SM_SHRD_MBOX_FULL) == 0) { mbox_chan_txdone(chan, 0); + + /* Wait until channel is empty */Quoted 8 lines
drivers/mailbox/tegra-hsp.c static int tegra_hsp_mailbox_flush(struct mbox_chan *chan, · line 421
Quoted 5 lines
drivers/mailbox/tegra-hsp.c +3
-0+ if (chan->active_req != NULL) + continue; + return 0; }Any feedback on this? Can we queue this up for v5.18?
Quoted 3 lines
Feel free to add my ...
Reviewed-by Jon Hunter <[email protected]>
Any feedback?
Jon
Signature · 1 line
nvpublic
Jassi Brar
maintainerQuoted 6 lines · Jon Hunter
Jassi,
Quoted 2 lines
Reviewed-by Jon Hunter <[email protected]>Any feedback?
thnx