Skip to contentSkip to conversation

mailbox: tegra-hsp: Flush whole channel

PATCH In review Thierry Reding 3 participants 5 messages Mar 2, 2022 – Mar 22, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mailbox: tegra-hsp: Flush whole channel

From: Pekka Pessi <[email protected]>

The txdone can re-fill the mailbox. Keep polling the mailbox during the flush until all the messages have been delivered.

This fixes an issue with the Tegra Combined UART (TCU) where output can get truncated under high traffic load.

Fixes 91b1b1c3da8a ("mailbox: tegra-hsp: Add support for shared mailboxes")

---
Changes in v2:
- add Fixes: line
- Cc stable

 drivers/mailbox/tegra-hsp.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/mailbox/tegra-hsp.c +5 -0
index acd0675da681..78f7265039c6 100644
@@ -412,6 +412,11 @@ static int tegra_hsp_mailbox_flush(struct mbox_chan *chan,
 		value = tegra_hsp_channel_readl(ch, HSP_SM_SHRD_MBOX);
 		if ((value & HSP_SM_SHRD_MBOX_FULL) == 0) {
 			mbox_chan_txdone(chan, 0);
+
+			/* Wait until channel is empty */
+			if (chan->active_req != NULL)
+				continue;
+
 			return 0;
 		}
 
Signature · 1 line
2.35.1
maintainer
#1 lore raw

Hi Jassi,

Quoted 27 lines · Thierry Reding

From: Pekka Pessi <[email protected]>

The txdone can re-fill the mailbox. Keep polling the mailbox during the flush until all the messages have been delivered.

This fixes an issue with the Tegra Combined UART (TCU) where output can get truncated under high traffic load.

Fixes 91b1b1c3da8a ("mailbox: tegra-hsp: Add support for shared mailboxes")

---
Changes in v2:
- add Fixes: line
- Cc stable

  drivers/mailbox/tegra-hsp.c | 5 +++++
  1 file changed, 5 insertions(+)
drivers/mailbox/tegra-hsp.c +0 -0
index acd0675da681..78f7265039c6 100644
@@ -412,6 +412,11 @@ static int tegra_hsp_mailbox_flush(struct mbox_chan *chan,
  		value = tegra_hsp_channel_readl(ch, HSP_SM_SHRD_MBOX);

drivers/mailbox/tegra-hsp.c static int tegra_hsp_mailbox_flush(struct mbox_chan *chan, · line 422

Quoted 10 lines
drivers/mailbox/tegra-hsp.c +5 -0
  		if ((value & HSP_SM_SHRD_MBOX_FULL) == 0) {
  			mbox_chan_txdone(chan, 0);
+
+			/* Wait until channel is empty */
+			if (chan->active_req != NULL)
+				continue;
+
  			return 0;
  		}
 

Any feedback on this? Can we queue this up for v5.18?

Thanks
Jon

Signature · 1 line
nvpublic
maintainer Reviewed-by
#2 lore raw
Quoted 35 lines · Jon Hunter

Hi Jassi,

Quoted 32 lines · Thierry Reding

From: Pekka Pessi <[email protected]>

The txdone can re-fill the mailbox. Keep polling the mailbox during the flush until all the messages have been delivered.

This fixes an issue with the Tegra Combined UART (TCU) where output can get truncated under high traffic load.

Fixes 91b1b1c3da8a ("mailbox: tegra-hsp: Add support for shared mailboxes")

---
Changes in v2:
- add Fixes: line
- Cc stable

  drivers/mailbox/tegra-hsp.c | 5 +++++

  1 file changed, 5 insertions(+)
drivers/mailbox/tegra-hsp.c +2 -0
index acd0675da681..78f7265039c6 100644
@@ -412,6 +412,11 @@ static int tegra_hsp_mailbox_flush(struct 
 mbox_chan *chan,
           value = tegra_hsp_channel_readl(ch, HSP_SM_SHRD_MBOX);
           if ((value & HSP_SM_SHRD_MBOX_FULL) == 0) {
               mbox_chan_txdone(chan, 0);
+
+            /* Wait until channel is empty */
Quoted 8 lines

drivers/mailbox/tegra-hsp.c static int tegra_hsp_mailbox_flush(struct mbox_chan *chan, · line 421

Quoted 5 lines
drivers/mailbox/tegra-hsp.c +3 -0
+            if (chan->active_req != NULL)
+                continue;
+
               return 0;
           }

Any feedback on this? Can we queue this up for v5.18?

Feel free to add my ...

Jon

Signature · 1 line
nvpublic
maintainer
#3 lore raw

Jassi,

Quoted 47 lines · Jon Hunter
Quoted 35 lines · Jon Hunter

Hi Jassi,

Quoted 32 lines · Thierry Reding

From: Pekka Pessi <[email protected]>

The txdone can re-fill the mailbox. Keep polling the mailbox during the flush until all the messages have been delivered.

This fixes an issue with the Tegra Combined UART (TCU) where output can get truncated under high traffic load.

Fixes 91b1b1c3da8a ("mailbox: tegra-hsp: Add support for shared mailboxes")

---
Changes in v2:
- add Fixes: line
- Cc stable

  drivers/mailbox/tegra-hsp.c | 5 +++++

  1 file changed, 5 insertions(+)
drivers/mailbox/tegra-hsp.c +2 -0
index acd0675da681..78f7265039c6 100644
@@ -412,6 +412,11 @@ static int tegra_hsp_mailbox_flush(struct 
 mbox_chan *chan,
           value = tegra_hsp_channel_readl(ch, HSP_SM_SHRD_MBOX);
           if ((value & HSP_SM_SHRD_MBOX_FULL) == 0) {
               mbox_chan_txdone(chan, 0);
+
+            /* Wait until channel is empty */
Quoted 8 lines

drivers/mailbox/tegra-hsp.c static int tegra_hsp_mailbox_flush(struct mbox_chan *chan, · line 421

Quoted 5 lines
drivers/mailbox/tegra-hsp.c +3 -0
+            if (chan->active_req != NULL)
+                continue;
+
               return 0;
           }

Any feedback on this? Can we queue this up for v5.18?

Quoted 3 lines

Feel free to add my ...

Any feedback?

Jon

Signature · 1 line
nvpublic