Skip to contentSkip to conversation

ACPI: Arm Generic Diagnostic Dump and Reset device

PATCH RESEND Superseded Ilkka Koskinen 2 participants 6 messages Mar 4, 2022 – Mar 8, 2022

Subsystems (2)

v5 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v5 cover ACPI: Arm Generic Diagnostic Dump and Reset device

Hi Lorenzo,

Would you prefer this version, which doesn't have platform device/driver any more?

--Ilkka

----

Arm Generic Diagnostic Dump and Reset device enables a maintainer to request OS to perform a diagnostic dump and reset a system via SDEI event or an interrupt. This patchset adds support for the SDEI path.

I do have a patch to enable the interrupt path as well but I'm holding it back since AGDI table is missing interrupt configuration fields (trigger type etc.).

The recently published specification is available at
https://developer.arm.com/documentation/den0093/latest

The patchset was tested on Ampere Altra/Mt. Jade.

The patchset applies on top of
git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm bleeding-edge (9db71e8e3027)

I also tested it works on top of Shuai Xue's new patches in bleeding-edge branch (c6f4ba2d2b9a)

From v1:
* Moved pdata to the stack and dropped unnecessary kzalloc() in agdi_init()
* Changed the ACPICA patch upstreaming order comment in the paragraph above

From v2:
* The first patch was split. The most of it was merged to ACPICA project at first and later ported to linux-acpi (fd919e37cb15914c6fe13e13d530a4f732407c6d). The rest are in the first patch.

From v3:
Fixed:
* Moved header files in alphabetical order and removed unnecessary ones

From v4:
* Platform device/driver stuff removed
* acpi_agdi_init() call moved from device_initcall to acpi_init()
* Slightly modified Kconfig text to keep checkpatch happy

Ilkka Koskinen (2):
ACPI: tables: Add AGDI to the list of known table signatures
ACPI: AGDI: Add support for Arm Generic Diagnostic Dump and Reset
device

 drivers/acpi/arm64/Kconfig  | 10 +++++++
 drivers/acpi/arm64/Makefile |  1 +
 drivers/acpi/arm64/agdi.c   | 52 +++++++++++++++++++++++++++++++++++++
 drivers/acpi/bus.c          |  2 ++
 drivers/acpi/tables.c       |  2 +-
 include/linux/acpi_agdi.h   | 13 ++++++++++
 6 files changed, 79 insertions(+), 1 deletion(-)
 create mode 100644 drivers/acpi/arm64/agdi.c
 create mode 100644 include/linux/acpi_agdi.h
Signature · 1 line
2.17.1
#1 lore raw

PATCH RESEND v5 1/2 ACPI: tables: Add AGDI to the list of known table signatures

Add AGDI to the list of known ACPI table signatures to allow the kernel to recognize it when upgrading tables via initrd.

---
 drivers/acpi/tables.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/tables.c +1 -1
index 369eb998c3d1..ceee808f7f2a 100644
@@ -545,7 +545,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {
 	ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
 	ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
 	ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
-	ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT };
+	ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT, ACPI_SIG_AGDI };
 
 #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
 
Signature · 1 line
2.17.1
#2 lore raw

PATCH RESEND v5 2/2 ACPI: AGDI: Add support for Arm Generic Diagnostic Dump and Reset device

In reply to Ilkka Koskinen

ACPI for Arm Components 1.1 Platform Design Document v1.1 [0] specifices Arm Generic Diagnostic Device Interface (AGDI). It allows an admin to issue diagnostic dump and reset via an SDEI event or an interrupt. This patch implements SDEI path.

[0] https://developer.arm.com/documentation/den0093/latest/

---
 drivers/acpi/arm64/Kconfig  | 10 +++++++
 drivers/acpi/arm64/Makefile |  1 +
 drivers/acpi/arm64/agdi.c   | 52 +++++++++++++++++++++++++++++++++++++
 drivers/acpi/bus.c          |  2 ++
 include/linux/acpi_agdi.h   | 13 ++++++++++
 5 files changed, 78 insertions(+)
 create mode 100644 drivers/acpi/arm64/agdi.c
 create mode 100644 include/linux/acpi_agdi.h
drivers/acpi/arm64/Kconfig +10 -0
index 6dba187f4f2e..d4a72835f328 100644
@@ -8,3 +8,13 @@ config ACPI_IORT
 
 config ACPI_GTDT
 	bool
+
+config ACPI_AGDI
+	bool "Arm Generic Diagnostic Dump and Reset Device Interface"
+	depends on ARM_SDE_INTERFACE
+	help
+	  Arm Generic Diagnostic Dump and Reset Device Interface (AGDI) is
+	  a standard that enables issuing a non-maskable diagnostic dump and
+	  reset command.
+
+	  If set, the kernel parses AGDI table and listens for the command.
drivers/acpi/arm64/Makefile +1 -0
index 66acbe77f46e..7b9e4045659d 100644
@@ -1,4 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0-only
+obj-$(CONFIG_ACPI_AGDI) 	+= agdi.o
 obj-$(CONFIG_ACPI_IORT) 	+= iort.o
 obj-$(CONFIG_ACPI_GTDT) 	+= gtdt.o
 obj-y				+= dma.o
drivers/acpi/arm64/agdi.c new file +52 -0

52 lines not on this page · raw message

drivers/acpi/bus.c +2 -0
index eaa511fc9c66..87b93f4df0cf 100644
@@ -26,6 +26,7 @@
 #include <asm/mpspec.h>
 #include <linux/dmi.h>
 #endif
+#include <linux/acpi_agdi.h>
 #include <linux/acpi_iort.h>
 #include <linux/acpi_viot.h>
 #include <linux/pci.h>
@@ -1386,6 +1387,7 @@ static int __init acpi_init(void)
 	acpi_debugger_init();
 	acpi_setup_sb_notify_handler();
 	acpi_viot_init();
+	acpi_agdi_init();
 	return 0;
 }
 
include/linux/acpi_agdi.h new file +13 -0
new file mode 100644
index 000000000000..f477f0b452fa
@@ -0,0 +1,13 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#ifndef __ACPI_AGDI_H__
+#define __ACPI_AGDI_H__
+
+#include <linux/acpi.h>
+
+#ifdef CONFIG_ACPI_AGDI
+void __init acpi_agdi_init(void);
+#else
+static inline void acpi_agdi_init(void) {}
+#endif
+#endif /* __ACPI_AGDI_H__ */
Signature · 1 line
2.17.1
#3 lore raw
In reply to Ilkka Koskinen
Quoted 4 lines · Ilkka Koskinen

Hi Lorenzo,

Would you prefer this version, which doesn't have platform device/driver any more?

I thought about that and in order to keep consistency it is better to keep the platform device model, so please resend the latest version platform device based and I will ACK it (hopefully it is not too late for v5.18).

Please note before resending it that sdei_event_unregister() requires a retry loop since it can return -EINPROGRESS (see sdei_unregister_ghes()).

Thanks,
Lorenzo

Quoted 61 lines

--Ilkka

----

Arm Generic Diagnostic Dump and Reset device enables a maintainer to request OS to perform a diagnostic dump and reset a system via SDEI event or an interrupt. This patchset adds support for the SDEI path.

I do have a patch to enable the interrupt path as well but I'm holding it back since AGDI table is missing interrupt configuration fields (trigger type etc.).

The recently published specification is available at
https://developer.arm.com/documentation/den0093/latest

The patchset was tested on Ampere Altra/Mt. Jade.

The patchset applies on top of
git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm bleeding-edge (9db71e8e3027)

I also tested it works on top of Shuai Xue's new patches in bleeding-edge branch (c6f4ba2d2b9a)

From v1:
* Moved pdata to the stack and dropped unnecessary kzalloc() in agdi_init()
* Changed the ACPICA patch upstreaming order comment in the paragraph above

From v2:
* The first patch was split. The most of it was merged to ACPICA project at first and later ported to linux-acpi (fd919e37cb15914c6fe13e13d530a4f732407c6d). The rest are in the first patch.

From v3:
Fixed:
* Moved header files in alphabetical order and removed unnecessary ones

From v4:
* Platform device/driver stuff removed
* acpi_agdi_init() call moved from device_initcall to acpi_init()
* Slightly modified Kconfig text to keep checkpatch happy

Ilkka Koskinen (2):
ACPI: tables: Add AGDI to the list of known table signatures
ACPI: AGDI: Add support for Arm Generic Diagnostic Dump and Reset
device

 drivers/acpi/arm64/Kconfig  | 10 +++++++
 drivers/acpi/arm64/Makefile |  1 +
 drivers/acpi/arm64/agdi.c   | 52 +++++++++++++++++++++++++++++++++++++
 drivers/acpi/bus.c          |  2 ++
 drivers/acpi/tables.c       |  2 +-
 include/linux/acpi_agdi.h   | 13 ++++++++++
 6 files changed, 79 insertions(+), 1 deletion(-)
 create mode 100644 drivers/acpi/arm64/agdi.c
 create mode 100644 include/linux/acpi_agdi.h
Signature · 1 line
2.17.1
#4 lore raw
Quoted 10 lines · Lorenzo Pieralisi
Quoted 4 lines · Ilkka Koskinen

Hi Lorenzo,

Would you prefer this version, which doesn't have platform device/driver any more?

I thought about that and in order to keep consistency it is better to keep the platform device model, so please resend the latest version platform device based and I will ACK it (hopefully it is not too late for v5.18).

Sure, I can do that. Just one question, do you still prefer agdi_init() getting called from acpi_init() or via device_initcall()?

Quoted 2 lines

Please note before resending it that sdei_event_unregister() requires a retry loop since it can return -EINPROGRESS (see sdei_unregister_ghes()).

Thanks for pointing out, I'll fix it.

Cheers, Ilkka

Quoted 66 lines

Thanks,
Lorenzo

Quoted 61 lines

--Ilkka

----

Arm Generic Diagnostic Dump and Reset device enables a maintainer to request OS to perform a diagnostic dump and reset a system via SDEI event or an interrupt. This patchset adds support for the SDEI path.

I do have a patch to enable the interrupt path as well but I'm holding it back since AGDI table is missing interrupt configuration fields (trigger type etc.).

The recently published specification is available at
https://developer.arm.com/documentation/den0093/latest

The patchset was tested on Ampere Altra/Mt. Jade.

The patchset applies on top of
git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm bleeding-edge (9db71e8e3027)

I also tested it works on top of Shuai Xue's new patches in bleeding-edge branch (c6f4ba2d2b9a)

From v1:
* Moved pdata to the stack and dropped unnecessary kzalloc() in agdi_init()
* Changed the ACPICA patch upstreaming order comment in the paragraph above

From v2:
* The first patch was split. The most of it was merged to ACPICA project at first and later ported to linux-acpi (fd919e37cb15914c6fe13e13d530a4f732407c6d). The rest are in the first patch.

From v3:
Fixed:
* Moved header files in alphabetical order and removed unnecessary ones

From v4:
* Platform device/driver stuff removed
* acpi_agdi_init() call moved from device_initcall to acpi_init()
* Slightly modified Kconfig text to keep checkpatch happy

Ilkka Koskinen (2):
ACPI: tables: Add AGDI to the list of known table signatures
ACPI: AGDI: Add support for Arm Generic Diagnostic Dump and Reset
device

 drivers/acpi/arm64/Kconfig  | 10 +++++++
 drivers/acpi/arm64/Makefile |  1 +
 drivers/acpi/arm64/agdi.c   | 52 +++++++++++++++++++++++++++++++++++++
 drivers/acpi/bus.c          |  2 ++
 drivers/acpi/tables.c       |  2 +-
 include/linux/acpi_agdi.h   | 13 ++++++++++
 6 files changed, 79 insertions(+), 1 deletion(-)
 create mode 100644 drivers/acpi/arm64/agdi.c
 create mode 100644 include/linux/acpi_agdi.h

--
2.17.1

#5 lore raw

On Mon, Mar 07, 2022 at 02:29:10PM -0800, Ilkka Koskinen wrote:

[...]

Quoted 10 lines
Quoted 7 lines
Quoted 2 lines

Would you prefer this version, which doesn't have platform device/driver any more?

I thought about that and in order to keep consistency it is better to keep the platform device model, so please resend the latest version platform device based and I will ACK it (hopefully it is not too late for v5.18).

Sure, I can do that. Just one question, do you still prefer agdi_init() getting called from acpi_init() or via device_initcall()?

In acpi_init(), thanks.

Lorenzo