Skip to contentSkip to conversation

dt-bindings: rtc: convert at91sam9 bindings to

PATCH Applied Sergiu Moga 5 participants 11 messages Mar 4, 2022 – Mar 8, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v4 cover dt-bindings: rtc: convert at91sam9 bindings to

This patch series addresses the conversion of the RTC binding for Atmel/Microchip SoCs to Device Tree Schema format. It also changes the node names from some of the "dtsi" files from "rtt" to the more generic "rtc", while adding the atmel,rtt-rtc-time-reg required property to the board files that were missing it.

Changes since v3:
- Removed unnecessary additional rtc node from arch/arm/boot/dts/at91sam9263ek.dts.
- Squashed commit related to the conversion of the binding to json-schema with the commit related to the usage of macros for the IRQ type of the binding's example.

Sergiu Moga (4):
ARM: dts: at91: Add the required atmel,rtt-rtc-time-reg property
ARM: dts: at91: Use the generic "rtc" node name for the rtt IPs
dt-bindings: rtc: convert at91sam9 bindings to json-schema
dt-bindings: rtc: at91: Add SAMA7G5 compatible strings list

 .../bindings/rtc/atmel,at91sam9-rtc.txt       | 25 -------
 .../bindings/rtc/atmel,at91sam9-rtc.yaml      | 69 +++++++++++++++++++
 arch/arm/boot/dts/at91sam9261ek.dts           |  4 ++
 arch/arm/boot/dts/at91sam9263ek.dts           |  4 ++
 arch/arm/boot/dts/at91sam9rlek.dts            |  4 ++
 arch/arm/boot/dts/sam9x60.dtsi                |  2 +-
 arch/arm/boot/dts/sama7g5.dtsi                |  2 +-
 7 files changed, 83 insertions(+), 27 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
Signature · 1 line
2.25.1
#1 lore raw

PATCH v4 1/4 ARM: dts: at91: Add the required `atmel,rtt-rtc-time-reg` property

Add the required atmel,rtt-rtc-time-reg property to the rtt nodes of the board files that were missing it.

---
 arch/arm/boot/dts/at91sam9261ek.dts | 4 ++++
 arch/arm/boot/dts/at91sam9263ek.dts | 4 ++++
 arch/arm/boot/dts/at91sam9rlek.dts  | 4 ++++
 3 files changed, 12 insertions(+)
arch/arm/boot/dts/at91sam9261ek.dts +4 -0
index beed819609e8..3c1f40b4a13e 100644
@@ -178,6 +178,10 @@ dbgu: serial@fffff200 {
 				status = "okay";
 			};
 
+			rtc@fffffd20 {
+				atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
+			};
+
 			watchdog@fffffd40 {
 				status = "okay";
 			};
arch/arm/boot/dts/at91sam9263ek.dts +4 -0
index 71f60576761a..4d922c10c26c 100644
@@ -102,6 +102,10 @@ mtd_dataflash@0 {
 				};
 			};
 
+			rtc@fffffd20 {
+				atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
+			};
+
 			watchdog@fffffd40 {
 				status = "okay";
 			};
arch/arm/boot/dts/at91sam9rlek.dts +4 -0
index 62981b39c815..a26f9f70b6b2 100644
@@ -212,6 +212,10 @@ watchdog@fffffd40 {
 				status = "okay";
 			};
 
+			rtc@fffffd20 {
+				atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
+			};
+
 			rtc@fffffe00 {
 				status = "okay";
 			};
Signature · 1 line
2.25.1
Reviewed-by on v4 1/4
#2 lore raw

Re: [PATCH v4 1/4] ARM: dts: at91: Add the required `atmel, rtt-rtc-time-reg` property

Quoted 6 lines · Sergiu Moga

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Add the required atmel,rtt-rtc-time-reg property to the rtt nodes of the board files that were missing it.

Quoted 59 lines
---
 arch/arm/boot/dts/at91sam9261ek.dts | 4 ++++
 arch/arm/boot/dts/at91sam9263ek.dts | 4 ++++
 arch/arm/boot/dts/at91sam9rlek.dts  | 4 ++++
 3 files changed, 12 insertions(+)
arch/arm/boot/dts/at91sam9261ek.dts +4 -0
index beed819609e8..3c1f40b4a13e 100644
@@ -178,6 +178,10 @@ dbgu: serial@fffff200 {
                                status = "okay";
                        };
 
+                       rtc@fffffd20 {
+                               atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
+                       };
+
                        watchdog@fffffd40 {
                                status = "okay";
                        };
arch/arm/boot/dts/at91sam9263ek.dts +4 -0
index 71f60576761a..4d922c10c26c 100644
@@ -102,6 +102,10 @@ mtd_dataflash@0 {
                                };
                        };
 
+                       rtc@fffffd20 {
+                               atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
+                       };
+
                        watchdog@fffffd40 {
                                status = "okay";
                        };
arch/arm/boot/dts/at91sam9rlek.dts +4 -1
index 62981b39c815..a26f9f70b6b2 100644
@@ -212,6 +212,10 @@ watchdog@fffffd40 {
                                status = "okay";
                        };
 
+                       rtc@fffffd20 {
+                               atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
+                       };
+
                        rtc@fffffe00 {
                                status = "okay";
                        };
--

2.25.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#3 lore raw

PATCH v4 2/4 ARM: dts: at91: Use the generic "rtc" node name for the rtt IPs

In reply to Sergiu Moga

As the DT specification recommends, the node names should be of a generic nature. Thus, the most appropriate generic node name for the at91 rtt IPs is the "rtc" node name.

---
 arch/arm/boot/dts/sam9x60.dtsi | 2 +-
 arch/arm/boot/dts/sama7g5.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/sam9x60.dtsi +1 -1
index 998629a3c34f..c328b67bea0c 100644
@@ -684,7 +684,7 @@ shutdown_controller: shdwc@fffffe10 {
 				status = "disabled";
 			};
 
-			rtt: rtt@fffffe20 {
+			rtt: rtc@fffffe20 {
 				compatible = "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt";
 				reg = <0xfffffe20 0x20>;
 				interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
arch/arm/boot/dts/sama7g5.dtsi +1 -1
index e6d0c90cf710..5d8841d0831a 100644
@@ -170,7 +170,7 @@ shdwc: shdwc@e001d010 {
 			status = "disabled";
 		};
 
-		rtt: rtt@e001d020 {
+		rtt: rtc@e001d020 {
 			compatible = "microchip,sama7g5-rtt", "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt";
 			reg = <0xe001d020 0x30>;
 			interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
Signature · 1 line
2.25.1
#4 lore raw

PATCH v4 3/4 dt-bindings: rtc: convert at91sam9 bindings to json-schema

In reply to Sergiu Moga

Convert RTC binding for Atmel/Microchip SoCs to Device Tree Schema format.

---
 .../bindings/rtc/atmel,at91sam9-rtc.txt       | 25 -------
 .../bindings/rtc/atmel,at91sam9-rtc.yaml      | 65 +++++++++++++++++++
 2 files changed, 65 insertions(+), 25 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt deleted +0 -25
deleted file mode 100644
index 3f0e2a5950eb..000000000000
@@ -1,25 +0,0 @@
-Atmel AT91SAM9260 Real Time Timer
-
-Required properties:
-- compatible: should be one of the following:
-	- "atmel,at91sam9260-rtt"
-	- "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt"
-- reg: should encode the memory region of the RTT controller
-- interrupts: rtt alarm/event interrupt
-- clocks: should contain the 32 KHz slow clk that will drive the RTT block.
-- atmel,rtt-rtc-time-reg: should encode the GPBR register used to store
-	the time base when the RTT is used as an RTC.
-	The first cell should point to the GPBR node and the second one
-	encode the offset within the GPBR block (or in other words, the
-	GPBR register used to store the time base).
-
-
-Example:
-
-rtt@fffffd20 {
-	compatible = "atmel,at91sam9260-rtt";
-	reg = <0xfffffd20 0x10>;
-	interrupts = <1 4 7>;
-	clocks = <&clk32k>;
-	atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
-};
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +65 -0

65 lines not on this page · raw message

Signature · 1 line
2.25.1
maintainer Reviewed-by on v4 3/4
#5 lore raw

Re: [PATCH v4 3/4] dt-bindings: rtc: convert at91sam9 bindings to json-schema

Quoted 10 lines · Sergiu Moga

Convert RTC binding for Atmel/Microchip SoCs to Device Tree Schema format.

---
 .../bindings/rtc/atmel,at91sam9-rtc.txt       | 25 -------
 .../bindings/rtc/atmel,at91sam9-rtc.yaml      | 65 +++++++++++++++++++
 2 files changed, 65 insertions(+), 25 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
Reviewed-by on v4 3/4
#6 lore raw

Re: [PATCH v4 3/4] dt-bindings: rtc: convert at91sam9 bindings to json-schema

In reply to Sergiu Moga
Quoted 11 lines · Sergiu Moga

Convert RTC binding for Atmel/Microchip SoCs to Device Tree Schema format.

---
 .../bindings/rtc/atmel,at91sam9-rtc.txt       | 25 -------
 .../bindings/rtc/atmel,at91sam9-rtc.yaml      | 65 +++++++++++++++++++
 2 files changed, 65 insertions(+), 25 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml

Best regards,
Krzysztof

maintainer Applied
#7 lore raw

Re: (subset) [PATCH v4 3/4] dt-bindings: rtc: convert at91sam9 bindings to json-schema

In reply to Sergiu Moga
Quoted 4 lines · Sergiu Moga

Convert RTC binding for Atmel/Microchip SoCs to Device Tree Schema format.

Applied, thanks!

[3/4] dt-bindings: rtc: convert at91sam9 bindings to json-schema

      commit: 5b05198b3108d5d287da8c457183855fb91ae4cc

Best regards,

Signature · 1 line
Alexandre Belloni <[email protected]>
#8 lore raw

PATCH v4 4/4 dt-bindings: rtc: at91: Add SAMA7G5 compatible strings list

In reply to Sergiu Moga

Add compatible strings list for SAMA7G5.

---
 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml +4 -0
index d2452067bfe4..e5c3c384e172 100644
@@ -21,6 +21,10 @@ properties:
       - items:
           - const: microchip,sam9x60-rtt
           - const: atmel,at91sam9260-rtt
+      - items:
+          - const: microchip,sama7g5-rtt
+          - const: microchip,sam9x60-rtt
+          - const: atmel,at91sam9260-rtt
 
   reg:
     maxItems: 1
Signature · 1 line
2.25.1
Reviewed-by on v4 4/4
#9 lore raw

Re: [PATCH v4 4/4] dt-bindings: rtc: at91: Add SAMA7G5 compatible strings list

Quoted 6 lines · Sergiu Moga

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Add compatible strings list for SAMA7G5.

Quoted 27 lines
---
 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml +4 -1
index d2452067bfe4..e5c3c384e172 100644
@@ -21,6 +21,10 @@ properties:
       - items:
           - const: microchip,sam9x60-rtt
           - const: atmel,at91sam9260-rtt
+      - items:
+          - const: microchip,sama7g5-rtt
+          - const: microchip,sam9x60-rtt
+          - const: atmel,at91sam9260-rtt
 
   reg:
     maxItems: 1
--

2.25.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer Applied
#10 lore raw

Re: (subset) [PATCH v4 4/4] dt-bindings: rtc: at91: Add SAMA7G5 compatible strings list

In reply to Sergiu Moga
Quoted 3 lines · Sergiu Moga

Add compatible strings list for SAMA7G5.

Applied, thanks!

[4/4] dt-bindings: rtc: at91: Add SAMA7G5 compatible strings list

      commit: 64a6497017843fc23d4c18542bdd4cfcca7878c9

Best regards,

Signature · 1 line
Alexandre Belloni <[email protected]>