dt-bindings: rtc: convert at91sam9 bindings to
v2 cover dt-bindings: rtc: convert at91sam9 bindings to
This patch series addresses the conversion of the RTC binding for Atmel/Microchip SoCs to Device Tree Schema format. It also changes the node names from some of the "dtsi" files from "rtt" to the more generic "rtc", while moving some of the specific properties from the "dts" files to the "dtsi" files as well as adding this required property to the "dtsi" files that were missing it.
Changes since v1:
- Add the "start-year" property as suggested by Alexandre Belloni
- Fix the errors generated from not using the more generic "rtc" node name for the example of the binding, as suggested by Krzysztof Kozlowski
- Replace the "uint32-array" type of the "atmel,rtt-rtc-time-reg" property with "syscon", as suggested by Krzysztof Kozlowski
- Move the "atmel,rtt-rtc-time-reg" property from some of the Atmel/Microchip board files to the SoC files
- Add the "atmel,rtt-rtc-time-reg" required property to the Atmel/Microchip SoC files that were missing it
- Use the more generic "rtc" node name inside the Atmel/Microchip SoC files that were using "rtt" instead
- Add SAMA7G5 compatible strings list to the DT binding
Sergiu Moga (5):
ARM: dts: at91: Move rtt node properties from "dts" file to "dtsi"
file
ARM: dts: at91: Add the required atmel,rtt-rtc-time-reg property
ARM: dts: at91: Use the generic "rtc" node name for the rtt IPs
dt-bindings: rtc: convert at91sam9 bindings to json-schema
dt-bindings: rtc: at91: Add SAMA7G5 compatible strings list
.../bindings/rtc/atmel,at91sam9-rtc.txt | 25 ------- .../bindings/rtc/atmel,at91sam9-rtc.yaml | 65 +++++++++++++++++++ arch/arm/boot/dts/at91-sam9x60ek.dts | 5 -- arch/arm/boot/dts/at91-sama7g5ek.dts | 4 -- arch/arm/boot/dts/at91sam9260.dtsi | 1 + arch/arm/boot/dts/at91sam9260ek.dts | 1 - arch/arm/boot/dts/at91sam9261.dtsi | 1 + arch/arm/boot/dts/at91sam9263.dtsi | 2 + arch/arm/boot/dts/at91sam9g45.dtsi | 1 + arch/arm/boot/dts/at91sam9m10g45ek.dts | 1 - arch/arm/boot/dts/at91sam9rl.dtsi | 1 + arch/arm/boot/dts/sam9x60.dtsi | 3 +- arch/arm/boot/dts/sama7g5.dtsi | 3 +- 13 files changed, 75 insertions(+), 38 deletions(-) delete mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt create mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
Signature · 1 line
2.25.1
PATCH v2 1/5 ARM: dts: at91: Move rtt node properties from "dts" file to "dtsi" file
Move the properties of the rtt node of RTT IPs from the "dts" file to the "dtsi" file, since it is more IP specific than it is board specific.
--- arch/arm/boot/dts/at91-sam9x60ek.dts | 5 ----- arch/arm/boot/dts/at91-sama7g5ek.dts | 4 ---- arch/arm/boot/dts/at91sam9260.dtsi | 1 + arch/arm/boot/dts/at91sam9260ek.dts | 1 - arch/arm/boot/dts/at91sam9g45.dtsi | 1 + arch/arm/boot/dts/at91sam9m10g45ek.dts | 1 - arch/arm/boot/dts/sam9x60.dtsi | 1 + arch/arm/boot/dts/sama7g5.dtsi | 1 + 8 files changed, 4 insertions(+), 11 deletions(-)
arch/arm/boot/dts/at91-sam9x60ek.dts +0 -5
@@ -656,11 +656,6 @@ kernel@200000 { }; }; -&rtt { - atmel,rtt-rtc-time-reg = <&gpbr 0x0>; - status = "okay"; -}; - &shutdown_controller { debounce-delay-us = <976>; status = "okay";
arch/arm/boot/dts/at91-sama7g5ek.dts +0 -4
@@ -708,10 +708,6 @@ &pwm { status = "disabled"; /* Conflict with leds. */ }; -&rtt { - atmel,rtt-rtc-time-reg = <&gpbr 0x0>; -}; - &sdmmc0 { bus-width = <8>; non-removable;
arch/arm/boot/dts/at91sam9260.dtsi +1 -0
@@ -713,6 +713,7 @@ rtc@fffffd20 { reg = <0xfffffd20 0x10>; interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; clocks = <&pmc PMC_TYPE_CORE PMC_SLOW>; + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; status = "disabled"; };
arch/arm/boot/dts/at91sam9260ek.dts +0 -1
@@ -118,7 +118,6 @@ shdwc@fffffd10 { }; rtc@fffffd20 { - atmel,rtt-rtc-time-reg = <&gpbr 0x0>; status = "okay"; };
arch/arm/boot/dts/at91sam9g45.dtsi +1 -0
@@ -929,6 +929,7 @@ rtc@fffffd20 { reg = <0xfffffd20 0x10>; interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; clocks = <&clk32k>; + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; status = "disabled"; };
arch/arm/boot/dts/at91sam9m10g45ek.dts +0 -1
@@ -220,7 +220,6 @@ pwm0: pwm@fffb8000 { }; rtc@fffffd20 { - atmel,rtt-rtc-time-reg = <&gpbr 0x0>; status = "okay"; };
arch/arm/boot/dts/sam9x60.dtsi +1 -0
@@ -693,6 +693,7 @@ rtt: rtt@fffffe20 { reg = <0xfffffe20 0x20>; interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; clocks = <&clk32k 0>; + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; }; pit: timer@fffffe40 {
arch/arm/boot/dts/sama7g5.dtsi +1 -0
@@ -138,6 +138,7 @@ rtt: rtt@e001d020 { reg = <0xe001d020 0x30>; interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clk32k 0>; + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; }; clk32k: clock-controller@e001d050 {
Signature · 1 line
2.25.1
Alexandre Belloni
maintainerRe: [PATCH v2 1/5] ARM: dts: at91: Move rtt node properties from "dts" file to "dtsi" file
Quoted 3 lines · Sergiu Moga
Move the properties of the rtt node of RTT IPs from the "dts" file to the "dtsi" file, since it is more IP specific than it is board specific.
The fact that it uses a specific GPBR register makes it board specific so I don't really agree with this patch.
Quoted 118 lines
Signed-off-by Sergiu Moga <[email protected]>--- arch/arm/boot/dts/at91-sam9x60ek.dts | 5 ----- arch/arm/boot/dts/at91-sama7g5ek.dts | 4 ---- arch/arm/boot/dts/at91sam9260.dtsi | 1 + arch/arm/boot/dts/at91sam9260ek.dts | 1 - arch/arm/boot/dts/at91sam9g45.dtsi | 1 + arch/arm/boot/dts/at91sam9m10g45ek.dts | 1 - arch/arm/boot/dts/sam9x60.dtsi | 1 + arch/arm/boot/dts/sama7g5.dtsi | 1 + 8 files changed, 4 insertions(+), 11 deletions(-)arch/arm/boot/dts/at91-sam9x60ek.dts +0
-5@@ -656,11 +656,6 @@ kernel@200000 { }; }; -&rtt { - atmel,rtt-rtc-time-reg = <&gpbr 0x0>; - status = "okay"; -}; - &shutdown_controller { debounce-delay-us = <976>; status = "okay";arch/arm/boot/dts/at91-sama7g5ek.dts +0
-4@@ -708,10 +708,6 @@ &pwm { status = "disabled"; /* Conflict with leds. */ }; -&rtt { - atmel,rtt-rtc-time-reg = <&gpbr 0x0>; -}; - &sdmmc0 { bus-width = <8>; non-removable;arch/arm/boot/dts/at91sam9260.dtsi +1
-0@@ -713,6 +713,7 @@ rtc@fffffd20 { reg = <0xfffffd20 0x10>; interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; clocks = <&pmc PMC_TYPE_CORE PMC_SLOW>; + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; status = "disabled"; };arch/arm/boot/dts/at91sam9260ek.dts +0
-1@@ -118,7 +118,6 @@ shdwc@fffffd10 { }; rtc@fffffd20 { - atmel,rtt-rtc-time-reg = <&gpbr 0x0>; status = "okay"; };arch/arm/boot/dts/at91sam9g45.dtsi +1
-0@@ -929,6 +929,7 @@ rtc@fffffd20 { reg = <0xfffffd20 0x10>; interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; clocks = <&clk32k>; + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; status = "disabled"; };arch/arm/boot/dts/at91sam9m10g45ek.dts +0
-1@@ -220,7 +220,6 @@ pwm0: pwm@fffb8000 { }; rtc@fffffd20 { - atmel,rtt-rtc-time-reg = <&gpbr 0x0>; status = "okay"; };arch/arm/boot/dts/sam9x60.dtsi +1
-0@@ -693,6 +693,7 @@ rtt: rtt@fffffe20 { reg = <0xfffffe20 0x20>; interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; clocks = <&clk32k 0>; + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; }; pit: timer@fffffe40 {arch/arm/boot/dts/sama7g5.dtsi +1
-0@@ -138,6 +138,7 @@ rtt: rtt@e001d020 { reg = <0xe001d020 0x30>; interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clk32k 0>; + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; }; clk32k: clock-controller@e001d050 {Signature · 1 line
2.25.1
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
Re: [PATCH v2 1/5] ARM: dts: at91: Move rtt node properties from "dts" file to "dtsi" file
Quoted 7 lines · Alexandre Belloni
Quoted 3 lines · Sergiu Moga
Move the properties of the rtt node of RTT IPs from the "dts" file to the "dtsi" file, since it is more IP specific than it is board specific.
The fact that it uses a specific GPBR register makes it board specific so I don't really agree with this patch.
Ah, I see. I will remove this patch from the series then.
Quoted 114 lines
Quoted 114 lines
Signed-off-by Sergiu Moga <[email protected]>--- arch/arm/boot/dts/at91-sam9x60ek.dts | 5 ----- arch/arm/boot/dts/at91-sama7g5ek.dts | 4 ---- arch/arm/boot/dts/at91sam9260.dtsi | 1 + arch/arm/boot/dts/at91sam9260ek.dts | 1 - arch/arm/boot/dts/at91sam9g45.dtsi | 1 + arch/arm/boot/dts/at91sam9m10g45ek.dts | 1 - arch/arm/boot/dts/sam9x60.dtsi | 1 + arch/arm/boot/dts/sama7g5.dtsi | 1 + 8 files changed, 4 insertions(+), 11 deletions(-)arch/arm/boot/dts/at91-sam9x60ek.dts +0
-5@@ -656,11 +656,6 @@ kernel@200000 { }; }; -&rtt { - atmel,rtt-rtc-time-reg = <&gpbr 0x0>; - status = "okay"; -}; - &shutdown_controller { debounce-delay-us = <976>; status = "okay";arch/arm/boot/dts/at91-sama7g5ek.dts +0
-4@@ -708,10 +708,6 @@ &pwm { status = "disabled"; /* Conflict with leds. */ }; -&rtt { - atmel,rtt-rtc-time-reg = <&gpbr 0x0>; -}; - &sdmmc0 { bus-width = <8>; non-removable;arch/arm/boot/dts/at91sam9260.dtsi +1
-0@@ -713,6 +713,7 @@ rtc@fffffd20 { reg = <0xfffffd20 0x10>; interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; clocks = <&pmc PMC_TYPE_CORE PMC_SLOW>; + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; status = "disabled"; };arch/arm/boot/dts/at91sam9260ek.dts +0
-1@@ -118,7 +118,6 @@ shdwc@fffffd10 { }; rtc@fffffd20 { - atmel,rtt-rtc-time-reg = <&gpbr 0x0>; status = "okay"; };arch/arm/boot/dts/at91sam9g45.dtsi +1
-0@@ -929,6 +929,7 @@ rtc@fffffd20 { reg = <0xfffffd20 0x10>; interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; clocks = <&clk32k>; + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; status = "disabled"; };arch/arm/boot/dts/at91sam9m10g45ek.dts +0
-1@@ -220,7 +220,6 @@ pwm0: pwm@fffb8000 { }; rtc@fffffd20 { - atmel,rtt-rtc-time-reg = <&gpbr 0x0>; status = "okay"; };arch/arm/boot/dts/sam9x60.dtsi +1
-0@@ -693,6 +693,7 @@ rtt: rtt@fffffe20 { reg = <0xfffffe20 0x20>; interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; clocks = <&clk32k 0>; + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; }; pit: timer@fffffe40 {arch/arm/boot/dts/sama7g5.dtsi +1
-0@@ -138,6 +138,7 @@ rtt: rtt@e001d020 { reg = <0xe001d020 0x30>; interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clk32k 0>; + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; };
Quoted 8 lines
Quoted 4 lines
arch/arm/boot/dts/sama7g5.dtsi +0
-1clk32k: clock-controller@e001d050 { --2.25.1
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Thank you for the feedback.
Sergiu
PATCH v2 2/5 ARM: dts: at91: Add the required `atmel,rtt-rtc-time-reg` property
In reply to Sergiu MogaAdd the required atmel,rtt-rtc-time-reg property to the rtt nodes of the RTT IPs.
--- arch/arm/boot/dts/at91sam9261.dtsi | 1 + arch/arm/boot/dts/at91sam9263.dtsi | 2 ++ arch/arm/boot/dts/at91sam9rl.dtsi | 1 + 3 files changed, 4 insertions(+)
arch/arm/boot/dts/at91sam9261.dtsi +1 -0
@@ -627,6 +627,7 @@ rtc@fffffd20 { reg = <0xfffffd20 0x10>; interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; clocks = <&slow_xtal>; + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; status = "disabled"; };
arch/arm/boot/dts/at91sam9263.dtsi +2 -0
@@ -734,6 +734,7 @@ rtc@fffffd20 { reg = <0xfffffd20 0x10>; interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; clocks = <&slow_xtal>; + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; status = "disabled"; };
@@ -742,6 +743,7 @@ rtc@fffffd50 { reg = <0xfffffd50 0x10>; interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; clocks = <&slow_xtal>; + atmel,rtt-rtc-time-reg = <&gpbr 0x4>; status = "disabled"; };
arch/arm/boot/dts/at91sam9rl.dtsi +1 -0
@@ -805,6 +805,7 @@ rtc@fffffd20 { reg = <0xfffffd20 0x10>; interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; clocks = <&clk32k>; + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; status = "disabled"; };
Signature · 1 line
2.25.1
Re: [PATCH v2 2/5] ARM: dts: at91: Add the required `atmel, rtt-rtc-time-reg` property
Quoted 11 lines · Sergiu Moga
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
Add the required
atmel,rtt-rtc-time-regproperty to therttnodes of the RTT IPs.Signed-off-by Sergiu Moga <[email protected]>--- arch/arm/boot/dts/at91sam9261.dtsi | 1 + arch/arm/boot/dts/at91sam9263.dtsi | 2 ++ arch/arm/boot/dts/at91sam9rl.dtsi | 1 + 3 files changed, 4 insertions(+)
Now with Alexandre's feedback from patch 1/5, you should probably move the atmel,rtt-rtc-time-reg prop to each of the board files that uses these SoCs.
cheers,
ta
PATCH v2 3/5 ARM: dts: at91: Use the generic "rtc" node name for the rtt IPs
In reply to Sergiu MogaAs the DT specification recommends, the node names should be of a generic nature. Thus, the most appropriate generic node name for the at91 rtt IPs is the "rtc" node name.
--- arch/arm/boot/dts/sam9x60.dtsi | 2 +- arch/arm/boot/dts/sama7g5.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/sam9x60.dtsi +1 -1
@@ -688,7 +688,7 @@ shutdown_controller: shdwc@fffffe10 { status = "disabled"; }; - rtt: rtt@fffffe20 { + rtt: rtc@fffffe20 { compatible = "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt"; reg = <0xfffffe20 0x20>; interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
arch/arm/boot/dts/sama7g5.dtsi +1 -1
@@ -133,7 +133,7 @@ shdwc: shdwc@e001d010 { status = "disabled"; }; - rtt: rtt@e001d020 { + rtt: rtc@e001d020 { compatible = "microchip,sama7g5-rtt", "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt"; reg = <0xe001d020 0x30>; interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
Signature · 1 line
2.25.1
Re: [PATCH v2 3/5] ARM: dts: at91: Use the generic "rtc" node name for the rtt IPs
Quoted 10 lines · Sergiu Moga
As the DT specification recommends, the node names should be of a generic nature. Thus, the most appropriate generic node name for the at91 rtt IPs is the "rtc" node name.
Signed-off-by Sergiu Moga <[email protected]>--- arch/arm/boot/dts/sam9x60.dtsi | 2 +- arch/arm/boot/dts/sama7g5.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Best regards,
Krzysztof
Re: [PATCH v2 3/5] ARM: dts: at91: Use the generic "rtc" node name for the rtt IPs
In reply to Sergiu MogaQuoted 7 lines · Sergiu Moga
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
As the DT specification recommends, the node names should be of a generic nature. Thus, the most appropriate generic node name for the at91 rtt IPs is the "rtc" node name.
Signed-off-by Sergiu Moga <[email protected]>
Quoted 39 lines
--- arch/arm/boot/dts/sam9x60.dtsi | 2 +- arch/arm/boot/dts/sama7g5.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)arch/arm/boot/dts/sam9x60.dtsi +1
-1@@ -688,7 +688,7 @@ shutdown_controller: shdwc@fffffe10 { status = "disabled"; }; - rtt: rtt@fffffe20 { + rtt: rtc@fffffe20 { compatible = "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt"; reg = <0xfffffe20 0x20>; interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;arch/arm/boot/dts/sama7g5.dtsi +1
-2@@ -133,7 +133,7 @@ shdwc: shdwc@e001d010 { status = "disabled"; }; - rtt: rtt@e001d020 { + rtt: rtc@e001d020 { compatible = "microchip,sama7g5-rtt", "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt"; reg = <0xe001d020 0x30>; interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>; --2.25.1
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v2 4/5 dt-bindings: rtc: convert at91sam9 bindings to json-schema
In reply to Sergiu MogaConvert RTC binding for Atmel/Microchip SoCs to Device Tree Schema format.
--- .../bindings/rtc/atmel,at91sam9-rtc.txt | 25 -------- .../bindings/rtc/atmel,at91sam9-rtc.yaml | 61 +++++++++++++++++++ 2 files changed, 61 insertions(+), 25 deletions(-) delete mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt create mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt deleted +0 -25
@@ -1,25 +0,0 @@ -Atmel AT91SAM9260 Real Time Timer - -Required properties: -- compatible: should be one of the following: - - "atmel,at91sam9260-rtt" - - "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt" -- reg: should encode the memory region of the RTT controller -- interrupts: rtt alarm/event interrupt -- clocks: should contain the 32 KHz slow clk that will drive the RTT block. -- atmel,rtt-rtc-time-reg: should encode the GPBR register used to store - the time base when the RTT is used as an RTC. - The first cell should point to the GPBR node and the second one - encode the offset within the GPBR block (or in other words, the - GPBR register used to store the time base). - - -Example: - -rtt@fffffd20 { - compatible = "atmel,at91sam9260-rtt"; - reg = <0xfffffd20 0x10>; - interrupts = <1 4 7>; - clocks = <&clk32k>; - atmel,rtt-rtc-time-reg = <&gpbr 0x0>; -};
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +61 -0
61 lines not on this page · raw message
Signature · 1 line
2.25.1
Re: [PATCH v2 4/5] dt-bindings: rtc: convert at91sam9 bindings to json-schema
Quoted 78 lines · Sergiu Moga
Convert RTC binding for Atmel/Microchip SoCs to Device Tree Schema format.
Signed-off-by Sergiu Moga <[email protected]>--- .../bindings/rtc/atmel,at91sam9-rtc.txt | 25 -------- .../bindings/rtc/atmel,at91sam9-rtc.yaml | 61 +++++++++++++++++++ 2 files changed, 61 insertions(+), 25 deletions(-) delete mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt create mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yamlDocumentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt deleted +0
-25@@ -1,25 +0,0 @@ -Atmel AT91SAM9260 Real Time Timer - -Required properties: -- compatible: should be one of the following: - - "atmel,at91sam9260-rtt" - - "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt" -- reg: should encode the memory region of the RTT controller -- interrupts: rtt alarm/event interrupt -- clocks: should contain the 32 KHz slow clk that will drive the RTT block. -- atmel,rtt-rtc-time-reg: should encode the GPBR register used to store - the time base when the RTT is used as an RTC. - The first cell should point to the GPBR node and the second one - encode the offset within the GPBR block (or in other words, the - GPBR register used to store the time base). - - -Example: - -rtt@fffffd20 { - compatible = "atmel,at91sam9260-rtt"; - reg = <0xfffffd20 0x10>; - interrupts = <1 4 7>; - clocks = <&clk32k>; - atmel,rtt-rtc-time-reg = <&gpbr 0x0>; -};Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +30
-0@@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) 2022 Microchip Technology, Inc. and its subsidiaries +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/atmel,at91sam9-rtc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Atmel AT91 RTT Device Tree Bindings + +allOf: + - $ref: "rtc.yaml#" + +maintainers: + - Alexandre Belloni <[email protected]> + +properties: + compatible: + oneOf: + - items: + - const: atmel,at91sam9260-rtt + - items: + - const: microchip,sam9x60-rtt + - const: atmel,at91sam9260-rtt + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 +
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml line 40
Quoted 10 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +10
-0+ clocks: + maxItems: 1 + + atmel,rtt-rtc-time-reg: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: | + Should encode the GPBR register used to store the time base when the + RTT is used as an RTC. The first cell should point to the GPBR node + and the second one encodes the offset within the GPBR block (or in + other words, the GPBR register used to store the time base).
Instead of describing cells here, you need items with description. I gave you the example last time, so instead of ignoring it, please implement it.
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml line 51
Quoted 11 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +11
-0+ + start-year: true + +required: + - compatible + - reg + - interrupts + - clocks + - atmel,rtt-rtc-time-reg + +additionalProperties: false
This will disallow any other properties mentioned in rtc.yaml, e.g. popular wakeup-source. Is it really intended? If core schema is extended, the driver would need to be updated to support new features. Any reason to choose such approach? The other way is to remove start-year and have here unevaluatedProperties.
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml line 58
Quoted 7 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +7
-0+ +examples: + - | + rtc@fffffd20 { + compatible = "atmel,at91sam9260-rtt"; + reg = <0xfffffd20 0x10>; + interrupts = <1 4 7>;
At least one number above looks like known macro, so use it.
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml line 61
Quoted 3 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +3
-0+ clocks = <&clk32k>; + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; + };
Best regards,
Krzysztof
Re: [PATCH v2 4/5] dt-bindings: rtc: convert at91sam9 bindings to json-schema
Quoted 84 lines · Krzysztof Kozlowski
Quoted 83 lines · Sergiu Moga
Convert RTC binding for Atmel/Microchip SoCs to Device Tree Schema format.
Signed-off-by Sergiu Moga <[email protected]>--- .../bindings/rtc/atmel,at91sam9-rtc.txt | 25 -------- .../bindings/rtc/atmel,at91sam9-rtc.yaml | 61 +++++++++++++++++++ 2 files changed, 61 insertions(+), 25 deletions(-)delete mode 100644
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txtcreate mode 100644Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yamlDocumentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt deleted +0
-25@@ -1,25 +0,0 @@ -Atmel AT91SAM9260 Real Time Timer - -Required properties: -- compatible: should be one of the following: - - "atmel,at91sam9260-rtt" - - "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt" -- reg: should encode the memory region of the RTT controller -- interrupts: rtt alarm/event interrupt -- clocks: should contain the 32 KHz slow clk that will drive the RTT block. -- atmel,rtt-rtc-time-reg: should encode the GPBR register used to store - the time base when the RTT is used as an RTC. - The first cell should point to the GPBR node and the second one - encode the offset within the GPBR block (or in other words, the - GPBR register used to store the time base). - - -Example: - -rtt@fffffd20 { - compatible = "atmel,at91sam9260-rtt"; - reg = <0xfffffd20 0x10>; - interrupts = <1 4 7>; - clocks = <&clk32k>; - atmel,rtt-rtc-time-reg = <&gpbr 0x0>; -};Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +35
-0@@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) 2022 Microchip Technology, Inc. and its subsidiaries +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/atmel,at91sam9-rtc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Atmel AT91 RTT Device Tree Bindings + +allOf: + - $ref: "rtc.yaml#" + +maintainers: + - Alexandre Belloni <[email protected]> + +properties: + compatible: + oneOf: + - items: + - const: atmel,at91sam9260-rtt + - items: + - const: microchip,sam9x60-rtt + - const: atmel,at91sam9260-rtt + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + + atmel,rtt-rtc-time-reg: + $ref: /schemas/types.yaml#/definitions/phandle-array
Quoted 9 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml line 40
Quoted 5 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +5
-0+ description: | + Should encode the GPBR register used to store the time base when the + RTT is used as an RTC. The first cell should point to the GPBR node + and the second one encodes the offset within the GPBR block (or in + other words, the GPBR register used to store the time base).Instead of describing cells here, you need items with description. I gave you the example last time, so instead of ignoring it, please implement it.
Noted.
Quoted 8 lines
Quoted 8 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +8
-0+ + start-year: true + +required: + - compatible + - reg + - interrupts + - clocks
Quoted 9 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml line 51
Quoted 3 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +3
-0+ - atmel,rtt-rtc-time-reg + +additionalProperties: falseThis will disallow any other properties mentioned in
rtc.yaml, e.g. popular wakeup-source. Is it really intended? If core schema is extended, the driver would need to be updated to support new features. Any reason to choose such approach? The other way is to remove start-year and have here unevaluatedProperties.
Ah, I see. Removing start-year and using "unevaluatedProperties: false" here is better indeed.
Quoted 9 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml line 58
Quoted 7 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +7
-0+ +examples: + - | + rtc@fffffd20 { + compatible = "atmel,at91sam9260-rtt"; + reg = <0xfffffd20 0x10>; + interrupts = <1 4 7>;At least one number above looks like known macro, so use it.
Noted. Will add another patch to the series for this.
Quoted 6 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml line 61
Quoted 3 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +3
-0+ clocks = <&clk32k>; + atmel,rtt-rtc-time-reg = <&gpbr 0x0>; + };Best regards,
Krzysztof
Thank you for the feedback.
Sergiu
PATCH v2 5/5 dt-bindings: rtc: at91: Add SAMA7G5 compatible strings list
In reply to Sergiu MogaAdd compatible strings list for SAMA7G5.
--- Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml | 4 ++++ 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml +4 -0
@@ -21,6 +21,10 @@ properties: - items: - const: microchip,sam9x60-rtt - const: atmel,at91sam9260-rtt + - items: + - const: microchip,sama7g5-rtt + - const: microchip,sam9x60-rtt + - const: atmel,at91sam9260-rtt reg: maxItems: 1
Signature · 1 line
2.25.1
Re: [PATCH v2 5/5] dt-bindings: rtc: at91: Add SAMA7G5 compatible strings list
Review
Quoted 8 lines · Sergiu Moga
Add compatible strings list for SAMA7G5.
Signed-off-by Sergiu Moga <[email protected]>--- Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml | 4 ++++ 1 file changed, 4 insertions(+)(quoted diff) +0
-0
Best regards,
Krzysztof