Skip to contentSkip to conversation

dt-bindings: rtc: convert at91sam9 bindings to

PATCH Superseded Sergiu Moga 4 participants 14 messages Mar 3, 2022 – Mar 4, 2022

Subsystems (3)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v2 cover dt-bindings: rtc: convert at91sam9 bindings to

This patch series addresses the conversion of the RTC binding for Atmel/Microchip SoCs to Device Tree Schema format. It also changes the node names from some of the "dtsi" files from "rtt" to the more generic "rtc", while moving some of the specific properties from the "dts" files to the "dtsi" files as well as adding this required property to the "dtsi" files that were missing it.

Changes since v1:
- Add the "start-year" property as suggested by Alexandre Belloni
- Fix the errors generated from not using the more generic "rtc" node name for the example of the binding, as suggested by Krzysztof Kozlowski
- Replace the "uint32-array" type of the "atmel,rtt-rtc-time-reg" property with "syscon", as suggested by Krzysztof Kozlowski
- Move the "atmel,rtt-rtc-time-reg" property from some of the Atmel/Microchip board files to the SoC files
- Add the "atmel,rtt-rtc-time-reg" required property to the Atmel/Microchip SoC files that were missing it
- Use the more generic "rtc" node name inside the Atmel/Microchip SoC files that were using "rtt" instead
- Add SAMA7G5 compatible strings list to the DT binding

Sergiu Moga (5):
ARM: dts: at91: Move rtt node properties from "dts" file to "dtsi"
file
ARM: dts: at91: Add the required atmel,rtt-rtc-time-reg property
ARM: dts: at91: Use the generic "rtc" node name for the rtt IPs
dt-bindings: rtc: convert at91sam9 bindings to json-schema
dt-bindings: rtc: at91: Add SAMA7G5 compatible strings list

 .../bindings/rtc/atmel,at91sam9-rtc.txt       | 25 -------
 .../bindings/rtc/atmel,at91sam9-rtc.yaml      | 65 +++++++++++++++++++
 arch/arm/boot/dts/at91-sam9x60ek.dts          |  5 --
 arch/arm/boot/dts/at91-sama7g5ek.dts          |  4 --
 arch/arm/boot/dts/at91sam9260.dtsi            |  1 +
 arch/arm/boot/dts/at91sam9260ek.dts           |  1 -
 arch/arm/boot/dts/at91sam9261.dtsi            |  1 +
 arch/arm/boot/dts/at91sam9263.dtsi            |  2 +
 arch/arm/boot/dts/at91sam9g45.dtsi            |  1 +
 arch/arm/boot/dts/at91sam9m10g45ek.dts        |  1 -
 arch/arm/boot/dts/at91sam9rl.dtsi             |  1 +
 arch/arm/boot/dts/sam9x60.dtsi                |  3 +-
 arch/arm/boot/dts/sama7g5.dtsi                |  3 +-
 13 files changed, 75 insertions(+), 38 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
Signature · 1 line
2.25.1
#1 lore raw

PATCH v2 1/5 ARM: dts: at91: Move rtt node properties from "dts" file to "dtsi" file

Move the properties of the rtt node of RTT IPs from the "dts" file to the "dtsi" file, since it is more IP specific than it is board specific.

---
 arch/arm/boot/dts/at91-sam9x60ek.dts   | 5 -----
 arch/arm/boot/dts/at91-sama7g5ek.dts   | 4 ----
 arch/arm/boot/dts/at91sam9260.dtsi     | 1 +
 arch/arm/boot/dts/at91sam9260ek.dts    | 1 -
 arch/arm/boot/dts/at91sam9g45.dtsi     | 1 +
 arch/arm/boot/dts/at91sam9m10g45ek.dts | 1 -
 arch/arm/boot/dts/sam9x60.dtsi         | 1 +
 arch/arm/boot/dts/sama7g5.dtsi         | 1 +
 8 files changed, 4 insertions(+), 11 deletions(-)
arch/arm/boot/dts/at91-sam9x60ek.dts +0 -5
index b1068cca4228..97ff91346cb4 100644
@@ -656,11 +656,6 @@ kernel@200000 {
 	};
 };
 
-&rtt {
-	atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
-	status = "okay";
-};
-
 &shutdown_controller {
 	debounce-delay-us = <976>;
 	status = "okay";
arch/arm/boot/dts/at91-sama7g5ek.dts +0 -4
index ccf9e224da78..b7416d9469e3 100644
@@ -708,10 +708,6 @@ &pwm {
 	status = "disabled"; /* Conflict with leds. */
 };
 
-&rtt {
-	atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
-};
-
 &sdmmc0 {
 	bus-width = <8>;
 	non-removable;
arch/arm/boot/dts/at91sam9260.dtsi +1 -0
index 7368347c9357..66d11c8f1a9b 100644
@@ -713,6 +713,7 @@ rtc@fffffd20 {
 				reg = <0xfffffd20 0x10>;
 				interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
 				clocks = <&pmc PMC_TYPE_CORE PMC_SLOW>;
+				atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
 				status = "disabled";
 			};
 
arch/arm/boot/dts/at91sam9260ek.dts +0 -1
index ce96345d28a3..6932dab42f2e 100644
@@ -118,7 +118,6 @@ shdwc@fffffd10 {
 			};
 
 			rtc@fffffd20 {
-				atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
 				status = "okay";
 			};
 
arch/arm/boot/dts/at91sam9g45.dtsi +1 -0
index 2ab730fd6472..fd308e2c15e8 100644
@@ -929,6 +929,7 @@ rtc@fffffd20 {
 				reg = <0xfffffd20 0x10>;
 				interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
 				clocks = <&clk32k>;
+				atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
 				status = "disabled";
 			};
 
arch/arm/boot/dts/at91sam9m10g45ek.dts +0 -1
index b6256a20fbc7..07bfa8ef715d 100644
@@ -220,7 +220,6 @@ pwm0: pwm@fffb8000 {
 			};
 
 			rtc@fffffd20 {
-				atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
 				status = "okay";
 			};
 
arch/arm/boot/dts/sam9x60.dtsi +1 -0
index ec45ced3cde6..57ba47c54043 100644
@@ -693,6 +693,7 @@ rtt: rtt@fffffe20 {
 				reg = <0xfffffe20 0x20>;
 				interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
 				clocks = <&clk32k 0>;
+				atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
 			};
 
 			pit: timer@fffffe40 {
arch/arm/boot/dts/sama7g5.dtsi +1 -0
index eddcfbf4d223..1530d88ce80f 100644
@@ -138,6 +138,7 @@ rtt: rtt@e001d020 {
 			reg = <0xe001d020 0x30>;
 			interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&clk32k 0>;
+			atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
 		};
 
 		clk32k: clock-controller@e001d050 {
Signature · 1 line
2.25.1
#2 lore raw

Re: [PATCH v2 1/5] ARM: dts: at91: Move rtt node properties from "dts" file to "dtsi" file

Quoted 3 lines · Sergiu Moga

Move the properties of the rtt node of RTT IPs from the "dts" file to the "dtsi" file, since it is more IP specific than it is board specific.

The fact that it uses a specific GPBR register makes it board specific so I don't really agree with this patch.

Quoted 118 lines
---
 arch/arm/boot/dts/at91-sam9x60ek.dts   | 5 -----
 arch/arm/boot/dts/at91-sama7g5ek.dts   | 4 ----
 arch/arm/boot/dts/at91sam9260.dtsi     | 1 +
 arch/arm/boot/dts/at91sam9260ek.dts    | 1 -
 arch/arm/boot/dts/at91sam9g45.dtsi     | 1 +
 arch/arm/boot/dts/at91sam9m10g45ek.dts | 1 -
 arch/arm/boot/dts/sam9x60.dtsi         | 1 +
 arch/arm/boot/dts/sama7g5.dtsi         | 1 +
 8 files changed, 4 insertions(+), 11 deletions(-)
arch/arm/boot/dts/at91-sam9x60ek.dts +0 -5
index b1068cca4228..97ff91346cb4 100644
@@ -656,11 +656,6 @@ kernel@200000 {
 	};
 };
 
-&rtt {
-	atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
-	status = "okay";
-};
-
 &shutdown_controller {
 	debounce-delay-us = <976>;
 	status = "okay";
arch/arm/boot/dts/at91-sama7g5ek.dts +0 -4
index ccf9e224da78..b7416d9469e3 100644
@@ -708,10 +708,6 @@ &pwm {
 	status = "disabled"; /* Conflict with leds. */
 };
 
-&rtt {
-	atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
-};
-
 &sdmmc0 {
 	bus-width = <8>;
 	non-removable;
arch/arm/boot/dts/at91sam9260.dtsi +1 -0
index 7368347c9357..66d11c8f1a9b 100644
@@ -713,6 +713,7 @@ rtc@fffffd20 {
 				reg = <0xfffffd20 0x10>;
 				interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
 				clocks = <&pmc PMC_TYPE_CORE PMC_SLOW>;
+				atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
 				status = "disabled";
 			};
 
arch/arm/boot/dts/at91sam9260ek.dts +0 -1
index ce96345d28a3..6932dab42f2e 100644
@@ -118,7 +118,6 @@ shdwc@fffffd10 {
 			};
 
 			rtc@fffffd20 {
-				atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
 				status = "okay";
 			};
 
arch/arm/boot/dts/at91sam9g45.dtsi +1 -0
index 2ab730fd6472..fd308e2c15e8 100644
@@ -929,6 +929,7 @@ rtc@fffffd20 {
 				reg = <0xfffffd20 0x10>;
 				interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
 				clocks = <&clk32k>;
+				atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
 				status = "disabled";
 			};
 
arch/arm/boot/dts/at91sam9m10g45ek.dts +0 -1
index b6256a20fbc7..07bfa8ef715d 100644
@@ -220,7 +220,6 @@ pwm0: pwm@fffb8000 {
 			};
 
 			rtc@fffffd20 {
-				atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
 				status = "okay";
 			};
 
arch/arm/boot/dts/sam9x60.dtsi +1 -0
index ec45ced3cde6..57ba47c54043 100644
@@ -693,6 +693,7 @@ rtt: rtt@fffffe20 {
 				reg = <0xfffffe20 0x20>;
 				interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
 				clocks = <&clk32k 0>;
+				atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
 			};
 
 			pit: timer@fffffe40 {
arch/arm/boot/dts/sama7g5.dtsi +1 -0
index eddcfbf4d223..1530d88ce80f 100644
@@ -138,6 +138,7 @@ rtt: rtt@e001d020 {
 			reg = <0xe001d020 0x30>;
 			interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&clk32k 0>;
+			atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
 		};
 
 		clk32k: clock-controller@e001d050 {
Signature · 1 line
2.25.1
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

Re: [PATCH v2 1/5] ARM: dts: at91: Move rtt node properties from "dts" file to "dtsi" file

Quoted 7 lines · Alexandre Belloni
Quoted 3 lines · Sergiu Moga

Move the properties of the rtt node of RTT IPs from the "dts" file to the "dtsi" file, since it is more IP specific than it is board specific.

The fact that it uses a specific GPBR register makes it board specific so I don't really agree with this patch.

Ah, I see. I will remove this patch from the series then.

Quoted 114 lines
Quoted 114 lines
---
  arch/arm/boot/dts/at91-sam9x60ek.dts   | 5 -----
  arch/arm/boot/dts/at91-sama7g5ek.dts   | 4 ----
  arch/arm/boot/dts/at91sam9260.dtsi     | 1 +
  arch/arm/boot/dts/at91sam9260ek.dts    | 1 -
  arch/arm/boot/dts/at91sam9g45.dtsi     | 1 +
  arch/arm/boot/dts/at91sam9m10g45ek.dts | 1 -
  arch/arm/boot/dts/sam9x60.dtsi         | 1 +
  arch/arm/boot/dts/sama7g5.dtsi         | 1 +
  8 files changed, 4 insertions(+), 11 deletions(-)
arch/arm/boot/dts/at91-sam9x60ek.dts +0 -5
index b1068cca4228..97ff91346cb4 100644
@@ -656,11 +656,6 @@ kernel@200000 {
       };
  };
 
-&rtt {
-     atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
-     status = "okay";
-};
-
  &shutdown_controller {
       debounce-delay-us = <976>;
       status = "okay";
arch/arm/boot/dts/at91-sama7g5ek.dts +0 -4
index ccf9e224da78..b7416d9469e3 100644
@@ -708,10 +708,6 @@ &pwm {
       status = "disabled"; /* Conflict with leds. */
  };
 
-&rtt {
-     atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
-};
-
  &sdmmc0 {
       bus-width = <8>;
       non-removable;
arch/arm/boot/dts/at91sam9260.dtsi +1 -0
index 7368347c9357..66d11c8f1a9b 100644
@@ -713,6 +713,7 @@ rtc@fffffd20 {
                               reg = <0xfffffd20 0x10>;
                               interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
                               clocks = <&pmc PMC_TYPE_CORE PMC_SLOW>;
+                             atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
                               status = "disabled";
                       };
 
arch/arm/boot/dts/at91sam9260ek.dts +0 -1
index ce96345d28a3..6932dab42f2e 100644
@@ -118,7 +118,6 @@ shdwc@fffffd10 {
                       };
 
                       rtc@fffffd20 {
-                             atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
                               status = "okay";
                       };
 
arch/arm/boot/dts/at91sam9g45.dtsi +1 -0
index 2ab730fd6472..fd308e2c15e8 100644
@@ -929,6 +929,7 @@ rtc@fffffd20 {
                               reg = <0xfffffd20 0x10>;
                               interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
                               clocks = <&clk32k>;
+                             atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
                               status = "disabled";
                       };
 
arch/arm/boot/dts/at91sam9m10g45ek.dts +0 -1
index b6256a20fbc7..07bfa8ef715d 100644
@@ -220,7 +220,6 @@ pwm0: pwm@fffb8000 {
                       };
 
                       rtc@fffffd20 {
-                             atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
                               status = "okay";
                       };
 
arch/arm/boot/dts/sam9x60.dtsi +1 -0
index ec45ced3cde6..57ba47c54043 100644
@@ -693,6 +693,7 @@ rtt: rtt@fffffe20 {
                               reg = <0xfffffe20 0x20>;
                               interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
                               clocks = <&clk32k 0>;
+                             atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
                       };
 
                       pit: timer@fffffe40 {
arch/arm/boot/dts/sama7g5.dtsi +1 -0
index eddcfbf4d223..1530d88ce80f 100644
@@ -138,6 +138,7 @@ rtt: rtt@e001d020 {
                       reg = <0xe001d020 0x30>;
                       interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
                       clocks = <&clk32k 0>;
+                     atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
               };
 
Quoted 8 lines
Quoted 4 lines
arch/arm/boot/dts/sama7g5.dtsi +0 -1
               clk32k: clock-controller@e001d050 {
--

2.25.1

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Thank you for the feedback.

Sergiu

#4 lore raw

PATCH v2 2/5 ARM: dts: at91: Add the required `atmel,rtt-rtc-time-reg` property

In reply to Sergiu Moga

Add the required atmel,rtt-rtc-time-reg property to the rtt nodes of the RTT IPs.

---
 arch/arm/boot/dts/at91sam9261.dtsi | 1 +
 arch/arm/boot/dts/at91sam9263.dtsi | 2 ++
 arch/arm/boot/dts/at91sam9rl.dtsi  | 1 +
 3 files changed, 4 insertions(+)
arch/arm/boot/dts/at91sam9261.dtsi +1 -0
index 7adc36ca8a46..ac50b164138a 100644
@@ -627,6 +627,7 @@ rtc@fffffd20 {
 				reg = <0xfffffd20 0x10>;
 				interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
 				clocks = <&slow_xtal>;
+				atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
 				status = "disabled";
 			};
 
arch/arm/boot/dts/at91sam9263.dtsi +2 -0
index fe45d96239c9..6be91df2a8b1 100644
@@ -734,6 +734,7 @@ rtc@fffffd20 {
 				reg = <0xfffffd20 0x10>;
 				interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
 				clocks = <&slow_xtal>;
+				atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
 				status = "disabled";
 			};
 
@@ -742,6 +743,7 @@ rtc@fffffd50 {
 				reg = <0xfffffd50 0x10>;
 				interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
 				clocks = <&slow_xtal>;
+				atmel,rtt-rtc-time-reg = <&gpbr 0x4>;
 				status = "disabled";
 			};
 
arch/arm/boot/dts/at91sam9rl.dtsi +1 -0
index 730d1182c73e..80e41f115216 100644
@@ -805,6 +805,7 @@ rtc@fffffd20 {
 				reg = <0xfffffd20 0x10>;
 				interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
 				clocks = <&clk32k>;
+				atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
 				status = "disabled";
 			};
 
Signature · 1 line
2.25.1
#5 lore raw

Re: [PATCH v2 2/5] ARM: dts: at91: Add the required `atmel, rtt-rtc-time-reg` property

Quoted 11 lines · Sergiu Moga

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Add the required atmel,rtt-rtc-time-reg property to the rtt nodes of the RTT IPs.

---
 arch/arm/boot/dts/at91sam9261.dtsi | 1 +
 arch/arm/boot/dts/at91sam9263.dtsi | 2 ++
 arch/arm/boot/dts/at91sam9rl.dtsi  | 1 +
 3 files changed, 4 insertions(+)

Now with Alexandre's feedback from patch 1/5, you should probably move the atmel,rtt-rtc-time-reg prop to each of the board files that uses these SoCs.

cheers,
ta

#6 lore raw

PATCH v2 3/5 ARM: dts: at91: Use the generic "rtc" node name for the rtt IPs

In reply to Sergiu Moga

As the DT specification recommends, the node names should be of a generic nature. Thus, the most appropriate generic node name for the at91 rtt IPs is the "rtc" node name.

---
 arch/arm/boot/dts/sam9x60.dtsi | 2 +-
 arch/arm/boot/dts/sama7g5.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/sam9x60.dtsi +1 -1
index 57ba47c54043..af7602cb65f7 100644
@@ -688,7 +688,7 @@ shutdown_controller: shdwc@fffffe10 {
 				status = "disabled";
 			};
 
-			rtt: rtt@fffffe20 {
+			rtt: rtc@fffffe20 {
 				compatible = "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt";
 				reg = <0xfffffe20 0x20>;
 				interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
arch/arm/boot/dts/sama7g5.dtsi +1 -1
index 1530d88ce80f..87af6c680322 100644
@@ -133,7 +133,7 @@ shdwc: shdwc@e001d010 {
 			status = "disabled";
 		};
 
-		rtt: rtt@e001d020 {
+		rtt: rtc@e001d020 {
 			compatible = "microchip,sama7g5-rtt", "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt";
 			reg = <0xe001d020 0x30>;
 			interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
Signature · 1 line
2.25.1
Reviewed-by on v2 3/5
#7 lore raw

Re: [PATCH v2 3/5] ARM: dts: at91: Use the generic "rtc" node name for the rtt IPs

Quoted 10 lines · Sergiu Moga

As the DT specification recommends, the node names should be of a generic nature. Thus, the most appropriate generic node name for the at91 rtt IPs is the "rtc" node name.

---
 arch/arm/boot/dts/sam9x60.dtsi | 2 +-
 arch/arm/boot/dts/sama7g5.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Best regards,
Krzysztof

Reviewed-by on v2 3/5
#8 lore raw

Re: [PATCH v2 3/5] ARM: dts: at91: Use the generic "rtc" node name for the rtt IPs

In reply to Sergiu Moga
Quoted 7 lines · Sergiu Moga

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

As the DT specification recommends, the node names should be of a generic nature. Thus, the most appropriate generic node name for the at91 rtt IPs is the "rtc" node name.

Quoted 39 lines
---
 arch/arm/boot/dts/sam9x60.dtsi | 2 +-
 arch/arm/boot/dts/sama7g5.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/sam9x60.dtsi +1 -1
index 57ba47c54043..af7602cb65f7 100644
@@ -688,7 +688,7 @@ shutdown_controller: shdwc@fffffe10 {
                                status = "disabled";
                        };
 
-                       rtt: rtt@fffffe20 {
+                       rtt: rtc@fffffe20 {
                                compatible = "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt";
                                reg = <0xfffffe20 0x20>;
                                interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
arch/arm/boot/dts/sama7g5.dtsi +1 -2
index 1530d88ce80f..87af6c680322 100644
@@ -133,7 +133,7 @@ shdwc: shdwc@e001d010 {
                        status = "disabled";
                };
 
-               rtt: rtt@e001d020 {
+               rtt: rtc@e001d020 {
                        compatible = "microchip,sama7g5-rtt", "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt";
                        reg = <0xe001d020 0x30>;
                        interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
--

2.25.1

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#9 lore raw

PATCH v2 4/5 dt-bindings: rtc: convert at91sam9 bindings to json-schema

In reply to Sergiu Moga

Convert RTC binding for Atmel/Microchip SoCs to Device Tree Schema format.

---
 .../bindings/rtc/atmel,at91sam9-rtc.txt       | 25 --------
 .../bindings/rtc/atmel,at91sam9-rtc.yaml      | 61 +++++++++++++++++++
 2 files changed, 61 insertions(+), 25 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt deleted +0 -25
deleted file mode 100644
index 3f0e2a5950eb..000000000000
@@ -1,25 +0,0 @@
-Atmel AT91SAM9260 Real Time Timer
-
-Required properties:
-- compatible: should be one of the following:
-	- "atmel,at91sam9260-rtt"
-	- "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt"
-- reg: should encode the memory region of the RTT controller
-- interrupts: rtt alarm/event interrupt
-- clocks: should contain the 32 KHz slow clk that will drive the RTT block.
-- atmel,rtt-rtc-time-reg: should encode the GPBR register used to store
-	the time base when the RTT is used as an RTC.
-	The first cell should point to the GPBR node and the second one
-	encode the offset within the GPBR block (or in other words, the
-	GPBR register used to store the time base).
-
-
-Example:
-
-rtt@fffffd20 {
-	compatible = "atmel,at91sam9260-rtt";
-	reg = <0xfffffd20 0x10>;
-	interrupts = <1 4 7>;
-	clocks = <&clk32k>;
-	atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
-};
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +61 -0

61 lines not on this page · raw message

Signature · 1 line
2.25.1
#10 lore raw

Re: [PATCH v2 4/5] dt-bindings: rtc: convert at91sam9 bindings to json-schema

Quoted 78 lines · Sergiu Moga

Convert RTC binding for Atmel/Microchip SoCs to Device Tree Schema format.

---
 .../bindings/rtc/atmel,at91sam9-rtc.txt       | 25 --------
 .../bindings/rtc/atmel,at91sam9-rtc.yaml      | 61 +++++++++++++++++++
 2 files changed, 61 insertions(+), 25 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt
 create mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt deleted +0 -25
deleted file mode 100644
index 3f0e2a5950eb..000000000000
@@ -1,25 +0,0 @@
-Atmel AT91SAM9260 Real Time Timer
-
-Required properties:
-- compatible: should be one of the following:
-	- "atmel,at91sam9260-rtt"
-	- "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt"
-- reg: should encode the memory region of the RTT controller
-- interrupts: rtt alarm/event interrupt
-- clocks: should contain the 32 KHz slow clk that will drive the RTT block.
-- atmel,rtt-rtc-time-reg: should encode the GPBR register used to store
-	the time base when the RTT is used as an RTC.
-	The first cell should point to the GPBR node and the second one
-	encode the offset within the GPBR block (or in other words, the
-	GPBR register used to store the time base).
-
-
-Example:
-
-rtt@fffffd20 {
-	compatible = "atmel,at91sam9260-rtt";
-	reg = <0xfffffd20 0x10>;
-	interrupts = <1 4 7>;
-	clocks = <&clk32k>;
-	atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
-};
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +30 -0
new file mode 100644
index 000000000000..5a639c0ec2c0
@@ -0,0 +1,61 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (C) 2022 Microchip Technology, Inc. and its subsidiaries
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/atmel,at91sam9-rtc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Atmel AT91 RTT Device Tree Bindings
+
+allOf:
+  - $ref: "rtc.yaml#"
+
+maintainers:
+  - Alexandre Belloni <[email protected]>
+
+properties:
+  compatible:
+    oneOf:
+      - items:
+          - const: atmel,at91sam9260-rtt
+      - items:
+          - const: microchip,sam9x60-rtt
+          - const: atmel,at91sam9260-rtt
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+

Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml line 40

Quoted 10 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +10 -0
+  clocks:
+    maxItems: 1
+
+  atmel,rtt-rtc-time-reg:
+    $ref: /schemas/types.yaml#/definitions/phandle-array
+    description: |
+      Should encode the GPBR register used to store the time base when the
+      RTT is used as an RTC. The first cell should point to the GPBR node
+      and the second one encodes the offset within the GPBR block (or in
+      other words, the GPBR register used to store the time base).

Instead of describing cells here, you need items with description. I gave you the example last time, so instead of ignoring it, please implement it.

Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml line 51

Quoted 11 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +11 -0
+
+  start-year: true
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - atmel,rtt-rtc-time-reg
+
+additionalProperties: false

This will disallow any other properties mentioned in rtc.yaml, e.g. popular wakeup-source. Is it really intended? If core schema is extended, the driver would need to be updated to support new features. Any reason to choose such approach? The other way is to remove start-year and have here unevaluatedProperties.

Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml line 58

Quoted 7 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +7 -0
+
+examples:
+  - |
+    rtc@fffffd20 {
+        compatible = "atmel,at91sam9260-rtt";
+        reg = <0xfffffd20 0x10>;
+        interrupts = <1 4 7>;

At least one number above looks like known macro, so use it.

Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml line 61

Quoted 3 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +3 -0
+        clocks = <&clk32k>;
+        atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
+    };

Best regards,
Krzysztof

#11 lore raw

Re: [PATCH v2 4/5] dt-bindings: rtc: convert at91sam9 bindings to json-schema

Quoted 84 lines · Krzysztof Kozlowski
Quoted 83 lines · Sergiu Moga

Convert RTC binding for Atmel/Microchip SoCs to Device Tree Schema format.

---
  .../bindings/rtc/atmel,at91sam9-rtc.txt       | 25 --------
  .../bindings/rtc/atmel,at91sam9-rtc.yaml      | 61 +++++++++++++++++++
  2 files changed, 61 insertions(+), 25 deletions(-)

delete mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt create mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml

Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt deleted +0 -25
deleted file mode 100644
index 3f0e2a5950eb..000000000000
@@ -1,25 +0,0 @@
-Atmel AT91SAM9260 Real Time Timer
-
-Required properties:
-- compatible: should be one of the following:
-     - "atmel,at91sam9260-rtt"
-     - "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt"
-- reg: should encode the memory region of the RTT controller
-- interrupts: rtt alarm/event interrupt
-- clocks: should contain the 32 KHz slow clk that will drive the RTT block.
-- atmel,rtt-rtc-time-reg: should encode the GPBR register used to store
-     the time base when the RTT is used as an RTC.
-     The first cell should point to the GPBR node and the second one
-     encode the offset within the GPBR block (or in other words, the
-     GPBR register used to store the time base).
-
-
-Example:
-
-rtt@fffffd20 {
-     compatible = "atmel,at91sam9260-rtt";
-     reg = <0xfffffd20 0x10>;
-     interrupts = <1 4 7>;
-     clocks = <&clk32k>;
-     atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
-};
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +35 -0
new file mode 100644
index 000000000000..5a639c0ec2c0
@@ -0,0 +1,61 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (C) 2022 Microchip Technology, Inc. and its subsidiaries
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/atmel,at91sam9-rtc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Atmel AT91 RTT Device Tree Bindings
+
+allOf:
+  - $ref: "rtc.yaml#"
+
+maintainers:
+  - Alexandre Belloni <[email protected]>
+
+properties:
+  compatible:
+    oneOf:
+      - items:
+          - const: atmel,at91sam9260-rtt
+      - items:
+          - const: microchip,sam9x60-rtt
+          - const: atmel,at91sam9260-rtt
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  atmel,rtt-rtc-time-reg:
+    $ref: /schemas/types.yaml#/definitions/phandle-array
Quoted 9 lines

Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml line 40

Quoted 5 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +5 -0
+    description: |
+      Should encode the GPBR register used to store the time base when the
+      RTT is used as an RTC. The first cell should point to the GPBR node
+      and the second one encodes the offset within the GPBR block (or in
+      other words, the GPBR register used to store the time base).

Instead of describing cells here, you need items with description. I gave you the example last time, so instead of ignoring it, please implement it.

Noted.

Quoted 8 lines
Quoted 8 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +8 -0
+
+  start-year: true
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
Quoted 9 lines

Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml line 51

Quoted 3 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +3 -0
+  - atmel,rtt-rtc-time-reg
+
+additionalProperties: false

This will disallow any other properties mentioned in rtc.yaml, e.g. popular wakeup-source. Is it really intended? If core schema is extended, the driver would need to be updated to support new features. Any reason to choose such approach? The other way is to remove start-year and have here unevaluatedProperties.

Ah, I see. Removing start-year and using "unevaluatedProperties: false" here is better indeed.

Quoted 9 lines

Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml line 58

Quoted 7 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +7 -0
+
+examples:
+  - |
+    rtc@fffffd20 {
+        compatible = "atmel,at91sam9260-rtt";
+        reg = <0xfffffd20 0x10>;
+        interrupts = <1 4 7>;

At least one number above looks like known macro, so use it.

Noted. Will add another patch to the series for this.

Quoted 6 lines

Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml line 61

Quoted 3 lines
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml new file +3 -0
+        clocks = <&clk32k>;
+        atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
+    };

Best regards,
Krzysztof

Thank you for the feedback.

Sergiu

#12 lore raw

PATCH v2 5/5 dt-bindings: rtc: at91: Add SAMA7G5 compatible strings list

In reply to Sergiu Moga

Add compatible strings list for SAMA7G5.

---
 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml +4 -0
index 5a639c0ec2c0..d87aa67b442f 100644
@@ -21,6 +21,10 @@ properties:
       - items:
           - const: microchip,sam9x60-rtt
           - const: atmel,at91sam9260-rtt
+      - items:
+          - const: microchip,sama7g5-rtt
+          - const: microchip,sam9x60-rtt
+          - const: atmel,at91sam9260-rtt
 
   reg:
     maxItems: 1
Signature · 1 line
2.25.1