Skip to contentSkip to conversation

ASoC: max98390: Add reset gpio control

PATCH Superseded Steve Lee 3 participants 6 messages Mar 11, 2022 – Apr 21, 2022

Subsystems (3)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Steve Lee

author
#0 lore raw

PATCH v2 1/2 ASoC: max98390: Add reset gpio control

Add reset gpio control to support RESET PIN connected to gpio.

---
 sound/soc/codecs/max98390.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
sound/soc/codecs/max98390.c +12 -0
index b392567c2b3e..5c6162701667 100644
@@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct i2c_client *i2c,
 
 	struct max98390_priv *max98390 = NULL;
 	struct i2c_adapter *adapter = to_i2c_adapter(i2c->dev.parent);
+	struct gpio_desc *reset_gpio;
 
 	ret = i2c_check_functionality(adapter,
 		I2C_FUNC_SMBUS_BYTE
@@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(struct i2c_client *i2c,
 		return ret;
 	}
 
+	reset_gpio = devm_gpiod_get_optional(&i2c->dev,
+						"maxim,reset-gpios", GPIOD_OUT_LOW);
+
+	/* Power on device */
+	if (reset_gpio) {
+		usleep_range(1000, 2000);
+		/* bring out of reset */
+		gpiod_set_value_cansleep(reset_gpio, 1);
+		usleep_range(1000, 2000);
+	}
+
 	/* Check Revision ID */
 	ret = regmap_read(max98390->regmap,
 		MAX98390_R24FF_REV_ID, &reg);
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH v2 2/2 ASoC: dt-bindings: max98390: add reset gpio bindings

This adds support for the reset gpio binding.

---
 Documentation/devicetree/bindings/sound/maxim,max98390.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/sound/maxim,max98390.yaml +5 -0
index e5ac35280da3..4bf61fb6056a 100644
@@ -31,6 +31,9 @@ properties:
     minimum: 1
     maximum: 8388607
 
+  reset-gpios:
+    maxItems: 1
+
 required:
   - compatible
   - reg
@@ -39,6 +42,7 @@ additionalProperties: false
 
 examples:
   - |
+    #include <dt-bindings/gpio/gpio.h>
     i2c {
       #address-cells = <1>;
       #size-cells = <0>;
@@ -47,5 +51,6 @@ examples:
         reg = <0x38>;
         maxim,temperature_calib = <1024>;
         maxim,r0_calib = <100232>;
+        reset-gpios = <&gpio 9 GPIO_ACTIVE_LOW>;
       };
     };
Signature · 1 line
2.17.1
maintainer
#3 lore raw
In reply to Steve Lee
Quoted 1 line · Steve Lee

Add reset gpio control to support RESET PIN connected to gpio.

This doesn't apply against current code, please check and resend.

author
#4 lore raw
Quoted 5 lines · Mark Brown
Quoted 1 line · Steve Lee

Add reset gpio control to support RESET PIN connected to gpio.

This doesn't apply against current code, please check and resend.

I will check and resend patch.

maintainer
#5 lore raw
In reply to Steve Lee
Quoted 3 lines · Steve Lee

Add reset gpio control to support RESET PIN connected to gpio.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: max98390: Add reset gpio control

      commit: 397ff024960634962af93e9e2775fc0e4fe7de92
[2/2] ASoC: dt-bindings: max98390: add reset gpio bindings
      commit: 68514c9f6aa676f98328844336fc4400244a8479

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark