ASoC: max98390: Add reset gpio control
Subsystems (3)
PATCH v4 1/2 ASoC: max98390: Add reset gpio control
Add reset gpio control to support RESET PIN connected to gpio.
---
V3 -> V4: change reset gpio control as GPIO_ACTIVE_LOW in DT
sound/soc/codecs/max98390.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
sound/soc/codecs/max98390.c +12 -0
@@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(struct i2c_client *i2c,struct max98390_priv *max98390 =NULL ;struct i2c_adapter *adapter = i2c->adapter; +struct gpio_desc *reset_gpio; ret =i2c_check_functionality (adapter, I2C_FUNC_SMBUS_BYTE
@@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(struct i2c_client *i2c,return ret; } + reset_gpio =devm_gpiod_get_optional (&i2c->dev, +"reset" ,GPIOD_OUT_HIGH ); + +/* Power on device */ +if (reset_gpio) { +usleep_range (1000 ,2000 ); +/* bring out of reset */ +gpiod_set_value_cansleep (reset_gpio,0 ); +usleep_range (1000 ,2000 ); + } +/* Check Revision ID */ ret =regmap_read (max98390->regmap,MAX98390_R24FF_REV_ID , ®);
Signature · 1 line
2.17.1
PATCH v4 2/2 ASoC: dt-bindings: max98390: add reset gpio bindings
This adds support for the reset gpio binding.
--- Documentation/devicetree/bindings/sound/maxim,max98390.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/sound/maxim,max98390.yaml +5 -0
@@ -29,6 +29,9 @@ properties: minimum: 1 maximum: 8388607 + reset-gpios: + maxItems: 1 + required: - compatible - reg
@@ -37,6 +40,7 @@ additionalProperties: false examples: - | + #include <dt-bindings/gpio/gpio.h> i2c { #address-cells = <1>; #size-cells = <0>;
@@ -45,5 +49,6 @@ examples: reg = <0x38>; maxim,temperature_calib = <1024>; maxim,r0_calib = <100232>; + reset-gpios = <&gpio 9 GPIO_ACTIVE_LOW>; }; };
Signature · 1 line
2.17.1
Quoted 38 lines
-----Original Message-----
From: Steve Lee <[email protected]>
Sent: Wednesday, April 20, 2022 6:49 AM
To: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; alsa-devel@alsa- project.org
Cc: [email protected]; Sa, Nuno <[email protected]>; Lee, RyanS <[email protected]>; Steve Lee <[email protected]>
Subject: [V4 1/2] ASoC: max98390: Add reset gpio control[External]
Add reset gpio control to support RESET PIN connected to gpio.
Signed-off-by Steve Lee <[email protected]>---
V3 -> V4: change reset gpio control asGPIO_ACTIVE_LOWin DTsound/soc/codecs/max98390.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)sound/soc/codecs/max98390.c +1
-0@@ -1022,6 +1022,7 @@ static int max98390_i2c_probe(structi2c_client *i2c, struct max98390_priv *max98390 = NULL;struct i2c_adapter *adapter = i2c->adapter; +struct gpio_desc *reset_gpio; ret = i2c_check_functionality(adapter,sound/soc/codecs/max98390.c +0
-0I2C_FUNC_SMBUS_BYTE
sound/soc/codecs/max98390.c static int max98390_i2c_probe(struct · line 1081
Quoted 8 lines
sound/soc/codecs/max98390.c +4
-0@@ -1073,6 +1074,17 @@ static int max98390_i2c_probe(structi2c_client *i2c, return ret; } + reset_gpio =devm_gpiod_get_optional (&i2c->dev, +"reset" ,GPIOD_OUT_HIGH ); + +/* Power on device */
I guess this comment is redundant as you already say "bring out of reset" some lines below.
sound/soc/codecs/max98390.c static int max98390_i2c_probe(struct i2c_client *i2c, · line 1087
Quoted 7 lines
sound/soc/codecs/max98390.c +7
-0+if (reset_gpio) { +usleep_range (1000 ,2000 ); +/* bring out of reset */ +gpiod_set_value_cansleep (reset_gpio,0 ); +usleep_range (1000 ,2000 ); + } +
Anyways,
Mark Brown
maintainerQuoted 3 lines · Steve Lee
Add reset gpio control to support RESET PIN connected to gpio.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: max98390: Add reset gpio control
commit: 397ff024960634962af93e9e2775fc0e4fe7de92
[2/2] ASoC: dt-bindings: max98390: add reset gpio bindings
commit: 68514c9f6aa676f98328844336fc4400244a8479All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark