Skip to contentSkip to conversation

AM64: Tick timer fixes

PATCH In review Vignesh Raghavendra 3 participants 8 messages Mar 11, 2022 – Apr 5, 2022 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

v2 cover AM64: Tick timer fixes

Patch 1 switches AM64 to use armv8 per-cpu timer at A53 SPL/U-Boot stage as done in other TI K3 platforms

Patch 2 corrects DM timer freq to be 200MHz (used at R5 SPL stage)

v2:
Update commit message 1/2 as per Nishanth's suggestion Reword commit msg in 2/2 to be more readable.

v1: lore.kernel.org/r/[email protected]

Vignesh Raghavendra (2):
configs: am64x_evm_a53_defconfig: Switch to per-cpu timer as tick
provider
ARM: dts: k3-am642: Correct timer frequency

 arch/arm/dts/k3-am642-evm-u-boot.dtsi | 2 +-
 arch/arm/dts/k3-am642-sk-u-boot.dtsi  | 2 +-
 configs/am64x_evm_a53_defconfig       | 3 ---
 3 files changed, 2 insertions(+), 5 deletions(-)
Signature · 1 line
2.35.1
#1 lore raw

PATCH v2 1/2 configs: am64x_evm_a53_defconfig: Switch to per-cpu timer as tick provider

On arm64 systems, recommendation is to use per-cpu timer for time keeping. Currently AM64 ends up using DM timer as tick timer as driver is enabled in the config. Drop OMAP DM Timer related configs, this will switch to using armv8 per-cpu timer as tick timer for A53 SPL/U-Boot.

---
 configs/am64x_evm_a53_defconfig | 3 ---
 1 file changed, 3 deletions(-)
configs/am64x_evm_a53_defconfig +0 -3
index 7397436def..bceb35f5ec 100644
@@ -135,9 +135,6 @@ CONFIG_CADENCE_QSPI=y
 CONFIG_SYSRESET=y
 CONFIG_SPL_SYSRESET=y
 CONFIG_SYSRESET_TI_SCI=y
-CONFIG_TIMER=y
-CONFIG_SPL_TIMER=y
-CONFIG_OMAP_TIMER=y
 CONFIG_USB=y
 CONFIG_DM_USB_GADGET=y
 CONFIG_SPL_DM_USB_GADGET=y
Signature · 1 line
2.35.1
Reviewed-by on v2 1/2
#2 lore raw

Re: [PATCH v2 1/2] configs: am64x_evm_a53_defconfig: Switch to per-cpu timer as tick provider

Quoted 6 lines · Vignesh Raghavendra

On arm64 systems, recommendation is to use per-cpu timer for time keeping. Currently AM64 ends up using DM timer as tick timer as driver is enabled in the config. Drop OMAP DM Timer related configs, this will switch to using armv8 per-cpu timer as tick timer for A53 SPL/U-Boot.

meh.. patchworks is still not smart[1] - so, responding per patch..

[1] https://github.com/getpatchwork/patchwork/issues/113

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#3 lore raw

Re: [PATCH v2 1/2] configs: am64x_evm_a53_defconfig: Switch to per-cpu timer as tick provider

In reply to Vignesh Raghavendra
Quoted 7 lines · Vignesh Raghavendra

On arm64 systems, recommendation is to use per-cpu timer for time keeping. Currently AM64 ends up using DM timer as tick timer as driver is enabled in the config. Drop OMAP DM Timer related configs, this will switch to using armv8 per-cpu timer as tick timer for A53 SPL/U-Boot.

Applied to u-boot/master, thanks!

Signature · 1 line
Tom
#4 lore raw

PATCH v2 2/2 ARM: dts: k3-am642: Correct timer frequency

In reply to Vignesh Raghavendra

Timer0 runs at 200MHz,and the clock-frequency defined in DT is incorrect. Fix it.

---
 arch/arm/dts/k3-am642-evm-u-boot.dtsi | 2 +-
 arch/arm/dts/k3-am642-sk-u-boot.dtsi  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/dts/k3-am642-evm-u-boot.dtsi +1 -1
index 03688a51a3..0c2d973409 100644
@@ -16,7 +16,7 @@
 		compatible = "ti,omap5430-timer";
 		reg = <0x0 0x2400000 0x0 0x80>;
 		ti,timer-alwon;
-		clock-frequency = <250000000>;
+		clock-frequency = <200000000>;
 		u-boot,dm-spl;
 	};
 };
arch/arm/dts/k3-am642-sk-u-boot.dtsi +1 -1
index e5c26b8326..afe5baba8c 100644
@@ -20,7 +20,7 @@
 		compatible = "ti,omap5430-timer";
 		reg = <0x0 0x2400000 0x0 0x80>;
 		ti,timer-alwon;
-		clock-frequency = <250000000>;
+		clock-frequency = <200000000>;
 		u-boot,dm-spl;
 	};
 };
Signature · 1 line
2.35.1
Reviewed-by on the v2 series
#7 lore raw
In reply to Vignesh Raghavendra
Quoted 16 lines · Vignesh Raghavendra

Patch 1 switches AM64 to use armv8 per-cpu timer at A53 SPL/U-Boot stage as done in other TI K3 platforms

Patch 2 corrects DM timer freq to be 200MHz (used at R5 SPL stage)

v2:
Update commit message 1/2 as per Nishanth's suggestion Reword commit msg in 2/2 to be more readable.

v1: lore.kernel.org/r/[email protected]

Vignesh Raghavendra (2):
configs: am64x_evm_a53_defconfig: Switch to per-cpu timer as tick
provider
ARM: dts: k3-am642: Correct timer frequency

Quoted 8 lines
 arch/arm/dts/k3-am642-evm-u-boot.dtsi | 2 +-
 arch/arm/dts/k3-am642-sk-u-boot.dtsi  | 2 +-
 configs/am64x_evm_a53_defconfig       | 3 ---
 3 files changed, 2 insertions(+), 5 deletions(-)
Signature · 1 line
2.35.1
Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D