Skip to contentSkip to conversation

AM64: Tick timer fixes

PATCH Superseded Vignesh Raghavendra 2 participants 4 messages Mar 7, 2022 Arm (32-bit)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover AM64: Tick timer fixes

Patch 1 switches AM64 to use GTC as system timer at A53 SPL/U-boot stage as done in other TI K3 platforms

Patch 2 corrects DM timer freq to be 200MHz (used at R5 SPL stage)

Vignesh Raghavendra (2):
configs: am64x_evm_a53_defconfig: Switch to GTC as tick timer
ARM: dts: k3-am642: Fix correct timer frequency

 arch/arm/dts/k3-am642-evm-u-boot.dtsi | 2 +-
 arch/arm/dts/k3-am642-sk-u-boot.dtsi  | 2 +-
 configs/am64x_evm_a53_defconfig       | 3 ---
 3 files changed, 2 insertions(+), 5 deletions(-)
Signature · 1 line
2.35.1
#1 lore raw

PATCH 1/2 configs: am64x_evm_a53_defconfig: Switch to GTC as tick timer

GTC is to be used as tick timer for A53 SPL/U-Boot, but currently AM64 ends up using DM timer as driver is enabled in the config, drop OMAP DM Timer related configs so that GTC is used by default.

---
 configs/am64x_evm_a53_defconfig | 3 ---
 1 file changed, 3 deletions(-)
configs/am64x_evm_a53_defconfig +0 -3
index 7397436def..bceb35f5ec 100644
@@ -135,9 +135,6 @@ CONFIG_CADENCE_QSPI=y
 CONFIG_SYSRESET=y
 CONFIG_SPL_SYSRESET=y
 CONFIG_SYSRESET_TI_SCI=y
-CONFIG_TIMER=y
-CONFIG_SPL_TIMER=y
-CONFIG_OMAP_TIMER=y
 CONFIG_USB=y
 CONFIG_DM_USB_GADGET=y
 CONFIG_SPL_DM_USB_GADGET=y
Signature · 1 line
2.35.1
#2 lore raw

PATCH 2/2 ARM: dts: k3-am642: Fix correct timer frequency

In reply to Vignesh Raghavendra

Timer0 runs at 200MHz,and the clock-frequency defined in DT appears is incorrect.

---
 arch/arm/dts/k3-am642-evm-u-boot.dtsi | 2 +-
 arch/arm/dts/k3-am642-sk-u-boot.dtsi  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/dts/k3-am642-evm-u-boot.dtsi +1 -1
index 03688a51a3..0c2d973409 100644
@@ -16,7 +16,7 @@
 		compatible = "ti,omap5430-timer";
 		reg = <0x0 0x2400000 0x0 0x80>;
 		ti,timer-alwon;
-		clock-frequency = <250000000>;
+		clock-frequency = <200000000>;
 		u-boot,dm-spl;
 	};
 };
arch/arm/dts/k3-am642-sk-u-boot.dtsi +1 -1
index e5c26b8326..afe5baba8c 100644
@@ -20,7 +20,7 @@
 		compatible = "ti,omap5430-timer";
 		reg = <0x0 0x2400000 0x0 0x80>;
 		ti,timer-alwon;
-		clock-frequency = <250000000>;
+		clock-frequency = <200000000>;
 		u-boot,dm-spl;
 	};
 };
Signature · 1 line
2.35.1
#3 lore raw
In reply to Vignesh Raghavendra
Quoted 2 lines · Vignesh Raghavendra

Patch 1 switches AM64 to use GTC as system timer at A53 SPL/U-boot stage as done in other TI K3 platforms

Minor nuance clarification:
We don't use System timer (aka GTC) directly. System timer[1] feeds the armv8 per cpu timer[2] - and the per-cpu timer is what we use.

Will be good to fixup the commit messages and $subject accordingly.

Quoted 14 lines

Patch 2 corrects DM timer freq to be 200MHz (used at R5 SPL stage)

Vignesh Raghavendra (2):
configs: am64x_evm_a53_defconfig: Switch to GTC as tick timer
ARM: dts: k3-am642: Fix correct timer frequency

 arch/arm/dts/k3-am642-evm-u-boot.dtsi | 2 +-
 arch/arm/dts/k3-am642-sk-u-boot.dtsi  | 2 +-
 configs/am64x_evm_a53_defconfig       | 3 ---
 3 files changed, 2 insertions(+), 5 deletions(-)
Signature · 1 line
2.35.1

[1] https://developer.arm.com/documentation/102379/0000/System-Counter?lang=en
[2] https://developer.arm.com/documentation/den0024/a/Multi-core-processors/Multi-processing-systems/Timers

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D