net: mscc-miim: add integrated PHY reset support
Subsystems (4)
v3 cover net: mscc-miim: add integrated PHY reset support
The MDIO driver has support to release the integrated PHYs from reset. This was implemented for the SparX-5 for now. Now add support for the LAN966x, too.
changes since v2:
- fix typo in commit message
- use microchip,lan966x instead of mscc,lan966x
- rename mask variable to {phy_,}reset_bits
- check return code from device_get_match_data() right after the call instead of checking it where it is used
changes since v1:
- fix typo in the subject in patch 3/3
Michael Walle (3):
dt-bindings: net: mscc-miim: add lan966x compatible
net: mdio: mscc-miim: replace magic numbers for the bus reset
net: mdio: mscc-miim: add lan966x internal phy reset support
.../devicetree/bindings/net/mscc-miim.txt | 2 +- drivers/net/mdio/mdio-mscc-miim.c | 67 ++++++++++++++----- 2 files changed, 50 insertions(+), 19 deletions(-)
Signature · 1 line
2.30.2
PATCH v3 1/3 dt-bindings: net: mscc-miim: add lan966x compatible
The MDIO controller has support to release the internal PHYs from reset by specifying a second memory resource. This is different between the currently supported SparX-5 and the LAN966x. Add a new compatible to distinguish between these two.
--- Documentation/devicetree/bindings/net/mscc-miim.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/net/mscc-miim.txt +1 -1
@@ -2,7 +2,7 @@ Microsemi MII Management Controller (MIIM) / MDIO ================================================= Properties: -- compatible: must be "mscc,ocelot-miim" +- compatible: must be "mscc,ocelot-miim" or "microchip,lan966x-miim" - reg: The base address of the MDIO bus controller register bank. Optionally, a second register bank can be defined if there is an associated reset register for internal PHYs
Signature · 1 line
2.30.2
PATCH v3 2/3 net: mdio: mscc-miim: replace magic numbers for the bus reset
In reply to Michael WalleReplace the magic numbers by macros which are already defined. It seems the original commit missed to use them.
--- drivers/net/mdio/mdio-mscc-miim.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/net/mdio/mdio-mscc-miim.c +5 -5
@@ -158,18 +158,18 @@ static int mscc_miim_reset(struct mii_bus *bus) {struct mscc_miim_dev *miim = bus->priv;int offset = miim->phy_reset_offset; +int reset_bits =PHY_CFG_PHY_ENA |PHY_CFG_PHY_COMMON_RESET | +PHY_CFG_PHY_RESET ;int ret;if (miim->phy_regs) { - ret =regmap_write (miim->phy_regs, -MSCC_PHY_REG_PHY_CFG + offset,0 ); + ret =regmap_write (miim->phy_regs, offset,0 );if (ret <0 ) {WARN_ONCE (1 ,"mscc reset set error %d\n" , ret);return ret; } - ret =regmap_write (miim->phy_regs, -MSCC_PHY_REG_PHY_CFG + offset,0x1ff ); + ret =regmap_write (miim->phy_regs, offset, reset_bits);if (ret <0 ) {WARN_ONCE (1 ,"mscc reset clear error %d\n" , ret);return ret;
@@ -272,7 +272,7 @@ static int mscc_miim_probe(struct platform_device *pdev) miim = bus->priv; miim->phy_regs = phy_regmap; - miim->phy_reset_offset =0 ; + miim->phy_reset_offset =MSCC_PHY_REG_PHY_CFG ; ret =of_mdiobus_register (bus, pdev->dev.of_node);if (ret <0 ) {
Signature · 1 line
2.30.2
Re: [PATCH net-next v3 2/3] net: mdio: mscc-miim: replace magic numbers for the bus reset
Quoted 4 lines · Michael Walle
Replace the magic numbers by macros which are already defined. It seems the original commit missed to use them.
Signed-off-by Michael Walle <[email protected]>
Andrew
PATCH v3 3/3 net: mdio: mscc-miim: add lan966x internal phy reset support
In reply to Michael WalleThe LAN966x has two internal PHYs which are in reset by default. The driver already supported the internal PHYs of the SparX-5. Now add support for the LAN966x, too. Add a new compatible to distinguish them.
The LAN966x has additional control bits in this register, thus convert the regmap_write() to regmap_update_bits() to leave the remaining bits untouched. This doesn't change anything for the SparX-5 SoC, because there, the register consists only of reset bits.
--- drivers/net/mdio/mdio-mscc-miim.c | 67 ++++++++++++++++++++++--------- 1 file changed, 49 insertions(+), 18 deletions(-)
drivers/net/mdio/mdio-mscc-miim.c +49 -18
@@ -15,6 +15,7 @@#include <linux/of_mdio.h> #include <linux/phy.h> #include <linux/platform_device.h> +#include <linux/property.h> #include <linux/regmap.h> #define MSCC_MIIM_REG_STATUS 0x0
@@ -36,11 +37,19 @@#define PHY_CFG_PHY_RESET (BIT(5) | BIT(6) | BIT(7) | BIT(8))#define MSCC_PHY_REG_PHY_STATUS 0x4 +#define LAN966X_CUPHY_COMMON_CFG 0x0 +#define CUPHY_COMMON_CFG_RESET_N BIT(0) + +struct mscc_miim_info { +unsigned int phy_reset_offset; +unsigned int phy_reset_bits; +}; +struct mscc_miim_dev {struct regmap *regs;int mii_status_offset;struct regmap *phy_regs; -int phy_reset_offset; +const struct mscc_miim_info *info; };/* When high resolution timers aren't built-in: we can't use usleep_range() as
@@ -157,27 +166,29 @@ static int mscc_miim_write(struct mii_bus *bus, int mii_id,static int mscc_miim_reset (struct mii_bus *bus) {struct mscc_miim_dev *miim = bus->priv; -int offset = miim->phy_reset_offset; -int reset_bits =PHY_CFG_PHY_ENA |PHY_CFG_PHY_COMMON_RESET | -PHY_CFG_PHY_RESET ; +unsigned int offset, bits;int ret; -if (miim->phy_regs) { - ret =regmap_write (miim->phy_regs, offset,0 ); -if (ret <0 ) { -WARN_ONCE (1 ,"mscc reset set error %d\n" , ret); -return ret; - } +if (!miim->phy_regs) +return 0 ; - ret =regmap_write (miim->phy_regs, offset, reset_bits); -if (ret <0 ) { -WARN_ONCE (1 ,"mscc reset clear error %d\n" , ret); -return ret; - } + offset = miim->info->phy_reset_offset; + bits = miim->info->phy_reset_bits; + + ret =regmap_update_bits (miim->phy_regs, offset, bits,0 ); +if (ret <0 ) { +WARN_ONCE (1 ,"mscc reset set error %d\n" , ret); +return ret; + } -mdelay (500 ); + ret =regmap_update_bits (miim->phy_regs, offset, bits, bits); +if (ret <0 ) { +WARN_ONCE (1 ,"mscc reset clear error %d\n" , ret); +return ret; } +mdelay (500 ); +return 0 ; }
@@ -272,7 +283,10 @@ static int mscc_miim_probe(struct platform_device *pdev) miim = bus->priv; miim->phy_regs = phy_regmap; - miim->phy_reset_offset =MSCC_PHY_REG_PHY_CFG ; + + miim->info =device_get_match_data (&pdev->dev); +if (!miim->info) +return -EINVAL ; ret =of_mdiobus_register (bus, pdev->dev.of_node);if (ret <0 ) {
@@ -294,8 +308,25 @@ static int mscc_miim_remove(struct platform_device *pdev)return 0 ; } +static const struct mscc_miim_info mscc_ocelot_miim_info = { + .phy_reset_offset =MSCC_PHY_REG_PHY_CFG , + .phy_reset_bits =PHY_CFG_PHY_ENA |PHY_CFG_PHY_COMMON_RESET | +PHY_CFG_PHY_RESET , +}; + +static const struct mscc_miim_info microchip_lan966x_miim_info = { + .phy_reset_offset =LAN966X_CUPHY_COMMON_CFG , + .phy_reset_bits =CUPHY_COMMON_CFG_RESET_N , +}; +static const struct of_device_id mscc_miim_match[] = { - { .compatible ="mscc,ocelot-miim" }, + { + .compatible ="mscc,ocelot-miim" , + .data = &mscc_ocelot_miim_info + }, { + .compatible ="microchip,lan966x-miim" , + .data = µchip_lan966x_miim_info + }, { } };MODULE_DEVICE_TABLE (of, mscc_miim_match);
Signature · 1 line
2.30.2
Re: [PATCH net-next v3 3/3] net: mdio: mscc-miim: add lan966x internal phy reset support
Quoted 10 lines · Michael Walle
The LAN966x has two internal PHYs which are in reset by default. The driver already supported the internal PHYs of the SparX-5. Now add support for the LAN966x, too. Add a new compatible to distinguish them.
The LAN966x has additional control bits in this register, thus convert the
regmap_write()toregmap_update_bits()to leave the remaining bits untouched. This doesn't change anything for the SparX-5 SoC, because there, the register consists only of reset bits.Signed-off-by Michael Walle <[email protected]>
Andrew
This series was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This series was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 4 lines · On Fri, 18 Mar 2022 21:13:21 +0100 you wrote:
The MDIO driver has support to release the integrated PHYs from reset. This was implemented for the SparX-5 for now. Now add support for the LAN966x, too.
Quoted 8 lines
changes since v2:
- fix typo in commit message
- use microchip,lan966x instead of mscc,lan966x
- rename mask variable to {phy_,}reset_bits
- check return code fromdevice_get_match_data()right after the call instead of checking it where it is used[...]
Here is the summary with links:
- [net-next,v3,1/3] dt-bindings: net: mscc-miim: add lan966x compatible
https://git.kernel.org/netdev/net-next/c/a2e4b5adfdf8 - [net-next,v3,2/3] net: mdio: mscc-miim: replace magic numbers for the bus reset https://git.kernel.org/netdev/net-next/c/58ebdba3d851 - [net-next,v3,3/3] net: mdio: mscc-miim: add lan966x internal phy reset support https://git.kernel.org/netdev/net-next/c/74529db3e01d
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html