Skip to contentSkip to conversation

imx8m: Use a sane SYS_MALLOC_F_LEN default

PATCH Superseded Fabio Estevam 3 participants 3 messages Mar 23, 2022

Subsystems (3)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 imx8m: Use a sane SYS_MALLOC_F_LEN default

From: Fabio Estevam <[email protected]>

When adding new features to imx8m boards, such as DM clock support, the malloc area can be exhausted.

To avoid such issue, provide a reasonable default for the SYS_MALLOC_F_LEN size.

---
 arch/arm/mach-imx/imx8m/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/mach-imx/imx8m/Kconfig +3 -0
index fae704999533..c7b7121fa845 100644
@@ -21,6 +21,9 @@ config IMX8MP
 	bool
 	select IMX8M
 
+config SYS_MALLOC_F_LEN
+	default 0x10000
+
 config SYS_SOC
 	default "imx8m"
 
Signature · 1 line
2.25.1
#1 lore raw
Quoted 19 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

When adding new features to imx8m boards, such as DM clock support, the malloc area can be exhausted.

To avoid such issue, provide a reasonable default for the SYS_MALLOC_F_LEN size.

---
  arch/arm/mach-imx/imx8m/Kconfig | 3 +++
  1 file changed, 3 insertions(+)
arch/arm/mach-imx/imx8m/Kconfig +0 -0
index fae704999533..c7b7121fa845 100644

arch/arm/mach-imx/imx8m/Kconfig config IMX8MP · line 25

Quoted 5 lines
arch/arm/mach-imx/imx8m/Kconfig +2 -0
@@ -21,6 +21,9 @@ config IMX8MP
  	bool
  	select IMX8M
 
+config SYS_MALLOC_F_LEN
+	default 0x10000

We have all defaults for SYS_MALLOC_F_LEN in /Kconfig. Why should i.mx8nm put it somewhere else?

Best regards

Heinrich

Quoted 4 lines
arch/arm/mach-imx/imx8m/Kconfig +1 -0
+
  config SYS_SOC
  	default "imx8m"
 
#2 lore raw
Quoted 23 lines · Heinrich Schuchardt
Quoted 22 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

When adding new features to imx8m boards, such as DM clock support, the malloc area can be exhausted.

To avoid such issue, provide a reasonable default for the SYS_MALLOC_F_LEN size.

---
  arch/arm/mach-imx/imx8m/Kconfig | 3 +++
  1 file changed, 3 insertions(+)
arch/arm/mach-imx/imx8m/Kconfig +0 -0
index fae704999533..c7b7121fa845 100644
@@ -21,6 +21,9 @@ config IMX8MP
  	bool
  	select IMX8M
 
Quoted 5 lines

arch/arm/mach-imx/imx8m/Kconfig config IMX8MP · line 25

Quoted 2 lines
arch/arm/mach-imx/imx8m/Kconfig +2 -0
+config SYS_MALLOC_F_LEN
+	default 0x10000

We have all defaults for SYS_MALLOC_F_LEN in /Kconfig. Why should i.mx8nm put it somewhere else?

I'm surprised Kconfig isn't complaining even, since there's already a default for ARCH_IMX8M in ./Kconfig.

Signature · 1 line
Tom