Skip to contentSkip to conversation

sandbox: sdl: Add stub sandbox_sdl_remove_display()

PATCH Superseded Andrew Scull 2 participants 3 messages Mar 23, 2022

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sandbox: sdl: Add stub sandbox_sdl_remove_display()

Building the sandbox with NO_SDL=1 resulted in an undefined reference to 'sandbox_sdl_remove_display'. Resolve this by adding a stub implementation to match the stubs to the other similar functions.

Cc Simon Glass <[email protected]>
Cc Anatolij Gustschin <[email protected]>
---
 arch/sandbox/include/asm/sdl.h | 5 +++++
 1 file changed, 5 insertions(+)
arch/sandbox/include/asm/sdl.h +5 -0
index e271a849af..821b0c6a0e 100644
@@ -94,6 +94,11 @@ static inline int sandbox_sdl_init_display(int width, int height, int log2_bpp,
 	return -ENODEV;
 }
 
+static int sandbox_sdl_remove_display(void)
+{
+	return -ENODEV;
+}
+
 static inline int sandbox_sdl_sync(void *lcd_base)
 {
 	return -ENODEV;
Signature · 1 line
2.35.1.894.gb6a874cedc-goog
#1 lore raw
Quoted 1 line

+static int sandbox_sdl_remove_display(void)

Forgot the inline :/ should I resend or can it be added when applying?

Quoted 7 lines
arch/sandbox/include/asm/sdl.h +4 -0
+{
+       return -ENODEV;
+}
+
 static inline int sandbox_sdl_sync(void *lcd_base)
 {
        return -ENODEV;
Reviewed-by
#2 lore raw

Hi Andrew,

Quoted 4 lines · Andrew Scull
Quoted 2 lines

+static int sandbox_sdl_remove_display(void)

Forgot the inline :/ should I resend or can it be added when applying?

Best to resend I think. With that you can add:

Quoted 8 lines

arch/sandbox/include/asm/sdl.h static inline int sandbox_sdl_init_display(int width, int height, int log2_bpp, · line 104

Quoted 8 lines
arch/sandbox/include/asm/sdl.h +4 -0
+{
+       return -ENODEV;
+}
+
 static inline int sandbox_sdl_sync(void *lcd_base)
 {
        return -ENODEV;

Regards,
Simon