Skip to contentSkip to conversation

Issues running nvme-tcp/rdma passthru blktests

PATCH Applied Alan Adamson 5 participants 8 messages Mar 31, 2022 – Apr 13, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

When executing blktest nvme tests with tcp and rdma, and with CONFIG_NVME_TARGET_PASSTHRU enabled, tests nvme/034-037 did not complete.

This was because the nvme/rc helper for setting up passthru targets hardcoded trtype to "loop" which resulted in the nvme connect to fail.

The following patch resolves this.

Alan

#1 lore raw

PATCH 1/1 nvme tests should use nvme_trtype when setting up passthru target

No matter what was passed in with nvme_trtype, the target was being set up with trtype as "loop". This caused several passthru tests to fail when testing tcp or rdma.

---
 tests/nvme/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/nvme/rc +1 -1
index 1c27cdee1b5f..3c38408a0bfe 100644
@@ -335,7 +335,7 @@ _nvmet_passthru_target_setup() {
 	local subsys_name=$1
 
 	_create_nvmet_passthru "${subsys_name}"
-	port="$(_create_nvmet_port "loop")"
+	port="$(_create_nvmet_port "${nvme_trtype}")"
 	_add_nvmet_subsys_to_port "${port}" "${subsys_name}"
 
 	echo "$port"
Signature · 1 line
2.27.0
Reviewed-by on v1 1/1
#3 lore raw

Re: [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target

In reply to Alan Adamson

(+Logan)

Quoted 6 lines · Alan Adamson

No matter what was passed in with nvme_trtype, the target was being set up with trtype as "loop". This caused several passthru tests to fail when testing tcp or rdma.

---

Thanks for your fix, looks good.

-ck

Reviewed-by on v1 1/1
#4 lore raw

Re: [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target

In reply to Alan Adamson
Quoted 29 lines · Alan Adamson

No matter what was passed in with nvme_trtype, the target was being set up with trtype as "loop". This caused several passthru tests to fail when testing tcp or rdma.

---
tests/nvme/rc | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
tests/nvme/rc +1 -1
index 1c27cdee1b5f..3c38408a0bfe 100644
@@ -335,7 +335,7 @@ _nvmet_passthru_target_setup() {
 	local subsys_name=$1
 
 	_create_nvmet_passthru "${subsys_name}"
-	port="$(_create_nvmet_port "loop")"
+	port="$(_create_nvmet_port "${nvme_trtype}")"
 	_add_nvmet_subsys_to_port "${port}" "${subsys_name}"
 
 	echo "$port"
Signature · 1 line
2.27.0

Looks Good

--
Himanshu Madhani Oracle Linux Engineering

#5 lore raw

Re: [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target

In reply to Alan Adamson
Quoted 8 lines · Alan Adamson

No matter what was passed in with nvme_trtype, the target was being set up with trtype as "loop". This caused several passthru tests to fail when testing tcp or rdma.

---
 tests/nvme/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

#6 lore raw
In reply to Alan Adamson
Quoted 8 lines · Alan Adamson

When executing blktest nvme tests with tcp and rdma, and with CONFIG_NVME_TARGET_PASSTHRU enabled, tests nvme/034-037 did not complete.

Quoted 8 lines

This was because the nvme/rc helper for setting up passthru targets hardcoded trtype to "loop" which resulted in the nvme connect to fail.

The following patch resolves this.

Alan

Can you resend with the patch included?

--
Himanshu Madhani Oracle Linux Engineering

#7 lore raw
Quoted 16 lines · Himanshu Madhani
Quoted 13 lines · Alan Adamson

When executing blktest nvme tests with tcp and rdma, and with CONFIG_NVME_TARGET_PASSTHRU enabled, tests nvme/034-037 did not complete.

This was because the nvme/rc helper for setting up passthru targets hardcoded trtype to "loop" which resulted in the nvme connect to fail.

Quoted 7 lines
Quoted 4 lines

The following patch resolves this.

Alan

Can you resend with the patch included?

Ignore this.. patch showed up in my inbox. ..

Quoted 3 lines

--
Himanshu Madhani Oracle Linux Engineering

--
Himanshu Madhani Oracle Linux Engineering