Issues running nvme-tcp/rdma passthru blktests
Subsystems (2)
When executing blktest nvme tests with tcp and rdma, and with CONFIG_NVME_TARGET_PASSTHRU enabled, tests nvme/034-037 did not complete.
This was because the nvme/rc helper for setting up passthru targets hardcoded trtype to "loop" which resulted in the nvme connect to fail.
The following patch resolves this.
Alan
PATCH 1/1 nvme tests should use nvme_trtype when setting up passthru target
No matter what was passed in with nvme_trtype, the target was being set up with trtype as "loop". This caused several passthru tests to fail when testing tcp or rdma.
--- tests/nvme/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/nvme/rc +1 -1
@@ -335,7 +335,7 @@ _nvmet_passthru_target_setup() { local subsys_name=$1 _create_nvmet_passthru "${subsys_name}" - port="$(_create_nvmet_port "loop")" + port="$(_create_nvmet_port "${nvme_trtype}")" _add_nvmet_subsys_to_port "${port}" "${subsys_name}" echo "$port"
Signature · 1 line
2.27.0
Re: [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target
Re: [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target
In reply to Alan Adamson(+Logan)
Quoted 6 lines · Alan Adamson
No matter what was passed in with
nvme_trtype, the target was being set up with trtype as "loop". This caused several passthru tests to fail when testing tcp or rdma.Signed-off-by Alan Adamson <[email protected]>---
Thanks for your fix, looks good.
-ck
Re: [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target
In reply to Alan AdamsonQuoted 29 lines · Alan Adamson
No matter what was passed in with
nvme_trtype, the target was being set up with trtype as "loop". This caused several passthru tests to fail when testing tcp or rdma.Signed-off-by Alan Adamson <[email protected]>---
tests/nvme/rc | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)tests/nvme/rc +1
-1@@ -335,7 +335,7 @@ _nvmet_passthru_target_setup() { local subsys_name=$1 _create_nvmet_passthru "${subsys_name}" - port="$(_create_nvmet_port "loop")" + port="$(_create_nvmet_port "${nvme_trtype}")" _add_nvmet_subsys_to_port "${port}" "${subsys_name}" echo "$port"Signature · 1 line
2.27.0
Looks Good
--
Himanshu Madhani Oracle Linux Engineering
Omar Sandoval
AppliedRe: [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target
In reply to Alan AdamsonQuoted 8 lines · Alan Adamson
No matter what was passed in with
nvme_trtype, the target was being set up with trtype as "loop". This caused several passthru tests to fail when testing tcp or rdma.Signed-off-by Alan Adamson <[email protected]>--- tests/nvme/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Quoted 8 lines · Alan Adamson
When executing blktest nvme tests with tcp and rdma, and with
CONFIG_NVME_TARGET_PASSTHRUenabled, tests nvme/034-037 did not complete.
Quoted 8 lines
This was because the nvme/rc helper for setting up passthru targets hardcoded trtype to "loop" which resulted in the nvme connect to fail.
The following patch resolves this.
Alan
Can you resend with the patch included?
--
Himanshu Madhani Oracle Linux Engineering
Quoted 16 lines · Himanshu Madhani
Quoted 13 lines · Alan Adamson
When executing blktest nvme tests with tcp and rdma, and with
CONFIG_NVME_TARGET_PASSTHRUenabled, tests nvme/034-037 did not complete.This was because the nvme/rc helper for setting up passthru targets hardcoded trtype to "loop" which resulted in the nvme connect to fail.
Quoted 7 lines
Quoted 4 lines
The following patch resolves this.
Alan
Can you resend with the patch included?
Ignore this.. patch showed up in my inbox. ..
Quoted 3 lines
--
Himanshu Madhani Oracle Linux Engineering
--
Himanshu Madhani Oracle Linux Engineering