Skip to contentSkip to conversation

Split "nfc: st21nfca: Refactor EVT_TRANSACTION" into 3

PATCH In review Martin Faltesek 3 participants 3 messages Apr 1, 2022 – Jun 2, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v2 cover Split "nfc: st21nfca: Refactor EVT_TRANSACTION" into 3

Changes in v2:
-- Split the original patch into 3 patches, so that each one solves
a single issue. The original patch indicated 4 bugs, but two are so closely related that I feel it makes sense to keep them together.

-- 1/3
nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION

This is mentioned in v1 as #1. It just changes logical AND to logical OR. The AND was rendering the check useless.

-- 2/3
nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling

This is from v1 #3.

-- 3/3
nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION

This is from v1 #2 and #4
Both are derived from the same bug, which is the incorrect calculation that buffer allocation size is skb->len - 2, so both should be combined.

After these 3 patches are applied, the end result is the same as v1 except:

-- minor comment rewording.
-- removed some comments which felt superfluous explanations of
obvious code.

Martin Faltesek (3):
nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION
nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling
nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION

 drivers/nfc/st21nfca/se.c | 51 +++++++++++++++++++++++----------------
 1 file changed, 30 insertions(+), 21 deletions(-)

base-commit: e8b767f5e04097aaedcd6e06e2270f9fe5282696

Signature · 1 line
2.35.1.1094.g7c7d902a7c-goog
#1 lore raw
Quoted 6 lines · Martin Faltesek

Changes in v2:
-- Split the original patch into 3 patches, so that each one solves
a single issue. The original patch indicated 4 bugs, but two are so closely related that I feel it makes sense to keep them together.

Please thread your patchset. git send-email does it by default, so just format-patch -3 --cover-letter -v2 and then git send-email ... v2*

In the Cc list, you missed the linux-nfc mailing list, probably because it requires subscription.

Best regards,
Krzysztof

#2 lore raw
In reply to Martin Faltesek

Hi,

Quoted 31 lines · Martin Faltesek

Changes in v2:
-- Split the original patch into 3 patches, so that each one solves
a single issue. The original patch indicated 4 bugs, but two are so closely related that I feel it makes sense to keep them together.

-- 1/3
nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION

This is mentioned in v1 as #1. It just changes logical AND to logical OR. The AND was rendering the check useless.

-- 2/3
nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling

This is from v1 #3.

-- 3/3
nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION

This is from v1 #2 and #4
Both are derived from the same bug, which is the incorrect calculation that buffer allocation size is skb->len - 2, so both should be combined.

After these 3 patches are applied, the end result is the same as v1 except:

-- minor comment rewording.
-- removed some comments which felt superfluous explanations of
obvious code.

Quoted 8 lines

Martin Faltesek (3):
nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION
nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling
nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION

 drivers/nfc/st21nfca/se.c | 51 +++++++++++++++++++++++----------------
 1 file changed, 30 insertions(+), 21 deletions(-)

Ping?

Denis