Skip to content

Split "nfc: st21nfca: Refactor EVT_TRANSACTION" into 3

Martin Faltesek netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest3 patches 5 repliesIn review

Changes in v2 from the cover letter

-- Split the original patch into 3 patches, so that each one solves
a single issue. The original patch indicated 4 bugs, but two are so closely related that I feel it makes sense to keep them together.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTIONdrivers/nfc/st21nfca/se.c+1 -11 reply
2/3nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handlingdrivers/nfc/st21nfca/se.c+10 -31 reply
3/3nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTIONdrivers/nfc/st21nfca/se.c+30 -281 reply

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchKrzysztof Kozlowski
1/3R-b
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] Split "nfc: st21nfca: Refactor EVT_TRANSACTION" into 3

Changes in v2:
-- Split the original patch into 3 patches, so that each one solves
a single issue. The original patch indicated 4 bugs, but two are so closely related that I feel it makes sense to keep them together.

-- 1/3
nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION

This is mentioned in v1 as #1. It just changes logical AND to logical OR. The AND was rendering the check useless.

-- 2/3
nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling

This is from v1 #3.

-- 3/3
nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION

This is from v1 #2 and #4
Both are derived from the same bug, which is the incorrect calculation that buffer allocation size is skb->len - 2, so both should be combined.

After these 3 patches are applied, the end result is the same as v1 except:

-- minor comment rewording.
-- removed some comments which felt superfluous explanations of
obvious code.

Martin Faltesek (3):
nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION
nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling
nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION

 drivers/nfc/st21nfca/se.c | 51 +++++++++++++++++++++++----------------
 1 file changed, 30 insertions(+), 21 deletions(-)

base-commit: e8b767f5e04097aaedcd6e06e2270f9fe5282696

Signature · 1 line
2.35.1.1094.g7c7d902a7c-goog