Skip to contentSkip to conversation

clk: bcm: rpi: Add support for two more clocks

PATCH Superseded Ivan T. Ivanov 4 participants 7 messages Apr 5, 2022 – Apr 15, 2022

Subsystems (2)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v2 cover clk: bcm: rpi: Add support for two more clocks

Add missing clock required by RPiVid video decoder and make HDMI pixel clock more reliable.

Changes since v1
- Drop RPI_FIRMWARE_VEC_CLK_ID clock it doesn't seems to be used.
- Rework downstream changes on top of recent Maxime changes.

Ivan T. Ivanov (2):
clk: bcm: rpi: Add support HEVC clock
clk: bcm: rpi: Handle pixel clock in firmware

 drivers/clk/bcm/clk-raspberrypi.c | 6 ++++++
 1 file changed, 6 insertions(+)
Signature · 1 line
2.26.2
#1 lore raw

PATCH v2 1/2 clk: bcm: rpi: Add support HEVC clock

Export clock required for RPiVid video decoder hardware.

---
 drivers/clk/bcm/clk-raspberrypi.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/clk/bcm/clk-raspberrypi.c +3 -0
index 9d09621549b9..2e2491d85835 100644
@@ -129,6 +129,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
 	[RPI_FIRMWARE_V3D_CLK_ID] = {
 		.export = true,
 	},
+	[RPI_FIRMWARE_HEVC_CLK_ID] = {
+		.export = true,
+	},
 	[RPI_FIRMWARE_PIXEL_BVB_CLK_ID] = {
 		.export = true,
 	},
Signature · 1 line
2.26.2
#2 lore raw

PATCH v2 2/2 clk: bcm: rpi: Handle pixel clock in firmware

In reply to Ivan T. Ivanov

The clk-bcm2835 handling of the pixel clock does not function correctly when the HDMI power domain is disabled.

The firmware supports it correctly, so add it to the firmware clock driver.

---
 drivers/clk/bcm/clk-raspberrypi.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/clk/bcm/clk-raspberrypi.c +3 -0
index 2e2491d85835..530820d13104 100644
@@ -129,6 +129,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
 	[RPI_FIRMWARE_V3D_CLK_ID] = {
 		.export = true,
 	},
+	[RPI_FIRMWARE_PIXEL_CLK_ID] = {
+		.export = true,
+	},
 	[RPI_FIRMWARE_HEVC_CLK_ID] = {
 		.export = true,
 	},
Signature · 1 line
2.26.2
Acked-by on v2 2/2
#3 lore raw

Re: [PATCH v2 2/2] clk: bcm: rpi: Handle pixel clock in firmware

Quoted 9 lines · Ivan T. Ivanov

The clk-bcm2835 handling of the pixel clock does not function correctly when the HDMI power domain is disabled.

The firmware supports it correctly, so add it to the firmware clock driver.

Quoted 21 lines
---
 drivers/clk/bcm/clk-raspberrypi.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/clk/bcm/clk-raspberrypi.c +3 -1
index 2e2491d85835..530820d13104 100644
@@ -129,6 +129,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
        [RPI_FIRMWARE_V3D_CLK_ID] = {
                .export = true,
        },
+       [RPI_FIRMWARE_PIXEL_CLK_ID] = {
+               .export = true,
+       },
        [RPI_FIRMWARE_HEVC_CLK_ID] = {
                .export = true,
        },
--

2.26.2

#5 lore raw

Hi Michael, Stephen,

Quoted 8 lines · Maxime Ripard

Date: Tue, 5 Apr 2022 11:04:31 +0200
From: Maxime Ripard <[email protected]>
To: "Ivan T. Ivanov" <[email protected]>
Cc: Michael Turquette <[email protected]>, Stephen Boyd
<[email protected]>, [email protected], [email protected]
Subject: Re: [PATCH v2 0/2] clk: bcm: rpi: Add support for two more clocks
Message-ID: <20220405090431.ktlybn62eueh7gqi@houat>

Tags: all clk linux me ring

Quoted 8 lines · Ivan T. Ivanov
Quoted 2 lines

Add missing clock required by RPiVid video decoder and make HDMI pixel clock more reliable.

For both patches:

Any chance that this is merged in foreseeable future? Do you have any comments or objections?

Thanks,
Ivan

#6 lore raw

Hi Ivan,

Am 15.04.22 um 09:48 schrieb Ivan T. Ivanov:

Quoted 12 lines

Hi Michael, Stephen,

Quoted 8 lines · Maxime Ripard

Date: Tue, 5 Apr 2022 11:04:31 +0200
From: Maxime Ripard <[email protected]>
To: "Ivan T. Ivanov" <[email protected]>
Cc: Michael Turquette <[email protected]>, Stephen Boyd
<[email protected]>, [email protected], [email protected]
Subject: Re: [PATCH v2 0/2] clk: bcm: rpi: Add support for two more clocks
Message-ID: <20220405090431.ktlybn62eueh7gqi@houat>

Tags: all clk linux me ring

Quoted 8 lines
Quoted 6 lines · Ivan T. Ivanov
Quoted 2 lines

Add missing clock required by RPiVid video decoder and make HDMI pixel clock more reliable.

For both patches:

Any chance that this is merged in foreseeable future? Do you have any comments or objections?

could you please send a new version with all tags and consider the whole audience based on this patch [1]?

Thanks

[1] - https://lore.kernel.org/linux-arm-kernel/[email protected]/T/

Quoted 5 lines

Thanks,
Ivan