xtensa: patch_text: Fixup last cpu should be master
Subsystems (4)
PATCH v3 1/1 xtensa: patch_text: Fixup last cpu should be master
From: Guo Ren <[email protected]>
These patch_text implementations are using stop_machine_cpuslocked infrastructure with atomic cpu_count. The original idea: When the master CPU patch_text, the others should wait for it. But current implementation is using the first CPU as master, which couldn't guarantee the remaining CPUs are waiting. This patch changes the last CPU as the master to solve the potential risk.
--- arch/xtensa/kernel/jump_label.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/xtensa/kernel/jump_label.c +1 -1
@@ -40,7 +40,7 @@ static int patch_text_stop_machine(void *data) {struct patch *patch = data; -if (atomic_inc_return (&patch->cpu_count) ==1 ) { +if (atomic_inc_return (&patch->cpu_count) ==num_online_cpus ()) {local_patch_text (patch->addr, patch->data, patch->sz);atomic_inc (&patch->cpu_count); }else {
Signature · 1 line
2.25.1
Max Filippov
maintainerQuoted 10 lines · On Wed, Apr 6, 2022 at 7:28 AM <[email protected]> wrote:
From: Guo Ren <[email protected]>
These
patch_textimplementations are usingstop_machine_cpuslockedinfrastructure with atomiccpu_count. The original idea: When the master CPUpatch_text, the others should wait for it. But current implementation is using the first CPU as master, which couldn't guarantee the remaining CPUs are waiting. This patch changes the last CPU as the master to solve the potential risk.
Quoted 8 lines
Signed-off-by Guo Ren <[email protected]>Signed-off-by Guo Ren <[email protected]>Reviewed-by Max Filippov <[email protected]>Reviewed-by Masami Hiramatsu <[email protected]>Cc <[email protected]>--- arch/xtensa/kernel/jump_label.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks. Applied to my xtensa tree.
-- Max
Quoted 21 lines · Max Filippov
Quoted 10 lines · On Wed, Apr 6, 2022 at 7:28 AM <[email protected]> wrote:
From: Guo Ren <[email protected]>
These
patch_textimplementations are usingstop_machine_cpuslockedinfrastructure with atomiccpu_count. The original idea: When the master CPUpatch_text, the others should wait for it. But current implementation is using the first CPU as master, which couldn't guarantee the remaining CPUs are waiting. This patch changes the last CPU as the master to solve the potential risk.Quoted 8 lines
Signed-off-by Guo Ren <[email protected]>Signed-off-by Guo Ren <[email protected]>Reviewed-by Max Filippov <[email protected]>Reviewed-by Masami Hiramatsu <[email protected]>Cc <[email protected]>--- arch/xtensa/kernel/jump_label.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 1 line
Thanks. Applied to my xtensa tree.
I've missed the "Fixes:" for [email protected], so I would update v3 to fix it.
Quoted 2 lines
-- Max
Signature · 4 lines
Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/