csky: patch_text: Fixup last cpu should be master
Subsystems (3)
[email protected]
maintainerPATCH v3 1/1 csky: patch_text: Fixup last cpu should be master
From: Guo Ren <[email protected]>
These patch_text implementations are using stop_machine_cpuslocked infrastructure with atomic cpu_count. The original idea: When the master CPU patch_text, the others should wait for it. But current implementation is using the first CPU as master, which couldn't guarantee the remaining CPUs are waiting. This patch changes the last CPU as the master to solve the potential risk.
Signed-off-by Guo Ren <[email protected]>
Signed-off-by Guo Ren <[email protected]>
Reviewed-by Masami Hiramatsu <[email protected]>
Cc <[email protected]>
--- arch/csky/kernel/probes/kprobes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/csky/kernel/probes/kprobes.c +1 -1
@@ -30,7 +30,7 @@ static int __kprobes patch_text_cb(void *priv)struct csky_insn_patch *param = priv;unsigned int addr = (unsigned int )param->addr; -if (atomic_inc_return (¶m->cpu_count) ==1 ) { +if (atomic_inc_return (¶m->cpu_count) ==num_online_cpus ()) { *(u16 *) addr =cpu_to_le16 (param->opcode);dcache_wb_range (addr, addr +2 );atomic_inc (¶m->cpu_count);
Signature · 1 line
2.25.1