Make AUX gpio pin optional for ktd2692
Subsystems (2)
v4 cover Make AUX gpio pin optional for ktd2692
Some appliances of ktd2692 don't have the AUX pin connected to a GPIO. Specifically, Samsung Galaxy J5 (2015), which uses ktd2692 for driving the front flash LED, has the pin not connected anywhere on schematics. Make specifying the AUX pin optional, since it is additional functionality and only affects amount of current going through the LED.
Also convert the txt device-tree bindings to yaml and pick up maintenance over the yaml binding and the driver itself.
v2:
- fix the dt_binding_check
v3:
- set the aux_gpio to NULL to avoid passing ERR_PTR as a gpio v4:
- maintainership -> maintenance (description)
- remove the if (led->aux_gpio)
- use devm_gpiod_get_optional for aux gpio
Markuss Broks (2):
dt-bindings: leds: convert ktd2692 bindings to yaml
leds: ktd2692: Make aux-gpios optional
.../bindings/leds/kinetic,ktd2692.yaml | 87 +++++++++++++++++++ .../devicetree/bindings/leds/leds-ktd2692.txt | 50 ----------- MAINTAINERS | 6 ++ drivers/leds/flash/leds-ktd2692.c | 18 ++-- 4 files changed, 103 insertions(+), 58 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml delete mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt
Signature · 1 line
2.35.1
PATCH v4 1/2 dt-bindings: leds: convert ktd2692 bindings to yaml
This patch converts the leds-ktd2692.txt bindings to modern yaml style device-tree bindings.
--- .../bindings/leds/kinetic,ktd2692.yaml | 87 +++++++++++++++++++ .../devicetree/bindings/leds/leds-ktd2692.txt | 50 ----------- 2 files changed, 87 insertions(+), 50 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml delete mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt
Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml new file +87 -0
@@ -0,0 +1,87 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/kinetic,ktd2692.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: KTD2692 Flash LED Driver from Kinetic Technologies + +maintainers: + - Markuss Broks <[email protected]> + +description: | + KTD2692 is the ideal power solution for high-power flash LEDs. + It uses ExpressWire single-wire programming for maximum flexibility. + + The ExpressWire interface through CTRL pin can control LED on/off and + enable/disable the IC, Movie(max 1/3 of Flash current) / Flash mode current, + Flash timeout, LVP(low voltage protection). + + Also, When the AUX pin is pulled high while CTRL pin is high, + LED current will be ramped up to the flash-mode current level. + +properties: + compatible: + const: kinetic,ktd2692 + + ctrl-gpios: + maxItems: 1 + description: Specifier of the GPIO connected to CTRL pin. + + aux-gpios: + maxItems: 1 + description: Specifier of the GPIO connected to CTRL pin. + + vin-supply: + description: LED supply (2.7V to 5.5V). + + led: + type: object + $ref: common.yaml# + description: Properties for the LED. + properties: + function: true + color: true + flash-max-timeout-us: + description: Flash LED maximum timeout. + + led-max-microamp: + maximum: 300000 + description: Minimum Threshold for Timer protection + is defined internally (Maximum 300mA). + + flash-max-microamp: + maximum: 300000 + description: Flash LED maximum current + Formula - I(uA) = 15000000 / Rset. + + additionalProperties: false + +required: + - compatible + - ctrl-gpios + - led + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/leds/common.h> + + ktd2692 { + compatible = "kinetic,ktd2692"; + ctrl-gpios = <&gpc0 1 0>; + aux-gpios = <&gpc0 2 0>; + vin-supply = <&vbat>; + + led { + function = LED_FUNCTION_FLASH; + color = <LED_COLOR_ID_WHITE>; + flash-max-timeout-us = <250000>; + flash-max-microamp = <150000>; + led-max-microamp = <25000>; + }; + }; + +...
Documentation/devicetree/bindings/leds/leds-ktd2692.txt deleted +0 -50
50 lines not on this page · raw message
Signature · 1 line
2.35.1
PATCH v4 2/2 leds: ktd2692: Make aux-gpios optional
In reply to Markuss BroksMake the AUX pin optional, since it isn't a core part of functionality, and the device is designed to be operational with only one CTRL pin.
Also pick up maintenance for the LED driver and the yaml bindings.
--- MAINTAINERS | 6 ++++++ drivers/leds/flash/leds-ktd2692.c | 7 +++---- 2 files changed, 9 insertions(+), 4 deletions(-)
MAINTAINERS +6 -0
@@ -10479,6 +10479,12 @@ S: Maintained F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml F: drivers/video/backlight/ktd253-backlight.c +KTD2692 FLASH LED DRIVER +M: Markuss Broks <[email protected]> +S: Maintained +F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktd2692.yaml +F: drivers/leds/flash/leds-ktd2692.yaml + KTEST M: Steven Rostedt <[email protected]> M: John Hawley <[email protected]>
drivers/leds/flash/leds-ktd2692.c +3 -4
@@ -284,10 +284,9 @@ static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev,return ret; } - led->aux_gpio =devm_gpiod_get (dev,"aux" ,GPIOD_ASIS ); - ret =PTR_ERR_OR_ZERO (led->aux_gpio); -if (ret) { -dev_err (dev,"cannot get aux-gpios %d\n" , ret); + led->aux_gpio =devm_gpiod_get_optional (dev,"aux" ,GPIOD_ASIS ); +if (IS_ERR (led->aux_gpio)) { +dev_err (dev,"cannot get aux-gpios: %d\n" , ret);return ret; }
Signature · 1 line
2.35.1
Re: [PATCH v4 2/2] leds: ktd2692: Make aux-gpios optional
Le 08/04/2022 à 18:33, Markuss Broks a écrit :
Quoted 34 lines
Make the AUX pin optional, since it isn't a core part of functionality, and the device is designed to be operational with only one CTRL pin.
Also pick up maintenance for the LED driver and the yaml bindings.
Signed-off-by Markuss Broks <[email protected]>--- MAINTAINERS | 6 ++++++ drivers/leds/flash/leds-ktd2692.c | 7 +++---- 2 files changed, 9 insertions(+), 4 deletions(-)MAINTAINERS +6
-0@@ -10479,6 +10479,12 @@ S: Maintained F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktd253.yaml F: drivers/video/backlight/ktd253-backlight.c +KTD2692 FLASH LED DRIVER +M: Markuss Broks <[email protected]> +S: Maintained +F: Documentation/devicetree/bindings/leds/backlight/kinetic,ktd2692.yaml +F: drivers/leds/flash/leds-ktd2692.yaml + KTEST M: Steven Rostedt <[email protected]> M: John Hawley <[email protected]>drivers/leds/flash/leds-ktd2692.c +0
-0@@ -284,10 +284,9 @@ static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev,return ret;
drivers/leds/flash/leds-ktd2692.c static int ktd2692_parse_dt(struct ktd2692_context *led, struct device *dev, · line 290
Quoted 10 lines
drivers/leds/flash/leds-ktd2692.c +3
-4} - led->aux_gpio =devm_gpiod_get (dev,"aux" ,GPIOD_ASIS ); - ret =PTR_ERR_OR_ZERO (led->aux_gpio); -if (ret) { -dev_err (dev,"cannot get aux-gpios %d\n" , ret); + led->aux_gpio =devm_gpiod_get_optional (dev,"aux" ,GPIOD_ASIS ); +if (IS_ERR (led->aux_gpio)) { +dev_err (dev,"cannot get aux-gpios: %d\n" , ret);return ret;
Hi,
'ret' is known to be 0 at this point.
maybe adding:
ret = PTR_ERR(led->aux_gpio);
?
CJ
Quoted 2 lines
drivers/leds/flash/leds-ktd2692.c +0
-0}