Skip to content

Make AUX gpio pin optional for ktd2692

Markuss Broks linux-devicetree linux-leds lkml 11 versions – Applied

Status from this message: Thank you, applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest0 of 2 patches 1 replyApplied
  2. v72 patches 4 repliesSuperseded
  3. v6 posting 4/42 patches 1 replySuperseded
Earlier versions · 8
VersionPostedPatchesRepliesStatus
v6 posting 3/41 of 2 patches0 repliesSuperseded
v6 posting 2/42 patches1 replySuperseded
v6 posting 1/42 patches3 repliesSuperseded
v52 patches1 replySuperseded
v42 patches1 replySuperseded
v32 patches1 replySuperseded
v22 patches0 repliesSuperseded
v12 patches2 repliesSuperseded

Changes in v8 from the cover letter

- introduce a patch changing dev_err in gpio access to dev_err_probe

Patches in v8 Applied

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchRob HerringAndy Shevchenko
SeriesR-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH v8 0/2] Make AUX gpio pin optional for ktd2692

Some appliances of ktd2692 don't have the AUX pin connected to a GPIO. Specifically, Samsung Galaxy J5 (2015), which uses ktd2692 for driving the front flash LED, has the pin not connected anywhere on schematics. Make specifying the AUX pin optional, since it is additional functionality and only affects the amount of current going through the LED.

Also convert the txt device-tree bindings to yaml.

v2:
- fix the dt_binding_check
v3:
- set the aux_gpio to NULL to avoid passing ERR_PTR as a gpio v4:
- maintainership -> maintenance (description)
- remove the if (led->aux_gpio)
- use devm_gpiod_get_optional for aux gpio
v5:
- use ret to pass a correct error return code (Christophe) v6:
- use PTR_ERR properly (when IS_ERR is true) (Christophe) v6-a:
- ended up being a mess, corrected-v2 should have proper tags now v7:
- drop the MAINTAINERS part
v8:
- introduce a patch changing dev_err in gpio access to dev_err_probe

Markuss Broks (2):
dt-bindings: leds: convert ktd2692 bindings to yaml
leds: ktd2692: Make aux-gpios optional

 .../bindings/leds/kinetic,ktd2692.yaml        | 87 +++++++++++++++++++
 .../devicetree/bindings/leds/leds-ktd2692.txt | 50 -----------
 MAINTAINERS                                   |  6 ++
 drivers/leds/flash/leds-ktd2692.c             | 18 ++--
 4 files changed, 103 insertions(+), 58 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/leds/kinetic,ktd2692.yaml
 delete mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt
Signature · 1 line
2.35.1