imx6 ddr initialization fixes
Subsystems (3)
cover imx6 ddr initialization fixes
Dear all,
the following series fixes a couple of issues on the i.MX6 DDR3 memory initialization we discovered while debugging some rare boot failures on apalis-imx6 [0]. This is a follow-up of this RFC series [1], with the apalis-imx6 changes removed since we do plan doing additional validation before merging.
[0] https://lore.kernel.org/all/[email protected]/
[1] https://lore.kernel.org/u-boot/[email protected]/
Changes in v1:
Add Reviewed-by: Marek Vasut [email protected]
Commit message and comments improvements, no code changes.
Francesco Dolcini (2):
mx6: ddr: Restore ralat/walat in write level calibration
mx6: ddr: Wait before issuing the first MRS cmd
arch/arm/mach-imx/mx6/ddr.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
Signature · 1 line
2.25.1
PATCH 1/2 mx6: ddr: Restore ralat/walat in write level calibration
The current DDR write level calibration routine always overwrite the ralat/walat fields to their maximum value, just save the existing values at the beginning of the calibration routine and restore it at the end.
In case the delay is estimated by the user to be more than one cycle the walat should be configured according to that, this is not automatically done. From the i.MX6 RM:
The user should read the results of the associated delay-line at MPWLDECTRL#[WL_DL_ABS_OFFSET#] and in case the user estimates that the reasonable delay may be above 1 cycle then the user should indicate it at MPWLDECTRL#[WL_CYC_DEL#]. Moreover the user should indicate it in MDMISC[WALAT] field. For example, if the result of the write leveling calibration is 100/256 parts of a cycle, but the user estimates that the delay is above 2 cycles then MPWLDECTRL#[WL_CYC_DEL#] should be configured to 2, so the total delay will be 2 and 100/256 parts of a cycle
Probably it would just possible to not overwrite the mdmisc register in the first place, since this is not present in the write_level_calib() example in NXP AN4467 nor in the i.MX6 RM (44.11.6.1 Hardware Write Leveling Calibration).
---
Changes in v1:
- Add Reviewed-by: Marek Vasut [email protected]
--- arch/arm/mach-imx/mx6/ddr.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
arch/arm/mach-imx/mx6/ddr.c +7 -1
@@ -108,7 +108,7 @@ int mmdc_do_write_level_calibration(struct mx6_ddr_sysinfo const *sysinfo) {struct mmdc_p_regs *mmdc0 = (struct mmdc_p_regs *)MMDC_P0_BASE_ADDR ;struct mmdc_p_regs *mmdc1 = (struct mmdc_p_regs *)MMDC_P1_BASE_ADDR ; -u32 esdmisc_val, zq_val; +u32 esdmisc_val, zq_val, mdmisc_val;u32 errors =0 ;u32 ldectrl[4 ] = {0 };u32 ddr_mr1 =0x4 ;
@@ -131,6 +131,9 @@ int mmdc_do_write_level_calibration(struct mx6_ddr_sysinfo const *sysinfo)/* disable Adopt power down timer */ setbits_le32 (&mmdc0->mapsr,0x1 ); +/* Save old RALAT and WALAT values */ + mdmisc_val =readl (&mmdc0->mdmisc); +debug ("Starting write leveling calibration.\n" );/*
@@ -217,6 +220,9 @@ int mmdc_do_write_level_calibration(struct mx6_ddr_sysinfo const *sysinfo)writel (esdmisc_val, &mmdc0->mdref);writel (zq_val, &mmdc0->mpzqhwctrl); +/* restore WALAT/RALAT */ +writel (mdmisc_val, &mmdc0->mdmisc); +debug ("\tMMDC_MPWLDECTRL0 after write level cal: 0x%08x\n" ,readl (&mmdc0->mpwldectrl0)); debug("\tMMDC_MPWLDECTRL1 after write level cal: 0x%08x\n",
Signature · 1 line
2.25.1
Re: [PATCH v1 1/2] mx6: ddr: Restore ralat/walat in write level calibration
Hi Francesco,
Quoted 19 lines · Francesco Dolcini
The current DDR write level calibration routine always overwrite the ralat/walat fields to their maximum value, just save the existing values at the beginning of the calibration routine and restore it at the end.
In case the delay is estimated by the user to be more than one cycle the walat should be configured according to that, this is not automatically done. From the i.MX6 RM:
The user should read the results of the associated delay-line at MPWLDECTRL#[WL_DL_ABS_OFFSET#] and in case the user estimates that the reasonable delay may be above 1 cycle then the user should indicate it at MPWLDECTRL#[WL_CYC_DEL#]. Moreover the user should indicate it in MDMISC[WALAT] field. For example, if the result of the write leveling calibration is 100/256 parts of a cycle, but the user estimates that the delay is above 2 cycles then MPWLDECTRL#[WL_CYC_DEL#] should be configured to 2, so the total delay will be 2 and 100/256 parts of a cycle
Quoted 8 lines
Probably it would just possible to not overwrite the mdmisc register in the first place, since this is not present in the
write_level_calib()example in NXP AN4467 nor in the i.MX6 RM (44.11.6.1 Hardware Write Leveling Calibration).Fixes d339f16911c7 ("arm: imx6: Add DDR3 calibration code for MX6 Q/D/DL")Signed-off-by Francesco Dolcini <[email protected]>Reviewed-by Marek Vasut <[email protected]>
PATCH 1/2 mx6: ddr: Restore ralat/walat in write level calibration
In reply to Francesco DolciniQuoted 19 lines
The current DDR write level calibration routine always overwrite
the ralat/walat fields to their maximum value, just save
the existing values at the beginning of the calibration routine
and restore it at the end.
In case the delay is estimated by the user to be more than one cycle the walat should be configured according to that, this is not
automatically done. From the i.MX6 RM:
The user should read the results of the associated delay-line at MPWLDECTRL#[WL_DL_ABS_OFFSET#] and in case the user estimates that the reasonable delay may be above 1 cycle then the user should indicate it at MPWLDECTRL#[WL_CYC_DEL#]. Moreover the user should indicate it in MDMISC[WALAT] field. For example, if the result of the write leveling calibration is 100/256 parts of a cycle, but the user estimates that the delay is above 2 cycles then MPWLDECTRL#[WL_CYC_DEL#] should be configured to 2, so the total delay will be 2 and 100/256 parts of a cycle
Probably it would just possible to not overwrite the mdmisc register in the first place, since this is not present in thewrite_level_calib()example in NXP AN4467 nor in the i.MX6 RM (44.11.6.1 Hardware Write Leveling Calibration).
Quoted 4 lines
Fixes d339f16911c7 ("arm: imx6: Add DDR3 calibration code for MX6 Q/D/DL")Signed-off-by Francesco Dolcini <[email protected]>Reviewed-by Marek Vasut <[email protected]>Reviewed-by Fabio Estevam <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] =====================================================================
PATCH 2/2 mx6: ddr: Wait before issuing the first MRS cmd
In reply to Francesco DolciniWait 1ms before issuing the first MRS command to write DDR3 Mode registers.
There is a requirement to wait a minimum time before issuing command to the DDR3 device, according to the JEDEC standard this time is 500us (after RESET_n is de-asserted until CKE becomes active) + tXPR (Reset CKE Exit time, maximum value 360ns).
It seems that for some reason this is not enforced by the MMDC controller.
Without this change we experienced random memory initialization failures with about 2% boot failure rate on specific problematic boards, after this change we were able to do more than 10.000 power-cycle without a single failure.
---
Changes in v1:
- Add Reviewed-by: Marek Vasut [email protected]
- Commit message and comments improvements, no code changes.
--- arch/arm/mach-imx/mx6/ddr.c | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm/mach-imx/mx6/ddr.c +5 -0
@@ -1526,6 +1526,11 @@ void mx6_ddr3_cfg(const struct mx6_ddr_sysinfo *sysinfo, ((sysinfo->ncs ==2 ) ?1 :0 ) <<30 ;/* SDE_1 for CS1 */ /* Step 8: Write Mode Registers to Init DDR3 devices */ +mdelay (1 );/* Wait before issuing the first MRS command. +* Minimum wait time is (tXPR + 500us), +* with max tXPR value 360ns, and 500us wait required after +* RESET_n is de-asserted. +*/ for (cs =0 ; cs < sysinfo->ncs; cs++) {/* MR2 */ val = (sysinfo->rtt_wr & 3) << 9 | (ddr3_cfg->SRT & 1) << 7 |
Signature · 1 line
2.25.1
Re: [PATCH v1 2/2] mx6: ddr: Wait before issuing the first MRS cmd
Hi Francesco,
Quoted 9 lines · Francesco Dolcini
Wait 1ms before issuing the first MRS command to write DDR3 Mode registers.
There is a requirement to wait a minimum time before issuing command to the DDR3 device, according to the JEDEC standard this time is 500us (after
RESET_nis de-asserted until CKE becomes active) + tXPR (Reset CKE Exit time, maximum value 360ns).
Quoted 7 lines
It seems that for some reason this is not enforced by the MMDC controller.
Without this change we experienced random memory initialization failures with about 2% boot failure rate on specific problematic boards, after this change we were able to do more than 10.000 power-cycle without a single failure.
Glad you fixed this problem. Not an easy one!
PATCH 2/2 mx6: ddr: Wait before issuing the first MRS cmd
In reply to Francesco DolciniQuoted 12 lines
Wait 1ms before issuing the first MRS command to write DDR3 Mode registers.
There is a requirement to wait a minimum time before issuing command to the DDR3 device, according to the JEDEC standard this time is 500us (afterRESET_nis de-asserted until CKE becomes active) + tXPR (Reset CKE Exit time, maximum value 360ns).
It seems that for some reason this is not enforced by the MMDC controller.
Without this change we experienced random memory initialization failures with about 2% boot failure rate on specific problematic boards, after this change we were able to do more than 10.000 power-cycle without a single failure.
Quoted 4 lines
Fixes fe0f7f7842e1 ("mx6: add mmdc configuration for MX6Q/MX6DL")Signed-off-by Francesco Dolcini <[email protected]>Reviewed-by Marek Vasut <[email protected]>Reviewed-by Fabio Estevam <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] =====================================================================